wooo/ewoooc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

新增市場情報 review decision writer run readiness

Browse Source
This commit is contained in:
OoO
2026-05-19 15:44:18 +08:00
parent dafde7e1a7
commit 8fd6c4a42c
10 changed files with 821 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

433
tests/test_market_intel_skeleton.py
View File

@@ -852,6 +852,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_package"
in template
)
assert (
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness"
in template
)
assert (
"data-market-intel-sample-candidate-queue-review-decision-writer"
in template
@@ -872,6 +876,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
"data-market-intel-sample-candidate-queue-review-decision-run-package"
in template
)
assert (
"data-market-intel-sample-candidate-queue-review-decision-run-readiness"
in template
)
assert "X-CSRFToken" in template
assert "market_intel.market_intel_scheduler_plan" in template
assert "market_intel.market_intel_match_review_plan" in template
@@ -908,7 +916,7 @@ def test_legacy_source_bridge_default_is_planned_only():
bridge = MarketIntelService().build_legacy_source_bridge()
assert bridge["mode"] == "legacy_source_bridge_planned"
assert bridge["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert bridge["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert bridge["execute_requested"] is False
assert bridge["read_only_query_executed"] is False
assert bridge["database_connection_opened"] is False
@@ -1066,7 +1074,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
contract = MarketIntelService().build_mcp_tool_contract()
assert contract["mode"] == "mcp_tool_contract_preview"
assert contract["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert contract["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert contract["caller"] == "market_intel"
assert contract["contract_ready"] is True
assert contract["blocked_reasons"] == []
@@ -1199,7 +1207,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_activation_runbook_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -1212,7 +1220,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
assert gate["mode"] == "mcp_fetch_gate_planned"
assert gate["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert gate["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert gate["fetch_requested"] is True
assert gate["manual_fetch_gate_open"] is False
assert gate["network_request_allowed"] is False
@@ -1282,7 +1290,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_fetch_gate_planned"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["fetch_requested"] is False
assert data["network_request_allowed"] is False
assert data["external_network_executed"] is False
@@ -1294,7 +1302,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write():
plan = MarketIntelService().build_manual_sample_plan()
assert plan["mode"] == "manual_sample_fetch_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_for_manual_sample_fetch"] is False
assert plan["sample_fetch_executed"] is False
assert plan["external_network_executed"] is False
@@ -1342,7 +1350,7 @@ def test_manual_sample_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_fetch_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["sample_fetch_executed"] is False
assert data["external_network_executed"] is False
assert data["database_write_executed"] is False
@@ -1353,7 +1361,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import():
acceptance = MarketIntelService().build_manual_sample_acceptance()
assert acceptance["mode"] == "manual_sample_acceptance_preview"
assert acceptance["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert acceptance["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert acceptance["contract_ready"] is True
assert acceptance["sample_result_loaded"] is False
assert acceptance["sample_result_accepted"] is False
@@ -1395,7 +1403,7 @@ def test_manual_sample_acceptance_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_acceptance_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["sample_result_loaded"] is False
assert data["candidate_import_allowed"] is False
assert data["external_network_executed"] is False
@@ -1407,7 +1415,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded():
review = MarketIntelService().build_manual_sample_review()
assert review["mode"] == "manual_sample_review_preview"
assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert review["contract_ready"] is True
assert review["sample_result_loaded"] is False
assert review["sample_result_reviewed"] is False
@@ -1518,7 +1526,7 @@ def test_manual_sample_review_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_review_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["sample_result_loaded"] is False
assert data["sample_result_reviewed"] is False
assert data["candidate_import_allowed"] is False
@@ -1557,7 +1565,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist
)
assert review["mode"] == "manual_sample_review_evaluation_preview"
assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert review["review_request_type"] == "operator_posted_json"
assert review["payload_received"] is True
assert review["payload_valid_json_object"] is True
@@ -1619,7 +1627,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_review_evaluation_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["payload_received"] is True
assert data["payload_valid_json_object"] is True
assert data["payload_persisted"] is False
@@ -1699,7 +1707,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers
)
assert handoff["mode"] == "manual_sample_candidate_handoff_preview"
assert handoff["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert handoff["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert handoff["payload_received"] is True
assert handoff["payload_valid_json_object"] is True
assert handoff["payload_persisted"] is False
@@ -1763,7 +1771,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_handoff_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["payload_received"] is True
assert data["handoff_ready"] is True
assert data["candidate_handoff_created"] is True
@@ -1822,7 +1830,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without
)
assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview"
assert queue_draft["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert queue_draft["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert queue_draft["payload_received"] is True
assert queue_draft["payload_valid_json_object"] is True
assert queue_draft["payload_persisted"] is False
@@ -1896,7 +1904,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_draft_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["payload_received"] is True
assert data["handoff_ready"] is True
assert data["queue_draft_ready"] is True
@@ -1959,7 +1967,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro
)
assert approval["mode"] == "manual_sample_candidate_queue_approval_preview"
assert approval["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert approval["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert approval["payload_received"] is True
assert approval["payload_valid_json_object"] is True
assert approval["payload_persisted"] is False
@@ -2037,7 +2045,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write(
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_approval_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["payload_received"] is True
assert data["approval_preview_created"] is True
assert data["approval_request_created"] is False
@@ -2100,7 +2108,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution():
)
assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview"
assert transaction["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert transaction["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert transaction["payload_received"] is True
assert transaction["payload_valid_json_object"] is True
assert transaction["payload_persisted"] is False
@@ -2180,7 +2188,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_transaction_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["payload_received"] is True
assert data["transaction_preview_created"] is True
assert data["transaction_ready"] is False
@@ -4266,6 +4274,151 @@ def test_candidate_queue_review_decision_writer_run_package_preview_is_safe():
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_review_decision_writer_run_readiness_preview_checks_operator_evidence():
from services.market_intel.candidate_queue_review_decision_writer_cli import (
build_candidate_queue_review_decision_writer_cli_plan,
)
from services.market_intel.candidate_queue_review_decision_writer_preflight import (
build_candidate_queue_review_decision_writer_preflight,
)
from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import (
build_candidate_queue_review_decision_writer_postwrite_smoke,
)
from services.market_intel.candidate_queue_review_decision_writer_operator_drill import (
build_candidate_queue_review_decision_writer_operator_drill,
)
from services.market_intel.candidate_queue_review_decision_writer_run_package import (
build_candidate_queue_review_decision_writer_run_package,
)
from services.market_intel.candidate_queue_review_decision_writer_run_readiness import (
build_candidate_queue_review_decision_writer_run_readiness,
)
transaction, operator_evidence = _build_ready_review_decision_transaction()
operator_evidence = {
**operator_evidence,
"operator_confirmed_manual_shell_window": True,
"operator_confirmed_post_update_inventory_planned": True,
"operator_drill_notes": "review_state shell drill reviewed",
}
writer_status = build_candidate_queue_review_decision_writer_cli_plan(
transaction_preview=transaction,
operator_evidence=operator_evidence,
)
preflight = build_candidate_queue_review_decision_writer_preflight(
writer_status=writer_status,
transaction_preview=transaction,
operator_evidence=operator_evidence,
)
smoke = build_candidate_queue_review_decision_writer_postwrite_smoke(
transaction_preview=transaction,
execute_requested=False,
)
drill = build_candidate_queue_review_decision_writer_operator_drill(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_evidence=operator_evidence,
)
package = build_candidate_queue_review_decision_writer_run_package(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_drill=drill,
)
missing = build_candidate_queue_review_decision_writer_run_readiness(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_drill=drill,
run_package=package,
)
ready = build_candidate_queue_review_decision_writer_run_readiness(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_drill=drill,
run_package=package,
operator_evidence={
"review_state_transaction_json_path": (
"artifacts/market_intel/review-state-transaction.json"
),
"backup_artifact_path": "scripts/tools/backups/backup.zip",
"preflight_artifact_path": (
"artifacts/market_intel/review-state-preflight.json"
),
"operator_confirmed_review_state_preflight_only": True,
"operator_acknowledged_shell_only_token": True,
},
)
token_leak = build_candidate_queue_review_decision_writer_run_readiness(
transaction_preview=transaction,
writer_preflight=preflight,
writer_status=writer_status,
postwrite_smoke=smoke,
operator_drill=drill,
run_package=package,
operator_evidence={
"review_state_transaction_json_path": (
"artifacts/market_intel/review-state-transaction.json"
),
"backup_artifact_path": "scripts/tools/backups/backup.zip",
"preflight_artifact_path": (
"artifacts/market_intel/review-state-preflight.json"
),
"operator_confirmed_review_state_preflight_only": True,
"operator_acknowledged_shell_only_token": True,
"approval_token": TEST_APPROVAL_TOKEN,
},
)
assert missing["mode"] == (
"candidate_queue_review_decision_writer_run_readiness_preview"
)
assert missing["target_table"] == "market_alert_review_queue"
assert missing["target_operation"] == "update_review_state"
assert missing["ready_for_cli_operator_run"] is False
assert missing["ready_for_api_review_state_update"] is False
assert missing["ready_for_api_database_write"] is False
assert missing["ready_for_scheduler_attach"] is False
assert missing["api_executes_cli"] is False
assert missing["api_reads_approval_token"] is False
assert missing["api_writes_file"] is False
assert missing["api_updates_review_state"] is False
assert missing["review_state_update_executed"] is False
assert missing["database_connection_opened"] is False
assert missing["database_write_executed"] is False
assert missing["database_commit_executed"] is False
assert missing["scheduler_attached"] is False
assert "review_state_transaction_json_path_recorded" in missing[
"blocked_reasons"
]
assert "operator_acknowledged_shell_only_token" in missing["blocked_reasons"]
assert ready["ready_for_cli_operator_run"] is True
assert ready["ready_for_api_review_state_update"] is False
assert ready["database_write_executed"] is False
assert ready["run_package_summary"]["package_ready"] is False
assert ready["run_package_summary"]["payload_count"] == 1
assert ready["operator_evidence_summary"]["artifact_path_count"] == 3
assert token_leak["ready_for_cli_operator_run"] is False
assert token_leak["operator_evidence_summary"][
"approval_token_submitted_to_api"
] is True
assert "approval_token_not_submitted_to_api" in token_leak["blocked_reasons"]
assert "do_not_update_review_state_from_review_state_run_readiness" in ready[
"safe_boundaries"
]
assert TEST_APPROVAL_TOKEN not in json.dumps(
token_leak,
ensure_ascii=False,
sort_keys=True,
)
def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
@@ -4308,7 +4461,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_preflight_planned"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -4365,7 +4518,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_cli_blocked"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["approval_token_present"] is False
@@ -4454,7 +4607,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write(
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -4508,7 +4661,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write()
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_operator_drill_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["operator_drill_ready"] is True
assert data["api_executes_cli"] is False
assert data["api_reads_approval_token"] is False
@@ -4564,7 +4717,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_package_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["package_ready"] is True
assert data["package_artifact_created"] is False
assert data["api_writes_file"] is False
@@ -4630,7 +4783,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_readiness_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["ready_for_cli_operator_run"] is True
assert data["ready_for_api_database_write"] is False
assert data["api_executes_cli"] is False
@@ -4932,7 +5085,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["receipt_passed"] is True
assert data["ready_for_api_database_write"] is False
assert data["ready_for_scheduler_attach"] is False
@@ -4980,7 +5133,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_closeout_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["closeout_passed"] is True
assert data["ready_for_next_manual_phase"] is True
assert data["ready_for_api_database_write"] is False
@@ -5029,7 +5182,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_handoff_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["handoff_ready"] is True
assert data["ready_for_manual_queue_review"] is True
assert data["ready_for_api_database_write"] is False
@@ -5087,7 +5240,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write():
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_inventory_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["review_inventory_ready"] is False
assert data["ready_for_human_decision_review"] is False
@@ -5153,7 +5306,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write():
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["decision_ready"] is False
assert data["ready_for_human_decision_record"] is False
assert data["ready_for_api_review_state_update"] is False
@@ -5224,7 +5377,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_approval_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["approval_ready"] is False
assert data["ready_for_review_state_transaction_preview"] is False
assert data["ready_for_cli_decision_writer"] is False
@@ -5300,7 +5453,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_transaction_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["transaction_preview_created"] is False
assert data["transaction_ready"] is False
assert data["ready_for_manual_shell_update_window"] is False
@@ -5382,7 +5535,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["approval_token_present"] is False
@@ -5468,7 +5621,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and
assert data["mode"] == (
"candidate_queue_review_decision_writer_preflight_preview"
)
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["read_only_query_executed"] is False
@@ -5551,7 +5704,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on
assert data["mode"] == (
"candidate_queue_review_decision_writer_postwrite_smoke_planned"
)
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -5634,7 +5787,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl
assert data["mode"] == (
"candidate_queue_review_decision_writer_operator_drill_preview"
)
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["operator_drill_ready"] is False
assert data["ready_for_api_review_state_update"] is False
assert data["ready_for_api_database_write"] is False
@@ -5720,7 +5873,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a
assert data["mode"] == (
"candidate_queue_review_decision_writer_run_package_preview"
)
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["package_ready"] is False
assert data["package_artifact_created"] is False
assert data["ready_for_api_review_state_update"] is False
@@ -5746,6 +5899,95 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
from routes.market_intel_review_routes import market_intel_review_bp
fixture = _build_candidate_queue_writer_receipt_fixture(
"sample-batch-review-decision-run-readiness-route"
)
app = Flask(__name__)
app.secret_key = "test-secret"
app.register_blueprint(market_intel_bp)
app.register_blueprint(market_intel_review_bp)
client = app.test_client()
with client.session_transaction() as session:
session["logged_in"] = True
get_response = client.get(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_readiness"
)
response = client.post(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_readiness"
"?execute=true&apply_real_write=true",
json={
"sample_result": fixture["sample_result"],
"operator_evidence": {
**fixture["operator_evidence"],
"review_state_transaction_json_path": (
"artifacts/market_intel/review-state-transaction.json"
),
"operator_confirmed_review_state_preflight_only": True,
"operator_acknowledged_shell_only_token": True,
"closeout_artifact_path": "artifacts/market_intel/closeout.json",
"operator_confirmed_queue_review_next": True,
"operator_confirmed_no_scheduler_attach": True,
"operator_confirmed_no_api_db_write": True,
"operator_confirmed_inventory_read_only": True,
"reviewer_id": "operator-a",
"proposed_review_decision": "confirmed",
"decision_notes": "manual review only",
"operator_confirmed_manual_decision_only": True,
"decision_approval_notes": "cli-only approval gate",
"operator_confirmed_decision_payload_reviewed": True,
"operator_confirmed_decision_apply_requires_cli": True,
"operator_confirmed_review_state_update_is_not_api": True,
"decision_transaction_notes": "shell-only transaction preview",
"operator_confirmed_transaction_payload_reviewed": True,
"operator_confirmed_cli_only_transaction": True,
"operator_confirmed_manual_shell_window": True,
"operator_confirmed_post_update_inventory_planned": True,
"operator_drill_notes": "manual shell drill reviewed",
},
"writer_output": fixture["writer_output"],
"postwrite_smoke_result": fixture["postwrite_smoke_result"],
},
)
data = response.get_json()
payload = json.dumps(data, ensure_ascii=False, sort_keys=True)
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == (
"candidate_queue_review_decision_writer_run_readiness_preview"
)
assert data["phase"] == (
"phase_74_candidate_queue_review_decision_writer_run_readiness"
)
assert data["ready_for_cli_operator_run"] is False
assert data["ready_for_api_review_state_update"] is False
assert data["ready_for_api_database_write"] is False
assert data["ready_for_scheduler_attach"] is False
assert data["api_writes_file"] is False
assert data["api_executes_cli"] is False
assert data["api_reads_approval_token"] is False
assert data["api_writes_database"] is False
assert data["api_updates_review_state"] is False
assert data["database_connection_opened"] is False
assert data["database_write_executed"] is False
assert data["database_commit_executed"] is False
assert data["review_state_update_executed"] is False
assert data["scheduler_attached"] is False
assert data["run_package_summary"]["payload_count"] == 0
assert "payload_count_within_small_batch_limit" in data["blocked_reasons"]
assert "do_not_execute_review_state_writer_from_run_readiness_api" in data[
"safe_boundaries"
]
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
@@ -5774,7 +6016,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["receipt_passed"] is True
assert data["ready_for_next_manual_review"] is True
assert data["ready_for_api_database_write"] is False
@@ -5799,7 +6041,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
plan = MarketIntelService().build_scheduler_plan()
assert plan["mode"] == "scheduler_attach_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_to_attach_scheduler"] is False
assert plan["scheduler_attached"] is False
assert plan["scheduler_registration_executed"] is False
@@ -5837,7 +6079,7 @@ def test_scheduler_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "scheduler_attach_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["scheduler_registration_executed"] is False
assert data["crawler_job_started"] is False
assert data["external_network_executed"] is False
@@ -5848,7 +6090,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
plan = MarketIntelService().build_match_review_plan()
assert plan["mode"] == "match_review_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_for_review_queue"] is False
assert plan["review_queue_created"] is False
assert plan["auto_match_executed"] is False
@@ -5884,7 +6126,7 @@ def test_match_review_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "match_review_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["review_queue_created"] is False
assert data["auto_confirm_executed"] is False
assert data["external_network_executed"] is False
@@ -5895,7 +6137,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
plan = MarketIntelService().build_opportunity_plan()
assert plan["mode"] == "opportunity_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_for_opportunity_queue"] is False
assert plan["opportunity_queue_created"] is False
assert plan["threat_alert_dispatched"] is False
@@ -5936,7 +6178,7 @@ def test_opportunity_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["opportunity_queue_created"] is False
assert data["threat_alert_dispatched"] is False
assert data["ai_summary_generated"] is False
@@ -5947,7 +6189,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
plan = MarketIntelService().build_opportunity_scoring_plan()
assert plan["mode"] == "opportunity_scoring_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_for_scoring_job"] is False
assert plan["scoring_job_created"] is False
assert plan["score_calculation_executed"] is False
@@ -5995,7 +6237,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_scoring_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["scoring_job_created"] is False
assert data["score_calculation_executed"] is False
assert data["sample_scores_generated"] is False
@@ -6007,7 +6249,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
plan = MarketIntelService().build_opportunity_evidence_plan()
assert plan["mode"] == "opportunity_evidence_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_for_evidence_bundle"] is False
assert plan["evidence_bundle_created"] is False
assert plan["evidence_query_executed"] is False
@@ -6053,7 +6295,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_evidence_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["evidence_bundle_created"] is False
assert data["evidence_query_executed"] is False
assert data["sample_evidence_generated"] is False
@@ -6066,7 +6308,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
plan = MarketIntelService().build_opportunity_alert_plan()
assert plan["mode"] == "opportunity_alert_plan_preview"
assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert plan["ready_for_alert_candidates"] is False
assert plan["alert_candidate_created"] is False
assert plan["alert_queue_created"] is False
@@ -6151,7 +6393,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_alert_plan_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["alert_candidate_created"] is False
assert data["alert_queue_created"] is False
assert data["review_queue_created"] is False
@@ -6229,7 +6471,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_external_deploy_preflight_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -6244,7 +6486,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
readiness = MarketIntelService().build_mcp_readiness()
assert readiness["mode"] == "mcp_readiness_planned"
assert readiness["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert readiness["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert readiness["execute_requested"] is False
assert readiness["router_enabled"] is False
assert readiness["external_mcp_complete"] is False
@@ -6714,6 +6956,12 @@ def test_deployment_readiness_reports_app_only_release_gate():
]
is True
)
assert (
readiness["checks"][
"candidate_queue_review_decision_writer_run_readiness_preview_safe"
]
is True
)
assert (
readiness["checks"][
"candidate_queue_review_decision_writer_cli_status_safe"
@@ -6828,6 +7076,11 @@ def test_deployment_readiness_reports_app_only_release_gate():
"candidate_queue_review_decision_writer_run_package"
in readiness["production_smoke_targets"]
)
assert (
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_run_readiness"
in readiness["production_smoke_targets"]
)
assert (
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_status"
@@ -7815,6 +8068,58 @@ def test_deployment_readiness_reports_app_only_release_gate():
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"]["mode"]
== "candidate_queue_review_decision_writer_run_readiness_preview"
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"ready_for_api_review_state_update"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"ready_for_api_database_write"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"api_executes_cli"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"api_reads_approval_token"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"api_updates_review_state"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"review_state_update_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"database_write_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_run_readiness"][
"scheduler_attached"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_status"]["mode"]
== "candidate_queue_review_decision_writer_cli_blocked"
@@ -7965,7 +8270,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only():
drill = MarketIntelService().build_migration_apply_drill()
assert drill["mode"] == "migration_apply_drill_preview"
assert drill["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert drill["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert drill["execute_requested"] is False
assert drill["schema_state"] == "planned_no_db_probe"
assert drill["drill_ready_for_operator_review"] is True
@@ -8080,7 +8385,7 @@ def test_migration_apply_drill_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_apply_drill_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["migration_executed"] is False
assert data["rollback_executed"] is False
@@ -8092,7 +8397,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic():
review = MarketIntelService().build_migration_catalog_review()
assert review["mode"] == "migration_catalog_review_preview"
assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert review["execute_requested"] is False
assert review["catalog_state"] == "planned_no_probe"
assert review["seed_state"] == "planned_no_probe"
@@ -8207,7 +8512,7 @@ def test_migration_catalog_review_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_catalog_review_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["catalog_state"] == "planned_no_probe"
assert data["migration_executed"] is False
@@ -8220,7 +8525,7 @@ def test_migration_live_smoke_planned_is_preview_only():
smoke = MarketIntelService().build_migration_live_smoke()
assert smoke["mode"] == "migration_live_smoke_preview"
assert smoke["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert smoke["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert smoke["execute_requested"] is False
assert smoke["smoke_result"] == "planned_no_execution"
assert smoke["live_smoke_passed"] is False
@@ -8282,7 +8587,7 @@ def test_migration_live_smoke_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_live_smoke_preview"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["smoke_result"] == "planned_no_execution"
assert data["migration_executed"] is False
@@ -8295,7 +8600,7 @@ def test_live_db_inventory_planned_is_preview_only():
inventory = MarketIntelService().build_live_db_inventory()
assert inventory["mode"] == "live_db_inventory_planned"
assert inventory["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert inventory["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert inventory["execute_requested"] is False
assert inventory["read_only_query_executed"] is False
assert inventory["database_connection_opened"] is False
@@ -8439,7 +8744,7 @@ def test_live_db_inventory_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "live_db_inventory_planned"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_write_executed"] is False
@@ -8666,7 +8971,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path):
assert result.returncode == 0
assert data["mode"] == "candidate_queue_writer_cli_blocked"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["apply_real_write_requested"] is False
assert data["writes_executed"] is False
@@ -8695,7 +9000,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en
assert result.returncode == 0
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package"
assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness"
assert data["execute_requested"] is False
assert data["apply_real_write_requested"] is False
assert data["approval_token_present"] is False