diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 5d336d8..77e6bc8 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -147,6 +147,7 @@ - Phase 71 candidate queue review decision writer post-write smoke：新增 `services/market_intel/candidate_queue_review_decision_writer_postwrite_smoke.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` 與 UI smoke 按鈕，人工 CLI 更新 review_state 後可用 dedupe key 只讀驗證 row 是否存在且 state 符合預期；API/UI 預設不連 DB，execute=true 也只讀查詢，不更新 review_state、不 commit、不讀 token、不掛 scheduler；版本同步至 V10.260。 - Phase 72 candidate queue review decision writer operator drill：新增 `services/market_intel/candidate_queue_review_decision_writer_operator_drill.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` 與 UI drill 按鈕，將 review_state CLI 更新前後的 transaction JSON、備份、preflight、CLI writer、post-write smoke 與 rollback plan 組成可稽核操作順序；API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.261。 - Phase 73 candidate queue review decision writer run package：新增 `services/market_intel/candidate_queue_review_decision_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 與 UI package 按鈕，將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 run package；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.262。 + - Phase 74 candidate queue review decision writer run readiness：新增 `services/market_intel/candidate_queue_review_decision_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 與 UI readiness 按鈕，檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.264。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/config.py b/config.py index d1127a9..24d834c 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.263" +SYSTEM_VERSION = "V10.264" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index c8399e6..6ebf067 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -199,6 +199,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review decision writer post-write smoke：`services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke` 依 review_state transaction preview 的 dedupe key 只讀查詢 `market_alert_review_queue`，確認人工 CLI 更新後的 `review_state` 是否符合預期。UI 預設 `execute=false` 不連 DB；人工 smoke 即使 `execute=true` 也只讀查詢，不更新 `review_state`、不 commit、不讀 approval token、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer operator drill：`services.market_intel.candidate_queue_review_decision_writer_operator_drill` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill` 整理 review_state CLI 更新前後的操作員順序、preflight、post-write smoke、gate 與 rollback plan。此 drill 只輸出可稽核操作計畫；API/UI 不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run package：`services.market_intel.candidate_queue_review_decision_writer_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 package。此 package 只輸出預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue review decision writer run readiness：`services.market_intel.candidate_queue_review_decision_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備。此 readiness 只輸出操作員 gate 預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 1ae2ea3..1b51ef5 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,8 +19,8 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 73 candidate queue review decision writer run package 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | -| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` | +| `market_intel_routes.py` | 市場情報 Phase 74 candidate queue review decision writer run readiness 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py index d53ebd0..5a2d37b 100644 --- a/routes/market_intel_review_routes.py +++ b/routes/market_intel_review_routes.py @@ -36,6 +36,9 @@ from services.market_intel.candidate_queue_review_decision_writer_operator_drill from services.market_intel.candidate_queue_review_decision_writer_run_package import ( build_candidate_queue_review_decision_writer_run_package, ) +from services.market_intel.candidate_queue_review_decision_writer_run_readiness import ( + build_candidate_queue_review_decision_writer_run_readiness, +) from services.market_intel.candidate_queue_writer_cli import ( build_candidate_queue_writer_cli_plan, ) @@ -583,3 +586,72 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_run_packag ) data["phase"] = service.phase return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_readiness", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness(): + service = MarketIntelService() + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction = _build_review_decision_transaction_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + limit=limit, + execute_requested=False, + ) + writer_status = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + operator_evidence=operator_evidence, + execute_requested=False, + apply_real_write=False, + approval_token=None, + approval_token_secret=None, + backup_verified=False, + review_inventory_smoke_passed=False, + ) + writer_preflight = build_candidate_queue_review_decision_writer_preflight( + writer_status=writer_status, + transaction_preview=transaction, + operator_evidence=operator_evidence, + execute_requested=False, + apply_real_write=False, + ) + postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + operator_drill = build_candidate_queue_review_decision_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_evidence=operator_evidence, + ) + run_package = build_candidate_queue_review_decision_writer_run_package( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + data = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 diff --git a/services/market_intel/candidate_queue_review_decision_writer_run_readiness.py b/services/market_intel/candidate_queue_review_decision_writer_run_readiness.py new file mode 100644 index 0000000..d36c59d --- /dev/null +++ b/services/market_intel/candidate_queue_review_decision_writer_run_readiness.py @@ -0,0 +1,249 @@ +"""候選審核 queue review_state writer operator run readiness preview。 + +本模組只檢查正式 CLI 更新 review_state 前的操作員證據是否齊備； +不讀 approval token、不執行 CLI、不開 DB connection、不更新 review_state、 +不 commit、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _payload_manifest(run_package): + return _as_dict(_as_dict(run_package).get("payload_manifest")) + + +def _payload_count(run_package): + return int(_payload_manifest(run_package).get("payload_count") or 0) + + +def _artifact_summary(operator_evidence): + artifact_paths = { + "review_state_transaction_json_path": operator_evidence.get( + "review_state_transaction_json_path" + ), + "backup_artifact_path": operator_evidence.get("backup_artifact_path"), + "preflight_artifact_path": operator_evidence.get("preflight_artifact_path"), + } + return { + "provided_keys": sorted(operator_evidence.keys()), + "artifact_path_count": sum(1 for value in artifact_paths.values() if _has_text(value)), + "review_state_transaction_json_path_recorded": _has_text( + artifact_paths["review_state_transaction_json_path"] + ), + "backup_artifact_path_recorded": _has_text( + artifact_paths["backup_artifact_path"] + ), + "preflight_artifact_path_recorded": _has_text( + artifact_paths["preflight_artifact_path"] + ), + "operator_acknowledged_shell_only_token": bool( + operator_evidence.get("operator_acknowledged_shell_only_token") + ), + "operator_confirmed_review_state_preflight_only": bool( + operator_evidence.get("operator_confirmed_review_state_preflight_only") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _readiness_gates( + *, + run_package, + operator_drill, + postwrite_smoke, + operator_evidence, +): + artifact_summary = _artifact_summary(operator_evidence) + payload_count = _payload_count(run_package) + run_package = _as_dict(run_package) + operator_drill = _as_dict(operator_drill) + return [ + { + "key": "run_package_preview_available", + "label": "review_state run package preview 已產生", + "passed": run_package.get("mode") + == "candidate_queue_review_decision_writer_run_package_preview", + }, + { + "key": "payload_manifest_available", + "label": "run package 已包含 review_state update payload manifest", + "passed": bool(_payload_manifest(run_package).get("manifest_hash")), + }, + { + "key": "payload_count_within_small_batch_limit", + "label": "首次 review_state operator run 必須是 1 到 5 筆小流量", + "passed": 0 < payload_count <= 5, + }, + { + "key": "operator_drill_ready", + "label": "operator drill 已提供 review_state CLI 操作順序", + "passed": bool(operator_drill.get("operator_drill_ready")), + }, + { + "key": "review_state_transaction_json_path_recorded", + "label": "操作員已記錄 review_state transaction JSON 檔案路徑", + "passed": artifact_summary[ + "review_state_transaction_json_path_recorded" + ], + }, + { + "key": "backup_artifact_path_recorded", + "label": "操作員已記錄最新備份檔路徑", + "passed": artifact_summary["backup_artifact_path_recorded"], + }, + { + "key": "preflight_artifact_path_recorded", + "label": "操作員已記錄 CLI read-only preflight 輸出路徑", + "passed": artifact_summary["preflight_artifact_path_recorded"], + }, + { + "key": "operator_confirmed_review_state_preflight_only", + "label": "操作員確認 preflight 只讀且不更新 review_state", + "passed": artifact_summary[ + "operator_confirmed_review_state_preflight_only" + ], + }, + { + "key": "operator_acknowledged_shell_only_token", + "label": "操作員確認一次性 token 只在 CLI shell 提供", + "passed": artifact_summary["operator_acknowledged_shell_only_token"], + }, + { + "key": "approval_token_not_submitted_to_api", + "label": "payload 不得包含 approval token 或 token key", + "passed": not artifact_summary["approval_token_submitted_to_api"], + }, + { + "key": "postwrite_smoke_plan_available", + "label": "post-write smoke 已可在更新後做只讀驗證", + "passed": bool(postwrite_smoke), + }, + ] + + +def build_candidate_queue_review_decision_writer_run_readiness( + *, + transaction_preview, + writer_preflight, + writer_status, + postwrite_smoke, + operator_drill, + run_package, + operator_evidence=None, +): + """建立 review_state operator run readiness preview；不執行任何副作用。""" + operator_evidence = _as_dict(operator_evidence) + artifact_summary = _artifact_summary(operator_evidence) + gates = _readiness_gates( + run_package=run_package, + operator_drill=operator_drill, + postwrite_smoke=postwrite_smoke, + operator_evidence=operator_evidence, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + ready_for_cli_operator_run = bool(not blocked_reasons) + manifest = _payload_manifest(run_package) + transaction_summary = _as_dict(transaction_preview.get("transaction_summary")) + + return { + "mode": "candidate_queue_review_decision_writer_run_readiness_preview", + "target_table": "market_alert_review_queue", + "target_operation": "update_review_state", + "ready_for_cli_operator_run": ready_for_cli_operator_run, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "approval_record_written": False, + "decision_record_written": False, + "review_state_update_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_evidence_summary": artifact_summary, + "run_package_summary": { + "mode": run_package.get("mode"), + "package_ready": bool(run_package.get("package_ready")), + "payload_count": int(manifest.get("payload_count") or 0), + "manifest_hash": manifest.get("manifest_hash"), + "required_artifact_count": len(run_package.get("required_artifacts") or []), + "command_count": len(run_package.get("command_bundle") or []), + }, + "writer_summary": { + "writer_status_mode": writer_status.get("mode"), + "writer_preflight_mode": writer_preflight.get("mode"), + "postwrite_smoke_mode": postwrite_smoke.get("mode"), + "transaction_statement_count": int( + transaction_summary.get("statement_count") or 0 + ), + }, + "cli_execution_boundary": { + "api_may_execute_cli": False, + "operator_shell_required": True, + "one_time_token_shell_only": True, + "requires_backup_verified": True, + "requires_review_state_transaction_json": True, + "requires_read_only_preflight": True, + "requires_postwrite_smoke_after_cli": True, + }, + "next_operator_steps": [ + "保存 review_state transaction JSON", + "執行並記錄最新備份檔路徑", + "執行 read-only preflight 並保存輸出", + "確認一次性 approval token 只在 CLI shell 注入", + "CLI 更新後立即保存 writer output 與 post-write smoke 結果", + ], + "safe_boundaries": [ + "do_not_execute_review_state_writer_from_run_readiness_api", + "do_not_read_approval_token_from_run_readiness_api", + "do_not_create_review_state_run_artifacts_from_api", + "do_not_open_database_connection_from_review_state_run_readiness", + "do_not_update_review_state_from_review_state_run_readiness", + "do_not_attach_scheduler_from_review_state_run_readiness", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 3ec2e6a..0a60d58 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -21,10 +21,11 @@ from services.market_intel.candidate_queue_review_decision_writer_preflight impo from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import build_candidate_queue_review_decision_writer_postwrite_smoke from services.market_intel.candidate_queue_review_decision_writer_operator_drill import build_candidate_queue_review_decision_writer_operator_drill from services.market_intel.candidate_queue_review_decision_writer_run_package import build_candidate_queue_review_decision_writer_run_package +from services.market_intel.candidate_queue_review_decision_writer_run_readiness import build_candidate_queue_review_decision_writer_run_readiness BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database") -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -141,6 +142,14 @@ def build_deployment_readiness_preview( postwrite_smoke=candidate_queue_review_decision_writer_postwrite_smoke, operator_drill=candidate_queue_review_decision_writer_operator_drill, ) + candidate_queue_review_decision_writer_run_readiness = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=candidate_queue_review_decision_transaction, + writer_preflight=candidate_queue_review_decision_writer_preflight, + writer_status=candidate_queue_review_decision_writer_status, + postwrite_smoke=candidate_queue_review_decision_writer_postwrite_smoke, + operator_drill=candidate_queue_review_decision_writer_operator_drill, + run_package=candidate_queue_review_decision_writer_run_package, + ) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -395,6 +404,10 @@ def build_deployment_readiness_preview( candidate_queue_review_decision_writer_run_package, "candidate_queue_review_decision_writer_run_package_preview", ), + "candidate_queue_review_decision_writer_run_readiness_preview_safe": _run_review_preview_safe( + candidate_queue_review_decision_writer_run_readiness, + "candidate_queue_review_decision_writer_run_readiness_preview", + ), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -635,6 +648,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_decision_writer_postwrite_smoke": candidate_queue_review_decision_writer_postwrite_smoke, "candidate_queue_review_decision_writer_operator_drill": candidate_queue_review_decision_writer_operator_drill, "candidate_queue_review_decision_writer_run_package": candidate_queue_review_decision_writer_run_package, + "candidate_queue_review_decision_writer_run_readiness": candidate_queue_review_decision_writer_run_readiness, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index ef27a8f..fbb95f2 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_73_candidate_queue_review_decision_writer_run_package" +MARKET_INTEL_PHASE = "phase_74_candidate_queue_review_decision_writer_run_readiness" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 517fcc2..d1815ff 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -655,6 +655,9 @@ + @@ -1004,6 +1007,7 @@ const sampleCandidateQueueReviewDecisionPostwriteSmoke = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-postwrite-smoke]') : null; const sampleCandidateQueueReviewDecisionOperatorDrill = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-operator-drill]') : null; const sampleCandidateQueueReviewDecisionRunPackage = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-package]') : null; + const sampleCandidateQueueReviewDecisionRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-readiness]') : null; const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; @@ -1028,6 +1032,7 @@ const sampleCandidateQueueReviewDecisionPostwriteSmokeEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_postwrite_smoke') }}"; const sampleCandidateQueueReviewDecisionOperatorDrillEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_operator_drill') }}"; const sampleCandidateQueueReviewDecisionRunPackageEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_package') }}"; + const sampleCandidateQueueReviewDecisionRunReadinessEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness') }}"; const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; @@ -4100,6 +4105,108 @@ } }; + const renderCandidateQueueReviewDecisionRunReadiness = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const evidence = data.operator_evidence_summary || {}; + const packageSummary = data.run_package_summary || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `cli_ready=${data.ready_for_cli_operator_run ? 'yes' : 'no'}`, + `api_update=${data.ready_for_api_review_state_update ? 'yes' : 'no'}`, + `payloads=${packageSummary.payload_count || 0}`, + `paths=${evidence.artifact_path_count || 0}`, + `token_api=${evidence.approval_token_submitted_to_api ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只檢查 review_state CLI 更新前的操作員證據；API/UI 不讀 token、不執行 CLI、不產檔、不更新 review_state。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
manifest=${escapeHtml((packageSummary.manifest_hash || '').slice(0, 16) || 'none')} / artifacts=${escapeHtml(packageSummary.required_artifact_count || 0)} / commands=${escapeHtml(packageSummary.command_count || 0)}
+
+
+

READINESS GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 readiness gate。
' + }
+
+
+

EVIDENCE

+
+ ${[ + ['review_state_transaction_json_path_recorded', evidence.review_state_transaction_json_path_recorded], + ['backup_artifact_path_recorded', evidence.backup_artifact_path_recorded], + ['preflight_artifact_path_recorded', evidence.preflight_artifact_path_recorded], + ['preflight_only', evidence.operator_confirmed_review_state_preflight_only], + ['shell_only_token', evidence.operator_acknowledged_shell_only_token], + ['approval_token_submitted_to_api', evidence.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+

WRITE FLAGS

+
+ ${[ + ['api_executes_cli', data.api_executes_cli], + ['api_reads_token', data.api_reads_approval_token], + ['api_updates_review_state', data.api_updates_review_state], + ['review_state_update_executed', data.review_state_update_executed], + ['database_write', data.database_write_executed], + ['scheduler', data.scheduler_attached] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueReviewDecisionRunReadiness = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue review decision writer run readiness 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewDecisionRunReadinessEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewDecisionRunReadiness(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review decision writer run readiness 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -5770,6 +5877,9 @@ if (sampleCandidateQueueReviewDecisionRunPackage) { sampleCandidateQueueReviewDecisionRunPackage.addEventListener('click', loadCandidateQueueReviewDecisionRunPackage); } + if (sampleCandidateQueueReviewDecisionRunReadiness) { + sampleCandidateQueueReviewDecisionRunReadiness.addEventListener('click', loadCandidateQueueReviewDecisionRunReadiness); + } if (sampleCandidateQueueReviewDecisionWriter) { sampleCandidateQueueReviewDecisionWriter.addEventListener('click', loadCandidateQueueReviewDecisionWriter); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index c2d90b3..9acabf6 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -852,6 +852,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_package" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -872,6 +876,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-decision-run-package" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-decision-run-readiness" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -908,7 +916,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert bridge["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1066,7 +1074,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert contract["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1199,7 +1207,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1212,7 +1220,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert gate["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1282,7 +1290,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1294,7 +1302,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1342,7 +1350,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1353,7 +1361,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert acceptance["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1395,7 +1403,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1407,7 +1415,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1518,7 +1526,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1557,7 +1565,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1619,7 +1627,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1699,7 +1707,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert handoff["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1763,7 +1771,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1822,7 +1830,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert queue_draft["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1896,7 +1904,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1959,7 +1967,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert approval["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2037,7 +2045,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2100,7 +2108,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert transaction["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2180,7 +2188,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -4266,6 +4274,151 @@ def test_candidate_queue_review_decision_writer_run_package_preview_is_safe(): assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_decision_writer_run_readiness_preview_checks_operator_evidence(): + from services.market_intel.candidate_queue_review_decision_writer_cli import ( + build_candidate_queue_review_decision_writer_cli_plan, + ) + from services.market_intel.candidate_queue_review_decision_writer_preflight import ( + build_candidate_queue_review_decision_writer_preflight, + ) + from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import ( + build_candidate_queue_review_decision_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_review_decision_writer_operator_drill import ( + build_candidate_queue_review_decision_writer_operator_drill, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_package import ( + build_candidate_queue_review_decision_writer_run_package, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_readiness import ( + build_candidate_queue_review_decision_writer_run_readiness, + ) + + transaction, operator_evidence = _build_ready_review_decision_transaction() + operator_evidence = { + **operator_evidence, + "operator_confirmed_manual_shell_window": True, + "operator_confirmed_post_update_inventory_planned": True, + "operator_drill_notes": "review_state shell drill reviewed", + } + writer_status = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + operator_evidence=operator_evidence, + ) + preflight = build_candidate_queue_review_decision_writer_preflight( + writer_status=writer_status, + transaction_preview=transaction, + operator_evidence=operator_evidence, + ) + smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + drill = build_candidate_queue_review_decision_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_evidence=operator_evidence, + ) + package = build_candidate_queue_review_decision_writer_run_package( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + ) + missing = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + run_package=package, + ) + ready = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + run_package=package, + operator_evidence={ + "review_state_transaction_json_path": ( + "artifacts/market_intel/review-state-transaction.json" + ), + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": ( + "artifacts/market_intel/review-state-preflight.json" + ), + "operator_confirmed_review_state_preflight_only": True, + "operator_acknowledged_shell_only_token": True, + }, + ) + token_leak = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + run_package=package, + operator_evidence={ + "review_state_transaction_json_path": ( + "artifacts/market_intel/review-state-transaction.json" + ), + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": ( + "artifacts/market_intel/review-state-preflight.json" + ), + "operator_confirmed_review_state_preflight_only": True, + "operator_acknowledged_shell_only_token": True, + "approval_token": TEST_APPROVAL_TOKEN, + }, + ) + + assert missing["mode"] == ( + "candidate_queue_review_decision_writer_run_readiness_preview" + ) + assert missing["target_table"] == "market_alert_review_queue" + assert missing["target_operation"] == "update_review_state" + assert missing["ready_for_cli_operator_run"] is False + assert missing["ready_for_api_review_state_update"] is False + assert missing["ready_for_api_database_write"] is False + assert missing["ready_for_scheduler_attach"] is False + assert missing["api_executes_cli"] is False + assert missing["api_reads_approval_token"] is False + assert missing["api_writes_file"] is False + assert missing["api_updates_review_state"] is False + assert missing["review_state_update_executed"] is False + assert missing["database_connection_opened"] is False + assert missing["database_write_executed"] is False + assert missing["database_commit_executed"] is False + assert missing["scheduler_attached"] is False + assert "review_state_transaction_json_path_recorded" in missing[ + "blocked_reasons" + ] + assert "operator_acknowledged_shell_only_token" in missing["blocked_reasons"] + assert ready["ready_for_cli_operator_run"] is True + assert ready["ready_for_api_review_state_update"] is False + assert ready["database_write_executed"] is False + assert ready["run_package_summary"]["package_ready"] is False + assert ready["run_package_summary"]["payload_count"] == 1 + assert ready["operator_evidence_summary"]["artifact_path_count"] == 3 + assert token_leak["ready_for_cli_operator_run"] is False + assert token_leak["operator_evidence_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "approval_token_not_submitted_to_api" in token_leak["blocked_reasons"] + assert "do_not_update_review_state_from_review_state_run_readiness" in ready[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -4308,7 +4461,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4365,7 +4518,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -4454,7 +4607,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4508,7 +4661,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -4564,7 +4717,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -4630,7 +4783,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -4932,7 +5085,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -4980,7 +5133,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -5029,7 +5182,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -5087,7 +5240,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -5153,7 +5306,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -5224,7 +5377,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -5300,7 +5453,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -5382,7 +5535,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -5468,7 +5621,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -5551,7 +5704,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -5634,7 +5787,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -5720,7 +5873,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -5746,6 +5899,95 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-review-decision-run-readiness-route" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_readiness" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_readiness" + "?execute=true&apply_real_write=true", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": { + **fixture["operator_evidence"], + "review_state_transaction_json_path": ( + "artifacts/market_intel/review-state-transaction.json" + ), + "operator_confirmed_review_state_preflight_only": True, + "operator_acknowledged_shell_only_token": True, + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_inventory_read_only": True, + "reviewer_id": "operator-a", + "proposed_review_decision": "confirmed", + "decision_notes": "manual review only", + "operator_confirmed_manual_decision_only": True, + "decision_approval_notes": "cli-only approval gate", + "operator_confirmed_decision_payload_reviewed": True, + "operator_confirmed_decision_apply_requires_cli": True, + "operator_confirmed_review_state_update_is_not_api": True, + "decision_transaction_notes": "shell-only transaction preview", + "operator_confirmed_transaction_payload_reviewed": True, + "operator_confirmed_cli_only_transaction": True, + "operator_confirmed_manual_shell_window": True, + "operator_confirmed_post_update_inventory_planned": True, + "operator_drill_notes": "manual shell drill reviewed", + }, + "writer_output": fixture["writer_output"], + "postwrite_smoke_result": fixture["postwrite_smoke_result"], + }, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_decision_writer_run_readiness_preview" + ) + assert data["phase"] == ( + "phase_74_candidate_queue_review_decision_writer_run_readiness" + ) + assert data["ready_for_cli_operator_run"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_writes_file"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["scheduler_attached"] is False + assert data["run_package_summary"]["payload_count"] == 0 + assert "payload_count_within_small_batch_limit" in data["blocked_reasons"] + assert "do_not_execute_review_state_writer_from_run_readiness_api" in data[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -5774,7 +6016,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -5799,7 +6041,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -5837,7 +6079,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -5848,7 +6090,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -5884,7 +6126,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -5895,7 +6137,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -5936,7 +6178,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -5947,7 +6189,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -5995,7 +6237,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -6007,7 +6249,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -6053,7 +6295,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -6066,7 +6308,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert plan["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -6151,7 +6393,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -6229,7 +6471,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -6244,7 +6486,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert readiness["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -6714,6 +6956,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_decision_writer_run_readiness_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -6828,6 +7076,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_decision_writer_run_package" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_readiness" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -7815,6 +8068,58 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"]["mode"] + == "candidate_queue_review_decision_writer_run_readiness_preview" + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "ready_for_api_review_state_update" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "api_executes_cli" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "api_reads_approval_token" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "api_updates_review_state" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "review_state_update_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_readiness"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -7965,7 +8270,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert drill["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -8080,7 +8385,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -8092,7 +8397,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert review["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -8207,7 +8512,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -8220,7 +8525,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert smoke["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -8282,7 +8587,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -8295,7 +8600,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert inventory["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -8439,7 +8744,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -8666,7 +8971,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -8695,7 +9000,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_73_candidate_queue_review_decision_writer_run_package" + assert data["phase"] == "phase_74_candidate_queue_review_decision_writer_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False