From d32b1f0e8072775f3aadf5002c758766118c568c Mon Sep 17 00:00:00 2001 From: OoO Date: Tue, 19 May 2026 20:52:14 +0800 Subject: [PATCH] =?UTF-8?q?=E6=96=B0=E5=A2=9E=E5=B8=82=E5=A0=B4=E6=83=85?= =?UTF-8?q?=E5=A0=B1=20review=20decision=20writer=20run=20closeout?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TODO_NEXT_STEPS.txt | 2 +- config.py | 2 +- ...s-platform-market-campaign-intelligence.md | 1 + .../code_modularization_inventory_20260430.md | 3 +- routes/README.md | 4 +- routes/market_intel_review_routes.py | 150 +++-- ...eue_review_decision_writer_run_closeout.py | 352 ++++++++++++ services/market_intel/deployment_readiness.py | 12 +- services/market_intel/phase.py | 2 +- templates/market_intel/disabled.html | 108 ++++ tests/test_market_intel_skeleton.py | 524 +++++++++++++++--- 11 files changed, 1039 insertions(+), 121 deletions(-) create mode 100644 services/market_intel/candidate_queue_review_decision_writer_run_closeout.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index c659f35..fd4b49f 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -150,7 +150,7 @@ - Phase 73 candidate queue review decision writer run package：新增 `services/market_intel/candidate_queue_review_decision_writer_run_package.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 與 UI package 按鈕，將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 run package；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.262。 - Phase 74 candidate queue review decision writer run readiness：新增 `services/market_intel/candidate_queue_review_decision_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 與 UI readiness 按鈕，檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.264。 - Phase 75 candidate queue review decision writer run receipt：新增 `services/market_intel/candidate_queue_review_decision_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 與 UI receipt 按鈕，審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.266。 - - Phase 76 candidate queue review decision writer run closeout：新增 `services/market_intel/candidate_queue_review_decision_writer_run_closeout.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 與 UI closeout 按鈕，在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.267。 + - Phase 76 candidate queue review decision writer run closeout：新增 `services/market_intel/candidate_queue_review_decision_writer_run_closeout.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 與 UI closeout 按鈕，在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.268。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/config.py b/config.py index 7874031..af5955d 100644 --- a/config.py +++ b/config.py @@ -320,7 +320,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.267" +SYSTEM_VERSION = "V10.268" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index b086cb0..c73a006 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -201,6 +201,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review decision writer run package：`services.market_intel.candidate_queue_review_decision_writer_run_package` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package` 將 review_state transaction、preflight、operator drill、writer gate、post-write smoke、必要 artifact 與 rollback plan 組成正式 CLI 更新前的可稽核 package。此 package 只輸出預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run readiness：`services.market_intel.candidate_queue_review_decision_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備。此 readiness 只輸出操作員 gate 預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run receipt：`services.market_intel.candidate_queue_review_decision_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue review decision writer run closeout：`services.market_intel.candidate_queue_review_decision_writer_run_closeout` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要。此 closeout 只允許放行到後續人工/只讀檢查；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 8704468..98b045d 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -13,6 +13,7 @@ - 2026-05-18 追記：Phase 42 市場情報只在 `app.py` 的 `EXPECTED_METADATA_TABLES` 補上 `market_alert_review_queue` 名稱，未新增 route / bootstrap 邏輯；後續仍應把 metadata verification 抽到 app factory 或 startup guard module，避免 `app.py` 繼續承接功能。 - 2026-05-19 追記：同步治理測試盤點，校正 `routes/admin_observability_routes.py` 行數；此處只更新 inventory，不變更觀測台功能。 - 2026-05-19 追記：V10.229 之後 `services/ppt_vision_service.py` 進入 800 行治理清單；本次只補 inventory 讓守門測試反映現況，不變更 PPT 視覺 QA 功能。 +- 2026-05-19 追記：同步背景 V10.267 ElephantAlpha 更新後的 `services/elephant_alpha_autonomous_engine.py` 行數；此處只更新 inventory，不變更 AI engine 行為。 ## 達到或超過 800 行檔案清單 @@ -30,7 +31,7 @@ | 1485 | `routes/vendor_routes.py` | P1 Vendor Blueprint | route glue / stockout mutation/email；V2 page query、stockout list/batches API query、vendor list/detail query 已抽到 `services/vendor_stockout_query_service.py` | | 1390 | `services/telegram_bot_service.py` | P1 Telegram service | command handlers / message formatters / bot client | | 1237 | `app.py` | P1 bootstrap | 保持只做 app setup；繼續往 app_factory / extension setup 抽；Phase 42 只做 metadata table name 對齊 | -| 1144 | `services/elephant_alpha_autonomous_engine.py` | P1 ElephantAlpha engine | HITL / executor / planning policy | +| 1597 | `services/elephant_alpha_autonomous_engine.py` | P1 ElephantAlpha engine | HITL / executor / planning policy | | 970 | `routes/cicd_routes.py` | P2 CI/CD Blueprint | route glue / CI query service / deployment action service | | 1017 | `run_scheduler.py` | P2 scheduler entrypoint | observability jobs / token report jobs / task registration 分離 | | 916 | `services/ppt_auto_generation_service.py` | P2 PPT 自動產線 service | schedule resolver / generation queue / missing report planner | diff --git a/routes/README.md b/routes/README.md index 0c434da..925542a 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,8 +19,8 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 75 candidate queue review decision writer run receipt 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | -| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` | +| `market_intel_routes.py` | 市場情報 Phase 76 candidate queue review decision writer run closeout 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py index cc8ca42..3717fde 100644 --- a/routes/market_intel_review_routes.py +++ b/routes/market_intel_review_routes.py @@ -42,6 +42,9 @@ from services.market_intel.candidate_queue_review_decision_writer_run_readiness from services.market_intel.candidate_queue_review_decision_writer_run_receipt import ( build_candidate_queue_review_decision_writer_run_receipt, ) +from services.market_intel.candidate_queue_review_decision_writer_run_closeout import ( + build_candidate_queue_review_decision_writer_run_closeout, +) from services.market_intel.candidate_queue_writer_cli import ( build_candidate_queue_writer_cli_plan, ) @@ -250,6 +253,80 @@ def _build_review_decision_transaction_stack( ) +def _build_review_decision_writer_receipt_stack( + *, + service, + sample_result, + payload_error, + operator_evidence, + writer_output, + postwrite_smoke_result, + limit, +): + transaction = _build_review_decision_transaction_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + limit=limit, + execute_requested=False, + ) + writer_status = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + operator_evidence=operator_evidence, + execute_requested=False, + apply_real_write=False, + approval_token=None, + approval_token_secret=None, + backup_verified=False, + review_inventory_smoke_passed=False, + ) + writer_preflight = build_candidate_queue_review_decision_writer_preflight( + writer_status=writer_status, + transaction_preview=transaction, + operator_evidence=operator_evidence, + execute_requested=False, + apply_real_write=False, + ) + postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + operator_drill = build_candidate_queue_review_decision_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_evidence=operator_evidence, + ) + run_package = build_candidate_queue_review_decision_writer_run_package( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + ) + run_readiness = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=writer_preflight, + writer_status=writer_status, + postwrite_smoke=postwrite_smoke, + operator_drill=operator_drill, + run_package=run_package, + operator_evidence=operator_evidence, + ) + receipt = build_candidate_queue_review_decision_writer_run_receipt( + transaction_preview=transaction, + run_readiness=run_readiness, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=operator_evidence, + ) + return transaction, receipt + + @market_intel_review_bp.route( "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", methods=["POST"], @@ -671,7 +748,7 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_run_receip sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( _extract_run_payload() ) - transaction = _build_review_decision_transaction_stack( + transaction, data = _build_review_decision_writer_receipt_stack( service=service, sample_result=sample_result, payload_error=payload_error, @@ -679,57 +756,34 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_run_receip writer_output=writer_output, postwrite_smoke_result=smoke_result, limit=limit, - execute_requested=False, ) - writer_status = build_candidate_queue_review_decision_writer_cli_plan( - transaction_preview=transaction, + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_closeout", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeout(): + service = MarketIntelService() + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction, receipt = _build_review_decision_writer_receipt_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, operator_evidence=operator_evidence, - execute_requested=False, - apply_real_write=False, - approval_token=None, - approval_token_secret=None, - backup_verified=False, - review_inventory_smoke_passed=False, - ) - writer_preflight = build_candidate_queue_review_decision_writer_preflight( - writer_status=writer_status, - transaction_preview=transaction, - operator_evidence=operator_evidence, - execute_requested=False, - apply_real_write=False, - ) - postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( - transaction_preview=transaction, - execute_requested=False, - ) - operator_drill = build_candidate_queue_review_decision_writer_operator_drill( - transaction_preview=transaction, - writer_preflight=writer_preflight, - writer_status=writer_status, - postwrite_smoke=postwrite_smoke, - operator_evidence=operator_evidence, - ) - run_package = build_candidate_queue_review_decision_writer_run_package( - transaction_preview=transaction, - writer_preflight=writer_preflight, - writer_status=writer_status, - postwrite_smoke=postwrite_smoke, - operator_drill=operator_drill, - ) - run_readiness = build_candidate_queue_review_decision_writer_run_readiness( - transaction_preview=transaction, - writer_preflight=writer_preflight, - writer_status=writer_status, - postwrite_smoke=postwrite_smoke, - operator_drill=operator_drill, - run_package=run_package, - operator_evidence=operator_evidence, - ) - data = build_candidate_queue_review_decision_writer_run_receipt( - transaction_preview=transaction, - run_readiness=run_readiness, writer_output=writer_output, postwrite_smoke_result=smoke_result, + limit=limit, + ) + data = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=transaction, + run_receipt=receipt, operator_evidence=operator_evidence, ) data["phase"] = service.phase diff --git a/services/market_intel/candidate_queue_review_decision_writer_run_closeout.py b/services/market_intel/candidate_queue_review_decision_writer_run_closeout.py new file mode 100644 index 0000000..90dadbd --- /dev/null +++ b/services/market_intel/candidate_queue_review_decision_writer_run_closeout.py @@ -0,0 +1,352 @@ +"""候選審核 queue review_state writer operator run closeout preview。 + +本模組只在 review_state receipt review 之後整理 closeout gate；不回吐 +原始 receipt、不讀 approval token、不執行 CLI、不開 DB connection、不更新 +review_state、不 commit、不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +REQUIRED_RECEIPT_BOUNDARIES = { + "do_not_execute_review_state_writer_from_receipt_api", + "do_not_read_approval_token_from_receipt_api", + "do_not_echo_operator_receipt_payload", + "do_not_open_database_connection_from_review_state_receipt", + "do_not_update_review_state_from_review_state_receipt", + "do_not_commit_review_state_receipt", + "do_not_attach_scheduler_from_review_state_receipt", +} + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _receipt_summary(run_receipt): + run_receipt = _as_dict(run_receipt) + writer = _as_dict(run_receipt.get("writer_output_summary")) + smoke = _as_dict(run_receipt.get("postwrite_smoke_summary")) + expected_keys = _as_list(run_receipt.get("expected_dedupe_keys")) + expected_updates = _as_list(run_receipt.get("expected_review_state_updates")) + blocked_reasons = _as_list(run_receipt.get("blocked_reasons")) + safe_boundaries = set(str(item) for item in _as_list(run_receipt.get("safe_boundaries"))) + missing_boundaries = sorted(REQUIRED_RECEIPT_BOUNDARIES - safe_boundaries) + + return { + "provided": bool(run_receipt), + "mode": run_receipt.get("mode"), + "target_operation": run_receipt.get("target_operation"), + "receipt_passed": bool(run_receipt.get("receipt_passed")), + "ready_for_next_manual_phase": bool( + run_receipt.get("ready_for_next_manual_phase") + ), + "expected_dedupe_key_count": len(expected_keys), + "expected_review_state_update_count": len(expected_updates), + "blocked_count": len(blocked_reasons), + "writer_mode": writer.get("mode"), + "writer_review_state_update_executed": bool( + writer.get("review_state_update_executed") + ), + "writer_dedupe_keys_match_expected": bool( + writer.get("dedupe_keys_match_expected") + ), + "postwrite_smoke_passed": bool(smoke.get("postwrite_smoke_passed")), + "postwrite_smoke_read_only": bool(smoke.get("read_only_query_executed")), + "postwrite_smoke_review_state_verified": bool( + smoke.get("review_state_update_verified") + ), + "postwrite_smoke_dedupe_keys_match_expected": bool( + smoke.get("dedupe_keys_match_expected") + ), + "safe_boundaries_complete": not missing_boundaries, + "missing_safe_boundaries": missing_boundaries, + "ready_for_api_review_state_update": bool( + run_receipt.get("ready_for_api_review_state_update") + ), + "ready_for_api_database_write": bool( + run_receipt.get("ready_for_api_database_write") + ), + "ready_for_scheduler_attach": bool(run_receipt.get("ready_for_scheduler_attach")), + "api_executes_cli": bool(run_receipt.get("api_executes_cli")), + "api_reads_approval_token": bool(run_receipt.get("api_reads_approval_token")), + "api_writes_file": bool(run_receipt.get("api_writes_file")), + "api_writes_database": bool(run_receipt.get("api_writes_database")), + "api_updates_review_state": bool(run_receipt.get("api_updates_review_state")), + "database_connection_opened": bool( + run_receipt.get("database_connection_opened") + ), + "database_write_executed": bool(run_receipt.get("database_write_executed")), + "database_commit_executed": bool(run_receipt.get("database_commit_executed")), + "review_state_update_executed": bool( + run_receipt.get("review_state_update_executed") + ), + "scheduler_attached": bool(run_receipt.get("scheduler_attached")), + } + + +def _operator_closeout_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "closeout_artifact_path_recorded": _has_text( + operator_evidence.get("review_state_closeout_artifact_path") + or operator_evidence.get("closeout_artifact_path") + ), + "operator_confirmed_review_state_closeout_next": bool( + operator_evidence.get("operator_confirmed_review_state_closeout_next") + or operator_evidence.get("operator_confirmed_queue_review_next") + ), + "operator_confirmed_post_closeout_inventory_read_only": bool( + operator_evidence.get("operator_confirmed_post_closeout_inventory_read_only") + or operator_evidence.get("operator_confirmed_inventory_read_only") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "closeout_notes_recorded": _has_text(operator_evidence.get("closeout_notes")), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _closeout_gates(receipt_summary, closeout_summary): + return [ + { + "key": "receipt_preview_provided", + "label": "必須提供上一階段 review_state receipt preview 摘要", + "passed": bool( + receipt_summary["provided"] + and receipt_summary["mode"] + == "candidate_queue_review_decision_writer_run_receipt_preview" + ), + }, + { + "key": "receipt_target_operation_review_state", + "label": "receipt 必須鎖定 market_alert_review_queue.review_state 更新", + "passed": receipt_summary["target_operation"] == "update_review_state", + }, + { + "key": "receipt_passed", + "label": "receipt 必須已通過 writer output 與 post-write smoke 審核", + "passed": receipt_summary["receipt_passed"], + }, + { + "key": "receipt_ready_for_next_manual_phase", + "label": "receipt 只能放行到下一個人工/只讀階段", + "passed": receipt_summary["ready_for_next_manual_phase"], + }, + { + "key": "receipt_expected_review_state_updates_present", + "label": "receipt 必須保有 review_state update 與 dedupe key 摘要", + "passed": bool( + receipt_summary["expected_dedupe_key_count"] + and receipt_summary["expected_review_state_update_count"] + ), + }, + { + "key": "writer_and_smoke_review_state_confirmed", + "label": "writer output 與 smoke 必須確認 review_state 更新且 key 一致", + "passed": bool( + receipt_summary["writer_review_state_update_executed"] + and receipt_summary["writer_dedupe_keys_match_expected"] + and receipt_summary["postwrite_smoke_read_only"] + and receipt_summary["postwrite_smoke_passed"] + and receipt_summary["postwrite_smoke_review_state_verified"] + and receipt_summary["postwrite_smoke_dedupe_keys_match_expected"] + ), + }, + { + "key": "receipt_safe_boundaries_complete", + "label": "receipt 必須保留不讀 token、不執行 CLI、不更新 review_state 的安全邊界", + "passed": receipt_summary["safe_boundaries_complete"], + }, + { + "key": "receipt_no_api_review_state_update", + "label": "closeout 前不得出現 API/UI review_state 更新", + "passed": bool( + not receipt_summary["ready_for_api_review_state_update"] + and not receipt_summary["api_updates_review_state"] + and not receipt_summary["review_state_update_executed"] + ), + }, + { + "key": "receipt_no_api_database_write", + "label": "closeout 前不得出現 API/UI DB 寫入或 commit", + "passed": bool( + not receipt_summary["ready_for_api_database_write"] + and not receipt_summary["api_writes_database"] + and not receipt_summary["database_write_executed"] + and not receipt_summary["database_commit_executed"] + ), + }, + { + "key": "receipt_no_scheduler_or_cli_attach", + "label": "closeout 前不得從 API/UI 執行 CLI 或掛 scheduler", + "passed": bool( + not receipt_summary["ready_for_scheduler_attach"] + and not receipt_summary["api_executes_cli"] + and not receipt_summary["scheduler_attached"] + ), + }, + { + "key": "receipt_no_token_or_file_side_effect", + "label": "closeout 前 API/UI 不得讀 token 或寫 artifact 檔案", + "passed": bool( + not receipt_summary["api_reads_approval_token"] + and not receipt_summary["api_writes_file"] + ), + }, + { + "key": "closeout_artifact_path_recorded", + "label": "操作員需記錄 review_state closeout artifact 路徑", + "passed": closeout_summary["closeout_artifact_path_recorded"], + }, + { + "key": "operator_confirmed_review_state_closeout_next", + "label": "操作員確認下一步只進 review_state 後續人工/只讀檢查", + "passed": closeout_summary["operator_confirmed_review_state_closeout_next"], + }, + { + "key": "operator_confirmed_post_closeout_inventory_read_only", + "label": "操作員確認 closeout 後 inventory/smoke 仍為只讀", + "passed": closeout_summary[ + "operator_confirmed_post_closeout_inventory_read_only" + ], + }, + { + "key": "operator_confirmed_no_scheduler_attach", + "label": "操作員確認本階段不掛 scheduler", + "passed": closeout_summary["operator_confirmed_no_scheduler_attach"], + }, + { + "key": "operator_confirmed_no_api_db_write", + "label": "操作員確認本階段不由 API/UI 寫 DB", + "passed": closeout_summary["operator_confirmed_no_api_db_write"], + }, + { + "key": "closeout_no_approval_token_submitted_to_api", + "label": "closeout payload 不得包含一次性 approval token key", + "passed": not closeout_summary["approval_token_submitted_to_api"], + }, + ] + + +def build_candidate_queue_review_decision_writer_run_closeout( + *, + transaction_preview, + run_receipt, + operator_evidence=None, +): + """建立 review_state CLI 更新後 closeout gate；不執行任何副作用。""" + receipt_summary = _receipt_summary(run_receipt) + closeout_summary = _operator_closeout_summary(operator_evidence) + gates = _closeout_gates(receipt_summary, closeout_summary) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + closeout_passed = bool(not blocked_reasons) + statement_count = len(_as_list(_as_dict(transaction_preview).get("statements"))) + + return { + "mode": "candidate_queue_review_decision_writer_run_closeout_preview", + "target_table": "market_alert_review_queue", + "target_operation": "update_review_state", + "closeout_reviewed": True, + "closeout_passed": closeout_passed, + "ready_for_next_manual_phase": closeout_passed, + "ready_for_review_inventory": closeout_passed, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "approval_record_written": False, + "decision_record_written": False, + "review_state_update_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "statement_count": statement_count, + "blocked_reasons": blocked_reasons, + "gates": gates, + "receipt_summary": receipt_summary, + "operator_closeout_summary": closeout_summary, + "promotion_gate": { + "allowed": closeout_passed, + "next_manual_phase": "review_state_post_closeout_read_only_inventory", + "requires_real_db_write": False, + "requires_scheduler_attach": False, + "requires_operator_approval": True, + }, + "next_operator_steps": [ + "保存 review_state closeout artifact 與 receipt 摘要", + "以人工方式執行 post-closeout live inventory read-only smoke", + "只檢查 review_state 已完成的 queue row，不從 UI/API 補寫資料", + "若任何 closeout gate 阻擋，停在 receipt 階段並保留 feature flags 關閉", + ], + "safe_boundaries": [ + "do_not_echo_operator_receipt_payload", + "do_not_execute_review_state_writer_from_closeout_api", + "do_not_read_approval_token_from_closeout_api", + "do_not_write_closeout_artifact_from_api", + "do_not_open_database_connection_from_review_state_closeout", + "do_not_update_review_state_from_review_state_closeout", + "do_not_commit_review_state_closeout", + "do_not_attach_scheduler_from_review_state_closeout", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 5a02ae9..586bb88 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -23,10 +23,11 @@ from services.market_intel.candidate_queue_review_decision_writer_operator_drill from services.market_intel.candidate_queue_review_decision_writer_run_package import build_candidate_queue_review_decision_writer_run_package from services.market_intel.candidate_queue_review_decision_writer_run_readiness import build_candidate_queue_review_decision_writer_run_readiness from services.market_intel.candidate_queue_review_decision_writer_run_receipt import build_candidate_queue_review_decision_writer_run_receipt +from services.market_intel.candidate_queue_review_decision_writer_run_closeout import build_candidate_queue_review_decision_writer_run_closeout BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database") -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -155,6 +156,10 @@ def build_deployment_readiness_preview( transaction_preview=candidate_queue_review_decision_transaction, run_readiness=candidate_queue_review_decision_writer_run_readiness, ) + candidate_queue_review_decision_writer_run_closeout = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=candidate_queue_review_decision_transaction, + run_receipt=candidate_queue_review_decision_writer_run_receipt, + ) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -417,6 +422,10 @@ def build_deployment_readiness_preview( candidate_queue_review_decision_writer_run_receipt, "candidate_queue_review_decision_writer_run_receipt_preview", ), + "candidate_queue_review_decision_writer_run_closeout_preview_safe": _run_review_preview_safe( + candidate_queue_review_decision_writer_run_closeout, + "candidate_queue_review_decision_writer_run_closeout_preview", + ), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -659,6 +668,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_decision_writer_run_package": candidate_queue_review_decision_writer_run_package, "candidate_queue_review_decision_writer_run_readiness": candidate_queue_review_decision_writer_run_readiness, "candidate_queue_review_decision_writer_run_receipt": candidate_queue_review_decision_writer_run_receipt, + "candidate_queue_review_decision_writer_run_closeout": candidate_queue_review_decision_writer_run_closeout, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index d00b1a9..906af8c 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_75_candidate_queue_review_decision_writer_run_receipt" +MARKET_INTEL_PHASE = "phase_76_candidate_queue_review_decision_writer_run_closeout" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 90e8edb..0e7e905 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -664,6 +664,9 @@ + @@ -1013,6 +1016,7 @@ const sampleCandidateQueueReviewDecisionRunReadiness = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-readiness]') : null; const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null; const sampleCandidateQueueReviewDecisionRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-receipt]') : null; + const sampleCandidateQueueReviewDecisionRunCloseout = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-closeout]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1039,6 +1043,7 @@ const sampleCandidateQueueReviewDecisionRunReadinessEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_readiness') }}"; const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}"; const sampleCandidateQueueReviewDecisionRunReceiptEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt') }}"; + const sampleCandidateQueueReviewDecisionRunCloseoutEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeout') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -4313,6 +4318,106 @@ } }; + const renderCandidateQueueReviewDecisionRunCloseout = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const receipt = data.receipt_summary || {}; + const closeout = data.operator_closeout_summary || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `closeout=${data.closeout_passed ? 'pass' : 'blocked'}`, + `receipt=${receipt.receipt_passed ? 'pass' : 'blocked'}`, + `updates=${receipt.expected_review_state_update_count || 0}`, + `api_update=${data.ready_for_api_review_state_update ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只收尾 review_state writer run closeout；API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

CLOSEOUT GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 closeout gate。
' + }
+
+
+

RECEIPT SUMMARY

+
+ ${[ + ['target_operation', receipt.target_operation || 'unknown'], + ['receipt_passed', receipt.receipt_passed], + ['safe_boundaries_complete', receipt.safe_boundaries_complete], + ['writer_review_state_update', receipt.writer_review_state_update_executed], + ['smoke_review_state_verified', receipt.postwrite_smoke_review_state_verified], + ['api_updates_review_state', receipt.api_updates_review_state] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

OPERATOR CLOSEOUT

+
+ ${[ + ['closeout_artifact_path_recorded', closeout.closeout_artifact_path_recorded], + ['review_state_closeout_next', closeout.operator_confirmed_review_state_closeout_next], + ['inventory_read_only', closeout.operator_confirmed_post_closeout_inventory_read_only], + ['no_scheduler_attach', closeout.operator_confirmed_no_scheduler_attach], + ['no_api_db_write', closeout.operator_confirmed_no_api_db_write], + ['approval_token_submitted_to_api', closeout.approval_token_submitted_to_api] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${value ? 'YES' : 'NO'} +
+ `).join('')} +
+
+
+ `; + }; + + const loadCandidateQueueReviewDecisionRunCloseout = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
收尾 queue review decision writer run closeout 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewDecisionRunCloseoutEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewDecisionRunCloseout(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review decision writer run closeout 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -5992,6 +6097,9 @@ if (sampleCandidateQueueReviewDecisionRunReceipt) { sampleCandidateQueueReviewDecisionRunReceipt.addEventListener('click', loadCandidateQueueReviewDecisionRunReceipt); } + if (sampleCandidateQueueReviewDecisionRunCloseout) { + sampleCandidateQueueReviewDecisionRunCloseout.addEventListener('click', loadCandidateQueueReviewDecisionRunCloseout); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index f4a6b0c..8981d36 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -251,6 +251,155 @@ def _build_ready_review_decision_transaction( return transaction, transaction_evidence +def _build_review_decision_writer_receipt_fixture( + batch_id="sample-batch-review-decision-writer-closeout" +): + from services.market_intel.candidate_queue_review_decision_writer_cli import ( + build_candidate_queue_review_decision_writer_cli_plan, + ) + from services.market_intel.candidate_queue_review_decision_writer_preflight import ( + build_candidate_queue_review_decision_writer_preflight, + ) + from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import ( + build_candidate_queue_review_decision_writer_postwrite_smoke, + ) + from services.market_intel.candidate_queue_review_decision_writer_operator_drill import ( + build_candidate_queue_review_decision_writer_operator_drill, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_package import ( + build_candidate_queue_review_decision_writer_run_package, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_readiness import ( + build_candidate_queue_review_decision_writer_run_readiness, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_receipt import ( + build_candidate_queue_review_decision_writer_run_receipt, + ) + + transaction, operator_evidence = _build_ready_review_decision_transaction( + batch_id + ) + expected_key = transaction["statements"][0]["lookup"]["dedupe_key"] + operator_evidence = { + **operator_evidence, + "operator_confirmed_manual_shell_window": True, + "operator_confirmed_post_update_inventory_planned": True, + "operator_drill_notes": "review_state shell drill reviewed", + } + writer_status = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + operator_evidence=operator_evidence, + ) + preflight = build_candidate_queue_review_decision_writer_preflight( + writer_status=writer_status, + transaction_preview=transaction, + operator_evidence=operator_evidence, + ) + smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=False, + ) + drill = build_candidate_queue_review_decision_writer_operator_drill( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_evidence=operator_evidence, + ) + package = build_candidate_queue_review_decision_writer_run_package( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + ) + receipt_evidence = { + **operator_evidence, + "review_state_transaction_json_path": ( + "artifacts/market_intel/review-state-transaction.json" + ), + "backup_artifact_path": "scripts/tools/backups/backup.zip", + "preflight_artifact_path": ( + "artifacts/market_intel/review-state-preflight.json" + ), + "operator_confirmed_review_state_preflight_only": True, + "operator_acknowledged_shell_only_token": True, + "review_state_writer_output_json_path": ( + "artifacts/market_intel/review-state-writer-output.json" + ), + "review_state_postwrite_smoke_json_path": ( + "artifacts/market_intel/review-state-postwrite-smoke.json" + ), + "operator_confirmed_no_token_in_artifacts": True, + "receipt_notes": "review_state receipt reviewed", + } + readiness = build_candidate_queue_review_decision_writer_run_readiness( + transaction_preview=transaction, + writer_preflight=preflight, + writer_status=writer_status, + postwrite_smoke=smoke, + operator_drill=drill, + run_package=package, + operator_evidence=receipt_evidence, + ) + writer_output = { + "mode": "candidate_queue_review_decision_writer_cli_executed", + "exit_code": 0, + "approval_token_present": True, + "approval_token_valid": True, + "approval_token_secret_configured": True, + "approval_env_var": "MARKET_INTEL_QUEUE_WRITE_APPROVAL", + "writes_executed": True, + "would_write_database": True, + "database_connection_opened": True, + "explicit_transaction_opened": True, + "database_write_executed": True, + "database_commit_executed": True, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "api_updates_review_state": False, + "review_state_update_executed": True, + "updated_count": 1, + "skipped_count": 0, + "affected_dedupe_keys": [expected_key], + "skipped_dedupe_keys": [], + } + postwrite_smoke_result = { + "mode": "candidate_queue_review_decision_writer_postwrite_smoke_read_only", + "postwrite_smoke_passed": True, + "review_state_update_verified": True, + "ready_for_operator_review": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "expected_dedupe_key_count": 1, + "found_count": 1, + "missing_count": 0, + "state_mismatch_count": 0, + "found_dedupe_keys": [expected_key], + "missing_dedupe_keys": [], + "state_mismatches": [], + } + receipt = build_candidate_queue_review_decision_writer_run_receipt( + transaction_preview=transaction, + run_readiness=readiness, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + operator_evidence=receipt_evidence, + ) + return { + "transaction": transaction, + "operator_evidence": receipt_evidence, + "writer_output": writer_output, + "postwrite_smoke_result": postwrite_smoke_result, + "receipt": receipt, + } + + def test_market_intel_defaults_are_safe(): service = MarketIntelService() status = service.get_runtime_status().to_dict() @@ -860,6 +1009,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeout" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -888,6 +1041,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-decision-run-receipt" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-decision-run-closeout" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -924,7 +1081,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert bridge["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1082,7 +1239,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert contract["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1215,7 +1372,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1228,7 +1385,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert gate["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1298,7 +1455,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1310,7 +1467,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1358,7 +1515,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1369,7 +1526,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert acceptance["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1411,7 +1568,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1423,7 +1580,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert review["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1534,7 +1691,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1573,7 +1730,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert review["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1635,7 +1792,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1715,7 +1872,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert handoff["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1779,7 +1936,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1838,7 +1995,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert queue_draft["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1912,7 +2069,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1975,7 +2132,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert approval["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2053,7 +2210,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2116,7 +2273,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert transaction["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2196,7 +2353,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -4610,6 +4767,84 @@ def test_candidate_queue_review_decision_writer_run_receipt_preview_reviews_oper ) +def test_candidate_queue_review_decision_writer_run_closeout_preview_blocks_api_write_and_tokens(): + from services.market_intel.candidate_queue_review_decision_writer_run_closeout import ( + build_candidate_queue_review_decision_writer_run_closeout, + ) + + fixture = _build_review_decision_writer_receipt_fixture( + "sample-batch-review-state-closeout" + ) + closeout_evidence = { + **fixture["operator_evidence"], + "review_state_closeout_artifact_path": ( + "artifacts/market_intel/review-state-closeout.json" + ), + "operator_confirmed_review_state_closeout_next": True, + "operator_confirmed_post_closeout_inventory_read_only": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "closeout_notes": "review_state closeout reviewed", + } + closeout = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=fixture["receipt"], + operator_evidence=closeout_evidence, + ) + token_leak = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=fixture["receipt"], + operator_evidence={ + **closeout_evidence, + "approval_token": TEST_APPROVAL_TOKEN, + }, + ) + + assert closeout["mode"] == ( + "candidate_queue_review_decision_writer_run_closeout_preview" + ) + assert closeout["target_operation"] == "update_review_state" + assert closeout["closeout_passed"] is True + assert closeout["ready_for_next_manual_phase"] is True + assert closeout["ready_for_review_inventory"] is True + assert closeout["ready_for_api_review_state_update"] is False + assert closeout["ready_for_api_database_write"] is False + assert closeout["ready_for_scheduler_attach"] is False + assert closeout["api_executes_cli"] is False + assert closeout["api_reads_approval_token"] is False + assert closeout["api_writes_file"] is False + assert closeout["api_writes_database"] is False + assert closeout["api_updates_review_state"] is False + assert closeout["review_state_update_executed"] is False + assert closeout["database_connection_opened"] is False + assert closeout["database_write_executed"] is False + assert closeout["database_commit_executed"] is False + assert closeout["scheduler_attached"] is False + assert closeout["blocked_reasons"] == [] + assert closeout["receipt_summary"]["target_operation"] == "update_review_state" + assert closeout["receipt_summary"]["receipt_passed"] is True + assert closeout["receipt_summary"]["safe_boundaries_complete"] is True + assert closeout["operator_closeout_summary"][ + "closeout_artifact_path_recorded" + ] is True + assert closeout["promotion_gate"]["requires_real_db_write"] is False + assert "do_not_update_review_state_from_review_state_closeout" in closeout[ + "safe_boundaries" + ] + assert token_leak["closeout_passed"] is False + assert token_leak["operator_closeout_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "closeout_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -4652,7 +4887,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4709,7 +4944,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -4798,7 +5033,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4852,7 +5087,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -4908,7 +5143,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -4974,7 +5209,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -5276,7 +5511,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -5324,7 +5559,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -5373,7 +5608,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -5431,7 +5666,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -5497,7 +5732,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -5568,7 +5803,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -5644,7 +5879,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -5726,7 +5961,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -5812,7 +6047,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -5895,7 +6130,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -5978,7 +6213,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -6064,7 +6299,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -6155,7 +6390,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_75_candidate_queue_review_decision_writer_run_receipt" + "phase_76_candidate_queue_review_decision_writer_run_closeout" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -6265,7 +6500,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_75_candidate_queue_review_decision_writer_run_receipt" + "phase_76_candidate_queue_review_decision_writer_run_closeout" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -6289,6 +6524,94 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-review-decision-run-closeout-route" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_closeout" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_closeout" + "?execute=true&apply_real_write=true", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": { + **fixture["operator_evidence"], + "review_state_closeout_artifact_path": ( + "artifacts/market_intel/review-state-closeout.json" + ), + "operator_confirmed_review_state_closeout_next": True, + "operator_confirmed_post_closeout_inventory_read_only": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "closeout_notes": "review_state closeout reviewed", + }, + "writer_output": { + **fixture["writer_output"], + "mode": "candidate_queue_review_decision_writer_cli_executed", + "review_state_update_executed": True, + "api_updates_review_state": False, + }, + "postwrite_smoke_result": { + **fixture["postwrite_smoke_result"], + "mode": ( + "candidate_queue_review_decision_writer_postwrite_smoke_read_only" + ), + "review_state_update_verified": True, + "state_mismatch_count": 0, + "state_mismatches": [], + }, + }, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_decision_writer_run_closeout_preview" + ) + assert data["phase"] == ( + "phase_76_candidate_queue_review_decision_writer_run_closeout" + ) + assert data["closeout_passed"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_writes_file"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["scheduler_attached"] is False + assert data["receipt_summary"]["expected_dedupe_key_count"] == 0 + assert "receipt_expected_review_state_updates_present" in data[ + "blocked_reasons" + ] + assert "do_not_update_review_state_from_review_state_closeout" in data[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6317,7 +6640,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -6342,7 +6665,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -6380,7 +6703,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -6391,7 +6714,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -6427,7 +6750,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -6438,7 +6761,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -6479,7 +6802,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -6490,7 +6813,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -6538,7 +6861,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -6550,7 +6873,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -6596,7 +6919,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -6609,7 +6932,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -6694,7 +7017,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -6772,7 +7095,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -6787,7 +7110,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert readiness["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -7269,6 +7592,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_decision_writer_run_closeout_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -7393,6 +7722,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_decision_writer_run_receipt" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_run_closeout" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -8484,6 +8818,64 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"]["mode"] + == "candidate_queue_review_decision_writer_run_closeout_preview" + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "closeout_passed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "ready_for_api_review_state_update" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "api_executes_cli" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "api_reads_approval_token" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "api_updates_review_state" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "review_state_update_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_run_closeout"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -8634,7 +9026,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert drill["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -8749,7 +9141,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -8761,7 +9153,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert review["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -8876,7 +9268,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -8889,7 +9281,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert smoke["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -8951,7 +9343,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -8964,7 +9356,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert inventory["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -9108,7 +9500,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -9335,7 +9727,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -9364,7 +9756,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_75_candidate_queue_review_decision_writer_run_receipt" + assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False