From c196a0e228a297e677dd4599fdcd1f885695bbee Mon Sep 17 00:00:00 2001 From: OoO Date: Sun, 31 May 2026 12:51:00 +0800 Subject: [PATCH] V10.493 add market intel candidate handoff review gate --- ...s-platform-market-campaign-intelligence.md | 1 + docs/memory/history_logs.md | 1 + routes/market_intel_mcp_run_routes.py | 46 ++ services/market_intel/deployment_readiness.py | 41 + .../mcp_fetch_candidate_handoff_review.py | 758 ++++++++++++++++++ services/market_intel/phase.py | 2 +- templates/market_intel/disabled.html | 174 +++- tests/test_market_intel_skeleton.py | 486 +++++++---- 8 files changed, 1350 insertions(+), 159 deletions(-) create mode 100644 services/market_intel/mcp_fetch_candidate_handoff_review.py diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 202f0af..602f87d 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -164,6 +164,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-24 追加 MCP fetch run readiness gate：`services.market_intel.mcp_fetch_run_readiness` 與 `/api/market_intel/mcp_fetch_run_readiness` 在 run package 後檢查 command preview、receipt path、artifact path、節流/timeout/dry-run-first、secret payload 與操作員 shell-only 邊界；此階段不執行 CLI、不發外部 request、不寫 artifact、不開 DB、不掛 scheduler，只放行到人工 shell dry-run 與後續 receipt review。 - 2026-05-29 追加 MCP fetch run receipt gate：`services.market_intel.mcp_fetch_run_receipt` 與 `/api/market_intel/mcp_fetch_run_receipt` 在操作員 shell 完成 dry-run fetch 後審核 receipt id、artifact path、platform/source/receipt path 對帳、公開 URL、request/error budget、secret 外洩與 API/DB/scheduler 副作用旗標；API/UI 不執行 CLI、不發外部 request、不保存 receipt、不開 DB、不寫入、不掛 scheduler，只放行到後續 result parser review。 - 2026-05-31 追加 MCP fetch result parser review gate：`services.market_intel.mcp_fetch_result_parser_review` 與 `/api/market_intel/mcp_fetch_result_parser_review` 在 receipt 通過後審核操作員貼回的 parser 結構化摘要，檢查 receipt source/receipt path 對帳、parser artifact path、活動/商品候選必要欄位、公開 URL、小批次候選上限、raw HTML/secret 外洩與 API/DB/scheduler 副作用旗標；API/UI 不讀 artifact、不執行 parser CLI、不發外部 request、不保存 parser result、不寫入、不掛 scheduler，只放行到候選 handoff review。 +- 2026-05-31 追加 MCP fetch candidate handoff review gate：`services.market_intel.mcp_fetch_candidate_handoff_review` 與 `/api/market_intel/mcp_fetch_candidate_handoff_review` 在 parser review 通過後審核候選交接包，檢查 source/candidate key 對齊、queue policy 是否仍是 `manual_candidate_review` / `preview_only`、小批次候選上限、操作員無寫入/無連外/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不建立 queue、不讀 artifact、不寫 DB、不掛 scheduler，只放行到人工 candidate queue review。 - 2026-05-18 追加 scheduler attach plan preview：`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB；排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview：`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP；價格只能作為輔助訊號，不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview：`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB；高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 77f388d..aff27af 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24：PChome 近門檻身份回收第二輪 +- **V10.493 市場情報 MCP Fetch Candidate Handoff Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_handoff_review` 與 UI preview，只審核 parser review 後的候選交接包；要求 source/candidate key 完全對齊、queue policy 維持 `manual_candidate_review` / `preview_only`、候選數維持小批次，且 API 不建立 queue、不寫 DB、不讀 artifact、不連外、不掛 scheduler。 - **V10.491 市場情報 MCP Fetch Result Parser Review gate**: 新增 `/api/market_intel/mcp_fetch_result_parser_review` 與 UI preview，只審核操作員 shell parser 後貼回的結構化摘要；API 不讀 artifact、不執行 parser CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler，且會阻擋 raw HTML/body/snapshot、secret/token 欄位與 side-effect flags。 - **V10.489 PChome 低分同款人工覆核回收與 gate-pass 風險邊界**: `marketplace_product_matcher` 新增三個窄範圍 focused identity：TS6 超美白香氛誘霜 120g/ml、W 修護保養蝸牛特潤修護面膜 6 片、Derma 大地 Eco 植萃護膚油 2 入。這些樣本只升到 `identity_review / manual_review`，不進 `price_alert_exact`；同版補 Clarins 身體油不同線、命名組合品數量反轉、isLeaf 香型數量不一致 hard veto，HOOOME 大理石暖燈單側設計差留人工覆核。 - **V10.488 市場情報 MCP Fetch Run Receipt gate**: 新增 `/api/market_intel/mcp_fetch_run_receipt` 與 UI preview，只審核操作員 shell dry-run 後貼回的 receipt；API 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler，且會阻擋 secret/token 欄位與 side-effect flags。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index c4c534d..66bfdd6 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -19,6 +19,9 @@ from services.market_intel.mcp_fetch_run_receipt import ( from services.market_intel.mcp_fetch_result_parser_review import ( build_mcp_fetch_result_parser_review_preview, ) +from services.market_intel.mcp_fetch_candidate_handoff_review import ( + build_mcp_fetch_candidate_handoff_review_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -158,3 +161,46 @@ def market_intel_mcp_fetch_result_parser_review(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_handoff_review", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_handoff_review(): + parser_review_package = {} + parser_review_result = None + candidate_handoff = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("candidate_handoff_review") + or payload.get("handoff_review") + or payload + ) + parser_review_package = ( + package.get("parser_review_package") + or package.get("parser_review") + or package.get("result_parser_review") + or {} + ) + parser_review_result = ( + package.get("parser_review_result") + or package.get("mcp_fetch_result_parser_review") + ) + candidate_handoff = ( + package.get("candidate_handoff") + or package.get("handoff") + or package.get("handoff_payload") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_handoff_review_preview( + parser_review_package=parser_review_package, + parser_review_result=parser_review_result, + candidate_handoff=candidate_handoff, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 62941e9..7d1e6ea 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -75,6 +75,9 @@ from services.market_intel.mcp_fetch_run_receipt import ( from services.market_intel.mcp_fetch_result_parser_review import ( build_mcp_fetch_result_parser_review_preview, ) +from services.market_intel.mcp_fetch_candidate_handoff_review import ( + build_mcp_fetch_candidate_handoff_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -197,6 +200,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_result_parser_review",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_handoff_review",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -236,6 +244,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s mcp_fetch_result_parser_review = build_mcp_fetch_result_parser_review_preview( phase=service.phase, ) + mcp_fetch_candidate_handoff_review = ( + build_mcp_fetch_candidate_handoff_review_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -587,6 +600,33 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_fetch_result_parser_review["file_written"] and not mcp_fetch_result_parser_review["scheduler_attached"] ), + "mcp_fetch_candidate_handoff_review_preview_safe": bool( + mcp_fetch_candidate_handoff_review["mode"] + == "mcp_fetch_candidate_handoff_review_preview" + and not mcp_fetch_candidate_handoff_review["payload_persisted"] + and not mcp_fetch_candidate_handoff_review[ + "candidate_handoff_persisted" + ] + and not mcp_fetch_candidate_handoff_review["candidate_queue_created"] + and not mcp_fetch_candidate_handoff_review["candidate_queue_persisted"] + and not mcp_fetch_candidate_handoff_review[ + "manual_fetch_gate_opened_by_api" + ] + and not mcp_fetch_candidate_handoff_review["network_request_allowed"] + and not mcp_fetch_candidate_handoff_review["api_executes_cli"] + and not mcp_fetch_candidate_handoff_review[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_handoff_review["api_writes_database"] + and not mcp_fetch_candidate_handoff_review["api_uses_external_network"] + and not mcp_fetch_candidate_handoff_review[ + "database_write_executed" + ] + and not mcp_fetch_candidate_handoff_review["fetch_executed"] + and not mcp_fetch_candidate_handoff_review["cli_executed"] + and not mcp_fetch_candidate_handoff_review["file_written"] + and not mcp_fetch_candidate_handoff_review["scheduler_attached"] + ), "scheduler_plan_preview_safe": bool( scheduler_plan["mode"] == "scheduler_attach_plan_preview" and not scheduler_plan["scheduler_registration_executed"] @@ -1027,6 +1067,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_run_readiness": mcp_fetch_run_readiness, "mcp_fetch_run_receipt": mcp_fetch_run_receipt, "mcp_fetch_result_parser_review": mcp_fetch_result_parser_review, + "mcp_fetch_candidate_handoff_review": mcp_fetch_candidate_handoff_review, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_handoff_review.py b/services/market_intel/mcp_fetch_candidate_handoff_review.py new file mode 100644 index 0000000..e2946ac --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_handoff_review.py @@ -0,0 +1,758 @@ +"""市場情報 MCP fetch candidate handoff review preview。 + +本模組只審核 parser review 後的候選交接包；不建立 queue、不寫 DB、 +不讀 artifact、不發 HTTP request、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_run_package import RUN_ARTIFACT_DIR_PREFIX +from services.market_intel.mcp_fetch_result_parser_review import ( + build_mcp_fetch_result_parser_review_preview, +) + + +MAX_HANDOFF_CANDIDATES = 80 +SAFE_HANDOFF_STATUSES = {"queued_for_operator_review"} +SAFE_TARGET_QUEUES = {"manual_candidate_review"} +SAFE_DEDUPE_STRATEGIES = {"platform_source_candidate_key"} + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "secret", + "session_cookie", + "token", +) + +SAFE_SECRET_METADATA_KEYS = { + "operator_confirmed_no_secret_payload", +} + +FORBIDDEN_RAW_PAYLOAD_KEYS = ( + "body_html", + "document_html", + "html", + "page_html", + "raw_body", + "raw_html", + "raw_snapshot", + "response_body", +) + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_executed_cli", + "api_executes_cli", + "api_executes_docker", + "api_executes_health_check", + "api_executes_ssh", + "api_opens_database_connection", + "api_uses_external_network", + "api_writes_database", + "attach_scheduler", + "candidate_handoff_persisted", + "candidate_queue_created", + "candidate_queue_persisted", + "cli_executed", + "command_executed", + "database_commit_executed", + "database_session_created", + "database_write_executed", + "external_network_executed", + "fetch_executed", + "file_written", + "manual_fetch_gate_opened_by_api", + "network_request_allowed", + "payload_persisted", + "scheduler_attached", + "write_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _safe_artifact_path(value, *, require_json=False): + if not isinstance(value, str): + return False + normalized = value.strip().replace("\\", "/") + if not normalized or normalized.startswith("/"): + return False + parts = [part for part in normalized.split("/") if part] + if any(part in (".", "..") for part in parts): + return False + if not normalized.startswith(RUN_ARTIFACT_DIR_PREFIX): + return False + return not require_json or normalized.endswith(".json") + + +def _contains_forbidden_key(value, forbidden_keys, *, safe_keys=None): + safe_keys = safe_keys or set() + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in safe_keys and isinstance(nested, bool): + continue + if any(forbidden_key in normalized_key for forbidden_key in forbidden_keys): + return True + if _contains_forbidden_key(nested, forbidden_keys, safe_keys=safe_keys): + return True + elif isinstance(value, list): + return any( + _contains_forbidden_key(item, forbidden_keys, safe_keys=safe_keys) + for item in value + ) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _parser_review_from_inputs(parser_review_package, parser_review_result, phase): + if isinstance(parser_review_result, dict) and parser_review_result: + return parser_review_result + + parser_review_package = _as_dict(parser_review_package) + return build_mcp_fetch_result_parser_review_preview( + run_receipt_package=( + parser_review_package.get("run_receipt_package") + or parser_review_package.get("run_receipt") + or parser_review_package.get("receipt_review") + ), + run_receipt_result=( + parser_review_package.get("run_receipt_result") + or parser_review_package.get("mcp_fetch_run_receipt") + ), + parser_result=( + parser_review_package.get("parser_result") + or parser_review_package.get("fetch_result_parser") + or parser_review_package.get("parsed_result") + ), + phase=phase, + ) + + +def _candidate_identity(candidate, candidate_type): + candidate = _as_dict(candidate) + if candidate_type == "campaign": + return candidate.get("campaign_key") + return candidate.get("platform_product_id") + + +def _sample_candidate_handoff_package(): + parser_preview = build_mcp_fetch_result_parser_review_preview() + parser_review_package = parser_preview["sample_parser_result_package"] + parser_review_result = build_mcp_fetch_result_parser_review_preview( + run_receipt_package=parser_review_package["run_receipt_package"], + run_receipt_result=parser_review_package["run_receipt_result"], + parser_result=parser_review_package["parser_result"], + ) + parser_summary = parser_review_result["parser_result_summary"] + source_groups = [] + for source in parser_summary.get("source_summaries", []): + platform_code = source.get("platform_code") + source_key = source.get("source_key") + campaigns = [ + item for item in parser_summary.get("campaign_candidates", []) + if item.get("platform_code") == platform_code + and item.get("source_key") == source_key + ] + products = [ + item for item in parser_summary.get("product_candidates", []) + if item.get("platform_code") == platform_code + and item.get("source_key") == source_key + ] + source_groups.append( + { + "platform_code": platform_code, + "source_key": source_key, + "receipt_path": source.get("receipt_path"), + "parser_artifact_path": source.get("parser_artifact_path"), + "handoff_status": "queued_for_operator_review", + "candidate_review_scope": "campaign_and_product_identity_preview", + "campaign_candidate_count": len(campaigns), + "product_candidate_count": len(products), + "campaign_candidate_keys": [ + item.get("campaign_key") for item in campaigns + ], + "product_candidate_keys": [ + item.get("platform_product_id") for item in products + ], + "campaign_candidates": campaigns, + "product_candidates": products, + } + ) + + return { + "parser_review_package": parser_review_package, + "parser_review_result": parser_review_result, + "candidate_handoff": { + "handoff_id": "market-intel-candidate-handoff-sample", + "handoff_mode": "operator_review_preview", + "target_queue": "manual_candidate_review", + "queue_policy": { + "target_queue": "manual_candidate_review", + "dedupe_strategy": "platform_source_candidate_key", + "max_candidates_per_handoff": MAX_HANDOFF_CANDIDATES, + "write_mode": "preview_only", + }, + "operator_confirmed_no_database_write": True, + "operator_confirmed_no_external_network": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_persistence": True, + "operator_confirmed_manual_review_required": True, + "operator_confirmed_no_secret_payload": True, + "summary": { + "source_count": len(source_groups), + "campaign_candidate_count": parser_summary.get( + "campaign_candidate_count", + 0, + ), + "product_candidate_count": parser_summary.get( + "product_candidate_count", + 0, + ), + "candidate_count": parser_summary.get("candidate_count", 0), + }, + "candidate_groups": source_groups, + }, + } + + +def _parser_summary(parser_review): + parser_review = _as_dict(parser_review) + side_effects_clear = bool( + not parser_review.get("manual_fetch_gate_opened_by_api") + and not parser_review.get("network_request_allowed") + and not parser_review.get("parser_executed_by_api") + and not parser_review.get("api_executes_cli") + and not parser_review.get("api_opens_database_connection") + and not parser_review.get("api_writes_database") + and not parser_review.get("api_uses_external_network") + and not parser_review.get("database_write_executed") + and not parser_review.get("fetch_executed") + and not parser_review.get("cli_executed") + and not parser_review.get("file_written") + and not parser_review.get("scheduler_attached") + ) + parser_result_summary = _as_dict(parser_review.get("parser_result_summary")) + return { + "mode": parser_review.get("mode"), + "accepted": bool( + parser_review.get("mcp_fetch_result_parser_review_accepted") + ), + "ready_for_manual_fetch_candidate_handoff_review": bool( + parser_review.get("ready_for_manual_fetch_candidate_handoff_review") + ), + "source_count": _safe_int(parser_review.get("parser_source_count")), + "campaign_candidate_count": _safe_int( + parser_review.get("campaign_candidate_count") + ), + "product_candidate_count": _safe_int( + parser_review.get("product_candidate_count") + ), + "candidate_count": _safe_int(parser_review.get("candidate_count")), + "source_keys": sorted( + tuple(item) + for item in _as_list(parser_result_summary.get("source_keys")) + if isinstance(item, (list, tuple)) and len(item) == 2 + ), + "campaign_candidate_keys": sorted( + item.get("campaign_key") + for item in _as_list(parser_result_summary.get("campaign_candidates")) + if item.get("campaign_key") + ), + "product_candidate_keys": sorted( + item.get("platform_product_id") + for item in _as_list(parser_result_summary.get("product_candidates")) + if item.get("platform_product_id") + ), + "all_candidate_urls_public": bool( + parser_result_summary.get("all_candidate_urls_public") + ), + "all_candidate_required_fields_present": bool( + parser_result_summary.get("all_candidate_required_fields_present") + ), + "side_effects_clear": side_effects_clear, + "blocked_reasons": parser_review.get("blocked_reasons", []), + } + + +def _handoff_summary(candidate_handoff): + candidate_handoff = _as_dict(candidate_handoff) + groups = [_as_dict(item) for item in _as_list( + candidate_handoff.get("candidate_groups") + )] + queue_policy = _as_dict(candidate_handoff.get("queue_policy")) + campaign_candidates = [] + product_candidates = [] + group_summaries = [] + for group in groups: + campaigns = [_as_dict(item) for item in _as_list( + group.get("campaign_candidates") + )] + products = [_as_dict(item) for item in _as_list( + group.get("product_candidates") + )] + campaign_candidates.extend(campaigns) + product_candidates.extend(products) + group_summaries.append( + { + "platform_code": _safe_text(group.get("platform_code"), 80), + "source_key": _safe_text(group.get("source_key"), 160), + "receipt_path": _safe_text(group.get("receipt_path"), 500), + "receipt_path_safe": _safe_artifact_path( + group.get("receipt_path"), + require_json=True, + ), + "parser_artifact_path": _safe_text( + group.get("parser_artifact_path"), + 500, + ), + "parser_artifact_path_safe": _safe_artifact_path( + group.get("parser_artifact_path"), + require_json=True, + ), + "handoff_status": _safe_text(group.get("handoff_status"), 120), + "candidate_review_scope": _safe_text( + group.get("candidate_review_scope"), + 160, + ), + "campaign_candidate_count": _safe_int( + group.get("campaign_candidate_count") + ), + "product_candidate_count": _safe_int( + group.get("product_candidate_count") + ), + "observed_campaign_candidate_count": len(campaigns), + "observed_product_candidate_count": len(products), + "campaign_candidate_keys": sorted( + key for key in _as_list(group.get("campaign_candidate_keys")) if key + ), + "observed_campaign_candidate_keys": sorted( + _candidate_identity(item, "campaign") + for item in campaigns + if _candidate_identity(item, "campaign") + ), + "product_candidate_keys": sorted( + key for key in _as_list(group.get("product_candidate_keys")) if key + ), + "observed_product_candidate_keys": sorted( + _candidate_identity(item, "product") + for item in products + if _candidate_identity(item, "product") + ), + } + ) + + summary = _as_dict(candidate_handoff.get("summary")) + campaign_count = len(campaign_candidates) + product_count = len(product_candidates) + return { + "provided_keys": sorted(candidate_handoff.keys()), + "handoff_id": _safe_text(candidate_handoff.get("handoff_id"), 160), + "handoff_mode": _safe_text(candidate_handoff.get("handoff_mode"), 120), + "target_queue": _safe_text(candidate_handoff.get("target_queue"), 160), + "queue_policy": { + "target_queue": _safe_text(queue_policy.get("target_queue"), 160), + "dedupe_strategy": _safe_text(queue_policy.get("dedupe_strategy"), 160), + "max_candidates_per_handoff": _safe_int( + queue_policy.get("max_candidates_per_handoff") + ), + "write_mode": _safe_text(queue_policy.get("write_mode"), 80), + }, + "operator_confirmed_no_database_write": bool( + candidate_handoff.get("operator_confirmed_no_database_write") + ), + "operator_confirmed_no_external_network": bool( + candidate_handoff.get("operator_confirmed_no_external_network") + ), + "operator_confirmed_no_scheduler_attach": bool( + candidate_handoff.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_persistence": bool( + candidate_handoff.get("operator_confirmed_no_persistence") + ), + "operator_confirmed_manual_review_required": bool( + candidate_handoff.get("operator_confirmed_manual_review_required") + ), + "operator_confirmed_no_secret_payload": bool( + candidate_handoff.get("operator_confirmed_no_secret_payload") + ), + "source_count": len(group_summaries), + "summary_source_count": _safe_int(summary.get("source_count")), + "campaign_candidate_count": campaign_count, + "summary_campaign_candidate_count": _safe_int( + summary.get("campaign_candidate_count") + ), + "product_candidate_count": product_count, + "summary_product_candidate_count": _safe_int( + summary.get("product_candidate_count") + ), + "candidate_count": campaign_count + product_count, + "summary_candidate_count": _safe_int(summary.get("candidate_count")), + "source_keys": sorted( + ( + item["platform_code"], + item["source_key"], + ) + for item in group_summaries + if item["platform_code"] and item["source_key"] + ), + "campaign_candidate_keys": sorted( + _candidate_identity(item, "campaign") + for item in campaign_candidates + if _candidate_identity(item, "campaign") + ), + "product_candidate_keys": sorted( + _candidate_identity(item, "product") + for item in product_candidates + if _candidate_identity(item, "product") + ), + "group_summaries": group_summaries, + "campaign_candidates": campaign_candidates, + "product_candidates": product_candidates, + "all_group_paths_safe": bool( + group_summaries + and all( + item["receipt_path_safe"] and item["parser_artifact_path_safe"] + for item in group_summaries + ) + ), + "all_handoff_statuses_safe": bool( + group_summaries + and all( + item["handoff_status"] in SAFE_HANDOFF_STATUSES + for item in group_summaries + ) + ), + "group_counts_match_candidates": bool( + group_summaries + and all( + item["campaign_candidate_count"] + == item["observed_campaign_candidate_count"] + and item["product_candidate_count"] + == item["observed_product_candidate_count"] + and item["campaign_candidate_keys"] + == item["observed_campaign_candidate_keys"] + and item["product_candidate_keys"] + == item["observed_product_candidate_keys"] + for item in group_summaries + ) + ), + "summary_counts_match_candidates": bool( + _safe_int(summary.get("source_count")) == len(group_summaries) + and _safe_int(summary.get("campaign_candidate_count")) == campaign_count + and _safe_int(summary.get("product_candidate_count")) == product_count + and _safe_int(summary.get("candidate_count")) + == campaign_count + product_count + ), + "raw_payload_submitted_to_api": _contains_forbidden_key( + candidate_handoff, + FORBIDDEN_RAW_PAYLOAD_KEYS, + ), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + candidate_handoff, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_side_effects(candidate_handoff), + } + + +def _handoff_gates( + *, + parser_review_received, + handoff_payload_received, + handoff_valid_object, + parser, + handoff, +): + parser_source_keys = set(parser["source_keys"]) + handoff_source_keys = set(handoff["source_keys"]) + parser_campaign_keys = set(parser["campaign_candidate_keys"]) + handoff_campaign_keys = set(handoff["campaign_candidate_keys"]) + parser_product_keys = set(parser["product_candidate_keys"]) + handoff_product_keys = set(handoff["product_candidate_keys"]) + policy = handoff["queue_policy"] + operator_boundaries_confirmed = bool( + handoff["operator_confirmed_no_database_write"] + and handoff["operator_confirmed_no_external_network"] + and handoff["operator_confirmed_no_scheduler_attach"] + and handoff["operator_confirmed_no_persistence"] + and handoff["operator_confirmed_manual_review_required"] + and handoff["operator_confirmed_no_secret_payload"] + ) + return [ + { + "key": "parser_review_payload_or_result_received", + "label": "已提供 parser review package 或已審核結果", + "passed": parser_review_received, + }, + { + "key": "parser_review_accepted", + "label": "parser review gate 必須已通過", + "passed": parser["accepted"], + }, + { + "key": "parser_ready_for_candidate_handoff_review", + "label": "parser review 只放行到 candidate handoff review", + "passed": parser["ready_for_manual_fetch_candidate_handoff_review"], + }, + { + "key": "parser_side_effect_free", + "label": "parser review 未顯示 API 執行、連外、寫檔、寫 DB 或掛 scheduler", + "passed": parser["side_effects_clear"], + }, + { + "key": "handoff_payload_received", + "label": "已提供 candidate handoff 結構化摘要", + "passed": handoff_payload_received, + }, + { + "key": "handoff_valid_object", + "label": "candidate handoff payload 必須是 JSON object", + "passed": handoff_valid_object, + }, + { + "key": "handoff_identity_recorded", + "label": "candidate handoff 必須記錄 handoff_id", + "passed": bool(handoff["handoff_id"]), + }, + { + "key": "handoff_mode_preview_only", + "label": "candidate handoff 必須維持 operator_review_preview", + "passed": handoff["handoff_mode"] == "operator_review_preview", + }, + { + "key": "handoff_sources_match_parser", + "label": "handoff source 必須完全對齊 parser review", + "passed": bool(parser_source_keys and handoff_source_keys == parser_source_keys), + }, + { + "key": "handoff_candidates_match_parser", + "label": "handoff 候選 key 必須完全對齊 parser review", + "passed": bool( + parser_campaign_keys + and parser_product_keys + and handoff_campaign_keys == parser_campaign_keys + and handoff_product_keys == parser_product_keys + ), + }, + { + "key": "handoff_group_paths_safe", + "label": "handoff 引用的 receipt/parser artifact path 必須安全", + "passed": handoff["all_group_paths_safe"], + }, + { + "key": "handoff_status_operator_review_only", + "label": "handoff status 只能進人工覆核，不可標成已寫入", + "passed": handoff["all_handoff_statuses_safe"], + }, + { + "key": "handoff_candidate_counts_within_limit", + "label": "handoff 候選數需維持小批次上限", + "passed": bool(0 < handoff["candidate_count"] <= MAX_HANDOFF_CANDIDATES), + }, + { + "key": "handoff_candidate_counts_match_summary", + "label": "summary / group count 必須與候選陣列數量一致", + "passed": bool( + handoff["group_counts_match_candidates"] + and handoff["summary_counts_match_candidates"] + ), + }, + { + "key": "handoff_queue_policy_safe", + "label": "queue policy 只能指向 manual_candidate_review preview", + "passed": bool( + handoff["target_queue"] in SAFE_TARGET_QUEUES + and policy["target_queue"] in SAFE_TARGET_QUEUES + and policy["dedupe_strategy"] in SAFE_DEDUPE_STRATEGIES + and 0 < policy["max_candidates_per_handoff"] <= MAX_HANDOFF_CANDIDATES + and policy["write_mode"] == "preview_only" + ), + }, + { + "key": "handoff_operator_boundaries_confirmed", + "label": "操作員確認無寫入、無連外、無排程、無保存且需人工覆核", + "passed": operator_boundaries_confirmed, + }, + { + "key": "handoff_parser_candidates_were_safe", + "label": "parser candidate URL 與必要欄位已通過前一 gate", + "passed": bool( + parser["all_candidate_urls_public"] + and parser["all_candidate_required_fields_present"] + ), + }, + { + "key": "handoff_no_raw_payload", + "label": "handoff payload 不得回貼 raw HTML/body/snapshot", + "passed": not handoff["raw_payload_submitted_to_api"], + }, + { + "key": "handoff_no_secret_or_token_key", + "label": "handoff payload 不得包含 secret、cookie、password 或 token key", + "passed": not handoff["secret_or_token_submitted_to_api"], + }, + { + "key": "handoff_side_effect_free", + "label": "handoff payload 不得要求 API 執行、連外、寫檔、寫 DB 或掛 scheduler", + "passed": not handoff["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_handoff_review_preview( + *, + parser_review_package=None, + parser_review_result=None, + candidate_handoff=None, + phase=None, +): + """建立 fetch candidate handoff review；不建立 queue 或寫入。""" + parser_review_package = _as_dict(parser_review_package) + parser_review_result_received = bool( + isinstance(parser_review_result, dict) and parser_review_result + ) + handoff_valid_object = isinstance(candidate_handoff, dict) if ( + candidate_handoff is not None + ) else True + handoff_payload = _as_dict(candidate_handoff) + parser_review = _parser_review_from_inputs( + parser_review_package, + parser_review_result, + phase, + ) + parser_review_received = bool( + parser_review_package or parser_review_result_received + ) + payload_received = bool( + parser_review_received or handoff_payload or candidate_handoff is not None + ) + handoff_payload_received = bool(handoff_payload) + parser = _parser_summary(parser_review) + handoff = _handoff_summary(handoff_payload) + gates = _handoff_gates( + parser_review_received=parser_review_received, + handoff_payload_received=handoff_payload_received, + handoff_valid_object=handoff_valid_object, + parser=parser, + handoff=handoff, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_handoff_review" + if payload_received + else "mcp_fetch_candidate_handoff_review_preview" + ), + "phase": phase, + "candidate_handoff_payload_received": payload_received, + "parser_review_received": parser_review_received, + "handoff_payload_received": handoff_payload_received, + "handoff_valid_object": handoff_valid_object, + "parser_review_accepted": parser["accepted"], + "mcp_fetch_candidate_handoff_review_accepted": accepted, + "candidate_handoff_review_ready": accepted, + "ready_for_manual_candidate_queue_review": accepted, + "ready_for_candidate_queue_writer_preflight": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "manual_fetch_gate_opened_by_api": False, + "network_request_allowed": False, + "fetch_executed": False, + "cli_executed": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "parser_source_count": parser["source_count"], + "handoff_source_count": handoff["source_count"], + "candidate_count": handoff["candidate_count"], + "campaign_candidate_count": handoff["campaign_candidate_count"], + "product_candidate_count": handoff["product_candidate_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "parser_review_summary": parser, + "candidate_handoff_summary": handoff, + "sample_candidate_handoff_package": _sample_candidate_handoff_package(), + "next_operator_steps": [ + "candidate handoff 通過後，只代表可進人工 candidate queue review，不代表可寫 market_*", + "candidate queue writer、DB import、scheduler attach、AI/Telegram 摘要都必須另開獨立 gate", + "API/UI 仍不得建立 queue、不得讀 artifact、不得抓外站、不得寫 DB、不得掛 scheduler", + ], + "payload_persisted": False, + "candidate_handoff_persisted": False, + "api_executes_health_check": False, + "api_executes_docker": False, + "api_executes_ssh": False, + "api_executes_cli": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index ed2ab4f..a033779 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_125_market_intel_mcp_fetch_result_parser_review" +MARKET_INTEL_PHASE = "phase_126_market_intel_mcp_fetch_candidate_handoff_review" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index ad7a18e..6edd9b8 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -786,6 +786,32 @@ +
+
+
+

MCP / FETCH CANDIDATE HANDOFF

+

MCP Fetch Candidate Handoff 審核

+
+ +
+
+ loading +
+
+
讀取 MCP Fetch Candidate Handoff 審核中...
+
+
+ +
+ +
+
+
+
@@ -1299,6 +1325,7 @@ const mcpFetchRunReadinessRoot = document.querySelector('[data-market-intel-mcp-fetch-run-readiness]'); const mcpFetchRunReceiptRoot = document.querySelector('[data-market-intel-mcp-fetch-run-receipt]'); const mcpFetchResultParserReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-result-parser-review]'); + const mcpFetchCandidateHandoffReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1315,7 +1342,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1416,6 +1443,12 @@ const mcpFetchResultParserReviewReview = mcpFetchResultParserReviewRoot ? mcpFetchResultParserReviewRoot.querySelector('[data-market-intel-mcp-fetch-result-parser-review-review]') : null; const mcpFetchResultParserReviewRefresh = mcpFetchResultParserReviewRoot ? mcpFetchResultParserReviewRoot.querySelector('[data-market-intel-mcp-fetch-result-parser-review-refresh]') : null; const mcpFetchResultParserReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_result_parser_review') }}"; + const mcpFetchCandidateHandoffReviewMeta = mcpFetchCandidateHandoffReviewRoot ? mcpFetchCandidateHandoffReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review-meta]') : null; + const mcpFetchCandidateHandoffReviewBody = mcpFetchCandidateHandoffReviewRoot ? mcpFetchCandidateHandoffReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review-body]') : null; + const mcpFetchCandidateHandoffReviewInput = mcpFetchCandidateHandoffReviewRoot ? mcpFetchCandidateHandoffReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review-input]') : null; + const mcpFetchCandidateHandoffReviewReview = mcpFetchCandidateHandoffReviewRoot ? mcpFetchCandidateHandoffReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review-review]') : null; + const mcpFetchCandidateHandoffReviewRefresh = mcpFetchCandidateHandoffReviewRoot ? mcpFetchCandidateHandoffReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-handoff-review-refresh]') : null; + const mcpFetchCandidateHandoffReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_handoff_review') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -3493,6 +3526,138 @@ } }; + const renderMcpFetchCandidateHandoffReviewMeta = data => { + mcpFetchCandidateHandoffReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_handoff_review_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `sources=${data.handoff_source_count || 0}`, + `candidates=${data.candidate_count || 0}`, + `queue=${data.candidate_queue_created ? 'created' : 'preview'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateHandoffReviewBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const parser = data.parser_review_summary || {}; + const handoff = data.candidate_handoff_summary || {}; + const groups = handoff.group_summaries || []; + const policy = handoff.queue_policy || {}; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateHandoffReviewBody.innerHTML = ` +
此 handoff review 只審核 parser 候選交接包；API 不建立 queue、不讀 artifact、不抓外站、不寫 DB、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

HANDOFF GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 handoff gates。
' + }
+
+
+

PARSER LINK

+
+ ${renderCheck('parser_review', `${parser.accepted ? 'accepted' : 'pending'} / sources=${parser.source_count || 0}`, parser.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('parser_candidates', `campaigns=${parser.campaign_candidate_count || 0} / products=${parser.product_candidate_count || 0}`, parser.all_candidate_required_fields_present ? 'READY' : 'PENDING')} + ${renderCheck('parser_boundary', 'no parser CLI / no external request / no DB / no scheduler', parser.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

HANDOFF GROUPS

+
${ + groups.length + ? groups.map(item => renderCheck( + `${item.platform_code || 'unknown'}:${item.source_key || 'source'}`, + `${item.handoff_status || 'missing'} / campaigns=${item.observed_campaign_candidate_count || 0} / products=${item.observed_product_candidate_count || 0}`, + item.handoff_status === 'queued_for_operator_review' ? 'QUEUE REVIEW' : 'BLOCK' + )).join('') + : '
尚未提供 candidate handoff groups。
' + }
+
+
+

QUEUE POLICY

+
+ ${renderCheck('target_queue', policy.target_queue || handoff.target_queue || 'missing', policy.target_queue === 'manual_candidate_review' ? 'MANUAL' : 'BLOCK')} + ${renderCheck('dedupe_strategy', policy.dedupe_strategy || 'missing', policy.dedupe_strategy === 'platform_source_candidate_key' ? 'READY' : 'BLOCK')} + ${renderCheck('write_mode', policy.write_mode || 'missing', policy.write_mode === 'preview_only' ? 'PREVIEW' : 'BLOCK')} + ${renderCheck('candidate_count', `${handoff.candidate_count || 0}/${policy.max_candidates_per_handoff || 0}`, data.candidate_queue_created ? 'BLOCK' : 'NO WRITE')} +
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck( + 'api_boundary', + 'no queue create / no artifact read / no external request / no DB / no scheduler', + data.api_writes_database ? 'BLOCK' : 'CLOSED' + )} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateHandoffReviewInput && !mcpFetchCandidateHandoffReviewInput.value.trim() && data.sample_candidate_handoff_package) { + mcpFetchCandidateHandoffReviewInput.value = JSON.stringify(data.sample_candidate_handoff_package, null, 2); + } + }; + + const loadMcpFetchCandidateHandoffReview = async () => { + if (!mcpFetchCandidateHandoffReviewMeta || !mcpFetchCandidateHandoffReviewBody) return; + mcpFetchCandidateHandoffReviewBody.innerHTML = '
讀取 MCP Fetch Candidate Handoff 審核中...
'; + try { + const response = await fetch(mcpFetchCandidateHandoffReviewEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateHandoffReviewMeta(data); + renderMcpFetchCandidateHandoffReviewBody(data); + } catch (error) { + mcpFetchCandidateHandoffReviewMeta.innerHTML = 'error'; + mcpFetchCandidateHandoffReviewBody.innerHTML = `
MCP Fetch Candidate Handoff 審核讀取失敗：${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateHandoffReview = async () => { + if (!mcpFetchCandidateHandoffReviewMeta || !mcpFetchCandidateHandoffReviewBody || !mcpFetchCandidateHandoffReviewInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateHandoffReviewInput.value || '{}'); + } catch (error) { + mcpFetchCandidateHandoffReviewMeta.innerHTML = 'json_error'; + mcpFetchCandidateHandoffReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateHandoffReviewBody.innerHTML = '
審核 MCP Fetch Candidate Handoff 中...
'; + try { + const response = await fetch(mcpFetchCandidateHandoffReviewEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ candidate_handoff_review: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateHandoffReviewMeta(data); + renderMcpFetchCandidateHandoffReviewBody(data); + } catch (error) { + mcpFetchCandidateHandoffReviewMeta.innerHTML = 'error'; + mcpFetchCandidateHandoffReviewBody.innerHTML = `
MCP Fetch Candidate Handoff 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -12950,6 +13115,12 @@ if (mcpFetchResultParserReviewReview) { mcpFetchResultParserReviewReview.addEventListener('click', reviewMcpFetchResultParserReview); } + if (mcpFetchCandidateHandoffReviewRefresh) { + mcpFetchCandidateHandoffReviewRefresh.addEventListener('click', loadMcpFetchCandidateHandoffReview); + } + if (mcpFetchCandidateHandoffReviewReview) { + mcpFetchCandidateHandoffReviewReview.addEventListener('click', reviewMcpFetchCandidateHandoffReview); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -13213,6 +13384,7 @@ loadMcpFetchRunReadiness(); loadMcpFetchRunReceipt(); loadMcpFetchResultParserReview(); + loadMcpFetchCandidateHandoffReview(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 0fae4f4..728a914 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -32,6 +32,9 @@ from services.market_intel.mcp_fetch_run_receipt import ( from services.market_intel.mcp_fetch_result_parser_review import ( build_mcp_fetch_result_parser_review_preview, ) +from services.market_intel.mcp_fetch_candidate_handoff_review import ( + build_mcp_fetch_candidate_handoff_review_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1001,6 +1004,13 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-mcp-fetch-result-parser-review-sources" in template assert "data-market-intel-mcp-fetch-result-parser-review-candidates" in template assert "data-market-intel-mcp-fetch-result-parser-review-next" in template + assert "market_intel.market_intel_mcp_fetch_candidate_handoff_review" in template + assert "data-market-intel-mcp-fetch-candidate-handoff-review" in template + assert "data-market-intel-mcp-fetch-candidate-handoff-review-gates" in template + assert "data-market-intel-mcp-fetch-candidate-handoff-review-parser" in template + assert "data-market-intel-mcp-fetch-candidate-handoff-review-groups" in template + assert "data-market-intel-mcp-fetch-candidate-handoff-review-queue" in template + assert "data-market-intel-mcp-fetch-candidate-handoff-review-next" in template assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1471,7 +1481,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert bridge["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1629,7 +1639,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert contract["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1762,7 +1772,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1775,7 +1785,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert gate["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1845,7 +1855,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1859,7 +1869,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert audit["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -1933,7 +1943,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -1950,11 +1960,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review" + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert evidence["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -1979,7 +1989,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2037,12 +2047,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2051,11 +2061,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review" + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert receipt["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2083,7 +2093,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2148,12 +2158,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2162,11 +2172,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review" + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert promotion["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2194,7 +2204,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2254,12 +2264,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2268,11 +2278,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert handoff["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2300,7 +2310,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2362,12 +2372,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2378,11 +2388,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert review["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2412,7 +2422,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2490,13 +2500,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2508,11 +2518,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert package["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2544,7 +2554,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2619,13 +2629,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2639,11 +2649,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert readiness["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2678,11 +2688,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert readiness["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2758,13 +2768,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2778,11 +2788,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert receipt["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -2819,11 +2829,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert receipt["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -2902,13 +2912,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -2924,11 +2934,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert parser["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -2967,11 +2977,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_125_market_intel_mcp_fetch_result_parser_review", + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert parser["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3056,13 +3066,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3076,11 +3086,171 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert post_data["api_uses_external_network"] is False +def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): + handoff = build_mcp_fetch_candidate_handoff_review_preview( + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", + ) + + assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" + assert handoff["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" + assert handoff["candidate_handoff_payload_received"] is False + assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False + assert handoff["candidate_handoff_review_ready"] is False + assert handoff["ready_for_manual_candidate_queue_review"] is False + assert handoff["ready_for_candidate_queue_writer_preflight"] is False + assert handoff["ready_for_api_database_write"] is False + assert handoff["ready_for_scheduler_attach"] is False + assert handoff["manual_fetch_gate_opened_by_api"] is False + assert handoff["network_request_allowed"] is False + assert handoff["fetch_executed"] is False + assert handoff["cli_executed"] is False + assert handoff["payload_persisted"] is False + assert handoff["candidate_handoff_persisted"] is False + assert handoff["candidate_queue_created"] is False + assert handoff["candidate_queue_persisted"] is False + assert handoff["api_executes_cli"] is False + assert handoff["api_opens_database_connection"] is False + assert handoff["api_writes_database"] is False + assert handoff["api_uses_external_network"] is False + assert handoff["database_write_executed"] is False + assert handoff["external_network_executed"] is False + assert handoff["file_written"] is False + assert handoff["scheduler_attached"] is False + assert "parser_review_payload_or_result_received" in handoff["blocked_reasons"] + assert "handoff_payload_received" in handoff["blocked_reasons"] + assert "parser_review_package" in handoff["sample_candidate_handoff_package"] + assert "candidate_handoff" in handoff["sample_candidate_handoff_package"] + + +def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): + sample = ( + build_mcp_fetch_candidate_handoff_review_preview() + ["sample_candidate_handoff_package"] + ) + handoff = build_mcp_fetch_candidate_handoff_review_preview( + parser_review_package=sample["parser_review_package"], + parser_review_result=sample["parser_review_result"], + candidate_handoff=sample["candidate_handoff"], + phase="phase_126_market_intel_mcp_fetch_candidate_handoff_review", + ) + + assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" + assert handoff["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" + assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True + assert handoff["candidate_handoff_review_ready"] is True + assert handoff["ready_for_manual_candidate_queue_review"] is True + assert handoff["ready_for_candidate_queue_writer_preflight"] is False + assert handoff["ready_for_api_database_write"] is False + assert handoff["blocked_reasons"] == [] + assert handoff["passed_gate_count"] == handoff["gate_count"] + assert handoff["parser_review_accepted"] is True + assert handoff["handoff_source_count"] >= 8 + assert handoff["candidate_count"] == ( + handoff["campaign_candidate_count"] + handoff["product_candidate_count"] + ) + assert handoff["candidate_handoff_summary"]["all_group_paths_safe"] is True + assert handoff["candidate_handoff_summary"]["all_handoff_statuses_safe"] is True + assert handoff["candidate_handoff_summary"]["group_counts_match_candidates"] is True + assert handoff["candidate_handoff_summary"]["raw_payload_submitted_to_api"] is False + assert handoff["candidate_handoff_summary"]["secret_or_token_submitted_to_api"] is False + assert handoff["manual_fetch_gate_opened_by_api"] is False + assert handoff["network_request_allowed"] is False + assert handoff["fetch_executed"] is False + assert handoff["cli_executed"] is False + assert handoff["candidate_queue_created"] is False + assert handoff["candidate_queue_persisted"] is False + assert handoff["file_written"] is False + assert handoff["database_write_executed"] is False + assert handoff["api_uses_external_network"] is False + assert handoff["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_handoff_review_blocks_unsafe_handoff(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_handoff_review_preview() + ["sample_candidate_handoff_package"] + ) + ) + candidate_handoff = sample["candidate_handoff"] + candidate_handoff["approval_token"] = "do-not-submit" + candidate_handoff["raw_html"] = "raw" + candidate_handoff["api_writes_database"] = True + candidate_handoff["operator_confirmed_no_database_write"] = False + candidate_handoff["queue_policy"]["write_mode"] = "write_database" + first_group = candidate_handoff["candidate_groups"][0] + first_group["parser_artifact_path"] = "../unsafe.json" + first_group["handoff_status"] = "persisted" + first_group["product_candidate_keys"].pop() + + handoff = build_mcp_fetch_candidate_handoff_review_preview( + parser_review_package=sample["parser_review_package"], + parser_review_result=sample["parser_review_result"], + candidate_handoff=candidate_handoff, + ) + + assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False + assert handoff["parser_review_accepted"] is True + assert "handoff_group_paths_safe" in handoff["blocked_reasons"] + assert "handoff_status_operator_review_only" in handoff["blocked_reasons"] + assert "handoff_candidate_counts_match_summary" in handoff["blocked_reasons"] + assert "handoff_queue_policy_safe" in handoff["blocked_reasons"] + assert "handoff_operator_boundaries_confirmed" in handoff["blocked_reasons"] + assert "handoff_no_raw_payload" in handoff["blocked_reasons"] + assert "handoff_no_secret_or_token_key" in handoff["blocked_reasons"] + assert "handoff_side_effect_free" in handoff["blocked_reasons"] + assert handoff["network_request_allowed"] is False + assert handoff["api_writes_database"] is False + assert handoff["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get("/api/market_intel/mcp_fetch_candidate_handoff_review") + get_data = get_response.get_json() + sample = get_data["sample_candidate_handoff_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_handoff_review", + json={"candidate_handoff_review": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" + assert get_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" + assert get_data["api_executes_cli"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_uses_external_network"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" + assert post_data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" + assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True + assert post_data["ready_for_manual_candidate_queue_review"] is True + assert post_data["ready_for_candidate_queue_writer_preflight"] is False + assert post_data["manual_fetch_gate_opened_by_api"] is False + assert post_data["network_request_allowed"] is False + assert post_data["fetch_executed"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_handoff_persisted"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["api_opens_database_connection"] is False + assert post_data["api_uses_external_network"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -3128,7 +3298,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -3139,7 +3309,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert acceptance["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -3181,7 +3351,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -3193,7 +3363,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert review["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -3304,7 +3474,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -3343,7 +3513,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert review["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -3405,7 +3575,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -3485,7 +3655,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert handoff["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -3549,7 +3719,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -3608,7 +3778,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert queue_draft["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -3682,7 +3852,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -3745,7 +3915,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert approval["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -3823,7 +3993,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -3886,7 +4056,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert transaction["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -3966,7 +4136,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -9677,7 +9847,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9752,7 +9922,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -10024,7 +10194,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10312,7 +10482,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -10622,7 +10792,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -10925,7 +11095,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -11184,7 +11354,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -11457,7 +11627,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -11705,7 +11875,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -11935,7 +12105,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -12172,7 +12342,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -12414,7 +12584,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -12690,7 +12860,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -12967,7 +13137,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -13246,7 +13416,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -13575,7 +13745,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -13837,7 +14007,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -14101,7 +14271,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -14371,7 +14541,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -14659,7 +14829,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -14946,7 +15116,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -15032,7 +15202,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15089,7 +15259,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15178,7 +15348,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15232,7 +15402,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -15288,7 +15458,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -15354,7 +15524,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -15656,7 +15826,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -15704,7 +15874,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -15753,7 +15923,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -15811,7 +15981,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -15877,7 +16047,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -15948,7 +16118,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -16024,7 +16194,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -16106,7 +16276,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -16192,7 +16362,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -16275,7 +16445,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -16358,7 +16528,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -16444,7 +16614,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -16535,7 +16705,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -16645,7 +16815,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16731,7 +16901,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16788,7 +16958,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16841,7 +17011,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16894,7 +17064,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16955,7 +17125,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17024,7 +17194,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17096,7 +17266,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -17169,7 +17339,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -17240,7 +17410,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -17305,7 +17475,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -17376,7 +17546,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -17449,7 +17619,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -17526,7 +17696,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -17603,7 +17773,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -17680,7 +17850,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -17754,7 +17924,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -17833,7 +18003,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -17920,7 +18090,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -18001,7 +18171,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -18083,7 +18253,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_125_market_intel_mcp_fetch_result_parser_review" + "phase_126_market_intel_mcp_fetch_candidate_handoff_review" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -18166,7 +18336,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -18191,7 +18361,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -18229,7 +18399,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -18240,7 +18410,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -18276,7 +18446,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -18287,7 +18457,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -18328,7 +18498,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -18339,7 +18509,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -18387,7 +18557,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -18399,7 +18569,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -18445,7 +18615,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -18458,7 +18628,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert plan["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -18543,7 +18713,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -18621,7 +18791,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -18636,7 +18806,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert readiness["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -19032,6 +19202,8 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["mcp_fetch_run_package_preview_safe"] is True assert readiness["checks"]["mcp_fetch_run_readiness_preview_safe"] is True assert readiness["checks"]["mcp_fetch_run_receipt_preview_safe"] is True + assert readiness["checks"]["mcp_fetch_result_parser_review_preview_safe"] is True + assert readiness["checks"]["mcp_fetch_candidate_handoff_review_preview_safe"] is True assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -23452,7 +23624,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert drill["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -23567,7 +23739,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -23579,7 +23751,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert review["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -23694,7 +23866,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -23707,7 +23879,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert smoke["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -23769,7 +23941,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -23782,7 +23954,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert inventory["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -23926,7 +24098,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -24162,7 +24334,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -24191,7 +24363,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_125_market_intel_mcp_fetch_result_parser_review" + assert data["phase"] == "phase_126_market_intel_mcp_fetch_candidate_handoff_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False