This commit is contained in:
@@ -522,6 +522,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
|
||||
assert "data-market-intel-sample-candidate-queue-draft" in template
|
||||
assert "data-market-intel-sample-candidate-queue-approval" in template
|
||||
assert "data-market-intel-sample-candidate-queue-transaction" in template
|
||||
assert "data-market-intel-sample-candidate-queue-writer" in template
|
||||
assert "data-market-intel-approval" in template
|
||||
assert "data-market-intel-approval-gates" in template
|
||||
assert "data-market-intel-deploy" in template
|
||||
@@ -545,6 +546,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
|
||||
assert "market_intel.market_intel_manual_sample_candidate_queue_draft" in template
|
||||
assert "market_intel.market_intel_manual_sample_candidate_queue_approval" in template
|
||||
assert "market_intel.market_intel_manual_sample_candidate_queue_transaction" in template
|
||||
assert "market_intel.market_intel_manual_sample_candidate_queue_writer_status" in template
|
||||
assert "X-CSRFToken" in template
|
||||
assert "market_intel.market_intel_scheduler_plan" in template
|
||||
assert "market_intel.market_intel_match_review_plan" in template
|
||||
@@ -581,7 +583,7 @@ def test_legacy_source_bridge_default_is_planned_only():
|
||||
bridge = MarketIntelService().build_legacy_source_bridge()
|
||||
|
||||
assert bridge["mode"] == "legacy_source_bridge_planned"
|
||||
assert bridge["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert bridge["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert bridge["execute_requested"] is False
|
||||
assert bridge["read_only_query_executed"] is False
|
||||
assert bridge["database_connection_opened"] is False
|
||||
@@ -739,7 +741,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
|
||||
contract = MarketIntelService().build_mcp_tool_contract()
|
||||
|
||||
assert contract["mode"] == "mcp_tool_contract_preview"
|
||||
assert contract["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert contract["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert contract["caller"] == "market_intel"
|
||||
assert contract["contract_ready"] is True
|
||||
assert contract["blocked_reasons"] == []
|
||||
@@ -872,7 +874,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "mcp_activation_runbook_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["deployment_actions_executed"] is False
|
||||
assert data["docker_command_executed"] is False
|
||||
assert data["ssh_command_executed"] is False
|
||||
@@ -885,7 +887,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
|
||||
gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
|
||||
|
||||
assert gate["mode"] == "mcp_fetch_gate_planned"
|
||||
assert gate["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert gate["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert gate["fetch_requested"] is True
|
||||
assert gate["manual_fetch_gate_open"] is False
|
||||
assert gate["network_request_allowed"] is False
|
||||
@@ -955,7 +957,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "mcp_fetch_gate_planned"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["fetch_requested"] is False
|
||||
assert data["network_request_allowed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -967,7 +969,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write():
|
||||
plan = MarketIntelService().build_manual_sample_plan()
|
||||
|
||||
assert plan["mode"] == "manual_sample_fetch_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_for_manual_sample_fetch"] is False
|
||||
assert plan["sample_fetch_executed"] is False
|
||||
assert plan["external_network_executed"] is False
|
||||
@@ -1015,7 +1017,7 @@ def test_manual_sample_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_fetch_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["sample_fetch_executed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
@@ -1026,7 +1028,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import():
|
||||
acceptance = MarketIntelService().build_manual_sample_acceptance()
|
||||
|
||||
assert acceptance["mode"] == "manual_sample_acceptance_preview"
|
||||
assert acceptance["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert acceptance["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert acceptance["contract_ready"] is True
|
||||
assert acceptance["sample_result_loaded"] is False
|
||||
assert acceptance["sample_result_accepted"] is False
|
||||
@@ -1068,7 +1070,7 @@ def test_manual_sample_acceptance_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_acceptance_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["sample_result_loaded"] is False
|
||||
assert data["candidate_import_allowed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -1080,7 +1082,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded():
|
||||
review = MarketIntelService().build_manual_sample_review()
|
||||
|
||||
assert review["mode"] == "manual_sample_review_preview"
|
||||
assert review["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert review["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert review["contract_ready"] is True
|
||||
assert review["sample_result_loaded"] is False
|
||||
assert review["sample_result_reviewed"] is False
|
||||
@@ -1191,7 +1193,7 @@ def test_manual_sample_review_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_review_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["sample_result_loaded"] is False
|
||||
assert data["sample_result_reviewed"] is False
|
||||
assert data["candidate_import_allowed"] is False
|
||||
@@ -1230,7 +1232,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist
|
||||
)
|
||||
|
||||
assert review["mode"] == "manual_sample_review_evaluation_preview"
|
||||
assert review["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert review["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert review["review_request_type"] == "operator_posted_json"
|
||||
assert review["payload_received"] is True
|
||||
assert review["payload_valid_json_object"] is True
|
||||
@@ -1292,7 +1294,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_review_evaluation_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["payload_received"] is True
|
||||
assert data["payload_valid_json_object"] is True
|
||||
assert data["payload_persisted"] is False
|
||||
@@ -1372,7 +1374,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers
|
||||
)
|
||||
|
||||
assert handoff["mode"] == "manual_sample_candidate_handoff_preview"
|
||||
assert handoff["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert handoff["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert handoff["payload_received"] is True
|
||||
assert handoff["payload_valid_json_object"] is True
|
||||
assert handoff["payload_persisted"] is False
|
||||
@@ -1436,7 +1438,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_handoff_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["payload_received"] is True
|
||||
assert data["handoff_ready"] is True
|
||||
assert data["candidate_handoff_created"] is True
|
||||
@@ -1495,7 +1497,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without
|
||||
)
|
||||
|
||||
assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview"
|
||||
assert queue_draft["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert queue_draft["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert queue_draft["payload_received"] is True
|
||||
assert queue_draft["payload_valid_json_object"] is True
|
||||
assert queue_draft["payload_persisted"] is False
|
||||
@@ -1569,7 +1571,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_queue_draft_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["payload_received"] is True
|
||||
assert data["handoff_ready"] is True
|
||||
assert data["queue_draft_ready"] is True
|
||||
@@ -1632,7 +1634,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro
|
||||
)
|
||||
|
||||
assert approval["mode"] == "manual_sample_candidate_queue_approval_preview"
|
||||
assert approval["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert approval["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert approval["payload_received"] is True
|
||||
assert approval["payload_valid_json_object"] is True
|
||||
assert approval["payload_persisted"] is False
|
||||
@@ -1710,7 +1712,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write(
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_queue_approval_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["payload_received"] is True
|
||||
assert data["approval_preview_created"] is True
|
||||
assert data["approval_request_created"] is False
|
||||
@@ -1773,7 +1775,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution():
|
||||
)
|
||||
|
||||
assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview"
|
||||
assert transaction["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert transaction["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert transaction["payload_received"] is True
|
||||
assert transaction["payload_valid_json_object"] is True
|
||||
assert transaction["payload_persisted"] is False
|
||||
@@ -1851,7 +1853,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "manual_sample_candidate_queue_transaction_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["payload_received"] is True
|
||||
assert data["transaction_preview_created"] is True
|
||||
assert data["transaction_ready"] is False
|
||||
@@ -1884,11 +1886,169 @@ def test_manual_sample_candidate_queue_transaction_blocks_invalid_payload():
|
||||
assert "queue_transaction_preview_not_ready" in transaction["blocked_reasons"]
|
||||
|
||||
|
||||
def test_candidate_queue_writer_cli_gate_blocks_real_write_even_with_token():
|
||||
from services.market_intel.candidate_queue_writer_cli import (
|
||||
build_candidate_queue_writer_cli_plan,
|
||||
)
|
||||
|
||||
sample_result = {
|
||||
"batch_id": "sample-batch-13",
|
||||
"platform_code": "momo",
|
||||
"source_key": "homepage",
|
||||
"source_url": "https://www.momoshop.com.tw/",
|
||||
"status": "fetched",
|
||||
"status_code": 200,
|
||||
"content_length": 1700,
|
||||
"page_hash": "a" * 64,
|
||||
"title": "MOMO 活動",
|
||||
"diagnostics": {
|
||||
"link_count": 1,
|
||||
"same_host_link_count": 1,
|
||||
"campaign_link_candidates": [
|
||||
{
|
||||
"confidence_band": "high",
|
||||
"score": 94,
|
||||
"url": "https://www.momoshop.com.tw/activity/sample",
|
||||
"text": "品牌活動",
|
||||
},
|
||||
],
|
||||
},
|
||||
}
|
||||
transaction = MarketIntelService().build_manual_sample_candidate_queue_transaction(
|
||||
sample_result=sample_result
|
||||
)
|
||||
status = build_candidate_queue_writer_cli_plan(
|
||||
transaction_preview=transaction,
|
||||
execute_requested=True,
|
||||
apply_real_write=True,
|
||||
approval_token=TEST_APPROVAL_TOKEN,
|
||||
approval_token_secret=TEST_APPROVAL_TOKEN,
|
||||
)
|
||||
|
||||
assert status["mode"] == "candidate_queue_writer_cli_blocked"
|
||||
assert status["execute_requested"] is True
|
||||
assert status["apply_real_write_requested"] is True
|
||||
assert status["approval_token_present"] is True
|
||||
assert status["approval_token_valid"] is True
|
||||
assert status["queue_writer_implementation_enabled"] is False
|
||||
assert status["ready_for_real_write"] is False
|
||||
assert status["writes_executed"] is False
|
||||
assert status["would_write_database"] is False
|
||||
assert status["database_connection_opened"] is False
|
||||
assert status["database_session_created"] is False
|
||||
assert status["explicit_transaction_opened"] is False
|
||||
assert status["database_write_executed"] is False
|
||||
assert status["database_commit_executed"] is False
|
||||
assert status["scheduler_attached"] is False
|
||||
assert status["exit_code"] == 2
|
||||
assert status["transaction_preview_summary"]["statement_count"] == 1
|
||||
assert "approval_token_valid" not in status["blocked_reasons"]
|
||||
assert "queue_writer_implementation_enabled" in status["blocked_reasons"]
|
||||
assert "candidate_queue_writer_execution_not_enabled" in status["blocked_reasons"]
|
||||
assert status["safety_contract"]["refuses_api_execution"] is True
|
||||
assert (
|
||||
"do_not_execute_candidate_queue_writer_from_api"
|
||||
in status["safe_boundaries"]
|
||||
)
|
||||
|
||||
|
||||
def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypatch):
|
||||
from routes.market_intel_routes import market_intel_bp
|
||||
|
||||
monkeypatch.setenv("MARKET_INTEL_QUEUE_WRITE_APPROVAL", TEST_APPROVAL_TOKEN)
|
||||
|
||||
app = Flask(__name__)
|
||||
app.secret_key = "test-secret"
|
||||
app.register_blueprint(market_intel_bp)
|
||||
client = app.test_client()
|
||||
with client.session_transaction() as session:
|
||||
session["logged_in"] = True
|
||||
|
||||
response = client.post(
|
||||
"/api/market_intel/manual_sample_review/candidate_queue_writer_status"
|
||||
"?execute=true&apply_real_write=true",
|
||||
json={
|
||||
"sample_result": {
|
||||
"batch_id": "sample-batch-14",
|
||||
"platform_code": "pchome",
|
||||
"source_key": "homepage",
|
||||
"source_url": "https://24h.pchome.com.tw/",
|
||||
"status": "fetched",
|
||||
"status_code": 200,
|
||||
"content_length": 1800,
|
||||
"page_hash": "b" * 64,
|
||||
"title": "PChome 活動",
|
||||
"diagnostics": {
|
||||
"link_count": 1,
|
||||
"same_host_link_count": 1,
|
||||
"campaign_link_candidates": [
|
||||
{
|
||||
"confidence_band": "medium",
|
||||
"score": 74,
|
||||
"url": "https://24h.pchome.com.tw/activity/sample",
|
||||
"text": "活動頁",
|
||||
},
|
||||
],
|
||||
},
|
||||
}
|
||||
},
|
||||
)
|
||||
data = response.get_json()
|
||||
payload = json.dumps(data, ensure_ascii=False, sort_keys=True)
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "candidate_queue_writer_cli_blocked"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["execute_requested"] is True
|
||||
assert data["apply_real_write_requested"] is True
|
||||
assert data["approval_token_present"] is False
|
||||
assert data["approval_token_valid"] is False
|
||||
assert data["approval_token_secret_configured"] is True
|
||||
assert data["ready_for_real_write"] is False
|
||||
assert data["writes_executed"] is False
|
||||
assert data["would_write_database"] is False
|
||||
assert data["database_connection_opened"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
assert data["database_commit_executed"] is False
|
||||
assert data["scheduler_attached"] is False
|
||||
assert data["transaction_preview_summary"]["statement_count"] == 1
|
||||
assert "approval_token_present" in data["blocked_reasons"]
|
||||
assert "approval_token_valid" in data["blocked_reasons"]
|
||||
assert "approval_token_hint" not in payload
|
||||
assert TEST_APPROVAL_TOKEN not in payload
|
||||
assert "APPROVED_MARKET_INTEL_QUEUE_WRITE" not in payload
|
||||
|
||||
|
||||
def test_candidate_queue_writer_status_blocks_invalid_payload():
|
||||
from routes.market_intel_routes import market_intel_bp
|
||||
|
||||
app = Flask(__name__)
|
||||
app.secret_key = "test-secret"
|
||||
app.register_blueprint(market_intel_bp)
|
||||
client = app.test_client()
|
||||
with client.session_transaction() as session:
|
||||
session["logged_in"] = True
|
||||
|
||||
response = client.post(
|
||||
"/api/market_intel/manual_sample_review/candidate_queue_writer_status",
|
||||
data="not-json",
|
||||
content_type="application/json",
|
||||
)
|
||||
data = response.get_json()
|
||||
|
||||
assert response.status_code == 400
|
||||
assert data["mode"] == "candidate_queue_writer_cli_blocked"
|
||||
assert data["ready_for_real_write"] is False
|
||||
assert data["writes_executed"] is False
|
||||
assert data["transaction_preview_summary"]["statement_count"] == 0
|
||||
assert "transaction_preview_created" in data["blocked_reasons"]
|
||||
|
||||
|
||||
def test_scheduler_plan_preview_blocks_job_attachment():
|
||||
plan = MarketIntelService().build_scheduler_plan()
|
||||
|
||||
assert plan["mode"] == "scheduler_attach_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_to_attach_scheduler"] is False
|
||||
assert plan["scheduler_attached"] is False
|
||||
assert plan["scheduler_registration_executed"] is False
|
||||
@@ -1926,7 +2086,7 @@ def test_scheduler_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "scheduler_attach_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["scheduler_registration_executed"] is False
|
||||
assert data["crawler_job_started"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -1937,7 +2097,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
|
||||
plan = MarketIntelService().build_match_review_plan()
|
||||
|
||||
assert plan["mode"] == "match_review_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_for_review_queue"] is False
|
||||
assert plan["review_queue_created"] is False
|
||||
assert plan["auto_match_executed"] is False
|
||||
@@ -1973,7 +2133,7 @@ def test_match_review_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "match_review_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["review_queue_created"] is False
|
||||
assert data["auto_confirm_executed"] is False
|
||||
assert data["external_network_executed"] is False
|
||||
@@ -1984,7 +2144,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
|
||||
plan = MarketIntelService().build_opportunity_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_for_opportunity_queue"] is False
|
||||
assert plan["opportunity_queue_created"] is False
|
||||
assert plan["threat_alert_dispatched"] is False
|
||||
@@ -2025,7 +2185,7 @@ def test_opportunity_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["opportunity_queue_created"] is False
|
||||
assert data["threat_alert_dispatched"] is False
|
||||
assert data["ai_summary_generated"] is False
|
||||
@@ -2036,7 +2196,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
|
||||
plan = MarketIntelService().build_opportunity_scoring_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_scoring_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_for_scoring_job"] is False
|
||||
assert plan["scoring_job_created"] is False
|
||||
assert plan["score_calculation_executed"] is False
|
||||
@@ -2084,7 +2244,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_scoring_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["scoring_job_created"] is False
|
||||
assert data["score_calculation_executed"] is False
|
||||
assert data["sample_scores_generated"] is False
|
||||
@@ -2096,7 +2256,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
|
||||
plan = MarketIntelService().build_opportunity_evidence_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_evidence_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_for_evidence_bundle"] is False
|
||||
assert plan["evidence_bundle_created"] is False
|
||||
assert plan["evidence_query_executed"] is False
|
||||
@@ -2142,7 +2302,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_evidence_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["evidence_bundle_created"] is False
|
||||
assert data["evidence_query_executed"] is False
|
||||
assert data["sample_evidence_generated"] is False
|
||||
@@ -2155,7 +2315,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
|
||||
plan = MarketIntelService().build_opportunity_alert_plan()
|
||||
|
||||
assert plan["mode"] == "opportunity_alert_plan_preview"
|
||||
assert plan["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert plan["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert plan["ready_for_alert_candidates"] is False
|
||||
assert plan["alert_candidate_created"] is False
|
||||
assert plan["alert_queue_created"] is False
|
||||
@@ -2240,7 +2400,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "opportunity_alert_plan_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["alert_candidate_created"] is False
|
||||
assert data["alert_queue_created"] is False
|
||||
assert data["review_queue_created"] is False
|
||||
@@ -2318,7 +2478,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "mcp_external_deploy_preflight_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["deployment_actions_executed"] is False
|
||||
assert data["docker_command_executed"] is False
|
||||
assert data["ssh_command_executed"] is False
|
||||
@@ -2333,7 +2493,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
|
||||
readiness = MarketIntelService().build_mcp_readiness()
|
||||
|
||||
assert readiness["mode"] == "mcp_readiness_planned"
|
||||
assert readiness["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert readiness["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert readiness["execute_requested"] is False
|
||||
assert readiness["router_enabled"] is False
|
||||
assert readiness["external_mcp_complete"] is False
|
||||
@@ -2729,6 +2889,7 @@ def test_deployment_readiness_reports_app_only_release_gate():
|
||||
assert readiness["checks"]["manual_sample_candidate_queue_draft_post_safe"] is True
|
||||
assert readiness["checks"]["manual_sample_candidate_queue_approval_post_safe"] is True
|
||||
assert readiness["checks"]["manual_sample_candidate_queue_transaction_post_safe"] is True
|
||||
assert readiness["checks"]["candidate_queue_writer_cli_status_safe"] is True
|
||||
assert readiness["checks"]["match_review_plan_preview_safe"] is True
|
||||
assert readiness["checks"]["opportunity_plan_preview_safe"] is True
|
||||
assert readiness["checks"]["opportunity_scoring_plan_preview_safe"] is True
|
||||
@@ -3029,6 +3190,39 @@ def test_deployment_readiness_reports_app_only_release_gate():
|
||||
readiness["manual_sample_candidate_queue_transaction"]["scheduler_attached"]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["mode"]
|
||||
== "candidate_queue_writer_cli_blocked"
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["ready_for_real_write"]
|
||||
is False
|
||||
)
|
||||
assert readiness["candidate_queue_writer_cli_status"]["writes_executed"] is False
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["would_write_database"]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["database_connection_opened"]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["explicit_transaction_opened"]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["database_write_executed"]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["database_commit_executed"]
|
||||
is False
|
||||
)
|
||||
assert (
|
||||
readiness["candidate_queue_writer_cli_status"]["scheduler_attached"]
|
||||
is False
|
||||
)
|
||||
assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False
|
||||
assert readiness["scheduler_plan"]["crawler_job_started"] is False
|
||||
assert readiness["scheduler_plan"]["database_write_executed"] is False
|
||||
@@ -3133,7 +3327,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only():
|
||||
drill = MarketIntelService().build_migration_apply_drill()
|
||||
|
||||
assert drill["mode"] == "migration_apply_drill_preview"
|
||||
assert drill["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert drill["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert drill["execute_requested"] is False
|
||||
assert drill["schema_state"] == "planned_no_db_probe"
|
||||
assert drill["drill_ready_for_operator_review"] is True
|
||||
@@ -3248,7 +3442,7 @@ def test_migration_apply_drill_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "migration_apply_drill_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["migration_executed"] is False
|
||||
assert data["rollback_executed"] is False
|
||||
@@ -3260,7 +3454,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic():
|
||||
review = MarketIntelService().build_migration_catalog_review()
|
||||
|
||||
assert review["mode"] == "migration_catalog_review_preview"
|
||||
assert review["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert review["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert review["execute_requested"] is False
|
||||
assert review["catalog_state"] == "planned_no_probe"
|
||||
assert review["seed_state"] == "planned_no_probe"
|
||||
@@ -3375,7 +3569,7 @@ def test_migration_catalog_review_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "migration_catalog_review_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["catalog_state"] == "planned_no_probe"
|
||||
assert data["migration_executed"] is False
|
||||
@@ -3388,7 +3582,7 @@ def test_migration_live_smoke_planned_is_preview_only():
|
||||
smoke = MarketIntelService().build_migration_live_smoke()
|
||||
|
||||
assert smoke["mode"] == "migration_live_smoke_preview"
|
||||
assert smoke["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert smoke["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert smoke["execute_requested"] is False
|
||||
assert smoke["smoke_result"] == "planned_no_execution"
|
||||
assert smoke["live_smoke_passed"] is False
|
||||
@@ -3450,7 +3644,7 @@ def test_migration_live_smoke_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "migration_live_smoke_preview"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["smoke_result"] == "planned_no_execution"
|
||||
assert data["migration_executed"] is False
|
||||
@@ -3463,7 +3657,7 @@ def test_live_db_inventory_planned_is_preview_only():
|
||||
inventory = MarketIntelService().build_live_db_inventory()
|
||||
|
||||
assert inventory["mode"] == "live_db_inventory_planned"
|
||||
assert inventory["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert inventory["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert inventory["execute_requested"] is False
|
||||
assert inventory["read_only_query_executed"] is False
|
||||
assert inventory["database_connection_opened"] is False
|
||||
@@ -3607,7 +3801,7 @@ def test_live_db_inventory_route_is_preview_only():
|
||||
|
||||
assert response.status_code == 200
|
||||
assert data["mode"] == "live_db_inventory_planned"
|
||||
assert data["phase"] == "phase_54_manual_sample_candidate_queue_transaction"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["read_only_query_executed"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
@@ -3779,3 +3973,68 @@ def test_seed_writer_cli_script_outputs_blocked_plan():
|
||||
assert data["exit_code"] == 0
|
||||
assert data["transaction_preview"]["statement_count"] == 4
|
||||
assert data["transaction_preview"]["transaction_opened"] is False
|
||||
|
||||
|
||||
def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path):
|
||||
sample_file = tmp_path / "sample.json"
|
||||
sample_file.write_text(
|
||||
json.dumps(
|
||||
{
|
||||
"batch_id": "sample-batch-15",
|
||||
"platform_code": "momo",
|
||||
"source_key": "homepage",
|
||||
"source_url": "https://www.momoshop.com.tw/",
|
||||
"status": "fetched",
|
||||
"status_code": 200,
|
||||
"content_length": 1700,
|
||||
"page_hash": "c" * 64,
|
||||
"title": "MOMO 活動",
|
||||
"diagnostics": {
|
||||
"link_count": 1,
|
||||
"same_host_link_count": 1,
|
||||
"campaign_link_candidates": [
|
||||
{
|
||||
"confidence_band": "high",
|
||||
"score": 94,
|
||||
"url": "https://www.momoshop.com.tw/activity/sample",
|
||||
"text": "品牌活動",
|
||||
},
|
||||
],
|
||||
},
|
||||
},
|
||||
ensure_ascii=False,
|
||||
),
|
||||
encoding="utf-8",
|
||||
)
|
||||
env = {
|
||||
**os.environ,
|
||||
"MOMO_ALLOW_INSECURE_CONFIG_FOR_TESTS": "true",
|
||||
"SECRET_KEY": "test",
|
||||
"LOGIN_PASSWORD": "test",
|
||||
}
|
||||
result = subprocess.run(
|
||||
[
|
||||
sys.executable,
|
||||
"scripts/market_intel_candidate_queue_writer.py",
|
||||
"--sample-json",
|
||||
str(sample_file),
|
||||
],
|
||||
capture_output=True,
|
||||
check=False,
|
||||
env=env,
|
||||
text=True,
|
||||
)
|
||||
data = json.loads(result.stdout)
|
||||
|
||||
assert result.returncode == 0
|
||||
assert data["mode"] == "candidate_queue_writer_cli_blocked"
|
||||
assert data["phase"] == "phase_55_candidate_queue_writer_cli_gate"
|
||||
assert data["execute_requested"] is False
|
||||
assert data["apply_real_write_requested"] is False
|
||||
assert data["writes_executed"] is False
|
||||
assert data["database_connection_opened"] is False
|
||||
assert data["database_write_executed"] is False
|
||||
assert data["database_commit_executed"] is False
|
||||
assert data["scheduler_attached"] is False
|
||||
assert data["transaction_preview_summary"]["statement_count"] == 1
|
||||
assert "execute_requested" in data["blocked_reasons"]
|
||||
|
||||
Reference in New Issue
Block a user