From 9843843fbb43258f251823447d2a8121d94925e4 Mon Sep 17 00:00:00 2001 From: OoO Date: Sun, 31 May 2026 14:20:46 +0800 Subject: [PATCH] V10.497 add market intel queue writer run package review gate --- TODO_NEXT_STEPS.txt | 1 + config.py | 2 +- ...s-platform-market-campaign-intelligence.md | 1 + .../code_modularization_inventory_20260430.md | 1 + .../current_execution_queue_20260524.md | 1 + docs/memory/history_logs.md | 1 + routes/market_intel_mcp_run_routes.py | 51 ++ services/market_intel/deployment_readiness.py | 57 ++ ...ndidate_queue_writer_run_package_review.py | 660 ++++++++++++++++++ services/market_intel/phase.py | 2 +- templates/market_intel/disabled.html | 167 ++++- tests/test_market_intel_skeleton.py | 623 ++++++++++++----- 12 files changed, 1383 insertions(+), 184 deletions(-) create mode 100644 services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index a6003b5..afc1930 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.497 新增市場情報 MCP Fetch Candidate Queue Writer Run Package Review 安全預覽 gate：只審核 CLI review 通過後的 operator run package 草案，要求 package id、artifact manifest、operator shell command sequence、candidate/dedupe keys 與 CLI review 對齊；API 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - V10.496 新增市場情報 MCP Fetch Candidate Queue Writer CLI Review 安全預覽 gate：只審核 writer preflight 後的 CLI review 草案，確認 script path、target table、preflight id、payload row count、candidate/dedupe keys 與 command argv；禁止 API 執行 CLI、禁止 `--execute` / `--apply-real-write` / `--approval-token` 進 payload，API 不讀 token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - V10.495 新增市場情報 MCP Fetch Candidate Queue Writer Preflight 安全預覽 gate：只審核 queue review 後的 writer preflight 草案，確認 target_table、write_mode、dedupe strategy、insert columns、payload rows 與候選 key 對齊；API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - V10.494 新增市場情報 MCP Fetch Candidate Queue Review 安全預覽 gate：只審核 candidate handoff 後的人工 queue review 草案，要求候選 key 對齊、review_state 停在 needs_review、allowed actions 限定人工確認/否決/延後、queue_write_status 維持 not_persisted；API 不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 diff --git a/config.py b/config.py index 2eb762e..bce5074 100644 --- a/config.py +++ b/config.py @@ -350,7 +350,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.496" +SYSTEM_VERSION = "V10.497" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 9920a4d..9470a92 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -168,6 +168,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-31 追加 MCP fetch candidate queue review gate：`services.market_intel.mcp_fetch_candidate_queue_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_review` 在 handoff review 通過後審核人工 queue review 草案，檢查候選 key 對齊、`review_state=needs_review`、allowed actions 人工限定、`queue_write_status=not_persisted`、操作員無寫入/無連外/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不建立 queue、不更新 review_state、不讀 artifact、不寫 DB、不掛 scheduler，只放行到 writer preflight。 - 2026-05-31 追加 MCP fetch candidate queue writer preflight gate：`services.market_intel.mcp_fetch_candidate_queue_writer_preflight` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 在 queue review 通過後審核 writer preflight 草案，檢查 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows、候選 key 對齊、小批次上限、操作員無寫入/無連外/無 CLI/無排程確認、raw HTML/secret 外洩與 side-effect flags；API/UI 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不掛 scheduler，只放行到 CLI writer review。 - 2026-05-31 追加 MCP fetch candidate queue writer CLI review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_cli_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review` 在 writer preflight 通過後審核 CLI review 草案，檢查 script path、target table、preflight id、payload row count、candidate/dedupe keys、`--sample-json`、`--read-only-preflight` 與 forbidden flags；API/UI 不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler，只放行到 operator run package review。 +- 2026-05-31 追加 MCP fetch candidate queue writer run package review gate：`services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review` 與 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review` 在 CLI review 通過後審核 operator run package 草案，檢查 package identity、artifact manifest、operator shell command sequence、candidate/dedupe keys、CLI review id 與 preflight id；API/UI 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - 2026-05-18 追加 scheduler attach plan preview：`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB；排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview：`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP；價格只能作為輔助訊號，不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview：`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB；高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index e754dd3..13ac918 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -46,6 +46,7 @@ - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer preflight gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增邏輯維持在獨立 `services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py`，route 延續 `routes/market_intel_mcp_run_routes.py` extension。 - 2026-05-31 追記：`services/market_intel/mcp_fetch_candidate_queue_writer_preflight.py` 目前 628 行，略過 600 行提醒門檻；暫不拆分的理由是 gate 條件、sample payload 與 side-effect blocklist 需留在單一 preview module 便於審核，下一個 writer CLI review gate 若共用相同常數再抽 `mcp_fetch_candidate_queue_writer_policy.py`。 - 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer CLI review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_cli_review.py` 為 591 行，仍低於 600 行提醒門檻。 +- 2026-05-31 追記：同步市場情報 MCP fetch candidate queue writer run package review gate 後的 `services/market_intel/deployment_readiness.py` 行數；本次新增 `services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py` 為 660 行，略過 600 行提醒門檻。暫不拆分的理由是 run package gate 需要把 CLI review linkage、artifact manifest、operator shell command sequence 與 side-effect blocklist 放在單一 preview module 便於安全審核；若下一段 run readiness review 重複相同 policy，應抽出 writer policy helper。 - 2026-05-24 追記：同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數；此處只更新 inventory，不變更 Code Review 行為。 - 2026-05-21 追記：同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 - 2026-05-21 追記：同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數；此處只更新 inventory，不變更模組化決策。 diff --git a/docs/memory/current_execution_queue_20260524.md b/docs/memory/current_execution_queue_20260524.md index 38f7a81..828d6a3 100644 --- a/docs/memory/current_execution_queue_20260524.md +++ b/docs/memory/current_execution_queue_20260524.md @@ -92,6 +92,7 @@ - 2026-05-31 起，`V10.494` 新增市場情報 MCP Fetch Candidate Queue Review gate：在 handoff review 通過後只審核人工 queue review 草案，要求候選 key 完全對齊、review_state 只停在 `needs_review`、allowed actions 限人工操作、queue_write_status 維持 `not_persisted`；仍不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - 2026-05-31 起，`V10.495` 新增市場情報 MCP Fetch Candidate Queue Writer Preflight gate：在 queue review 通過後只審核 writer preflight 草案，要求 target table、write mode、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊；仍不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - 2026-05-31 起，`V10.496` 新增市場情報 MCP Fetch Candidate Queue Writer CLI Review gate：在 writer preflight 通過後只審核 CLI review 草案，要求 script path、target table、preflight id、row count、candidate/dedupe keys 與 read-only command argv 對齊；仍不執行 CLI、不讀 approval token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 +- 2026-05-31 起，`V10.497` 新增市場情報 MCP Fetch Candidate Queue Writer Run Package Review gate：在 CLI review 通過後只審核 operator run package 草案，要求 artifact manifest、operator shell command sequence、package identity、candidate/dedupe keys 與 CLI review 對齊；仍不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 ## 3. 12 Agent 決策信封整合 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 06e6732..c3dc3f2 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24：PChome 近門檻身份回收第二輪 +- **V10.497 市場情報 MCP Fetch Candidate Queue Writer Run Package Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review` 與 UI preview，只審核 CLI review 後的 operator run package 草案；要求 package identity、artifact manifest、operator shell command sequence、candidate/dedupe keys 與 CLI review 完全對齊，且 API 不產檔、不讀 approval token、不執行 CLI、不開 DB、不寫 queue、不掛 scheduler，只放行到 run readiness review。 - **V10.496 市場情報 MCP Fetch Candidate Queue Writer CLI Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review` 與 UI preview，只審核 writer preflight 後的 CLI review 草案；要求 script path、target table、preflight id、payload row count、candidate/dedupe keys 與 command argv 完全對齊，並禁止 `--execute`、`--apply-real-write`、`--approval-token` 進 API payload，且 API 不執行 CLI、不讀 token、不寫檔、不開 DB、不寫 queue、不掛 scheduler。 - **V10.495 市場情報 MCP Fetch Candidate Queue Writer Preflight gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_writer_preflight` 與 UI preview，只審核 queue review 後的 writer preflight 草案；要求 `target_table=market_alert_review_queue`、`write_mode=cli_only_later`、dedupe strategy、insert columns、payload rows 與候選 key 完全對齊，且 API 不開 DB、不執行 CLI、不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 - **V10.494 市場情報 MCP Fetch Candidate Queue Review gate**: 新增 `/api/market_intel/mcp_fetch_candidate_queue_review` 與 UI preview，只審核 candidate handoff 後的人工 queue review 草案；要求候選 key 完全對齊、`review_state=needs_review`、allowed actions 限人工確認/否決/延後、`queue_write_status=not_persisted`，且 API 不建立 queue、不更新 review_state、不寫 DB、不連外、不掛 scheduler。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index 6f3eb0f..4228da2 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -31,6 +31,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( build_mcp_fetch_candidate_queue_writer_cli_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -347,3 +350,51 @@ def market_intel_mcp_fetch_candidate_queue_writer_cli_review(): phase=service.phase, ) ) + + +@market_intel_bp.route( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review", + methods=["GET", "POST"], +) +@login_required +def market_intel_mcp_fetch_candidate_queue_writer_run_package_review(): + writer_cli_review_package = {} + writer_cli_review_result = None + writer_run_package_review = None + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = ( + payload.get("writer_run_package_review_package") + or payload.get("candidate_queue_writer_run_package_review") + or payload.get("writer_run_package_review") + or payload.get("run_package_review") + or payload + ) + writer_cli_review_package = ( + package.get("writer_cli_review_package") + or package.get("candidate_queue_writer_cli_review") + or package.get("writer_cli_review") + or package.get("cli_review_package") + or {} + ) + writer_cli_review_result = ( + package.get("writer_cli_review_result") + or package.get("mcp_fetch_candidate_queue_writer_cli_review") + ) + writer_run_package_review = ( + package.get("writer_run_package_review") + or package.get("candidate_queue_writer_run_package_review") + or package.get("run_package_review") + or package.get("package_review") + or package.get("review_payload") + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + writer_cli_review_package=writer_cli_review_package, + writer_cli_review_result=writer_cli_review_result, + writer_run_package_review=writer_run_package_review, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 6fabad6..686b034 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -87,6 +87,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( build_mcp_fetch_candidate_queue_writer_cli_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -229,6 +232,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_candidate_queue_writer_cli_review",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -288,6 +296,11 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s phase=service.phase, ) ) + mcp_fetch_candidate_queue_writer_run_package_review = ( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + phase=service.phase, + ) + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -862,6 +875,49 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_fetch_candidate_queue_writer_cli_review["file_written"] and not mcp_fetch_candidate_queue_writer_cli_review["scheduler_attached"] ), + "mcp_fetch_candidate_queue_writer_run_package_review_preview_safe": bool( + mcp_fetch_candidate_queue_writer_run_package_review["mode"] + == "mcp_fetch_candidate_queue_writer_run_package_review_preview" + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "payload_persisted" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "run_package_persisted" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "package_artifact_created" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "api_writes_file" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "api_executes_cli" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "api_reads_approval_token" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "api_opens_database_connection" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "api_writes_database" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "api_uses_external_network" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "database_write_executed" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "cli_executed" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "file_written" + ] + and not mcp_fetch_candidate_queue_writer_run_package_review[ + "scheduler_attached" + ] + ), "candidate_queue_writer_postwrite_smoke_planned_safe": bool( candidate_queue_writer_postwrite_smoke["mode"] == "candidate_queue_writer_postwrite_smoke_planned" @@ -1183,6 +1239,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_fetch_candidate_queue_review": mcp_fetch_candidate_queue_review, "mcp_fetch_candidate_queue_writer_preflight": mcp_fetch_candidate_queue_writer_preflight, "mcp_fetch_candidate_queue_writer_cli_review": mcp_fetch_candidate_queue_writer_cli_review, + "mcp_fetch_candidate_queue_writer_run_package_review": mcp_fetch_candidate_queue_writer_run_package_review, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py b/services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py new file mode 100644 index 0000000..870a962 --- /dev/null +++ b/services/market_intel/mcp_fetch_candidate_queue_writer_run_package_review.py @@ -0,0 +1,660 @@ +"""市場情報 MCP fetch candidate queue writer run package review preview。 + +本模組只審核 writer CLI review 後的 operator run package 草案；API/UI +不建立 artifact、不寫檔、不執行 CLI、不讀 approval token、不開 DB、不寫 +queue、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( + build_mcp_fetch_candidate_queue_writer_cli_review_preview, +) +from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import TARGET_TABLE + + +MAX_RUN_PACKAGE_ITEMS = 80 +SAFE_PACKAGE_MODES = {"candidate_queue_writer_run_package_review_preview"} +SAFE_PACKAGE_STAGES = {"operator_review_only"} + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "secret", + "session_cookie", + "token", +) + +SAFE_SECRET_METADATA_KEYS = { + "approval_token_shell_only_required", + "contains_approval_token", + "no_approval_token_payload", + "no_secret_payload", + "operator_confirmed_no_approval_token_in_payload", + "reads_approval_token", + "real_write_approval_token_not_included", +} + +FORBIDDEN_RAW_PAYLOAD_KEYS = ( + "body_html", + "document_html", + "html", + "page_html", + "raw_body", + "raw_html", + "raw_snapshot", + "response_body", +) + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_cli_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_executed_cli", + "api_executes", + "api_executes_cli", + "api_opens_database_connection", + "api_reads_approval_token", + "api_uses_external_network", + "api_writes_database", + "api_writes_file", + "apply_real_write", + "attach_scheduler", + "candidate_queue_created", + "candidate_queue_persisted", + "candidate_review_state_updated", + "cli_executed", + "command_executed", + "contains_approval_token", + "database_commit_executed", + "database_connection_opened", + "database_session_created", + "database_write_executed", + "execute_requested", + "executes_now", + "external_network_executed", + "file_written", + "file_written_by_api", + "network_request_allowed", + "opens_database_connection", + "package_artifact_created", + "payload_persisted", + "ready_for_api_database_write", + "ready_for_real_write", + "reads_approval_token", + "review_state_update_executed", + "run_package_persisted", + "scheduler_attach", + "scheduler_attached", + "write_database", + "writes_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _safe_int(value): + try: + return int(value or 0) + except (TypeError, ValueError): + return 0 + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _contains_forbidden_key(value, forbidden_keys, *, safe_keys=None): + safe_keys = safe_keys or set() + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in safe_keys and isinstance(nested, bool): + continue + if any(forbidden_key in normalized_key for forbidden_key in forbidden_keys): + return True + if _contains_forbidden_key(nested, forbidden_keys, safe_keys=safe_keys): + return True + elif isinstance(value, list): + return any( + _contains_forbidden_key(item, forbidden_keys, safe_keys=safe_keys) + for item in value + ) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + normalized_key = str(key).lower() + key_path = f"{path}.{key}" if path else key + if normalized_key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _cli_review_from_inputs(cli_review_package, cli_review_result, phase): + if isinstance(cli_review_result, dict) and cli_review_result: + return cli_review_result + + cli_review_package = _as_dict(cli_review_package) + return build_mcp_fetch_candidate_queue_writer_cli_review_preview( + writer_preflight_package=( + cli_review_package.get("writer_preflight_package") + or cli_review_package.get("candidate_queue_writer_preflight") + or cli_review_package.get("writer_preflight") + or cli_review_package.get("preflight_package") + ), + writer_preflight_result=( + cli_review_package.get("writer_preflight_result") + or cli_review_package.get("mcp_fetch_candidate_queue_writer_preflight") + ), + writer_cli_review=( + cli_review_package.get("writer_cli_review") + or cli_review_package.get("candidate_queue_writer_cli_review") + or cli_review_package.get("cli_review") + or cli_review_package.get("review_payload") + ), + phase=phase, + ) + + +def _cli_review_summary(cli_review): + cli_review = _as_dict(cli_review) + summary = _as_dict(cli_review.get("writer_cli_review_summary")) + side_effects_clear = bool( + not cli_review.get("network_request_allowed") + and not cli_review.get("api_executes_cli") + and not cli_review.get("api_reads_approval_token") + and not cli_review.get("api_opens_database_connection") + and not cli_review.get("api_writes_database") + and not cli_review.get("api_uses_external_network") + and not cli_review.get("database_write_executed") + and not cli_review.get("cli_executed") + and not cli_review.get("file_written") + and not cli_review.get("scheduler_attached") + and not cli_review.get("candidate_queue_created") + and not cli_review.get("candidate_queue_persisted") + and not cli_review.get("candidate_review_state_updated") + ) + return { + "mode": cli_review.get("mode"), + "accepted": bool( + cli_review.get("mcp_fetch_candidate_queue_writer_cli_review_accepted") + ), + "ready_for_run_package_review": bool( + cli_review.get("ready_for_candidate_queue_writer_run_package_review") + ), + "review_id": _safe_text(summary.get("review_id"), 160), + "target_table": _safe_text(summary.get("target_table"), 160), + "payload_row_count": _safe_int(summary.get("expected_payload_row_count")), + "candidate_keys": sorted( + key for key in _as_list(summary.get("expected_candidate_keys")) if key + ), + "dedupe_keys": sorted( + key for key in _as_list(summary.get("expected_dedupe_keys")) if key + ), + "side_effects_clear": side_effects_clear, + "blocked_reasons": cli_review.get("blocked_reasons", []), + } + + +def _sample_run_package_review_package(): + cli_preview = build_mcp_fetch_candidate_queue_writer_cli_review_preview() + cli_package = cli_preview["sample_writer_cli_review_package"] + cli_result = build_mcp_fetch_candidate_queue_writer_cli_review_preview( + writer_preflight_package=cli_package["writer_preflight_package"], + writer_preflight_result=cli_package["writer_preflight_result"], + writer_cli_review=cli_package["writer_cli_review"], + ) + cli_summary = _cli_review_summary(cli_result) + run_package_review = { + "run_package_id": "market-intel-candidate-writer-run-package-sample", + "package_mode": "candidate_queue_writer_run_package_review_preview", + "package_stage": "operator_review_only", + "target_table": TARGET_TABLE, + "writer_cli_review_id": cli_summary["review_id"], + "expected_payload_row_count": cli_summary["payload_row_count"], + "expected_candidate_keys": cli_summary["candidate_keys"], + "expected_dedupe_keys": cli_summary["dedupe_keys"], + "required_artifacts": [ + { + "key": "operator_reviewed_json", + "path_shape": "artifacts/market_intel/reviewed-sample-*.json", + "created_by_api": False, + }, + { + "key": "project_backup_zip", + "path_shape": "scripts/tools/backups/momo_pro_system_backup_*.zip", + "created_by_api": False, + }, + { + "key": "read_only_preflight_output", + "path_shape": "artifacts/market_intel/preflight-*.json", + "created_by_api": False, + }, + ], + "command_bundle": [ + { + "step": 1, + "key": "save_reviewed_json", + "operator_shell_only": True, + "api_executes": False, + "executes_now": False, + "writes_database": False, + "reads_approval_token": False, + "contains_approval_token": False, + "opens_database_connection": False, + }, + { + "step": 2, + "key": "backup_required", + "operator_shell_only": True, + "api_executes": False, + "executes_now": False, + "writes_database": False, + "reads_approval_token": False, + "contains_approval_token": False, + "opens_database_connection": False, + }, + { + "step": 3, + "key": "read_only_preflight", + "operator_shell_only": True, + "api_executes": False, + "executes_now": False, + "writes_database": False, + "reads_approval_token": False, + "contains_approval_token": False, + "opens_database_connection": False, + }, + ], + "operator_confirmations": { + "no_api_file_write": True, + "no_api_cli_execution": True, + "no_approval_token_payload": True, + "no_database_write": True, + "no_external_network": True, + "no_scheduler_attach": True, + "no_persistence": True, + "no_secret_payload": True, + }, + "promotion_policy": { + "next_gate": "candidate_queue_writer_run_readiness_review", + "approval_token_shell_only_required": True, + "real_write_approval_token_not_included": True, + "real_write_requires_separate_gate": True, + }, + "api_execution_allowed": False, + "real_write_allowed": False, + } + return { + "writer_cli_review_package": cli_package, + "writer_cli_review_result": cli_result, + "writer_run_package_review": run_package_review, + } + + +def _run_package_summary(run_package): + run_package = _as_dict(run_package) + artifacts = [ + item for item in _as_list(run_package.get("required_artifacts")) + if isinstance(item, dict) + ] + commands = [ + item for item in _as_list(run_package.get("command_bundle")) + if isinstance(item, dict) + ] + confirmations = _as_dict(run_package.get("operator_confirmations")) + candidate_keys = sorted( + key for key in _as_list(run_package.get("expected_candidate_keys")) if key + ) + dedupe_keys = sorted( + key for key in _as_list(run_package.get("expected_dedupe_keys")) if key + ) + artifacts_operator_created = bool( + artifacts + and all( + not item.get("created_by_api") + and not item.get("api_writes_file") + and not item.get("file_written_by_api") + for item in artifacts + ) + ) + command_bundle_api_safe = bool( + commands + and all( + not item.get("api_executes") + and not item.get("executes_now") + and not item.get("writes_database") + and not item.get("reads_approval_token") + and not item.get("contains_approval_token") + and not item.get("opens_database_connection") + and not item.get("external_network") + and not item.get("scheduler_attach") + and not item.get("file_written_by_api") + for item in commands + ) + ) + operator_boundaries_confirmed = bool( + confirmations.get("no_api_file_write") + and confirmations.get("no_api_cli_execution") + and confirmations.get("no_approval_token_payload") + and confirmations.get("no_database_write") + and confirmations.get("no_external_network") + and confirmations.get("no_scheduler_attach") + and confirmations.get("no_persistence") + and confirmations.get("no_secret_payload") + ) + return { + "provided_keys": sorted(run_package.keys()), + "run_package_id": _safe_text( + run_package.get("run_package_id") or run_package.get("package_id"), + 160, + ), + "package_mode": _safe_text(run_package.get("package_mode"), 160), + "package_stage": _safe_text(run_package.get("package_stage"), 160), + "target_table": _safe_text(run_package.get("target_table"), 160), + "writer_cli_review_id": _safe_text( + run_package.get("writer_cli_review_id"), 160 + ), + "expected_payload_row_count": _safe_int( + run_package.get("expected_payload_row_count") + ), + "expected_candidate_keys": candidate_keys, + "expected_dedupe_keys": dedupe_keys, + "candidate_keys_unique": bool( + candidate_keys and len(set(candidate_keys)) == len(candidate_keys) + ), + "dedupe_keys_unique": bool( + dedupe_keys and len(set(dedupe_keys)) == len(dedupe_keys) + ), + "required_artifact_count": len(artifacts), + "command_count": len(commands), + "artifacts_operator_created": artifacts_operator_created, + "command_bundle_api_safe": command_bundle_api_safe, + "operator_boundaries_confirmed": operator_boundaries_confirmed, + "api_execution_allowed": bool(run_package.get("api_execution_allowed")), + "real_write_allowed": bool(run_package.get("real_write_allowed")), + "promotion_next_gate": _safe_text( + _as_dict(run_package.get("promotion_policy")).get("next_gate"), 160 + ), + "raw_payload_submitted_to_api": _contains_forbidden_key( + run_package, + FORBIDDEN_RAW_PAYLOAD_KEYS, + ), + "secret_or_token_submitted_to_api": _contains_forbidden_key( + run_package, + FORBIDDEN_SECRET_KEYS, + safe_keys=SAFE_SECRET_METADATA_KEYS, + ), + "blocked_side_effects": _blocked_side_effects(run_package), + "required_artifacts": artifacts, + "command_bundle": commands, + } + + +def _review_gates( + *, + cli_received, + run_package_received, + run_package_valid_object, + cli_review, + run_package, +): + cli_candidate_keys = set(cli_review["candidate_keys"]) + package_candidate_keys = set(run_package["expected_candidate_keys"]) + cli_dedupe_keys = set(cli_review["dedupe_keys"]) + package_dedupe_keys = set(run_package["expected_dedupe_keys"]) + return [ + { + "key": "writer_cli_review_payload_or_result_received", + "label": "已提供 writer CLI review package 或已審核結果", + "passed": cli_received, + }, + { + "key": "writer_cli_review_accepted", + "label": "writer CLI review gate 必須已通過", + "passed": cli_review["accepted"], + }, + { + "key": "writer_cli_review_ready_for_run_package_review", + "label": "writer CLI review 只放行到 run package review", + "passed": cli_review["ready_for_run_package_review"], + }, + { + "key": "writer_cli_review_side_effect_free", + "label": "writer CLI review 未顯示 API 執行、寫 DB 或掛 scheduler", + "passed": cli_review["side_effects_clear"], + }, + { + "key": "writer_run_package_review_payload_received", + "label": "已提供 writer run package review 草案", + "passed": run_package_received, + }, + { + "key": "writer_run_package_review_valid_object", + "label": "writer run package review payload 必須是 JSON object", + "passed": run_package_valid_object, + }, + { + "key": "writer_run_package_identity_recorded", + "label": "run package 必須記錄 run_package_id", + "passed": bool(run_package["run_package_id"]), + }, + { + "key": "writer_run_package_mode_preview_only", + "label": "run package 必須維持 review preview mode", + "passed": run_package["package_mode"] in SAFE_PACKAGE_MODES, + }, + { + "key": "writer_run_package_stage_operator_review_only", + "label": "run package stage 必須是 operator_review_only", + "passed": run_package["package_stage"] in SAFE_PACKAGE_STAGES, + }, + { + "key": "writer_run_package_target_table_safe", + "label": "target table 必須是 market_alert_review_queue", + "passed": run_package["target_table"] == TARGET_TABLE, + }, + { + "key": "writer_run_package_cli_review_id_matches", + "label": "run package 必須對齊 writer CLI review id", + "passed": bool( + run_package["writer_cli_review_id"] + and run_package["writer_cli_review_id"] == cli_review["review_id"] + ), + }, + { + "key": "writer_run_package_payload_count_matches_cli_review", + "label": "run package row count 必須對齊 CLI review", + "passed": bool( + 0 < run_package["expected_payload_row_count"] <= MAX_RUN_PACKAGE_ITEMS + and run_package["expected_payload_row_count"] + == cli_review["payload_row_count"] + ), + }, + { + "key": "writer_run_package_candidate_keys_match_cli_review", + "label": "run package candidate keys 必須完全對齊 CLI review", + "passed": bool( + cli_candidate_keys + and package_candidate_keys == cli_candidate_keys + and run_package["candidate_keys_unique"] + ), + }, + { + "key": "writer_run_package_dedupe_keys_match_cli_review", + "label": "run package dedupe keys 必須完全對齊 CLI review", + "passed": bool( + cli_dedupe_keys + and package_dedupe_keys == cli_dedupe_keys + and run_package["dedupe_keys_unique"] + ), + }, + { + "key": "writer_run_package_artifacts_operator_created", + "label": "required artifacts 必須由操作員建立，API 不產檔", + "passed": run_package["artifacts_operator_created"], + }, + { + "key": "writer_run_package_command_bundle_api_safe", + "label": "command bundle 只能描述人工 shell 步驟，API 不執行", + "passed": run_package["command_bundle_api_safe"], + }, + { + "key": "writer_run_package_operator_boundaries_confirmed", + "label": "操作員確認 API 不寫檔、不執行 CLI、不讀 token、不寫 DB", + "passed": run_package["operator_boundaries_confirmed"], + }, + { + "key": "writer_run_package_no_api_execution_or_real_write", + "label": "run package review payload 不得允許 API execution 或 real write", + "passed": bool( + not run_package["api_execution_allowed"] + and not run_package["real_write_allowed"] + ), + }, + { + "key": "writer_run_package_no_raw_payload", + "label": "run package review payload 不得回貼 raw HTML/body/snapshot", + "passed": not run_package["raw_payload_submitted_to_api"], + }, + { + "key": "writer_run_package_no_secret_or_token_key", + "label": "run package review payload 不得包含 secret、cookie、password 或 token key", + "passed": not run_package["secret_or_token_submitted_to_api"], + }, + { + "key": "writer_run_package_side_effect_free", + "label": "run package review payload 不得要求 API 寫檔、執行、寫 DB 或掛 scheduler", + "passed": not run_package["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + *, + writer_cli_review_package=None, + writer_cli_review_result=None, + writer_run_package_review=None, + phase=None, +): + """建立 fetch candidate queue writer run package review；不執行任何寫入。""" + writer_cli_review_package = _as_dict(writer_cli_review_package) + cli_result_received = bool( + isinstance(writer_cli_review_result, dict) and writer_cli_review_result + ) + run_package_valid_object = ( + isinstance(writer_run_package_review, dict) + if writer_run_package_review is not None + else True + ) + run_package_payload = _as_dict(writer_run_package_review) + cli_data = _cli_review_from_inputs( + writer_cli_review_package, + writer_cli_review_result, + phase, + ) + cli_received = bool(writer_cli_review_package or cli_result_received) + payload_received = bool( + cli_received or run_package_payload or writer_run_package_review is not None + ) + run_package_received = bool(run_package_payload) + cli_review = _cli_review_summary(cli_data) + run_package = _run_package_summary(run_package_payload) + gates = _review_gates( + cli_received=cli_received, + run_package_received=run_package_received, + run_package_valid_object=run_package_valid_object, + cli_review=cli_review, + run_package=run_package, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + accepted = bool(payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_candidate_queue_writer_run_package_review" + if payload_received + else "mcp_fetch_candidate_queue_writer_run_package_review_preview" + ), + "phase": phase, + "writer_run_package_review_payload_received": payload_received, + "writer_cli_review_received": cli_received, + "writer_run_package_review_received": run_package_received, + "writer_run_package_review_valid_object": run_package_valid_object, + "writer_cli_review_accepted": cli_review["accepted"], + "mcp_fetch_candidate_queue_writer_run_package_review_accepted": accepted, + "candidate_queue_writer_run_package_review_ready": accepted, + "ready_for_candidate_queue_writer_run_readiness_review": accepted, + "ready_for_api_database_write": False, + "ready_for_real_write": False, + "ready_for_scheduler_attach": False, + "network_request_allowed": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "payload_row_count": run_package["expected_payload_row_count"], + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "writer_cli_review_summary": cli_review, + "writer_run_package_review_summary": run_package, + "sample_writer_run_package_review_package": _sample_run_package_review_package(), + "next_operator_steps": [ + "Run package review 通過後，只代表可進入 run readiness review", + "任何 --execute、--apply-real-write 與 approval token 仍必須留在後續人工 shell gate", + "API/UI 仍不得建立 artifact、寫檔、執行 CLI、讀 token、開 DB 或寫 queue", + ], + "payload_persisted": False, + "run_package_review_persisted": False, + "run_package_persisted": False, + "package_artifact_created": False, + "api_writes_file": False, + "database_session_created": False, + "database_commit_executed": False, + "database_write_executed": False, + "external_network_executed": False, + "cli_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + "scheduler_attached": False, + "candidate_queue_created": False, + "candidate_queue_persisted": False, + "candidate_review_state_updated": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 78b2bd9..d29c680 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" +MARKET_INTEL_PHASE = "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 7d7d4c5..81ad3f3 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -890,6 +890,32 @@ +
+
+
+

MCP / WRITER RUN PACKAGE REVIEW

+

MCP Candidate Queue Writer Run Package Review

+
+ +
+
+ loading +
+
+
讀取 MCP Writer Run Package Review 中...
+
+
+ +
+ +
+
+
+
@@ -1407,6 +1433,7 @@ const mcpFetchCandidateQueueReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-review]'); const mcpFetchCandidateQueueWriterPreflightRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-preflight]'); const mcpFetchCandidateQueueWriterCliReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review]'); + const mcpFetchCandidateQueueWriterRunPackageReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1423,7 +1450,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !mcpFetchRunReceiptRoot && !mcpFetchResultParserReviewRoot && !mcpFetchCandidateHandoffReviewRoot && !mcpFetchCandidateQueueReviewRoot && !mcpFetchCandidateQueueWriterPreflightRoot && !mcpFetchCandidateQueueWriterCliReviewRoot && !mcpFetchCandidateQueueWriterRunPackageReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1548,6 +1575,12 @@ const mcpFetchCandidateQueueWriterCliReviewReview = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-review]') : null; const mcpFetchCandidateQueueWriterCliReviewRefresh = mcpFetchCandidateQueueWriterCliReviewRoot ? mcpFetchCandidateQueueWriterCliReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-refresh]') : null; const mcpFetchCandidateQueueWriterCliReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_cli_review') }}"; + const mcpFetchCandidateQueueWriterRunPackageReviewMeta = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-meta]') : null; + const mcpFetchCandidateQueueWriterRunPackageReviewBody = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-body]') : null; + const mcpFetchCandidateQueueWriterRunPackageReviewInput = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-input]') : null; + const mcpFetchCandidateQueueWriterRunPackageReviewReview = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-review]') : null; + const mcpFetchCandidateQueueWriterRunPackageReviewRefresh = mcpFetchCandidateQueueWriterRunPackageReviewRoot ? mcpFetchCandidateQueueWriterRunPackageReviewRoot.querySelector('[data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-refresh]') : null; + const mcpFetchCandidateQueueWriterRunPackageReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_package_review') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -4142,6 +4175,131 @@ } }; + const renderMcpFetchCandidateQueueWriterRunPackageReviewMeta = data => { + mcpFetchCandidateQueueWriterRunPackageReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_candidate_queue_writer_run_package_review_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `rows=${data.payload_row_count || 0}`, + `cli=${data.api_executes_cli ? 'exec' : 'blocked'}`, + `db=${data.api_writes_database ? 'write' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchCandidateQueueWriterRunPackageReviewBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const cli = data.writer_cli_review_summary || {}; + const pkg = data.writer_run_package_review_summary || {}; + const artifacts = pkg.required_artifacts || []; + const commands = pkg.command_bundle || []; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchCandidateQueueWriterRunPackageReviewBody.innerHTML = ` +
此 run package review 只審核操作包草案；API 不建立 artifact、不寫檔、不執行 CLI、不讀 approval token、不開 DB、不寫 queue、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

RUN PACKAGE GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 run package gates。
' + }
+
+
+

CLI REVIEW LINK

+
+ ${renderCheck('writer_cli_review', `${cli.accepted ? 'accepted' : 'pending'} / rows=${cli.payload_row_count || 0}`, cli.accepted ? 'ACCEPTED' : 'PENDING')} + ${renderCheck('review_id', cli.review_id || 'missing', cli.review_id ? 'LINKED' : 'BLOCK')} + ${renderCheck('api_boundary', 'no CLI / no token / no DB / no scheduler', cli.side_effects_clear ? 'CLOSED' : 'BLOCK')} +
+
+
+

ARTIFACT MANIFEST

+
${ + artifacts.length + ? artifacts.map(item => renderCheck(item.key || 'artifact', item.path_shape || 'missing', !item.created_by_api ? 'OPERATOR' : 'BLOCK')).join('') + : '
尚未提供 artifact manifest。
' + }
+
+
+

COMMAND PACKAGE

+
${ + commands.length + ? commands.map(item => renderCheck(item.key || `step_${item.step || 0}`, item.operator_shell_only ? 'operator shell only' : 'missing boundary', item.api_executes || item.writes_database ? 'BLOCK' : 'PREVIEW')).join('') + : '
尚未提供 command package。
' + }
+
+
+

BOUNDARY / NEXT

+
+ ${renderCheck('package_mode', pkg.package_mode || 'missing', pkg.package_mode === 'candidate_queue_writer_run_package_review_preview' ? 'PREVIEW' : 'BLOCK')} + ${renderCheck('next_gate', pkg.promotion_next_gate || 'missing', pkg.promotion_next_gate ? 'NEXT' : 'BLOCK')} + ${renderCheck('api_side_effects', 'no artifact / no file / no CLI / no token / no DB / no queue', data.package_artifact_created || data.api_executes_cli || data.api_reads_approval_token || data.api_writes_database || data.api_writes_file ? 'BLOCK' : 'CLOSED')} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'NEXT')).join('')} +
+
+
+ `; + if (mcpFetchCandidateQueueWriterRunPackageReviewInput && !mcpFetchCandidateQueueWriterRunPackageReviewInput.value.trim() && data.sample_writer_run_package_review_package) { + mcpFetchCandidateQueueWriterRunPackageReviewInput.value = JSON.stringify(data.sample_writer_run_package_review_package, null, 2); + } + }; + + const loadMcpFetchCandidateQueueWriterRunPackageReview = async () => { + if (!mcpFetchCandidateQueueWriterRunPackageReviewMeta || !mcpFetchCandidateQueueWriterRunPackageReviewBody) return; + mcpFetchCandidateQueueWriterRunPackageReviewBody.innerHTML = '
讀取 MCP Writer Run Package Review 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterRunPackageReviewEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchCandidateQueueWriterRunPackageReviewMeta(data); + renderMcpFetchCandidateQueueWriterRunPackageReviewBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterRunPackageReviewMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterRunPackageReviewBody.innerHTML = `
MCP Writer Run Package Review 讀取失敗：${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchCandidateQueueWriterRunPackageReview = async () => { + if (!mcpFetchCandidateQueueWriterRunPackageReviewMeta || !mcpFetchCandidateQueueWriterRunPackageReviewBody || !mcpFetchCandidateQueueWriterRunPackageReviewInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchCandidateQueueWriterRunPackageReviewInput.value || '{}'); + } catch (error) { + mcpFetchCandidateQueueWriterRunPackageReviewMeta.innerHTML = 'json_error'; + mcpFetchCandidateQueueWriterRunPackageReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + mcpFetchCandidateQueueWriterRunPackageReviewBody.innerHTML = '
審核 MCP Writer Run Package Review 中...
'; + try { + const response = await fetch(mcpFetchCandidateQueueWriterRunPackageReviewEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ writer_run_package_review_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchCandidateQueueWriterRunPackageReviewMeta(data); + renderMcpFetchCandidateQueueWriterRunPackageReviewBody(data); + } catch (error) { + mcpFetchCandidateQueueWriterRunPackageReviewMeta.innerHTML = 'error'; + mcpFetchCandidateQueueWriterRunPackageReviewBody.innerHTML = `
MCP Writer Run Package Review 審核失敗：${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -13623,6 +13781,12 @@ if (mcpFetchCandidateQueueWriterCliReviewReview) { mcpFetchCandidateQueueWriterCliReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterCliReview); } + if (mcpFetchCandidateQueueWriterRunPackageReviewRefresh) { + mcpFetchCandidateQueueWriterRunPackageReviewRefresh.addEventListener('click', loadMcpFetchCandidateQueueWriterRunPackageReview); + } + if (mcpFetchCandidateQueueWriterRunPackageReviewReview) { + mcpFetchCandidateQueueWriterRunPackageReviewReview.addEventListener('click', reviewMcpFetchCandidateQueueWriterRunPackageReview); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -13890,6 +14054,7 @@ loadMcpFetchCandidateQueueReview(); loadMcpFetchCandidateQueueWriterPreflight(); loadMcpFetchCandidateQueueWriterCliReview(); + loadMcpFetchCandidateQueueWriterRunPackageReview(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index fd851a8..3c5b987 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -44,6 +44,9 @@ from services.market_intel.mcp_fetch_candidate_queue_writer_preflight import ( from services.market_intel.mcp_fetch_candidate_queue_writer_cli_review import ( build_mcp_fetch_candidate_queue_writer_cli_review_preview, ) +from services.market_intel.mcp_fetch_candidate_queue_writer_run_package_review import ( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -1077,6 +1080,34 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-mcp-fetch-candidate-queue-writer-cli-review-next" in template ) + assert ( + "market_intel.market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-gates" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-cli-review" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-artifacts" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-commands" + in template + ) + assert ( + "data-market-intel-mcp-fetch-candidate-queue-writer-run-package-review-next" + in template + ) assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1547,7 +1578,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert bridge["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1705,7 +1736,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert contract["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1838,7 +1869,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1851,7 +1882,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert gate["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1921,7 +1952,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1935,7 +1966,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert audit["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -2009,7 +2040,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -2026,11 +2057,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert evidence["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -2055,7 +2086,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2113,12 +2144,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2127,11 +2158,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert receipt["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2159,7 +2190,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2224,12 +2255,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2238,11 +2269,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert promotion["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2270,7 +2301,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2330,12 +2361,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2344,11 +2375,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2376,7 +2407,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2438,12 +2469,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2454,11 +2485,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2488,7 +2519,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2566,13 +2597,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2584,11 +2615,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert package["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2620,7 +2651,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2695,13 +2726,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2715,11 +2746,11 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): readiness = build_mcp_fetch_run_readiness_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_preview" - assert readiness["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert readiness["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert readiness["run_readiness_payload_received"] is False assert readiness["mcp_fetch_run_readiness_accepted"] is False assert readiness["run_readiness_ready"] is False @@ -2754,11 +2785,11 @@ def test_mcp_fetch_run_readiness_accepts_sample_package(): run_package=sample["run_package"], run_package_result=sample["run_package_result"], operator_readiness=sample["operator_readiness"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert readiness["mode"] == "mcp_fetch_run_readiness_review" - assert readiness["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert readiness["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert readiness["mcp_fetch_run_readiness_accepted"] is True assert readiness["run_readiness_ready"] is True assert readiness["ready_for_manual_fetch_operator_run"] is True @@ -2834,13 +2865,13 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_readiness_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_readiness_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_run_readiness_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2854,11 +2885,11 @@ def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_receipt_preview_is_safe_without_payload(): receipt = build_mcp_fetch_run_receipt_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_preview" - assert receipt["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert receipt["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert receipt["run_receipt_payload_received"] is False assert receipt["mcp_fetch_run_receipt_accepted"] is False assert receipt["run_receipt_ready"] is False @@ -2895,11 +2926,11 @@ def test_mcp_fetch_run_receipt_accepts_sample_receipt(): run_readiness_package=sample["run_readiness_package"], run_readiness_result=sample["run_readiness_result"], manual_fetch_receipt=sample["manual_fetch_receipt"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert receipt["mode"] == "mcp_fetch_run_receipt_review" - assert receipt["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert receipt["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert receipt["mcp_fetch_run_receipt_accepted"] is True assert receipt["run_receipt_ready"] is True assert receipt["operator_shell_fetch_receipt_received"] is True @@ -2978,13 +3009,13 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_receipt_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_receipt_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_run_receipt_accepted"] is True assert post_data["ready_for_manual_fetch_result_parser_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3000,11 +3031,11 @@ def test_mcp_fetch_run_receipt_route_get_and_post_are_preview_only(): def test_mcp_fetch_result_parser_review_preview_is_safe_without_payload(): parser = build_mcp_fetch_result_parser_review_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review_preview" - assert parser["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert parser["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert parser["parser_payload_received"] is False assert parser["mcp_fetch_result_parser_review_accepted"] is False assert parser["result_parser_review_ready"] is False @@ -3043,11 +3074,11 @@ def test_mcp_fetch_result_parser_review_accepts_sample_result(): run_receipt_package=sample["run_receipt_package"], run_receipt_result=sample["run_receipt_result"], parser_result=sample["parser_result"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert parser["mode"] == "mcp_fetch_result_parser_review" - assert parser["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert parser["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert parser["mcp_fetch_result_parser_review_accepted"] is True assert parser["result_parser_review_ready"] is True assert parser["ready_for_manual_fetch_candidate_handoff_review"] is True @@ -3132,13 +3163,13 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_result_parser_review_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_result_parser_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_result_parser_review_accepted"] is True assert post_data["ready_for_manual_fetch_candidate_handoff_review"] is True assert post_data["ready_for_api_database_write"] is False @@ -3154,11 +3185,11 @@ def test_mcp_fetch_result_parser_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_handoff_review_preview_is_safe_without_payload(): handoff = build_mcp_fetch_candidate_handoff_review_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert handoff["candidate_handoff_payload_received"] is False assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is False assert handoff["candidate_handoff_review_ready"] is False @@ -3197,11 +3228,11 @@ def test_mcp_fetch_candidate_handoff_review_accepts_sample_handoff(): parser_review_package=sample["parser_review_package"], parser_review_result=sample["parser_review_result"], candidate_handoff=sample["candidate_handoff"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert handoff["mode"] == "mcp_fetch_candidate_handoff_review" - assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert handoff["mcp_fetch_candidate_handoff_review_accepted"] is True assert handoff["candidate_handoff_review_ready"] is True assert handoff["ready_for_manual_candidate_queue_review"] is True @@ -3291,13 +3322,13 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_handoff_review_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_handoff_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_candidate_handoff_review_accepted"] is True assert post_data["ready_for_manual_candidate_queue_review"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is False @@ -3314,11 +3345,11 @@ def test_mcp_fetch_candidate_handoff_review_route_get_and_post_are_preview_only( def test_mcp_fetch_candidate_queue_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_review_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert review["candidate_queue_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_review_accepted"] is False assert review["candidate_queue_review_ready"] is False @@ -3355,11 +3386,11 @@ def test_mcp_fetch_candidate_queue_review_accepts_sample_review(): handoff_review_package=sample["handoff_review_package"], handoff_review_result=sample["handoff_review_result"], candidate_queue_review=sample["candidate_queue_review"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_review" - assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert review["mcp_fetch_candidate_queue_review_accepted"] is True assert review["candidate_queue_review_ready"] is True assert review["ready_for_candidate_queue_writer_preflight"] is True @@ -3450,13 +3481,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_candidate_queue_review_preview" - assert get_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert get_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_candidate_queue_review" - assert post_data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert post_data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert post_data["mcp_fetch_candidate_queue_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_preflight"] is True assert post_data["ready_for_api_database_write"] is False @@ -3472,13 +3503,13 @@ def test_mcp_fetch_candidate_queue_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_candidate_queue_writer_preflight_preview_is_safe_without_payload(): preflight = build_mcp_fetch_candidate_queue_writer_preflight_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( preflight["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert preflight["writer_preflight_payload_received"] is False assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is False @@ -3516,13 +3547,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_accepts_sample_preflight(): queue_review_package=sample["queue_review_package"], queue_review_result=sample["queue_review_result"], writer_preflight=sample["writer_preflight"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert preflight["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( preflight["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert preflight["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert preflight["candidate_queue_writer_preflight_ready"] is True @@ -3626,7 +3657,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight_preview" assert ( get_data["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False @@ -3635,7 +3666,7 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_preflight" assert ( post_data["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert post_data["mcp_fetch_candidate_queue_writer_preflight_accepted"] is True assert post_data["ready_for_candidate_queue_writer_cli_review"] is True @@ -3651,13 +3682,13 @@ def test_mcp_fetch_candidate_queue_writer_preflight_route_get_and_post_preview_o def test_mcp_fetch_candidate_queue_writer_cli_review_preview_is_safe_without_payload(): review = build_mcp_fetch_candidate_queue_writer_cli_review_preview( - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( review["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert review["writer_cli_review_payload_received"] is False assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is False @@ -3693,13 +3724,13 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_accepts_sample_review(): writer_preflight_package=sample["writer_preflight_package"], writer_preflight_result=sample["writer_preflight_result"], writer_cli_review=sample["writer_cli_review"], - phase="phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review", + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", ) assert review["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( review["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert review["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert review["candidate_queue_writer_cli_review_ready"] is True @@ -3800,7 +3831,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert get_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review_preview" assert ( get_data["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert get_data["api_executes_cli"] is False assert get_data["api_reads_approval_token"] is False @@ -3809,7 +3840,7 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["mode"] == "mcp_fetch_candidate_queue_writer_cli_review" assert ( post_data["phase"] - == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert post_data["mcp_fetch_candidate_queue_writer_cli_review_accepted"] is True assert post_data["ready_for_candidate_queue_writer_run_package_review"] is True @@ -3824,11 +3855,231 @@ def test_mcp_fetch_candidate_queue_writer_cli_review_route_get_and_post_preview_ assert post_data["api_opens_database_connection"] is False +def test_mcp_fetch_candidate_queue_writer_run_package_review_preview_is_safe_without_payload(): + review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + ) + + assert review["mode"] == ( + "mcp_fetch_candidate_queue_writer_run_package_review_preview" + ) + assert ( + review["phase"] + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + ) + assert review["writer_run_package_review_payload_received"] is False + assert ( + review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] + is False + ) + assert review["candidate_queue_writer_run_package_review_ready"] is False + assert review["ready_for_candidate_queue_writer_run_readiness_review"] is False + assert review["ready_for_api_database_write"] is False + assert review["ready_for_real_write"] is False + assert review["ready_for_scheduler_attach"] is False + assert review["network_request_allowed"] is False + assert review["api_executes_cli"] is False + assert review["api_reads_approval_token"] is False + assert review["api_writes_database"] is False + assert review["payload_persisted"] is False + assert review["run_package_review_persisted"] is False + assert review["run_package_persisted"] is False + assert review["package_artifact_created"] is False + assert review["file_written"] is False + assert review["database_write_executed"] is False + assert review["scheduler_attached"] is False + assert ( + "writer_cli_review_payload_or_result_received" + in review["blocked_reasons"] + ) + assert ( + "writer_run_package_review_payload_received" + in review["blocked_reasons"] + ) + assert ( + "writer_cli_review_package" + in review["sample_writer_run_package_review_package"] + ) + assert ( + "writer_run_package_review" + in review["sample_writer_run_package_review_package"] + ) + + +def test_mcp_fetch_candidate_queue_writer_run_package_review_accepts_sample_review(): + sample = ( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview() + ["sample_writer_run_package_review_package"] + ) + review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + writer_cli_review_package=sample["writer_cli_review_package"], + writer_cli_review_result=sample["writer_cli_review_result"], + writer_run_package_review=sample["writer_run_package_review"], + phase="phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review", + ) + + assert review["mode"] == "mcp_fetch_candidate_queue_writer_run_package_review" + assert ( + review["phase"] + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + ) + assert ( + review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] + is True + ) + assert review["candidate_queue_writer_run_package_review_ready"] is True + assert review["ready_for_candidate_queue_writer_run_readiness_review"] is True + assert review["ready_for_api_database_write"] is False + assert review["ready_for_real_write"] is False + assert review["blocked_reasons"] == [] + assert review["passed_gate_count"] == review["gate_count"] + assert review["writer_cli_review_accepted"] is True + summary = review["writer_run_package_review_summary"] + assert summary["package_mode"] == ( + "candidate_queue_writer_run_package_review_preview" + ) + assert summary["package_stage"] == "operator_review_only" + assert summary["target_table"] == "market_alert_review_queue" + assert summary["artifacts_operator_created"] is True + assert summary["command_bundle_api_safe"] is True + assert summary["operator_boundaries_confirmed"] is True + assert summary["candidate_keys_unique"] is True + assert summary["dedupe_keys_unique"] is True + assert summary["raw_payload_submitted_to_api"] is False + assert summary["secret_or_token_submitted_to_api"] is False + assert summary["blocked_side_effects"] == [] + assert review["network_request_allowed"] is False + assert review["api_executes_cli"] is False + assert review["api_reads_approval_token"] is False + assert review["api_writes_file"] is False + assert review["candidate_queue_persisted"] is False + assert review["database_write_executed"] is False + assert review["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_run_package_review_blocks_unsafe_review(): + sample = json.loads( + json.dumps( + build_mcp_fetch_candidate_queue_writer_run_package_review_preview() + ["sample_writer_run_package_review_package"] + ) + ) + run_package = sample["writer_run_package_review"] + run_package["target_table"] = "market_campaign_products" + run_package["approval_token"] = "do-not-submit" + run_package["raw_html"] = "raw" + run_package["api_writes_file"] = True + run_package["api_execution_allowed"] = True + run_package["real_write_allowed"] = True + run_package["operator_confirmations"]["no_api_cli_execution"] = False + run_package["required_artifacts"][0]["created_by_api"] = True + run_package["command_bundle"][0]["api_executes"] = True + run_package["expected_candidate_keys"].pop() + + review = build_mcp_fetch_candidate_queue_writer_run_package_review_preview( + writer_cli_review_package=sample["writer_cli_review_package"], + writer_cli_review_result=sample["writer_cli_review_result"], + writer_run_package_review=run_package, + ) + + assert ( + review["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] + is False + ) + assert review["writer_cli_review_accepted"] is True + assert "writer_run_package_target_table_safe" in review["blocked_reasons"] + assert ( + "writer_run_package_candidate_keys_match_cli_review" + in review["blocked_reasons"] + ) + assert ( + "writer_run_package_artifacts_operator_created" + in review["blocked_reasons"] + ) + assert ( + "writer_run_package_command_bundle_api_safe" + in review["blocked_reasons"] + ) + assert ( + "writer_run_package_operator_boundaries_confirmed" + in review["blocked_reasons"] + ) + assert ( + "writer_run_package_no_api_execution_or_real_write" + in review["blocked_reasons"] + ) + assert "writer_run_package_no_raw_payload" in review["blocked_reasons"] + assert "writer_run_package_no_secret_or_token_key" in review["blocked_reasons"] + assert "writer_run_package_side_effect_free" in review["blocked_reasons"] + assert review["api_executes_cli"] is False + assert review["api_reads_approval_token"] is False + assert review["api_writes_database"] is False + assert review["candidate_queue_persisted"] is False + assert review["scheduler_attached"] is False + + +def test_mcp_fetch_candidate_queue_writer_run_package_review_route_get_and_post_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review" + ) + get_data = get_response.get_json() + sample = get_data["sample_writer_run_package_review_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review", + json={"writer_run_package_review_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == ( + "mcp_fetch_candidate_queue_writer_run_package_review_preview" + ) + assert ( + get_data["phase"] + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + ) + assert get_data["api_executes_cli"] is False + assert get_data["api_reads_approval_token"] is False + assert get_data["api_writes_database"] is False + assert post_response.status_code == 200 + assert ( + post_data["mode"] + == "mcp_fetch_candidate_queue_writer_run_package_review" + ) + assert ( + post_data["phase"] + == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" + ) + assert ( + post_data["mcp_fetch_candidate_queue_writer_run_package_review_accepted"] + is True + ) + assert post_data["ready_for_candidate_queue_writer_run_readiness_review"] is True + assert post_data["ready_for_api_database_write"] is False + assert post_data["ready_for_real_write"] is False + assert post_data["network_request_allowed"] is False + assert post_data["api_executes_cli"] is False + assert post_data["api_reads_approval_token"] is False + assert post_data["cli_executed"] is False + assert post_data["candidate_queue_created"] is False + assert post_data["candidate_queue_persisted"] is False + assert post_data["api_opens_database_connection"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -3876,7 +4127,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -3887,7 +4138,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert acceptance["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -3929,7 +4180,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -3941,7 +4192,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -4052,7 +4303,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -4091,7 +4342,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -4153,7 +4404,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -4233,7 +4484,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert handoff["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -4297,7 +4548,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -4356,7 +4607,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert queue_draft["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -4430,7 +4681,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -4493,7 +4744,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert approval["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -4571,7 +4822,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -4634,7 +4885,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert transaction["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -4714,7 +4965,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -10425,7 +10676,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -10500,7 +10751,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -10772,7 +11023,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -11060,7 +11311,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -11370,7 +11621,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -11673,7 +11924,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -11932,7 +12183,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -12205,7 +12456,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -12453,7 +12704,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -12683,7 +12934,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -12920,7 +13171,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -13162,7 +13413,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -13438,7 +13689,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -13715,7 +13966,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -13994,7 +14245,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -14323,7 +14574,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -14585,7 +14836,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -14849,7 +15100,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -15119,7 +15370,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -15407,7 +15658,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -15694,7 +15945,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -15780,7 +16031,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15837,7 +16088,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15926,7 +16177,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15980,7 +16231,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -16036,7 +16287,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -16102,7 +16353,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -16404,7 +16655,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -16452,7 +16703,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -16501,7 +16752,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -16559,7 +16810,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -16625,7 +16876,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -16696,7 +16947,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -16772,7 +17023,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -16854,7 +17105,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -16940,7 +17191,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -17023,7 +17274,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -17106,7 +17357,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -17192,7 +17443,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -17283,7 +17534,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -17393,7 +17644,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17479,7 +17730,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -17536,7 +17787,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17589,7 +17840,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -17642,7 +17893,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17703,7 +17954,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17772,7 +18023,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -17844,7 +18095,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -17917,7 +18168,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -17988,7 +18239,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -18053,7 +18304,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -18124,7 +18375,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -18197,7 +18448,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -18274,7 +18525,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -18351,7 +18602,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -18428,7 +18679,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -18502,7 +18753,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -18581,7 +18832,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -18668,7 +18919,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -18749,7 +19000,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -18831,7 +19082,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -18914,7 +19165,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -18939,7 +19190,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -18977,7 +19228,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -18988,7 +19239,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -19024,7 +19275,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -19035,7 +19286,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -19076,7 +19327,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -19087,7 +19338,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -19135,7 +19386,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -19147,7 +19398,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -19193,7 +19444,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -19206,7 +19457,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert plan["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -19291,7 +19542,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -19369,7 +19620,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -19384,7 +19635,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert readiness["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -19795,6 +20046,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "mcp_fetch_candidate_queue_writer_run_package_review_preview_safe" + ] + is True + ) assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -20174,6 +20431,10 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/mcp_fetch_run_package" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_fetch_run_readiness" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_fetch_run_receipt" in readiness["production_smoke_targets"] + assert ( + "/api/market_intel/mcp_fetch_candidate_queue_writer_run_package_review" + in readiness["production_smoke_targets"] + ) assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -24215,7 +24476,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert drill["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -24330,7 +24591,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -24342,7 +24603,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert review["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -24457,7 +24718,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -24470,7 +24731,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert smoke["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -24532,7 +24793,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -24545,7 +24806,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert inventory["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -24689,7 +24950,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -24925,7 +25186,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -24954,7 +25215,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_129_market_intel_mcp_fetch_candidate_queue_writer_cli_review" + assert data["phase"] == "phase_130_market_intel_mcp_fetch_candidate_queue_writer_run_package_review" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False