From 934366bdd3d729c87be21351004ca62c77905948 Mon Sep 17 00:00:00 2001 From: OoO Date: Tue, 19 May 2026 13:59:51 +0800 Subject: [PATCH] =?UTF-8?q?=E6=96=B0=E5=A2=9E=E5=B8=82=E5=A0=B4=E6=83=85?= =?UTF-8?q?=E5=A0=B1=20review=20decision=20writer=20gate?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- TODO_NEXT_STEPS.txt | 1 + ...s-platform-market-campaign-intelligence.md | 1 + routes/README.md | 4 +- routes/market_intel_review_routes.py | 70 +++- .../market_intel_review_decision_writer.py | 90 +++++ ...didate_queue_review_decision_writer_cli.py | 381 ++++++++++++++++++ services/market_intel/deployment_readiness.py | 17 +- services/market_intel/service.py | 2 +- templates/market_intel/disabled.html | 121 ++++++ tests/test_market_intel_skeleton.py | 380 ++++++++++++++--- 10 files changed, 994 insertions(+), 73 deletions(-) create mode 100755 scripts/market_intel_review_decision_writer.py create mode 100644 services/market_intel/candidate_queue_review_decision_writer_cli.py diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index bf33b12..38c848a 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -140,6 +140,7 @@ - Phase 66 candidate queue review decision：新增 `services/market_intel/candidate_queue_review_decision.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision` 與 UI decision 按鈕，將通過 inventory 的 queue row 整理成人工決策草案；API/UI 不更新 review_state、不寫 decision record、不讀 token、不掛 scheduler；版本同步至 V10.254。 - Phase 67 candidate queue review decision approval：新增 `services/market_intel/candidate_queue_review_decision_approval.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval` 與 UI approval gate 按鈕，檢查人工決策草案是否可進入下一個 CLI-only transaction preview；API/UI 不更新 review_state、不寫 decision record、不建立 approval record、不讀 token、不掛 scheduler；版本同步至 V10.255。 - Phase 68 candidate queue review decision transaction：新增 `services/market_intel/candidate_queue_review_decision_transaction.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction` 與 UI transaction preview 按鈕，將 approval update preview 轉成 `review_state` update statement、payload hash 與 rollback plan；API/UI 不更新 review_state、不開 DB connection、不執行 CLI、不讀 token、不掛 scheduler；版本同步至 V10.256。 + - Phase 69 candidate queue review decision writer CLI gate：新增 `services/market_intel/candidate_queue_review_decision_writer_cli.py`、`scripts/market_intel_review_decision_writer.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status` 與 UI writer gate 按鈕，先建立 shell-only review_state writer gate 與 command bundle；writer implementation 本階段保持 disabled，API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state、不掛 scheduler；版本同步至 V10.257。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 24cea5f..fde44bb 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -194,6 +194,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review decision：`services.market_intel.candidate_queue_review_decision` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision` 將通過 inventory 的 queue row 整理成人工決策草案，限制 next state 為 `confirmed` / `rejected` / `deferred`。此階段不更新 `review_state`、不寫 decision record、不讀 approval token、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision approval：`services.market_intel.candidate_queue_review_decision_approval` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval` 檢查人工決策草案是否可進入下一個 CLI-only transaction preview。此階段不更新 `review_state`、不寫 decision record、不建立 approval record、不讀 approval token、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision transaction：`services.market_intel.candidate_queue_review_decision_transaction` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction` 將已批准的人工決策整理成 `review_state` update statement preview、payload hash、runtime order 與 rollback plan。此階段不連 DB、不開 transaction、不 commit、不更新 `review_state`、不讀 approval token、不執行 CLI、不掛 scheduler；真正更新只允許後續人工 shell/CLI 寫入窗口。 +- 2026-05-19 追加 candidate queue review decision writer CLI gate：`services.market_intel.candidate_queue_review_decision_writer_cli`、`scripts/market_intel_review_decision_writer.py` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status` 先建立 review_state writer 的 shell-only gate、一次性 token env var、command bundle 與 rollback plan。此階段 writer implementation 保持 disabled；API/UI 不讀 approval token、不執行 CLI、不連 DB、不開 transaction、不 commit、不更新 `review_state`、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index bd39d99..0185552 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,8 +19,8 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 68 candidate queue review decision transaction 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | -| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction` | +| `market_intel_routes.py` | 市場情報 Phase 69 candidate queue review decision writer CLI gate 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py index dec61ca..725de40 100644 --- a/routes/market_intel_review_routes.py +++ b/routes/market_intel_review_routes.py @@ -21,6 +21,9 @@ from services.market_intel.candidate_queue_review_decision_approval import ( from services.market_intel.candidate_queue_review_decision_transaction import ( build_candidate_queue_review_decision_transaction, ) +from services.market_intel.candidate_queue_review_decision_writer_cli import ( + build_candidate_queue_review_decision_writer_cli_plan, +) from services.market_intel.candidate_queue_writer_cli import ( build_candidate_queue_writer_cli_plan, ) @@ -202,6 +205,33 @@ def _build_review_decision_approval_stack( ) +def _build_review_decision_transaction_stack( + *, + service, + sample_result, + payload_error, + operator_evidence, + writer_output, + postwrite_smoke_result, + limit, + execute_requested, +): + approval = _build_review_decision_approval_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=postwrite_smoke_result, + limit=limit, + execute_requested=execute_requested, + ) + return build_candidate_queue_review_decision_transaction( + decision_approval=approval, + operator_evidence=operator_evidence, + ) + + @market_intel_review_bp.route( "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", methods=["POST"], @@ -303,7 +333,7 @@ def market_intel_manual_sample_candidate_queue_review_decision_transaction(): sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( _extract_run_payload() ) - approval = _build_review_decision_approval_stack( + data = _build_review_decision_transaction_stack( service=service, sample_result=sample_result, payload_error=payload_error, @@ -313,9 +343,43 @@ def market_intel_manual_sample_candidate_queue_review_decision_transaction(): limit=limit, execute_requested=execute_requested, ) - data = build_candidate_queue_review_decision_transaction( - decision_approval=approval, + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_status", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_decision_writer_status(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + apply_real_write = ( + request.args.get("apply_real_write", "false").lower() == "true" + ) + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction = _build_review_decision_transaction_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + limit=limit, + execute_requested=False, + ) + data = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + execute_requested=execute_requested, + apply_real_write=apply_real_write, + approval_token=None, + approval_token_secret=None, + backup_verified=False, + review_inventory_smoke_passed=False, ) data["phase"] = service.phase return jsonify(data), 400 if payload_error else 200 diff --git a/scripts/market_intel_review_decision_writer.py b/scripts/market_intel_review_decision_writer.py new file mode 100755 index 0000000..cb1d346 --- /dev/null +++ b/scripts/market_intel_review_decision_writer.py @@ -0,0 +1,90 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +"""Market intelligence review decision writer CLI gate. + +This script only prints JSON gate status. The review_state update implementation +is intentionally disabled in this phase. +""" + +import argparse +import contextlib +import json +import os +import sys +from pathlib import Path + + +REPO_ROOT = Path(__file__).resolve().parents[1] +if str(REPO_ROOT) not in sys.path: + sys.path.insert(0, str(REPO_ROOT)) + +with contextlib.redirect_stdout(sys.stderr): + from services.market_intel import MarketIntelService # noqa: E402 + from services.market_intel.candidate_queue_review_decision_writer_cli import ( # noqa: E402 + APPROVAL_ENV_VAR, + build_candidate_queue_review_decision_writer_cli_plan, + ) + + +def parse_args(argv=None): + parser = argparse.ArgumentParser( + description="Preview review decision writer execution gates." + ) + parser.add_argument( + "--transaction-json", + default=None, + help="Path to a review decision transaction preview JSON file.", + ) + parser.add_argument("--execute", action="store_true", help="Request execution.") + parser.add_argument( + "--apply-real-write", + action="store_true", + help="Request the guarded review_state update transaction.", + ) + parser.add_argument( + "--approval-token", + default=None, + help=f"One-time approval token checked against {APPROVAL_ENV_VAR}.", + ) + parser.add_argument( + "--backup-verified", + action="store_true", + help="Confirm a fresh operator backup before allowing a future write.", + ) + parser.add_argument( + "--review-inventory-smoke-passed", + action="store_true", + help="Confirm read-only review inventory smoke passed.", + ) + return parser.parse_args(argv) + + +def _load_transaction_preview(path): + if not path: + return {} + with open(path, encoding="utf-8") as handle: + payload = json.load(handle) + if not isinstance(payload, dict): + return {} + return payload.get("candidate_queue_review_decision_transaction", payload) + + +def main(argv=None): + args = parse_args(argv) + service = MarketIntelService() + plan = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=_load_transaction_preview(args.transaction_json), + execute_requested=args.execute, + apply_real_write=args.apply_real_write, + approval_token=args.approval_token, + approval_token_secret=os.getenv(APPROVAL_ENV_VAR), + backup_verified=args.backup_verified, + review_inventory_smoke_passed=args.review_inventory_smoke_passed, + ) + plan["phase"] = service.phase + print(json.dumps(plan, ensure_ascii=False, indent=2, sort_keys=True)) + return int(plan.get("exit_code", 2)) + + +if __name__ == "__main__": + raise SystemExit(main()) diff --git a/services/market_intel/candidate_queue_review_decision_writer_cli.py b/services/market_intel/candidate_queue_review_decision_writer_cli.py new file mode 100644 index 0000000..ad6c3b1 --- /dev/null +++ b/services/market_intel/candidate_queue_review_decision_writer_cli.py @@ -0,0 +1,381 @@ +"""候選審核 queue review_state writer CLI gate。 + +本模組只建立正式 shell/CLI 更新 review_state 前的 gate 狀態； +不讀環境 token、不執行 CLI、不連 DB、不更新 review_state。 +""" + +import hmac + + +APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +MIN_APPROVAL_TOKEN_LENGTH = 16 +TARGET_TABLE = "market_alert_review_queue" +ALLOWED_DECISIONS = ("confirmed", "rejected", "deferred") +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _approval_token_valid(approval_token, approval_token_secret): + if not approval_token or not approval_token_secret: + return False + if len(str(approval_token_secret)) < MIN_APPROVAL_TOKEN_LENGTH: + return False + return hmac.compare_digest(str(approval_token), str(approval_token_secret)) + + +def _statement_payloads(transaction_preview): + payloads = [] + invalid = [] + for statement in _as_list(_as_dict(transaction_preview).get("statements")): + statement = _as_dict(statement) + payload = _as_dict(statement.get("parameter_preview")) + current_state = ( + payload.get("expected_current_review_state") + or statement.get("expected_current_review_state") + ) + next_state = payload.get("next_review_state") or statement.get( + "next_review_state" + ) + dedupe_key = payload.get("dedupe_key") or _as_dict(statement.get("lookup")).get( + "dedupe_key" + ) + normalized = { + "idempotency_key": statement.get("idempotency_key"), + "dedupe_key": dedupe_key, + "expected_current_review_state": current_state, + "next_review_state": next_state, + "statement_type": statement.get("statement_type"), + "operation": statement.get("operation"), + "parameter_payload_hash": statement.get("parameter_payload_hash"), + } + missing_fields = [ + key + for key in ( + "dedupe_key", + "expected_current_review_state", + "next_review_state", + ) + if not normalized.get(key) + ] + transition_invalid = bool( + current_state != "needs_review" or next_state not in ALLOWED_DECISIONS + ) + operation_invalid = bool( + normalized["operation"] != "update" + or normalized["statement_type"] != "update_review_state" + ) + if missing_fields or transition_invalid or operation_invalid: + invalid.append( + { + "idempotency_key": normalized["idempotency_key"], + "missing_fields": missing_fields, + "transition_invalid": transition_invalid, + "operation_invalid": operation_invalid, + } + ) + payloads.append(normalized) + return payloads, invalid + + +def _operator_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "operator_confirmed_manual_shell_window": bool( + operator_evidence.get("operator_confirmed_manual_shell_window") + ), + "operator_confirmed_post_update_inventory_planned": bool( + operator_evidence.get("operator_confirmed_post_update_inventory_planned") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def build_candidate_queue_review_decision_writer_cli_plan( + *, + transaction_preview, + operator_evidence=None, + execute_requested=False, + apply_real_write=False, + approval_token=None, + approval_token_secret=None, + backup_verified=False, + review_inventory_smoke_passed=False, +): + """建立 review_state writer CLI gate；本階段仍不執行 update。""" + transaction_preview = _as_dict(transaction_preview) + operator_summary = _operator_summary(operator_evidence) + statement_payloads, invalid_payloads = _statement_payloads(transaction_preview) + approval_token_present = bool(approval_token) + approval_token_secret_configured = bool(approval_token_secret) + approval_token_valid = _approval_token_valid(approval_token, approval_token_secret) + post_update_inventory_planned = bool( + review_inventory_smoke_passed + or operator_summary["operator_confirmed_post_update_inventory_planned"] + ) + transaction_ready = bool( + transaction_preview.get("mode") + == "candidate_queue_review_decision_transaction_preview" + and transaction_preview.get("transaction_ready") + ) + writer_implementation_enabled = False + payloads_valid = bool(statement_payloads and not invalid_payloads) + gates = [ + { + "key": "transaction_preview_ready", + "label": "review_state transaction preview 必須通過", + "passed": transaction_ready, + }, + { + "key": "transaction_has_update_statements", + "label": "transaction preview 至少包含一筆 update_review_state statement", + "passed": bool(statement_payloads), + }, + { + "key": "transaction_statement_payloads_valid", + "label": "statement payload 必須包含 dedupe_key、目前狀態與下一狀態", + "passed": payloads_valid, + }, + { + "key": "execute_requested", + "label": "--execute flag 必須由 shell/CLI 明確提供", + "passed": bool(execute_requested), + }, + { + "key": "apply_real_write_requested", + "label": "--apply-real-write flag 必須由 shell/CLI 明確提供", + "passed": bool(apply_real_write), + }, + { + "key": "approval_token_present", + "label": f"{APPROVAL_ENV_VAR} approval token 必須只由 shell 提供", + "passed": approval_token_present, + }, + { + "key": "approval_token_secret_configured", + "label": f"{APPROVAL_ENV_VAR} 環境 token 必須只由 shell 載入", + "passed": approval_token_secret_configured, + }, + { + "key": "approval_token_valid", + "label": "approval token 必須符合 shell 環境 token", + "passed": approval_token_valid, + }, + { + "key": "backup_verified", + "label": "正式更新前必須確認最新備份已完成", + "passed": bool(backup_verified), + }, + { + "key": "manual_shell_window_acknowledged", + "label": "操作員確認只能在人工 shell 寫入窗口執行", + "passed": bool( + operator_summary["operator_confirmed_manual_shell_window"] + ), + }, + { + "key": "post_update_inventory_planned", + "label": "操作員確認正式更新後會跑只讀 inventory / smoke", + "passed": post_update_inventory_planned, + }, + { + "key": "operator_confirmed_no_api_db_write_or_scheduler", + "label": "操作員確認本 API 不寫 DB、不掛 scheduler", + "passed": bool( + operator_summary["operator_confirmed_no_api_db_write"] + and operator_summary["operator_confirmed_no_scheduler_attach"] + ), + }, + { + "key": "writer_no_token_submitted_to_api", + "label": "operator_evidence 不得包含一次性 approval token key", + "passed": not operator_summary["approval_token_submitted_to_api"], + }, + { + "key": "review_decision_writer_implementation_enabled", + "label": "review_state writer 實作尚未啟用，本階段只提供 status gate", + "passed": writer_implementation_enabled, + }, + { + "key": "crawler_stays_disabled", + "label": "review_state writer 不掛 crawler 或 scheduler", + "passed": True, + }, + ] + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + + return { + "mode": "candidate_queue_review_decision_writer_cli_blocked", + "target_table": TARGET_TABLE, + "target_operation": "update_review_state", + "execute_requested": bool(execute_requested), + "apply_real_write_requested": bool(apply_real_write), + "backup_verified": bool(backup_verified), + "approval_token_present": approval_token_present, + "approval_token_valid": approval_token_valid, + "approval_env_var": APPROVAL_ENV_VAR, + "approval_token_secret_configured": approval_token_secret_configured, + "writer_implementation_enabled": writer_implementation_enabled, + "ready_for_shell_command_authoring": bool( + transaction_ready + and payloads_valid + and operator_summary["operator_confirmed_manual_shell_window"] + and post_update_inventory_planned + and not operator_summary["approval_token_submitted_to_api"] + ), + "ready_for_real_write": False, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "review_state_update_allowed_from_api": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "approval_record_written": False, + "decision_record_written": False, + "review_state_update_executed": False, + "database_connection_opened": False, + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "exit_code": 2 if execute_requested else 0, + "blocked_reasons": blocked_reasons, + "approval_gates": gates, + "operator_writer_summary": operator_summary, + "writer_payload_summary": { + "statement_count": len(statement_payloads), + "invalid_statement_count": len(invalid_payloads), + "invalid_statements": invalid_payloads, + "allowed_next_states": list(ALLOWED_DECISIONS), + }, + "statement_summary": { + "statement_count": len(statement_payloads), + "invalid_statement_count": len(invalid_payloads), + "allowed_next_states": list(ALLOWED_DECISIONS), + "review_state_updates": [ + { + **payload, + "write_status": "blocked_writer_status_only", + } + for payload in statement_payloads + ], + }, + "script_path": "scripts/market_intel_review_decision_writer.py", + "command_bundle": { + "dry_run_command": ( + "python scripts/market_intel_review_decision_writer.py " + "--transaction-json " + ), + "apply_command_shape": ( + "MARKET_INTEL_QUEUE_WRITE_APPROVAL= " + "python scripts/market_intel_review_decision_writer.py --execute " + "--apply-real-write --transaction-json " + ), + "api_must_not_execute_command": True, + }, + "transaction_preview_summary": { + "mode": transaction_preview.get("mode"), + "transaction_preview_created": bool( + transaction_preview.get("transaction_preview_created") + ), + "transaction_ready": bool(transaction_preview.get("transaction_ready")), + "statement_count": len( + _as_list(transaction_preview.get("statements")) + ), + "api_write_allowed": False, + }, + "transaction_preview": { + "mode": transaction_preview.get("mode"), + "target_table": transaction_preview.get("target_table"), + "transaction_ready": bool(transaction_preview.get("transaction_ready")), + "transaction_preview_created": bool( + transaction_preview.get("transaction_preview_created") + ), + }, + "statement_payloads": statement_payloads, + "rollback_plan": [ + { + "key": "no_write_no_db_rollback_required", + "label": "本階段未寫 DB，不需要 DB rollback", + }, + { + "key": "manual_review_state_reversal", + "label": "正式更新後若需回退，必須依 dedupe_key 與審核證據人工稽核", + }, + ], + "safety_contract": { + "refuses_api_execution": True, + "refuses_execute_until_writer_enabled": True, + "requires_independent_approval_token": True, + "requires_backup_verified": True, + "requires_post_update_inventory": True, + "target_table": TARGET_TABLE, + }, + "safe_boundaries": [ + "do_not_execute_review_state_writer_from_api", + "do_not_execute_review_decision_writer_from_api", + "do_not_read_approval_token_from_review_state_writer_api", + "do_not_open_database_connection_from_review_state_writer_status", + "do_not_commit_review_state_writer_status", + "do_not_update_review_state_from_api_writer_status", + "do_not_update_review_state_from_review_state_writer_status", + "do_not_attach_scheduler_from_review_state_writer", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index b151fd7..0c5aaf1 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -16,10 +16,11 @@ from services.market_intel.candidate_queue_review_inventory import build_candida from services.market_intel.candidate_queue_review_decision import build_candidate_queue_review_decision from services.market_intel.candidate_queue_review_decision_approval import build_candidate_queue_review_decision_approval from services.market_intel.candidate_queue_review_decision_transaction import build_candidate_queue_review_decision_transaction +from services.market_intel.candidate_queue_review_decision_writer_cli import build_candidate_queue_review_decision_writer_cli_plan BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database") -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -112,12 +113,9 @@ def build_deployment_readiness_preview( candidate_queue_review_decision = build_candidate_queue_review_decision( review_inventory=candidate_queue_review_inventory, ) - candidate_queue_review_decision_approval = build_candidate_queue_review_decision_approval( - review_decision=candidate_queue_review_decision, - ) - candidate_queue_review_decision_transaction = build_candidate_queue_review_decision_transaction( - decision_approval=candidate_queue_review_decision_approval, - ) + candidate_queue_review_decision_approval = build_candidate_queue_review_decision_approval(review_decision=candidate_queue_review_decision) + candidate_queue_review_decision_transaction = build_candidate_queue_review_decision_transaction(decision_approval=candidate_queue_review_decision_approval) + candidate_queue_review_decision_writer_status = build_candidate_queue_review_decision_writer_cli_plan(transaction_preview=candidate_queue_review_decision_transaction) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -356,6 +354,10 @@ def build_deployment_readiness_preview( candidate_queue_review_decision_transaction, "candidate_queue_review_decision_transaction_preview", ), + "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( + candidate_queue_review_decision_writer_status, + "candidate_queue_review_decision_writer_cli_blocked", + ), "match_review_plan_preview_safe": bool( match_review_plan["mode"] == "match_review_plan_preview" and not match_review_plan["review_queue_created"] @@ -588,6 +590,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_decision": candidate_queue_review_decision, "candidate_queue_review_decision_approval": candidate_queue_review_decision_approval, "candidate_queue_review_decision_transaction": candidate_queue_review_decision_transaction, + "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, "opportunity_scoring_plan": opportunity_scoring_plan, diff --git a/services/market_intel/service.py b/services/market_intel/service.py index f6ef856..0a1f4e2 100644 --- a/services/market_intel/service.py +++ b/services/market_intel/service.py @@ -108,7 +108,7 @@ class MarketIntelRuntimeStatus: class MarketIntelService: """市場情報入口服務，先集中 feature gate 與安全狀態。""" - phase = "phase_68_candidate_queue_review_decision_transaction" + phase = "phase_69_candidate_queue_review_decision_writer_cli" def get_runtime_status(self) -> MarketIntelRuntimeStatus: return MarketIntelRuntimeStatus( diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index db1b2d7..26d75c7 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -643,6 +643,9 @@ + @@ -985,6 +988,7 @@ const sampleCandidateQueueReviewDecision = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision]') : null; const sampleCandidateQueueReviewDecisionApproval = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-approval]') : null; const sampleCandidateQueueReviewDecisionTransaction = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-transaction]') : null; + const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1004,6 +1008,7 @@ const sampleCandidateQueueReviewDecisionEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision') }}"; const sampleCandidateQueueReviewDecisionApprovalEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_approval') }}"; const sampleCandidateQueueReviewDecisionTransactionEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_transaction') }}"; + const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -3599,6 +3604,119 @@ } }; + const renderCandidateQueueReviewDecisionWriter = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const summary = data.statement_summary || {}; + const command = data.command_bundle || {}; + const gates = data.approval_gates || []; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `ready=${data.ready_for_real_write ? 'yes' : 'no'}`, + `statements=${summary.statement_count || 0}`, + `api_update=${data.api_updates_review_state ? 'yes' : 'no'}`, + `impl=${data.writer_implementation_enabled ? 'enabled' : 'blocked'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只檢查 queue review decision writer CLI gate；API/UI 不讀 token、不執行 CLI、不連 DB、不更新 review_state。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
+
+

WRITER GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 writer gates。
' + }
+
+
+

COMMAND SHAPE

+
+ ${[ + ['script_path', data.script_path || 'unknown'], + ['env_var', data.approval_env_var || 'unknown'], + ['dry_run', command.dry_run_command || 'not_ready'], + ['api_must_not_execute', command.api_must_not_execute_command] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

WRITE FLAGS

+
+ ${[ + ['execute_requested', data.execute_requested], + ['apply_real_write', data.apply_real_write_requested], + ['token_present', data.approval_token_present], + ['token_valid', data.approval_token_valid], + ['db_write', data.database_write_executed], + ['commit', data.database_commit_executed], + ['scheduler', data.scheduler_attached] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

STATEMENTS

+
${ + (summary.review_state_updates || []).map(row => ` +
+
+ ${escapeHtml(row.dedupe_key || row.idempotency_key || 'unknown')} + ${escapeHtml(row.expected_current_review_state || 'unknown')} -> ${escapeHtml(row.next_review_state || 'none')} +
+ ${escapeHtml(row.write_status || 'blocked')} +
+ `).join('') || '
尚未提供 review_state update statements。
' + }
+
+
+ `; + }; + + const loadCandidateQueueReviewDecisionWriter = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue review decision writer CLI gate 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewDecisionWriterEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewDecisionWriter(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review decision writer CLI gate 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderSchedulerMeta = data => { schedulerMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -5144,6 +5262,9 @@ if (sampleCandidateQueueReviewDecisionTransaction) { sampleCandidateQueueReviewDecisionTransaction.addEventListener('click', loadCandidateQueueReviewDecisionTransaction); } + if (sampleCandidateQueueReviewDecisionWriter) { + sampleCandidateQueueReviewDecisionWriter.addEventListener('click', loadCandidateQueueReviewDecisionWriter); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 2823924..6137b18 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -188,6 +188,69 @@ def _build_candidate_queue_writer_receipt_fixture(batch_id="sample-batch-receipt } +def _build_ready_review_decision_transaction( + batch_id="sample-batch-review-decision-writer" +): + from services.market_intel.candidate_queue_review_decision import ( + build_candidate_queue_review_decision, + ) + from services.market_intel.candidate_queue_review_decision_approval import ( + build_candidate_queue_review_decision_approval, + ) + from services.market_intel.candidate_queue_review_decision_transaction import ( + build_candidate_queue_review_decision_transaction, + ) + + fixture = _build_candidate_queue_writer_receipt_fixture(batch_id) + inventory = { + "mode": "candidate_queue_review_inventory_preview", + "review_inventory_ready": True, + "expected_dedupe_keys": fixture["expected_keys"], + "row_summaries": [ + { + "dedupe_key": fixture["expected_keys"][0], + "review_state": "needs_review", + "priority_lane": "watch", + "total_score": 82.5, + } + ], + } + decision_evidence = { + "reviewer_id": "operator-a", + "proposed_review_decision": "confirmed", + "decision_notes": "evidence reviewed manually", + "operator_confirmed_manual_decision_only": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_no_scheduler_attach": True, + } + approval_evidence = { + **decision_evidence, + "decision_approval_notes": "approved for cli-only transaction preview", + "operator_confirmed_decision_payload_reviewed": True, + "operator_confirmed_decision_apply_requires_cli": True, + "operator_confirmed_review_state_update_is_not_api": True, + } + transaction_evidence = { + **approval_evidence, + "decision_transaction_notes": "payload reviewed for shell transaction", + "operator_confirmed_transaction_payload_reviewed": True, + "operator_confirmed_cli_only_transaction": True, + } + decision = build_candidate_queue_review_decision( + review_inventory=inventory, + operator_evidence=decision_evidence, + ) + approval = build_candidate_queue_review_decision_approval( + review_decision=decision, + operator_evidence=approval_evidence, + ) + transaction = build_candidate_queue_review_decision_transaction( + decision_approval=approval, + operator_evidence=transaction_evidence, + ) + return transaction, transaction_evidence + + def test_market_intel_defaults_are_safe(): service = MarketIntelService() status = service.get_runtime_status().to_dict() @@ -769,6 +832,14 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-decision-transaction" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status" + in template + ) + assert ( + "data-market-intel-sample-candidate-queue-review-decision-writer" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -805,7 +876,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert bridge["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -963,7 +1034,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert contract["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1096,7 +1167,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1109,7 +1180,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert gate["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1179,7 +1250,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1191,7 +1262,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1239,7 +1310,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1250,7 +1321,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert acceptance["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1292,7 +1363,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1304,7 +1375,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert review["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1415,7 +1486,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1454,7 +1525,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert review["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1516,7 +1587,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1596,7 +1667,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert handoff["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1660,7 +1731,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1719,7 +1790,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert queue_draft["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -1793,7 +1864,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -1856,7 +1927,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert approval["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -1934,7 +2005,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -1997,7 +2068,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert transaction["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2077,7 +2148,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -3737,6 +3808,65 @@ def test_candidate_queue_review_decision_transaction_preview_is_shell_only(): ) +def test_candidate_queue_review_decision_writer_cli_gate_is_non_writing(): + from services.market_intel.candidate_queue_review_decision_writer_cli import ( + APPROVAL_ENV_VAR, + build_candidate_queue_review_decision_writer_cli_plan, + ) + + transaction, _ = _build_ready_review_decision_transaction() + plan = build_candidate_queue_review_decision_writer_cli_plan( + transaction_preview=transaction, + execute_requested=True, + apply_real_write=True, + approval_token=TEST_APPROVAL_TOKEN, + approval_token_secret=TEST_APPROVAL_TOKEN, + backup_verified=True, + review_inventory_smoke_passed=True, + ) + payload = json.dumps(plan, ensure_ascii=False, sort_keys=True) + + assert plan["mode"] == "candidate_queue_review_decision_writer_cli_blocked" + assert plan["target_table"] == "market_alert_review_queue" + assert plan["target_operation"] == "update_review_state" + assert plan["script_path"] == "scripts/market_intel_review_decision_writer.py" + assert plan["approval_env_var"] == APPROVAL_ENV_VAR + assert plan["execute_requested"] is True + assert plan["apply_real_write_requested"] is True + assert plan["approval_token_present"] is True + assert plan["approval_token_valid"] is True + assert plan["writer_implementation_enabled"] is False + assert plan["ready_for_real_write"] is False + assert plan["ready_for_api_review_state_update"] is False + assert plan["ready_for_api_database_write"] is False + assert plan["api_executes_cli"] is False + assert plan["api_reads_approval_token"] is False + assert plan["api_writes_database"] is False + assert plan["api_updates_review_state"] is False + assert plan["review_state_update_executed"] is False + assert plan["database_connection_opened"] is False + assert plan["database_session_created"] is False + assert plan["explicit_transaction_opened"] is False + assert plan["transaction_opened"] is False + assert plan["transaction_committed"] is False + assert plan["database_write_executed"] is False + assert plan["database_commit_executed"] is False + assert plan["scheduler_attached"] is False + assert plan["writes_executed"] is False + assert plan["would_write_database"] is False + assert plan["statement_summary"]["statement_count"] == 1 + assert plan["statement_summary"]["review_state_updates"][0][ + "next_review_state" + ] == "confirmed" + assert "review_decision_writer_implementation_enabled" in plan[ + "blocked_reasons" + ] + assert "do_not_update_review_state_from_api_writer_status" in plan[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -3779,7 +3909,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -3836,7 +3966,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -3925,7 +4055,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -3979,7 +4109,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -4035,7 +4165,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -4101,7 +4231,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -4403,7 +4533,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -4451,7 +4581,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -4500,7 +4630,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -4558,7 +4688,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -4624,7 +4754,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -4695,7 +4825,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -4771,7 +4901,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -4800,6 +4930,90 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w ] +def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + fixture = _build_candidate_queue_writer_receipt_fixture( + "sample-batch-review-decision-writer-route" + ) + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_status" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_writer_status?execute=true" + "&apply_real_write=true", + json={ + "sample_result": fixture["sample_result"], + "operator_evidence": { + **fixture["operator_evidence"], + "closeout_artifact_path": "artifacts/market_intel/closeout.json", + "operator_confirmed_queue_review_next": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "operator_confirmed_inventory_read_only": True, + "reviewer_id": "operator-a", + "proposed_review_decision": "confirmed", + "decision_notes": "manual review only", + "operator_confirmed_manual_decision_only": True, + "decision_approval_notes": "cli-only approval gate", + "operator_confirmed_decision_payload_reviewed": True, + "operator_confirmed_decision_apply_requires_cli": True, + "operator_confirmed_review_state_update_is_not_api": True, + "decision_transaction_notes": "shell-only transaction preview", + "operator_confirmed_transaction_payload_reviewed": True, + "operator_confirmed_cli_only_transaction": True, + }, + "writer_output": fixture["writer_output"], + "postwrite_smoke_result": fixture["postwrite_smoke_result"], + }, + ) + data = response.get_json() + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" + assert data["execute_requested"] is True + assert data["apply_real_write_requested"] is True + assert data["approval_token_present"] is False + assert data["approval_token_valid"] is False + assert data["writer_implementation_enabled"] is False + assert data["ready_for_real_write"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["review_state_update_executed"] is False + assert data["database_connection_opened"] is False + assert data["database_session_created"] is False + assert data["transaction_opened"] is False + assert data["transaction_committed"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["scheduler_attached"] is False + assert data["writes_executed"] is False + assert data["would_write_database"] is False + assert "approval_token_present" in data["blocked_reasons"] + assert "review_decision_writer_implementation_enabled" in data[ + "blocked_reasons" + ] + assert "do_not_execute_review_decision_writer_from_api" in data[ + "safe_boundaries" + ] + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -4828,7 +5042,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -4853,7 +5067,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -4891,7 +5105,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -4902,7 +5116,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -4938,7 +5152,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -4949,7 +5163,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -4990,7 +5204,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -5001,7 +5215,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -5049,7 +5263,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -5061,7 +5275,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -5107,7 +5321,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -5120,7 +5334,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -5205,7 +5419,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -5283,7 +5497,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -5298,7 +5512,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert readiness["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -5746,7 +5960,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): ) assert ( readiness["checks"][ - "candidate_queue_review_decision_transaction_preview_safe" + "candidate_queue_review_decision_writer_cli_status_safe" ] is True ) @@ -5840,7 +6054,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): ) assert ( "/api/market_intel/manual_sample_review/" - "candidate_queue_review_decision_transaction" + "candidate_queue_review_decision_writer_status" in readiness["production_smoke_targets"] ) assert readiness["write_approval_runbook"]["ready_for_real_write"] is False @@ -6623,6 +6837,52 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_decision_writer_status"]["mode"] + == "candidate_queue_review_decision_writer_cli_blocked" + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "ready_for_real_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "writer_implementation_enabled" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "api_updates_review_state" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "review_state_update_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "database_commit_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_writer_status"][ + "scheduler_attached" + ] + is False + ) assert readiness["scheduler_plan"]["scheduler_registration_executed"] is False assert readiness["scheduler_plan"]["crawler_job_started"] is False assert readiness["scheduler_plan"]["database_write_executed"] is False @@ -6727,7 +6987,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert drill["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -6842,7 +7102,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -6854,7 +7114,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert review["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -6969,7 +7229,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -6982,7 +7242,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert smoke["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -7044,7 +7304,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -7057,7 +7317,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert inventory["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -7201,7 +7461,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -7428,7 +7688,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_68_candidate_queue_review_decision_transaction" + assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False