diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index fd4b49f..b9d9cc1 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -151,6 +151,7 @@ - Phase 74 candidate queue review decision writer run readiness：新增 `services/market_intel/candidate_queue_review_decision_writer_run_readiness.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 與 UI readiness 按鈕，檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備；API/UI 不寫檔、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.264。 - Phase 75 candidate queue review decision writer run receipt：新增 `services/market_intel/candidate_queue_review_decision_writer_run_receipt.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 與 UI receipt 按鈕，審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.266。 - Phase 76 candidate queue review decision writer run closeout：新增 `services/market_intel/candidate_queue_review_decision_writer_run_closeout.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 與 UI closeout 按鈕，在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要；API/UI 不回吐 receipt 原文、不讀 token、不執行 CLI、不連 DB、不更新 review_state、不 commit、不掛 scheduler；版本同步至 V10.268。 + - Phase 77 candidate queue review decision post-closeout inventory：新增 `services/market_intel/candidate_queue_review_decision_post_closeout_inventory.py`、`routes/market_intel_review_post_routes.py`、POST `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory` 與 UI inventory 按鈕，在 review_state closeout 後整理 post-write smoke、live inventory、dedupe key 與 review_state 結果；API/UI 不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不 commit、不掛 scheduler；版本同步至 V10.270。 - V10.248 補市場情報 390px preview panel QA：sample review 工具列改為 textarea + 可換行 action rail，移除舊的硬編 8 欄 grid；`check_responsive_overflow` 新增 `--screenshot-all`，本機 390x844 `/market_intel` 真頁面 QA 通過且 overflow=0。 - V10.250 補 Code Review Gemini 備援遙測護欄：Ollama 主路徑失敗時 `fallback_to` 明確指向 `code_review_openclaw_gemini`，測試鎖住「Gemini 不得記成 `code_review_openclaw` 主 caller」；AI Calls 觀測台會把 legacy `code_review_openclaw + gemini` 顯示成 Gemini 備援，避免誤判 Gemini-first。 - Schema smoke：`tests/test_market_intel_skeleton.py` 檢查 `Base.metadata` 內含 ADR-035 八張 `market_*` tables。 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index c73a006..6e7ffc7 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -202,6 +202,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-19 追加 candidate queue review decision writer run readiness：`services.market_intel.candidate_queue_review_decision_writer_run_readiness` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness` 檢查 review_state CLI 更新前的 transaction JSON、備份、preflight、shell-only token 與 post-write smoke 計畫是否齊備。此 readiness 只輸出操作員 gate 預覽；API/UI 不寫檔、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run receipt：`services.market_intel.candidate_queue_review_decision_writer_run_receipt` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt` 審核 review_state CLI 更新後的 writer output、post-write smoke、dedupe key 一致性、artifact 路徑與 token 外洩風險。此 receipt 只輸出安全摘要；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 - 2026-05-19 追加 candidate queue review decision writer run closeout：`services.market_intel.candidate_queue_review_decision_writer_run_closeout` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` 在 review_state receipt 通過後整理 closeout gate、操作員 closeout artifact、post-closeout read-only inventory 確認與 promotion 摘要。此 closeout 只允許放行到後續人工/只讀檢查；API/UI 不回吐 receipt 原文、不讀 approval token、不執行 CLI、不連 DB、不更新 `review_state`、不 commit、不掛 scheduler。 +- 2026-05-19 追加 candidate queue review decision post-closeout inventory：`services.market_intel.candidate_queue_review_decision_post_closeout_inventory`、`routes.market_intel_review_post_routes` 與 `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory` 在 review_state closeout 後整理 post-write smoke、live inventory、dedupe key 與 review_state 結果。此 inventory 只允許只讀驗證；API/UI 不讀 approval token、不執行 CLI、不更新 `review_state`、不寫 DB、不 commit、不掛 scheduler。 ### Phase 4：Coupang / Shopee Adapter diff --git a/routes/README.md b/routes/README.md index 925542a..5fc8082 100644 --- a/routes/README.md +++ b/routes/README.md @@ -19,8 +19,9 @@ | `edm_routes.py` | EDM 與節慶儀表板 | `/edm`, `/festival` | | `monthly_routes.py` | 月結分析 | `/monthly_summary_analysis`, `/api/monthly_summary_data` | | `daily_sales_routes.py` | 當日業績 | `/daily_sales`, `/daily_sales/export*` | -| `market_intel_routes.py` | 市場情報 Phase 76 candidate queue review decision writer run closeout 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | +| `market_intel_routes.py` | 市場情報 Phase 77 candidate queue review decision post-closeout inventory 主路由 | `/market_intel`, `/market_intel/*`, `/api/market_intel/status`, `/api/market_intel/schema`, `/api/market_intel/schema_smoke`, `/api/market_intel/schema_db_probe`, `/api/market_intel/platform_seed_db_diff`, `/api/market_intel/legacy_source_bridge`, `/api/market_intel/mcp_readiness`, `/api/market_intel/mcp_tool_contract`, `/api/market_intel/mcp_deploy_preflight`, `/api/market_intel/mcp_activation_runbook`, `/api/market_intel/mcp_fetch_gate`, `/api/market_intel/scheduler_plan`, `/api/market_intel/manual_sample_plan`, `/api/market_intel/manual_sample_acceptance`, `/api/market_intel/manual_sample_review`, `/api/market_intel/manual_sample_review/evaluate`, `/api/market_intel/manual_sample_review/candidate_handoff`, `/api/market_intel/manual_sample_review/candidate_queue_draft`, `/api/market_intel/manual_sample_review/candidate_queue_approval`, `/api/market_intel/manual_sample_review/candidate_queue_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout`, `/api/market_intel/manual_sample_review/candidate_queue_review_handoff`, `/api/market_intel/match_review_plan`, `/api/market_intel/opportunity_plan`, `/api/market_intel/opportunity_scoring_plan`, `/api/market_intel/opportunity_evidence_plan`, `/api/market_intel/opportunity_alert_plan`, `/api/market_intel/adapters`, `/api/market_intel/dry_run_plan`, `/api/market_intel/discovery_plan`, `/api/market_intel/manual_discovery`, `/api/market_intel/candidate_preview`, `/api/market_intel/platform_seed_plan`, `/api/market_intel/platform_seed_write_guard`, `/api/market_intel/platform_seed_writer_plan`, `/api/market_intel/migration_blueprint`, `/api/market_intel/migration_apply_drill`, `/api/market_intel/migration_catalog_review`, `/api/market_intel/migration_live_smoke`, `/api/market_intel/live_db_inventory`, `/api/market_intel/seed_writer_cli_status`, `/api/market_intel/write_approval_runbook`, `/api/market_intel/deployment_readiness` | | `market_intel_review_routes.py` | 市場情報人工 queue review 只讀延伸 API | `/api/market_intel/manual_sample_review/candidate_queue_review_inventory`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt`, `/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout` | +| `market_intel_review_post_routes.py` | 市場情報 review_state closeout 後只讀延伸 API（掛在 `market_intel_review_bp`） | `/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory` | | `api_routes.py` | 通用任務與查詢 API | `/api/run_task`, `/api/history/*` | | `export_routes.py` | 匯出功能 | `/api/export/*` | | `import_routes.py` | 匯入功能 | `/api/import_excel`, `/api/import/monthly_summary` | diff --git a/routes/market_intel_review_post_routes.py b/routes/market_intel_review_post_routes.py new file mode 100644 index 0000000..a6bc568 --- /dev/null +++ b/routes/market_intel_review_post_routes.py @@ -0,0 +1,70 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +"""市場情報 review_state closeout 後只讀延伸 API。""" + +from flask import jsonify, request + +from auth import login_required +from routes.market_intel_review_routes import ( + _build_review_decision_writer_receipt_stack, + _extract_run_payload, + market_intel_review_bp, +) +from services.market_intel import MarketIntelService +from services.market_intel.candidate_queue_review_decision_post_closeout_inventory import ( + build_candidate_queue_review_decision_post_closeout_inventory, +) +from services.market_intel.candidate_queue_review_decision_writer_postwrite_smoke import ( + build_candidate_queue_review_decision_writer_postwrite_smoke, +) +from services.market_intel.candidate_queue_review_decision_writer_run_closeout import ( + build_candidate_queue_review_decision_writer_run_closeout, +) + + +@market_intel_review_bp.route( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_post_closeout_inventory", + methods=["POST"], +) +@login_required +def market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory(): + service = MarketIntelService() + execute_requested = request.args.get("execute", "false").lower() == "true" + sample_result, operator_evidence, writer_output, smoke_result, payload_error, limit = ( + _extract_run_payload() + ) + transaction, receipt = _build_review_decision_writer_receipt_stack( + service=service, + sample_result=sample_result, + payload_error=payload_error, + operator_evidence=operator_evidence, + writer_output=writer_output, + postwrite_smoke_result=smoke_result, + limit=limit, + ) + closeout = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=transaction, + run_receipt=receipt, + operator_evidence=operator_evidence, + ) + read_only_allowed = bool(execute_requested and closeout.get("closeout_passed")) + if isinstance(smoke_result, dict) and smoke_result: + postwrite_smoke = smoke_result + else: + postwrite_smoke = build_candidate_queue_review_decision_writer_postwrite_smoke( + transaction_preview=transaction, + execute_requested=read_only_allowed, + ) + data = build_candidate_queue_review_decision_post_closeout_inventory( + transaction_preview=transaction, + run_closeout=closeout, + postwrite_smoke=postwrite_smoke, + live_db_inventory=service.build_live_db_inventory( + execute_requested=read_only_allowed, + ), + operator_evidence=operator_evidence, + execute_requested=execute_requested, + ) + data["phase"] = service.phase + return jsonify(data), 400 if payload_error else 200 diff --git a/routes/market_intel_review_routes.py b/routes/market_intel_review_routes.py index 3717fde..1857195 100644 --- a/routes/market_intel_review_routes.py +++ b/routes/market_intel_review_routes.py @@ -788,3 +788,6 @@ def market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeo ) data["phase"] = service.phase return jsonify(data), 400 if payload_error else 200 + + +from routes import market_intel_review_post_routes # noqa: E402,F401 diff --git a/services/market_intel/candidate_queue_review_decision_post_closeout_inventory.py b/services/market_intel/candidate_queue_review_decision_post_closeout_inventory.py new file mode 100644 index 0000000..96dbf75 --- /dev/null +++ b/services/market_intel/candidate_queue_review_decision_post_closeout_inventory.py @@ -0,0 +1,444 @@ +"""候選審核 queue review_state closeout 後只讀庫存檢查。 + +本模組只整理 review_state writer closeout 後的 inventory / smoke 結果； +不讀 approval token、不執行 CLI、不更新 review_state、不寫 DB、不 commit、 +不掛 scheduler。 +""" + + +FORBIDDEN_TOKEN_KEYWORDS = ( + "approval_token", + "approval-token", + "market_intel_queue_write_approval", +) +SAFE_TOKEN_METADATA_KEYS = { + "approval_token_present", + "approval_token_valid", + "approval_token_secret_configured", +} +SAFE_APPROVAL_ENV_VAR = "MARKET_INTEL_QUEUE_WRITE_APPROVAL" +TARGET_TABLE = "market_alert_review_queue" + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _contains_forbidden_token_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if normalized_key in SAFE_TOKEN_METADATA_KEYS and isinstance(nested, bool): + continue + if normalized_key == "approval_env_var" and nested == SAFE_APPROVAL_ENV_VAR: + continue + if any(token_key in normalized_key for token_key in FORBIDDEN_TOKEN_KEYWORDS): + return True + if _contains_forbidden_token_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_token_key(item) for item in value) + return False + + +def _expected_updates_from_transaction(transaction_preview): + updates = [] + for statement in _as_list(_as_dict(transaction_preview).get("statements")): + statement = _as_dict(statement) + lookup = _as_dict(statement.get("lookup")) + parameter_preview = _as_dict(statement.get("parameter_preview")) + dedupe_key = lookup.get("dedupe_key") or parameter_preview.get("dedupe_key") + next_state = ( + parameter_preview.get("next_review_state") + or statement.get("next_review_state") + ) + current_state = ( + parameter_preview.get("expected_current_review_state") + or statement.get("expected_current_review_state") + ) + if dedupe_key: + updates.append( + { + "dedupe_key": str(dedupe_key), + "expected_current_review_state": current_state, + "expected_review_state": next_state, + "idempotency_key": statement.get("idempotency_key"), + "parameter_payload_hash": statement.get( + "parameter_payload_hash" + ), + } + ) + return updates + + +def _row_summaries(postwrite_smoke): + rows = [] + for row in _as_list(_as_dict(postwrite_smoke).get("row_summaries")): + row = _as_dict(row) + rows.append( + { + "dedupe_key": row.get("dedupe_key"), + "review_state": row.get("review_state"), + "priority_lane": row.get("priority_lane"), + "threshold_level": row.get("threshold_level"), + "total_score": row.get("total_score"), + "evidence_bundle_id": row.get("evidence_bundle_id"), + "source_batch_id": row.get("source_batch_id"), + "reviewed_at": row.get("reviewed_at"), + "created_at": row.get("created_at"), + "updated_at": row.get("updated_at"), + } + ) + return rows + + +def _alert_table_status(live_db_inventory): + for item in _as_list(_as_dict(live_db_inventory).get("table_statuses")): + item = _as_dict(item) + if item.get("table") == TARGET_TABLE: + return { + "exists": bool(item.get("exists")), + "row_count": item.get("row_count"), + "status": item.get("status"), + } + return {"exists": False, "row_count": None, "status": "not_reported"} + + +def _operator_summary(operator_evidence): + operator_evidence = _as_dict(operator_evidence) + return { + "provided_keys": sorted(operator_evidence.keys()), + "operator_confirmed_post_closeout_inventory_read_only": bool( + operator_evidence.get("operator_confirmed_post_closeout_inventory_read_only") + or operator_evidence.get("operator_confirmed_inventory_read_only") + ), + "operator_confirmed_review_state_closeout_next": bool( + operator_evidence.get("operator_confirmed_review_state_closeout_next") + or operator_evidence.get("operator_confirmed_queue_review_next") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_evidence.get("operator_confirmed_no_scheduler_attach") + ), + "operator_confirmed_no_api_db_write": bool( + operator_evidence.get("operator_confirmed_no_api_db_write") + ), + "approval_token_submitted_to_api": _contains_forbidden_token_key( + operator_evidence + ), + } + + +def _side_effects_clear(*payloads): + blocked_keys = ( + "api_executes_cli", + "api_writes_database", + "api_updates_review_state", + "database_write_executed", + "database_commit_executed", + "migration_executed", + "external_network_executed", + "scheduler_attached", + "review_state_update_executed", + "writes_executed", + "would_write_database", + ) + return all( + not _as_dict(payload).get(key) + for payload in payloads + for key in blocked_keys + ) + + +def _closeout_summary(run_closeout): + run_closeout = _as_dict(run_closeout) + promotion_gate = _as_dict(run_closeout.get("promotion_gate")) + receipt_summary = _as_dict(run_closeout.get("receipt_summary")) + return { + "provided": bool(run_closeout), + "mode": run_closeout.get("mode"), + "closeout_passed": bool(run_closeout.get("closeout_passed")), + "ready_for_next_manual_phase": bool( + run_closeout.get("ready_for_next_manual_phase") + ), + "ready_for_review_inventory": bool( + run_closeout.get("ready_for_review_inventory") + ), + "promotion_allowed": bool(promotion_gate.get("allowed")), + "next_manual_phase": promotion_gate.get("next_manual_phase"), + "receipt_passed": bool(receipt_summary.get("receipt_passed")), + "expected_review_state_update_count": int( + receipt_summary.get("expected_review_state_update_count") or 0 + ), + "safe_boundaries_complete": bool( + receipt_summary.get("safe_boundaries_complete") + ), + "ready_for_api_review_state_update": bool( + run_closeout.get("ready_for_api_review_state_update") + ), + "ready_for_api_database_write": bool( + run_closeout.get("ready_for_api_database_write") + ), + "ready_for_scheduler_attach": bool(run_closeout.get("ready_for_scheduler_attach")), + "api_executes_cli": bool(run_closeout.get("api_executes_cli")), + "api_reads_approval_token": bool(run_closeout.get("api_reads_approval_token")), + "api_writes_file": bool(run_closeout.get("api_writes_file")), + "api_writes_database": bool(run_closeout.get("api_writes_database")), + "api_updates_review_state": bool(run_closeout.get("api_updates_review_state")), + "database_connection_opened": bool( + run_closeout.get("database_connection_opened") + ), + "database_write_executed": bool(run_closeout.get("database_write_executed")), + "database_commit_executed": bool(run_closeout.get("database_commit_executed")), + "review_state_update_executed": bool( + run_closeout.get("review_state_update_executed") + ), + "scheduler_attached": bool(run_closeout.get("scheduler_attached")), + } + + +def _state_mismatches(rows, expected_updates): + expected_by_key = { + item["dedupe_key"]: item.get("expected_review_state") + for item in expected_updates + if item.get("dedupe_key") + } + mismatches = [] + for row in rows: + dedupe_key = row.get("dedupe_key") + expected_state = expected_by_key.get(dedupe_key) + if expected_state and row.get("review_state") != expected_state: + mismatches.append( + { + "dedupe_key": dedupe_key, + "expected_review_state": expected_state, + "actual_review_state": row.get("review_state"), + } + ) + return mismatches + + +def _inventory_gates( + *, + closeout_summary, + postwrite_smoke, + live_db_inventory, + operator_summary, + expected_updates, + expected_keys, + found_keys, + missing_keys, + rows, + state_mismatches, + table_status, +): + read_only_executed = bool( + postwrite_smoke.get("read_only_query_executed") + or live_db_inventory.get("read_only_query_executed") + ) + return [ + { + "key": "closeout_preview_provided", + "label": "必須提供 review_state writer closeout preview", + "passed": bool( + closeout_summary["provided"] + and closeout_summary["mode"] + == "candidate_queue_review_decision_writer_run_closeout_preview" + ), + }, + { + "key": "closeout_passed", + "label": "closeout 必須已通過才可做 post-closeout inventory", + "passed": closeout_summary["closeout_passed"], + }, + { + "key": "closeout_promotes_read_only_inventory", + "label": "closeout 只能放行到後續人工/只讀 inventory", + "passed": bool( + closeout_summary["promotion_allowed"] + and closeout_summary["ready_for_review_inventory"] + and closeout_summary["next_manual_phase"] + == "review_state_post_closeout_read_only_inventory" + ), + }, + { + "key": "expected_review_state_updates_present", + "label": "必須有 expected review_state update 才能比對", + "passed": bool(expected_updates and expected_keys), + }, + { + "key": "inventory_probe_is_read_only", + "label": "inventory / smoke 只能只讀，不得寫 DB、更新狀態或掛 scheduler", + "passed": _side_effects_clear( + closeout_summary, + postwrite_smoke, + live_db_inventory, + ), + }, + { + "key": "operator_confirmed_post_closeout_inventory_read_only", + "label": "操作員確認 closeout 後 inventory 仍只讀", + "passed": bool( + operator_summary["operator_confirmed_post_closeout_inventory_read_only"] + and operator_summary["operator_confirmed_no_api_db_write"] + and operator_summary["operator_confirmed_no_scheduler_attach"] + ), + }, + { + "key": "post_closeout_inventory_no_approval_token_submitted_to_api", + "label": "payload 不得包含一次性 approval token key", + "passed": not operator_summary["approval_token_submitted_to_api"], + }, + { + "key": "read_only_inventory_executed", + "label": "需執行只讀 post-write smoke 或 live inventory", + "passed": read_only_executed, + }, + { + "key": "alert_review_queue_table_exists", + "label": "market_alert_review_queue 必須存在於只讀 inventory", + "passed": bool(table_status["exists"]), + }, + { + "key": "dedupe_keys_found_after_review_state_write", + "label": "所有 expected dedupe key 都必須在 queue 中找到", + "passed": bool(expected_keys and found_keys and not missing_keys), + }, + { + "key": "review_state_matches_expected", + "label": "找到的 row review_state 必須符合人工 decision transaction", + "passed": bool(rows and not state_mismatches), + }, + ] + + +def build_candidate_queue_review_decision_post_closeout_inventory( + *, + transaction_preview, + run_closeout, + postwrite_smoke, + live_db_inventory, + operator_evidence=None, + execute_requested=False, +): + """建立 review_state closeout 後 inventory preview；不執行任何副作用。""" + postwrite_smoke = _as_dict(postwrite_smoke) + live_db_inventory = _as_dict(live_db_inventory) + expected_updates = _expected_updates_from_transaction(transaction_preview) + expected_keys = sorted({item["dedupe_key"] for item in expected_updates}) + found_keys = _as_list(postwrite_smoke.get("found_dedupe_keys")) + missing_keys = _as_list(postwrite_smoke.get("missing_dedupe_keys")) + rows = _row_summaries(postwrite_smoke) + state_mismatches = _state_mismatches(rows, expected_updates) + table_status = _alert_table_status(live_db_inventory) + closeout = _closeout_summary(run_closeout) + operator_summary = _operator_summary(operator_evidence) + gates = _inventory_gates( + closeout_summary=closeout, + postwrite_smoke=postwrite_smoke, + live_db_inventory=live_db_inventory, + operator_summary=operator_summary, + expected_updates=expected_updates, + expected_keys=expected_keys, + found_keys=found_keys, + missing_keys=missing_keys, + rows=rows, + state_mismatches=state_mismatches, + table_status=table_status, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + inventory_ready = bool(not blocked_reasons) + + return { + "mode": "candidate_queue_review_decision_post_closeout_inventory_preview", + "target_table": TARGET_TABLE, + "target_operation": "verify_review_state_after_closeout", + "execute_requested": bool(execute_requested), + "post_closeout_inventory_ready": inventory_ready, + "ready_for_next_manual_phase": inventory_ready, + "ready_for_review_completion_archive": inventory_ready, + "ready_for_api_review_state_update": False, + "ready_for_api_database_write": False, + "ready_for_scheduler_attach": False, + "api_executes_cli": False, + "api_reads_approval_token": False, + "api_writes_file": False, + "api_writes_database": False, + "api_updates_review_state": False, + "approval_record_written": False, + "decision_record_written": False, + "review_state_update_executed": False, + "read_only_query_executed": bool( + postwrite_smoke.get("read_only_query_executed") + or live_db_inventory.get("read_only_query_executed") + ), + "database_connection_opened": bool( + postwrite_smoke.get("database_connection_opened") + or live_db_inventory.get("database_connection_opened") + ), + "database_session_created": False, + "explicit_transaction_opened": False, + "transaction_opened": False, + "transaction_committed": False, + "database_write_executed": False, + "database_commit_executed": False, + "database_rollback_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "writes_executed": False, + "would_write_database": False, + "expected_dedupe_keys": expected_keys, + "found_dedupe_keys": found_keys, + "missing_dedupe_keys": missing_keys, + "expected_review_state_updates": expected_updates, + "row_summaries": rows, + "state_mismatches": state_mismatches, + "alert_review_queue_table": table_status, + "live_inventory_summary": { + "mode": live_db_inventory.get("mode"), + "summary_ready": bool(live_db_inventory.get("summary_ready")), + "total_rows": live_db_inventory.get("total_rows"), + "alert_review_state_breakdown": _as_list( + live_db_inventory.get("alert_review_state_breakdown") + ), + }, + "postwrite_smoke_summary": { + "mode": postwrite_smoke.get("mode"), + "postwrite_smoke_passed": bool( + postwrite_smoke.get("postwrite_smoke_passed") + ), + "review_state_update_verified": bool( + postwrite_smoke.get("review_state_update_verified") + ), + "found_count": postwrite_smoke.get("found_count"), + "missing_count": postwrite_smoke.get("missing_count"), + "state_mismatch_count": postwrite_smoke.get("state_mismatch_count"), + }, + "closeout_summary": closeout, + "operator_inventory_summary": operator_summary, + "blocked_reasons": blocked_reasons, + "gates": gates, + "next_operator_steps": [ + "確認 expected / found dedupe key 完全一致", + "確認每個 row review_state 符合 confirmed / rejected / deferred 決策", + "保存 post-closeout inventory artifact 與 live inventory 摘要", + "若 row 缺失或狀態不符，停回 review_state writer receipt / closeout", + ], + "safe_boundaries": [ + "do_not_update_review_state_from_post_closeout_inventory", + "do_not_insert_missing_queue_row_from_post_closeout_inventory", + "do_not_read_approval_token_from_post_closeout_inventory", + "do_not_execute_cli_from_post_closeout_inventory", + "do_not_attach_scheduler_from_post_closeout_inventory", + "post_closeout_inventory_read_only", + "no_remove_orphans", + "no_momo_db_lifecycle_change", + ], + } diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 586bb88..e63497c 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -24,10 +24,11 @@ from services.market_intel.candidate_queue_review_decision_writer_run_package im from services.market_intel.candidate_queue_review_decision_writer_run_readiness import build_candidate_queue_review_decision_writer_run_readiness from services.market_intel.candidate_queue_review_decision_writer_run_receipt import build_candidate_queue_review_decision_writer_run_receipt from services.market_intel.candidate_queue_review_decision_writer_run_closeout import build_candidate_queue_review_decision_writer_run_closeout +from services.market_intel.candidate_queue_review_decision_post_closeout_inventory import build_candidate_queue_review_decision_post_closeout_inventory BLOCKED_RUN_REVIEW_KEYS = ("ready_for_api_database_write", "ready_for_scheduler_attach", "api_executes_cli", "api_reads_approval_token", "api_writes_file", "api_writes_database", "api_updates_review_state", "approval_record_written", "decision_record_written", "review_state_update_executed", "database_connection_opened", "database_session_created", "explicit_transaction_opened", "transaction_opened", "transaction_committed", "database_write_executed", "database_commit_executed", "database_rollback_executed", "scheduler_attached", "writes_executed", "would_write_database") -PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") +PRODUCTION_SMOKE_TARGETS = ("/health", "/market_intel", "/api/market_intel/status", "/api/market_intel/deployment_readiness", "/api/market_intel/schema_smoke", "/api/market_intel/schema_db_probe", "/api/market_intel/platform_seed_db_diff", "/api/market_intel/legacy_source_bridge", "/api/market_intel/mcp_readiness", "/api/market_intel/mcp_tool_contract", "/api/market_intel/mcp_deploy_preflight", "/api/market_intel/mcp_activation_runbook", "/api/market_intel/mcp_fetch_gate", "/api/market_intel/scheduler_plan", "/api/market_intel/manual_sample_plan", "/api/market_intel/manual_sample_acceptance", "/api/market_intel/manual_sample_review", "/api/market_intel/match_review_plan", "/api/market_intel/opportunity_plan", "/api/market_intel/opportunity_scoring_plan", "/api/market_intel/opportunity_evidence_plan", "/api/market_intel/opportunity_alert_plan", "/api/market_intel/migration_apply_drill", "/api/market_intel/migration_catalog_review", "/api/market_intel/migration_live_smoke", "/api/market_intel/live_db_inventory", "/api/market_intel/manual_sample_review/candidate_queue_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_handoff", "/api/market_intel/manual_sample_review/candidate_queue_review_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_approval", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_transaction", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_preflight", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_postwrite_smoke", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_operator_drill", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_package", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_readiness", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_receipt", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_run_closeout", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_post_closeout_inventory", "/api/market_intel/manual_sample_review/candidate_queue_review_decision_writer_status") def _run_review_preview_safe(payload, mode): @@ -160,6 +161,12 @@ def build_deployment_readiness_preview( transaction_preview=candidate_queue_review_decision_transaction, run_receipt=candidate_queue_review_decision_writer_run_receipt, ) + candidate_queue_review_decision_post_closeout_inventory = build_candidate_queue_review_decision_post_closeout_inventory( + transaction_preview=candidate_queue_review_decision_transaction, + run_closeout=candidate_queue_review_decision_writer_run_closeout, + postwrite_smoke=candidate_queue_review_decision_writer_postwrite_smoke, + live_db_inventory=live_db_inventory, + ) checks = { "schema_smoke_passed": bool(schema_smoke["passed"]), "feature_flags_default_safe": bool( @@ -426,6 +433,10 @@ def build_deployment_readiness_preview( candidate_queue_review_decision_writer_run_closeout, "candidate_queue_review_decision_writer_run_closeout_preview", ), + "candidate_queue_review_decision_post_closeout_inventory_preview_safe": _run_review_preview_safe( + candidate_queue_review_decision_post_closeout_inventory, + "candidate_queue_review_decision_post_closeout_inventory_preview", + ), "candidate_queue_review_decision_writer_cli_status_safe": _run_review_preview_safe( candidate_queue_review_decision_writer_status, "candidate_queue_review_decision_writer_cli_blocked", @@ -669,6 +680,7 @@ def build_deployment_readiness_preview( "candidate_queue_review_decision_writer_run_readiness": candidate_queue_review_decision_writer_run_readiness, "candidate_queue_review_decision_writer_run_receipt": candidate_queue_review_decision_writer_run_receipt, "candidate_queue_review_decision_writer_run_closeout": candidate_queue_review_decision_writer_run_closeout, + "candidate_queue_review_decision_post_closeout_inventory": candidate_queue_review_decision_post_closeout_inventory, "candidate_queue_review_decision_writer_status": candidate_queue_review_decision_writer_status, "match_review_plan": match_review_plan, "opportunity_plan": opportunity_plan, diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 906af8c..bbf3197 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_76_candidate_queue_review_decision_writer_run_closeout" +MARKET_INTEL_PHASE = "phase_77_candidate_queue_review_decision_post_closeout_inventory" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 0e7e905..3465396 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -667,6 +667,9 @@ + @@ -1017,6 +1020,7 @@ const sampleCandidateQueueReviewDecisionWriter = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-writer]') : null; const sampleCandidateQueueReviewDecisionRunReceipt = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-receipt]') : null; const sampleCandidateQueueReviewDecisionRunCloseout = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-run-closeout]') : null; + const sampleCandidateQueueReviewDecisionPostCloseoutInventory = sampleReviewRoot ? sampleReviewRoot.querySelector('[data-market-intel-sample-candidate-queue-review-decision-post-closeout-inventory]') : null; const sampleReviewEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review') }}"; const sampleReviewEvaluateEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_review_evaluate') }}"; const sampleCandidateHandoffEndpoint = "{{ url_for('market_intel.market_intel_manual_sample_candidate_handoff') }}"; @@ -1044,6 +1048,7 @@ const sampleCandidateQueueReviewDecisionWriterEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status') }}"; const sampleCandidateQueueReviewDecisionRunReceiptEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_receipt') }}"; const sampleCandidateQueueReviewDecisionRunCloseoutEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeout') }}"; + const sampleCandidateQueueReviewDecisionPostCloseoutInventoryEndpoint = "{{ url_for('market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory') }}"; const schedulerMeta = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-meta]') : null; const schedulerBody = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-body]') : null; const schedulerRefresh = schedulerRoot ? schedulerRoot.querySelector('[data-market-intel-scheduler-refresh]') : null; @@ -4418,6 +4423,104 @@ } }; + const renderCandidateQueueReviewDecisionPostCloseoutInventory = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const closeout = data.closeout_summary || {}; + const smoke = data.postwrite_smoke_summary || {}; + const table = data.alert_review_queue_table || {}; + sampleReviewMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `inventory=${data.post_closeout_inventory_ready ? 'pass' : 'blocked'}`, + `closeout=${closeout.closeout_passed ? 'pass' : 'blocked'}`, + `query=${data.read_only_query_executed ? 'yes' : 'no'}`, + `api_update=${data.ready_for_api_review_state_update ? 'yes' : 'no'}` + ].map(item => `${escapeHtml(item)}`).join(''); + sampleReviewBody.innerHTML = ` +
此卡只檢查 review_state closeout 後的只讀 inventory / smoke；API/UI 不讀 token、不執行 CLI、不更新 review_state、不寫 DB、不掛 scheduler。${blockers ? `阻擋：${escapeHtml(blockers)}` : ''}
+
expected=${escapeHtml((data.expected_dedupe_keys || []).join(', ') || 'none')} / found=${escapeHtml((data.found_dedupe_keys || []).join(', ') || 'none')} / missing=${escapeHtml((data.missing_dedupe_keys || []).join(', ') || 'none')}
+
+
+

INVENTORY GATES

+
${ + gates.map(gate => ` +
+
+ ${escapeHtml(gate.key)} + ${escapeHtml(gate.label)} +
+ ${gate.passed ? 'PASS' : 'BLOCK'} +
+ `).join('') || '
尚未提供 inventory gate。
' + }
+
+
+

READ-ONLY RESULT

+
+ ${[ + ['table_exists', table.exists], + ['table_rows', table.row_count == null ? 'n/a' : table.row_count], + ['smoke_passed', smoke.postwrite_smoke_passed], + ['review_state_verified', smoke.review_state_update_verified], + ['state_mismatch_count', smoke.state_mismatch_count || 0], + ['db_write', data.database_write_executed] + ].map(([key, value]) => ` +
+
${escapeHtml(key)}
+ ${escapeHtml(String(value))} +
+ `).join('')} +
+
+
+

ROW SNAPSHOT

+
${ + (data.row_summaries || []).slice(0, 6).map(row => ` +
+
+ ${escapeHtml(row.dedupe_key || 'unknown')} + ${escapeHtml(row.review_state || 'unknown')} / score=${escapeHtml(row.total_score == null ? 'n/a' : row.total_score)} +
+ ${escapeHtml(row.priority_lane || 'ROW')} +
+ `).join('') || '
尚未載入 row snapshot。
' + }
+
+
+ `; + }; + + const loadCandidateQueueReviewDecisionPostCloseoutInventory = async () => { + if (!sampleReviewMeta || !sampleReviewBody || !sampleReviewInput) return; + let parsed; + try { + parsed = JSON.parse(sampleReviewInput.value || '{}'); + } catch (error) { + sampleReviewMeta.innerHTML = 'json_error'; + sampleReviewBody.innerHTML = `
JSON 格式錯誤：${escapeHtml(error.message)}
`; + return; + } + const body = parsed && parsed.sample_result ? parsed : { sample_result: parsed }; + sampleReviewBody.innerHTML = '
檢查 queue review decision post-closeout inventory 中...
'; + try { + const response = await fetch(sampleCandidateQueueReviewDecisionPostCloseoutInventoryEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify(body) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderCandidateQueueReviewDecisionPostCloseoutInventory(data); + } catch (error) { + sampleReviewMeta.innerHTML = 'error'; + sampleReviewBody.innerHTML = `
queue review decision post-closeout inventory 失敗：${escapeHtml(error.message)}
`; + } + }; + const renderCandidateQueueReviewDecisionWriter = data => { const blockers = (data.blocked_reasons || []).join(' / '); const summary = data.statement_summary || {}; @@ -6100,6 +6203,9 @@ if (sampleCandidateQueueReviewDecisionRunCloseout) { sampleCandidateQueueReviewDecisionRunCloseout.addEventListener('click', loadCandidateQueueReviewDecisionRunCloseout); } + if (sampleCandidateQueueReviewDecisionPostCloseoutInventory) { + sampleCandidateQueueReviewDecisionPostCloseoutInventory.addEventListener('click', loadCandidateQueueReviewDecisionPostCloseoutInventory); + } if (schedulerRefresh) { schedulerRefresh.addEventListener('click', loadScheduler); } diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 8981d36..33af234 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -383,6 +383,20 @@ def _build_review_decision_writer_receipt_fixture( "found_dedupe_keys": [expected_key], "missing_dedupe_keys": [], "state_mismatches": [], + "row_summaries": [ + { + "dedupe_key": expected_key, + "review_state": "confirmed", + "priority_lane": "watch", + "threshold_level": "medium", + "total_score": 82.5, + "evidence_bundle_id": "evidence-1", + "source_batch_id": batch_id, + "reviewed_at": "2026-05-19T12:30:00", + "created_at": "2026-05-19T12:00:00", + "updated_at": "2026-05-19T12:30:00", + } + ], } receipt = build_candidate_queue_review_decision_writer_run_receipt( transaction_preview=transaction, @@ -1013,6 +1027,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_run_closeout" in template ) + assert ( + "market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_post_closeout_inventory" + in template + ) assert ( "data-market-intel-sample-candidate-queue-review-decision-writer" in template @@ -1045,6 +1063,10 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): "data-market-intel-sample-candidate-queue-review-decision-run-closeout" in template ) + assert ( + "data-market-intel-sample-candidate-queue-review-decision-post-closeout-inventory" + in template + ) assert "X-CSRFToken" in template assert "market_intel.market_intel_scheduler_plan" in template assert "market_intel.market_intel_match_review_plan" in template @@ -1081,7 +1103,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert bridge["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1239,7 +1261,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert contract["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1372,7 +1394,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1385,7 +1407,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert gate["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1455,7 +1477,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1467,7 +1489,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -1515,7 +1537,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -1526,7 +1548,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert acceptance["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -1568,7 +1590,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -1580,7 +1602,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert review["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -1691,7 +1713,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -1730,7 +1752,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert review["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -1792,7 +1814,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -1872,7 +1894,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert handoff["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -1936,7 +1958,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -1995,7 +2017,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert queue_draft["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -2069,7 +2091,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -2132,7 +2154,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert approval["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -2210,7 +2232,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -2273,7 +2295,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert transaction["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -2353,7 +2375,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -4845,6 +4867,122 @@ def test_candidate_queue_review_decision_writer_run_closeout_preview_blocks_api_ ) +def test_candidate_queue_review_decision_post_closeout_inventory_is_read_only(): + from services.market_intel.candidate_queue_review_decision_post_closeout_inventory import ( + build_candidate_queue_review_decision_post_closeout_inventory, + ) + from services.market_intel.candidate_queue_review_decision_writer_run_closeout import ( + build_candidate_queue_review_decision_writer_run_closeout, + ) + + fixture = _build_review_decision_writer_receipt_fixture( + "sample-batch-review-state-post-closeout" + ) + closeout_evidence = { + **fixture["operator_evidence"], + "review_state_closeout_artifact_path": ( + "artifacts/market_intel/review-state-closeout.json" + ), + "operator_confirmed_review_state_closeout_next": True, + "operator_confirmed_post_closeout_inventory_read_only": True, + "operator_confirmed_no_scheduler_attach": True, + "operator_confirmed_no_api_db_write": True, + "closeout_notes": "review_state closeout reviewed", + } + closeout = build_candidate_queue_review_decision_writer_run_closeout( + transaction_preview=fixture["transaction"], + run_receipt=fixture["receipt"], + operator_evidence=closeout_evidence, + ) + live_inventory = { + "mode": "live_db_inventory_loaded", + "summary_ready": True, + "read_only_query_executed": True, + "database_connection_opened": True, + "database_write_executed": False, + "database_commit_executed": False, + "migration_executed": False, + "external_network_executed": False, + "scheduler_attached": False, + "total_rows": 1, + "table_statuses": [ + { + "table": "market_alert_review_queue", + "exists": True, + "row_count": 1, + "status": "loaded", + } + ], + "alert_review_state_breakdown": [ + { + "review_state": "confirmed", + "priority_lane": "watch", + "alert_count": 1, + } + ], + } + inventory = build_candidate_queue_review_decision_post_closeout_inventory( + transaction_preview=fixture["transaction"], + run_closeout=closeout, + postwrite_smoke=fixture["postwrite_smoke_result"], + live_db_inventory=live_inventory, + operator_evidence=closeout_evidence, + execute_requested=True, + ) + token_leak = build_candidate_queue_review_decision_post_closeout_inventory( + transaction_preview=fixture["transaction"], + run_closeout=closeout, + postwrite_smoke=fixture["postwrite_smoke_result"], + live_db_inventory=live_inventory, + operator_evidence={ + **closeout_evidence, + "approval_token": TEST_APPROVAL_TOKEN, + }, + execute_requested=True, + ) + + assert inventory["mode"] == ( + "candidate_queue_review_decision_post_closeout_inventory_preview" + ) + assert inventory["target_operation"] == "verify_review_state_after_closeout" + assert inventory["post_closeout_inventory_ready"] is True + assert inventory["ready_for_review_completion_archive"] is True + assert inventory["ready_for_api_review_state_update"] is False + assert inventory["ready_for_api_database_write"] is False + assert inventory["ready_for_scheduler_attach"] is False + assert inventory["api_executes_cli"] is False + assert inventory["api_reads_approval_token"] is False + assert inventory["api_writes_database"] is False + assert inventory["api_updates_review_state"] is False + assert inventory["review_state_update_executed"] is False + assert inventory["database_write_executed"] is False + assert inventory["database_commit_executed"] is False + assert inventory["scheduler_attached"] is False + assert inventory["read_only_query_executed"] is True + assert inventory["expected_dedupe_keys"] == fixture["receipt"][ + "expected_dedupe_keys" + ] + assert inventory["found_dedupe_keys"] == fixture["receipt"][ + "expected_dedupe_keys" + ] + assert inventory["state_mismatches"] == [] + assert inventory["alert_review_queue_table"]["exists"] is True + assert inventory["blocked_reasons"] == [] + assert "post_closeout_inventory_read_only" in inventory["safe_boundaries"] + assert token_leak["post_closeout_inventory_ready"] is False + assert token_leak["operator_inventory_summary"][ + "approval_token_submitted_to_api" + ] is True + assert "post_closeout_inventory_no_approval_token_submitted_to_api" in token_leak[ + "blocked_reasons" + ] + assert TEST_APPROVAL_TOKEN not in json.dumps( + token_leak, + ensure_ascii=False, + sort_keys=True, + ) + + def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -4887,7 +5025,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -4944,7 +5082,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -5033,7 +5171,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -5087,7 +5225,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -5143,7 +5281,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -5209,7 +5347,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -5511,7 +5649,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -5559,7 +5697,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -5608,7 +5746,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -5666,7 +5804,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -5732,7 +5870,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -5803,7 +5941,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -5879,7 +6017,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -5961,7 +6099,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -6047,7 +6185,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -6130,7 +6268,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -6213,7 +6351,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -6299,7 +6437,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -6390,7 +6528,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_76_candidate_queue_review_decision_writer_run_closeout" + "phase_77_candidate_queue_review_decision_post_closeout_inventory" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -6500,7 +6638,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_76_candidate_queue_review_decision_writer_run_closeout" + "phase_77_candidate_queue_review_decision_post_closeout_inventory" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -6586,7 +6724,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_76_candidate_queue_review_decision_writer_run_closeout" + "phase_77_candidate_queue_review_decision_post_closeout_inventory" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -6612,6 +6750,62 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ assert TEST_APPROVAL_TOKEN not in payload +def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_only_and_no_write(): + from routes.market_intel_routes import market_intel_bp + from routes.market_intel_review_routes import market_intel_review_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + app.register_blueprint(market_intel_review_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_post_closeout_inventory" + ) + response = client.post( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_post_closeout_inventory" + "?execute=true&apply_real_write=true", + json={"sample_result": {}}, + ) + data = response.get_json() + payload = json.dumps(data, ensure_ascii=False, sort_keys=True) + + assert get_response.status_code == 405 + assert response.status_code == 200 + assert data["mode"] == ( + "candidate_queue_review_decision_post_closeout_inventory_preview" + ) + assert data["phase"] == ( + "phase_77_candidate_queue_review_decision_post_closeout_inventory" + ) + assert data["post_closeout_inventory_ready"] is False + assert data["ready_for_api_review_state_update"] is False + assert data["ready_for_api_database_write"] is False + assert data["ready_for_scheduler_attach"] is False + assert data["api_writes_file"] is False + assert data["api_executes_cli"] is False + assert data["api_reads_approval_token"] is False + assert data["api_writes_database"] is False + assert data["api_updates_review_state"] is False + assert data["database_connection_opened"] is False + assert data["database_write_executed"] is False + assert data["database_commit_executed"] is False + assert data["review_state_update_executed"] is False + assert data["read_only_query_executed"] is False + assert data["scheduler_attached"] is False + assert data["expected_dedupe_keys"] == [] + assert "expected_review_state_updates_present" in data["blocked_reasons"] + assert "do_not_update_review_state_from_post_closeout_inventory" in data[ + "safe_boundaries" + ] + assert TEST_APPROVAL_TOKEN not in payload + + def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): from routes.market_intel_routes import market_intel_bp @@ -6640,7 +6834,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -6665,7 +6859,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -6703,7 +6897,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -6714,7 +6908,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -6750,7 +6944,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -6761,7 +6955,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -6802,7 +6996,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -6813,7 +7007,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -6861,7 +7055,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -6873,7 +7067,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -6919,7 +7113,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -6932,7 +7126,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert plan["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -7017,7 +7211,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -7095,7 +7289,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -7110,7 +7304,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert readiness["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -7598,6 +7792,12 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is True ) + assert ( + readiness["checks"][ + "candidate_queue_review_decision_post_closeout_inventory_preview_safe" + ] + is True + ) assert ( readiness["checks"][ "candidate_queue_review_decision_writer_cli_status_safe" @@ -7727,6 +7927,11 @@ def test_deployment_readiness_reports_app_only_release_gate(): "candidate_queue_review_decision_writer_run_closeout" in readiness["production_smoke_targets"] ) + assert ( + "/api/market_intel/manual_sample_review/" + "candidate_queue_review_decision_post_closeout_inventory" + in readiness["production_smoke_targets"] + ) assert ( "/api/market_intel/manual_sample_review/" "candidate_queue_review_decision_writer_status" @@ -8876,6 +9081,72 @@ def test_deployment_readiness_reports_app_only_release_gate(): ] is False ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "mode" + ] + == "candidate_queue_review_decision_post_closeout_inventory_preview" + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "post_closeout_inventory_ready" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "ready_for_api_review_state_update" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "ready_for_api_database_write" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "api_executes_cli" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "api_reads_approval_token" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "api_updates_review_state" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "review_state_update_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "read_only_query_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "database_write_executed" + ] + is False + ) + assert ( + readiness["candidate_queue_review_decision_post_closeout_inventory"][ + "scheduler_attached" + ] + is False + ) assert ( readiness["candidate_queue_review_decision_writer_status"]["mode"] == "candidate_queue_review_decision_writer_cli_blocked" @@ -9026,7 +9297,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert drill["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -9141,7 +9412,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -9153,7 +9424,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert review["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -9268,7 +9539,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -9281,7 +9552,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert smoke["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -9343,7 +9614,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -9356,7 +9627,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert inventory["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -9500,7 +9771,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -9727,7 +9998,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -9756,7 +10027,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_76_candidate_queue_review_decision_writer_run_closeout" + assert data["phase"] == "phase_77_candidate_queue_review_decision_post_closeout_inventory" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False