refactor(market-intel): modularize deployment readiness

tests/test_market_intel_skeleton.py

@@ -527,7 +527,7 @@ def test_legacy_source_bridge_default_is_planned_only():
     bridge = MarketIntelService().build_legacy_source_bridge()
 
     assert bridge["mode"] == "legacy_source_bridge_planned"
-    assert bridge["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert bridge["phase"] == "phase_40_deployment_readiness_modularized"
     assert bridge["execute_requested"] is False
     assert bridge["read_only_query_executed"] is False
     assert bridge["database_connection_opened"] is False
@@ -685,7 +685,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
     contract = MarketIntelService().build_mcp_tool_contract()
 
     assert contract["mode"] == "mcp_tool_contract_preview"
-    assert contract["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert contract["phase"] == "phase_40_deployment_readiness_modularized"
     assert contract["caller"] == "market_intel"
     assert contract["contract_ready"] is True
     assert contract["blocked_reasons"] == []
@@ -818,7 +818,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "mcp_activation_runbook_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["deployment_actions_executed"] is False
     assert data["docker_command_executed"] is False
     assert data["ssh_command_executed"] is False
@@ -831,7 +831,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
     gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
 
     assert gate["mode"] == "mcp_fetch_gate_planned"
-    assert gate["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert gate["phase"] == "phase_40_deployment_readiness_modularized"
     assert gate["fetch_requested"] is True
     assert gate["manual_fetch_gate_open"] is False
     assert gate["network_request_allowed"] is False
@@ -901,7 +901,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "mcp_fetch_gate_planned"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["fetch_requested"] is False
     assert data["network_request_allowed"] is False
     assert data["external_network_executed"] is False
@@ -913,7 +913,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
     plan = MarketIntelService().build_scheduler_plan()
 
     assert plan["mode"] == "scheduler_attach_plan_preview"
-    assert plan["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert plan["phase"] == "phase_40_deployment_readiness_modularized"
     assert plan["ready_to_attach_scheduler"] is False
     assert plan["scheduler_attached"] is False
     assert plan["scheduler_registration_executed"] is False
@@ -951,7 +951,7 @@ def test_scheduler_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "scheduler_attach_plan_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["scheduler_registration_executed"] is False
     assert data["crawler_job_started"] is False
     assert data["external_network_executed"] is False
@@ -962,7 +962,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
     plan = MarketIntelService().build_match_review_plan()
 
     assert plan["mode"] == "match_review_plan_preview"
-    assert plan["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert plan["phase"] == "phase_40_deployment_readiness_modularized"
     assert plan["ready_for_review_queue"] is False
     assert plan["review_queue_created"] is False
     assert plan["auto_match_executed"] is False
@@ -998,7 +998,7 @@ def test_match_review_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "match_review_plan_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["review_queue_created"] is False
     assert data["auto_confirm_executed"] is False
     assert data["external_network_executed"] is False
@@ -1009,7 +1009,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
     plan = MarketIntelService().build_opportunity_plan()
 
     assert plan["mode"] == "opportunity_plan_preview"
-    assert plan["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert plan["phase"] == "phase_40_deployment_readiness_modularized"
     assert plan["ready_for_opportunity_queue"] is False
     assert plan["opportunity_queue_created"] is False
     assert plan["threat_alert_dispatched"] is False
@@ -1050,7 +1050,7 @@ def test_opportunity_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "opportunity_plan_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["opportunity_queue_created"] is False
     assert data["threat_alert_dispatched"] is False
     assert data["ai_summary_generated"] is False
@@ -1061,7 +1061,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
     plan = MarketIntelService().build_opportunity_scoring_plan()
 
     assert plan["mode"] == "opportunity_scoring_plan_preview"
-    assert plan["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert plan["phase"] == "phase_40_deployment_readiness_modularized"
     assert plan["ready_for_scoring_job"] is False
     assert plan["scoring_job_created"] is False
     assert plan["score_calculation_executed"] is False
@@ -1109,7 +1109,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "opportunity_scoring_plan_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["scoring_job_created"] is False
     assert data["score_calculation_executed"] is False
     assert data["sample_scores_generated"] is False
@@ -1121,7 +1121,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
     plan = MarketIntelService().build_opportunity_evidence_plan()
 
     assert plan["mode"] == "opportunity_evidence_plan_preview"
-    assert plan["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert plan["phase"] == "phase_40_deployment_readiness_modularized"
     assert plan["ready_for_evidence_bundle"] is False
     assert plan["evidence_bundle_created"] is False
     assert plan["evidence_query_executed"] is False
@@ -1167,7 +1167,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "opportunity_evidence_plan_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["evidence_bundle_created"] is False
     assert data["evidence_query_executed"] is False
     assert data["sample_evidence_generated"] is False
@@ -1180,7 +1180,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
     plan = MarketIntelService().build_opportunity_alert_plan()
 
     assert plan["mode"] == "opportunity_alert_plan_preview"
-    assert plan["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert plan["phase"] == "phase_40_deployment_readiness_modularized"
     assert plan["ready_for_alert_candidates"] is False
     assert plan["alert_candidate_created"] is False
     assert plan["alert_queue_created"] is False
@@ -1245,7 +1245,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "opportunity_alert_plan_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["alert_candidate_created"] is False
     assert data["alert_queue_created"] is False
     assert data["review_queue_created"] is False
@@ -1320,7 +1320,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "mcp_external_deploy_preflight_preview"
-    assert data["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert data["phase"] == "phase_40_deployment_readiness_modularized"
     assert data["deployment_actions_executed"] is False
     assert data["docker_command_executed"] is False
     assert data["ssh_command_executed"] is False
@@ -1335,7 +1335,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
     readiness = MarketIntelService().build_mcp_readiness()
 
     assert readiness["mode"] == "mcp_readiness_planned"
-    assert readiness["phase"] == "phase_39_opportunity_alert_review_preview"
+    assert readiness["phase"] == "phase_40_deployment_readiness_modularized"
     assert readiness["execute_requested"] is False
     assert readiness["router_enabled"] is False
     assert readiness["external_mcp_complete"] is False
@@ -1795,6 +1795,16 @@ def test_deployment_readiness_reports_app_only_release_gate():
     assert readiness["opportunity_alert_plan"]["database_write_executed"] is False
 
 
+def test_market_intel_service_keeps_readiness_modularized():
+    service_path = Path("services/market_intel/service.py")
+    readiness_path = Path("services/market_intel/deployment_readiness.py")
+
+    assert service_path.exists()
+    assert readiness_path.exists()
+    assert len(service_path.read_text().splitlines()) < 800
+    assert "build_deployment_readiness_preview" in readiness_path.read_text()
+
+
 def test_write_approval_runbook_is_read_only_and_blocks_real_write():
     runbook = MarketIntelService().build_write_approval_runbook()
     gate_keys = {gate["key"] for gate in runbook["approval_gates"]}