diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 64df9ee..9910145 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.412 補市場情報 MCP fetch run package gate:新增 `mcp_fetch_run_package` read-only builder、route extension、GET/POST endpoint、UI run package 審核面板與 deployment readiness smoke target,將已通過的 target review 轉成操作員可覆核的 command argv preview 與 receipt path 契約;API/UI 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,只放行到後續 run readiness review。 - V10.409 補市場情報 MCP fetch target review gate:新增 `mcp_fetch_target_review` read-only builder、GET/POST endpoint、UI target review 審核面板與 deployment readiness smoke target,讓 manual fetch handoff 通過後,先人工審核 adapter registry 公開入口、每平台節流、樣本數、timeout 與 rollback plan;API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler,也不會自動打開 manual fetch。 - V10.405 補市場情報 MCP manual fetch handoff gate:新增 `mcp_manual_fetch_handoff` read-only builder、GET/POST endpoint、UI handoff package 審核面板與 deployment readiness smoke target,將 runtime promotion package 與操作員安全確認合併成「可進人工 fetch gate 審核」的交接收據;API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler,也不會自動打開 manual fetch。 - V10.379 補市場情報 MCP runtime promotion gate:新增 `mcp_runtime_promotion` read-only builder、GET/POST endpoint、UI promotion package 審核面板與 deployment readiness smoke target,將 MCP activation evidence 與 runtime smoke receipt 合併成可審核的 runtime promotion package;API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler,也不會自動打開人工 fetch gate。 diff --git a/config.py b/config.py index b03b88b..a11af99 100644 --- a/config.py +++ b/config.py @@ -325,7 +325,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.411" +SYSTEM_VERSION = "V10.412" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 9d0d1a0..4dc630c 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -160,6 +160,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-18 追加 MCP fetch gate preview:`services.market_intel.mcp_fetch_gate` 與 `/api/market_intel/mcp_fetch_gate` 將人工 discovery fetch 改成必須先通過市場情報 feature flags、MCP readiness、router、外部 MCP health 與 tool contract gate;`run_manual_discovery(fetch=true)` 即使 flags 開啟也會先被此 gate 阻擋,直到 MCP 條件全過。此 gate 不抓電商頁、不寫 DB、不掛 scheduler、不執行 deployment,UI 預設只呼叫 `fetch=false&execute=false`。 - 2026-05-24 追加 MCP manual fetch handoff gate:`services.market_intel.mcp_manual_fetch_handoff` 與 `/api/market_intel/mcp_manual_fetch_handoff` 將 runtime promotion package 與操作員安全確認合併成可審核 handoff,只放行到人工 fetch gate operator review;API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler,也不會自動打開 manual fetch。 - 2026-05-24 追加 MCP fetch target review gate:`services.market_intel.mcp_fetch_target_review` 與 `/api/market_intel/mcp_fetch_target_review` 在 manual fetch handoff 後審核 adapter registry 公開入口白名單、平台來源、每平台 delay / timeout / max pages / sample_limit、rollback plan 與操作員確認;API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler,也不會自動打開 manual fetch,只放行到後續人工 fetch run package review。 +- 2026-05-24 追加 MCP fetch run package gate:`services.market_intel.mcp_fetch_run_package` 與 `/api/market_intel/mcp_fetch_run_package` 將已通過的 target review 轉成 command argv preview、receipt path 與操作員 run controls 審核包;路由拆至 `routes.market_intel_mcp_run_routes`,主 Blueprint 僅掛 extension import。此階段不執行 CLI、不發外部 request、不寫 artifact、不開 DB、不掛 scheduler,只放行到後續 run readiness review。 - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 321901c..6347ff1 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -39,6 +39,7 @@ - 2026-05-21 追記:同步市場情報 MCP runtime promotion gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;此處只更新 inventory,後續市場情報 MCP route 應拆出子 Blueprint。 - 2026-05-24 追記:同步市場情報 MCP manual fetch handoff gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增邏輯已放在獨立 `services/market_intel/mcp_manual_fetch_handoff.py`,route 僅保留薄 glue,下一個 MCP/UI gate 應優先拆出子 Blueprint 或 route registration helper。 - 2026-05-24 追記:同步市場情報 MCP fetch target review gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增邏輯已放在獨立 `services/market_intel/mcp_fetch_target_review.py`,route 僅保留薄 glue,後續市場情報 MCP route 應拆出子 Blueprint 或 route registration helper。 +- 2026-05-24 追記:同步市場情報 MCP fetch run package gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增 endpoint 已拆到 `routes/market_intel_mcp_run_routes.py`,主 Blueprint 只新增 extension import,後續 MCP route 應延續此模式。 - 2026-05-21 追記:同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 EDM 失效頁 alert guard 與 REJURAN 唇膏寬價差 exact-identity matcher 更新後的 `scheduler.py`、`services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 @@ -72,7 +73,7 @@ | 940 | `services/import_service.py` | P2 import service | validators / import writers / report builders | | 933 | `services/telegram_templates.py` | P2 Telegram templates | alert template groups / channel-specific formatting / reusable render helpers | | 867 | `services/token_report_service.py` | P2 token report service | query / aggregation / chart payload / notification formatting | -| 3365 | `services/marketplace_product_matcher.py` | P2 marketplace matcher | identity parsing / unit-comparable scoring / search term quality / persistence normalization | +| 3393 | `services/marketplace_product_matcher.py` | P2 marketplace matcher | identity parsing / unit-comparable scoring / search term quality / persistence normalization | | 865 | `routes/daily_sales_routes.py` | P2 Daily Sales Blueprint | route glue / export helpers / daily query and formatting service | | 961 | `services/ollama_service.py` | P2 Ollama client | host health / request client / fallback policy / response parsing | | 849 | `services/pchome_crawler.py` | P2 PChome crawler | search fetch / parsing / fallback source handling / rate limit policy | @@ -83,8 +84,8 @@ | 1327 | `services/competitor_intel_repository.py` | P2 competitor intel repository | review queue query / cache shaping / formatting helpers | | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | -| 914 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 979 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 917 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | +| 1009 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 3c80f65..d5ec269 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24:PChome 近門檻身份回收第二輪 +- **V10.412 MCP fetch run package gate**: 新增 `mcp_fetch_run_package` read-only builder、獨立 route extension、GET/POST endpoint、UI run package 審核面板與 deployment readiness smoke target,將已通過的 target review 轉成操作員可覆核的 command argv preview 與 receipt path 契約;API/UI 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,只放行到後續 run readiness review。 - **V10.411 rom&nd / Summer’s Eve / Solone 近門檻 review-only 回收**: marketplace matcher 追加三條窄範圍 focused identity:rom&nd 果汁唇釉 2.0 catalog、Summer’s Eve 舒摩兒全肌防護浴潔露 2入、Solone 持久眼線筆;皆只進 `identity_review` / manual-review,不直接價格告警。production pilot 已回刷 3/3,`matched` 1616→1619、`true_low_confidence` 763→760;rom&nd 染眉膏 ZO&FRIENDS 色號、Summer’s Eve 雙天王任選、Lactacyd 清新舒涼 vs 生理呵護、MAC 柔霧 vs 緞光、NIVEA / 曼秀雷敦包數差異仍不自動救回,維持準確率優先。 - **V10.410 Code Review timeout 梯度改為保護 111**: 部署後實測顯示 GCP-A 從 188 失聯時,Code Review 仍會先等 primary 45s,GCP-B 完整審查 prompt 又常因 25s 太短而 timeout,最後轉落 111。`CODE_REVIEW_OLLAMA_TIMEOUT` 預設收斂為 `15s`,`CODE_REVIEW_OLLAMA_SECONDARY_TIMEOUT` 放寬為 `60s`;Hermes LLM scan 若啟用則 primary `15s`、secondary `45s`。目標是 A 掛時更快讓位給 B,並給 B 足夠時間完成,避免過早壓到 111。 - **V10.409 MCP fetch target review gate**: 新增 `mcp_fetch_target_review` read-only builder、GET/POST endpoint、UI target review 審核面板與 deployment readiness smoke target,讓 manual fetch handoff 通過後,先審核 adapter registry 公開入口、每平台節流、樣本數、timeout 與 rollback plan;API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler,也不會自動打開 manual fetch。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py new file mode 100644 index 0000000..7b0b1b5 --- /dev/null +++ b/routes/market_intel_mcp_run_routes.py @@ -0,0 +1,36 @@ +#!/usr/bin/env python3 +# -*- coding: utf-8 -*- +"""市場情報 MCP run package route extension。""" + +from flask import jsonify, request + +from auth import login_required +from routes.market_intel_routes import market_intel_bp +from services.market_intel import MarketIntelService +from services.market_intel.mcp_fetch_run_package import ( + build_mcp_fetch_run_package_preview, +) + + +@market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) +@login_required +def market_intel_mcp_fetch_run_package(): + target_review_package = {} + target_review_result = None + operator_run_controls = {} + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = payload.get("run_package") or payload.get("fetch_run_package") or payload + target_review_package = package.get("target_review_package", {}) + target_review_result = package.get("target_review_result") + operator_run_controls = package.get("operator_run_controls", {}) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_run_package_preview( + target_review_package=target_review_package, + target_review_result=target_review_result, + operator_run_controls=operator_run_controls, + phase=service.phase, + ) + ) diff --git a/routes/market_intel_routes.py b/routes/market_intel_routes.py index c16a837..cd8eb8e 100644 --- a/routes/market_intel_routes.py +++ b/routes/market_intel_routes.py @@ -912,3 +912,6 @@ def market_intel_write_approval_runbook(): @login_required def market_intel_deployment_readiness(): return jsonify(_service().build_deployment_readiness()) + + +from routes import market_intel_mcp_run_routes # noqa: E402,F401 diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index d323a25..549ee1f 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -63,6 +63,9 @@ from services.market_intel.mcp_activation_evidence import build_mcp_activation_e from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) +from services.market_intel.mcp_fetch_run_package import ( + build_mcp_fetch_run_package_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -165,6 +168,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_target_review",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_run_package",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -192,6 +200,9 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s mcp_fetch_target_review = build_mcp_fetch_target_review_preview( phase=service.phase, ) + mcp_fetch_run_package = build_mcp_fetch_run_package_preview( + phase=service.phase, + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -466,6 +477,24 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_fetch_target_review["fetch_executed"] and not mcp_fetch_target_review["scheduler_attached"] ), + "mcp_fetch_run_package_preview_safe": bool( + mcp_fetch_run_package["mode"] == "mcp_fetch_run_package_preview" + and not mcp_fetch_run_package["payload_persisted"] + and not mcp_fetch_run_package["run_package_persisted"] + and not mcp_fetch_run_package["command_preview_persisted"] + and not mcp_fetch_run_package["package_artifact_created"] + and not mcp_fetch_run_package["manual_fetch_gate_opened_by_api"] + and not mcp_fetch_run_package["network_request_allowed"] + and not mcp_fetch_run_package["api_executes_cli"] + and not mcp_fetch_run_package["api_opens_database_connection"] + and not mcp_fetch_run_package["api_writes_database"] + and not mcp_fetch_run_package["api_uses_external_network"] + and not mcp_fetch_run_package["database_write_executed"] + and not mcp_fetch_run_package["fetch_executed"] + and not mcp_fetch_run_package["cli_executed"] + and not mcp_fetch_run_package["file_written"] + and not mcp_fetch_run_package["scheduler_attached"] + ), "scheduler_plan_preview_safe": bool( scheduler_plan["mode"] == "scheduler_attach_plan_preview" and not scheduler_plan["scheduler_registration_executed"] @@ -902,6 +931,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_runtime_promotion": mcp_runtime_promotion, "mcp_manual_fetch_handoff": mcp_manual_fetch_handoff, "mcp_fetch_target_review": mcp_fetch_target_review, + "mcp_fetch_run_package": mcp_fetch_run_package, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_run_package.py b/services/market_intel/mcp_fetch_run_package.py new file mode 100644 index 0000000..390e4d6 --- /dev/null +++ b/services/market_intel/mcp_fetch_run_package.py @@ -0,0 +1,476 @@ +"""市場情報 MCP manual fetch run package preview。 + +本模組只把已通過的 target review 轉成可審核的人工 run package; +不執行 CLI、不發 HTTP request、不寫檔、不開 DB、不掛 scheduler。 +""" + +from services.market_intel.adapters import get_adapter_registry +from services.market_intel.mcp_fetch_target_review import ( + build_mcp_fetch_target_review_preview, +) + + +MAX_TOTAL_REQUESTS = 20 +MAX_STOP_AFTER_ERROR_COUNT = 3 +RUN_ARTIFACT_DIR_PREFIX = "artifacts/market_intel/manual_fetch/" + +RUN_ACKNOWLEDGEMENT_LABELS = { + "target_review_accepted": "target review 已通過且仍需另開 run package gate", + "command_bundle_reviewed": "操作員已覆核 command argv preview", + "artifact_path_reviewed": "artifact path 限定於 market intel manual fetch 目錄", + "dry_run_first": "第一次人工執行必須 dry-run first", + "receipt_required": "每個公開入口必須貼回 receipt 才能進下一段", + "stop_on_error": "達到錯誤門檻立即停止,不做重試風暴", + "no_api_execution": "本 API 不執行 CLI、不發外部 request", + "no_database_write": "本階段不得寫 DB", + "no_scheduler_attach": "不得掛 scheduler", +} + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_executes_cli", + "api_executes_docker", + "api_executes_health_check", + "api_executes_ssh", + "api_opens_database_connection", + "api_uses_external_network", + "api_writes_database", + "attach_scheduler", + "cli_executed", + "command_executed", + "database_commit_executed", + "database_session_created", + "database_write_executed", + "external_network_executed", + "fetch_executed", + "file_written", + "manual_fetch_gate_opened_by_api", + "network_request_allowed", + "package_artifact_created", + "run_package_persisted", + "scheduler_attached", + "write_database", + "writes_executed", + "would_write_database", +) + + +def _sample_operator_run_controls(target_review): + return { + "run_label": "market-intel-manual-fetch-sample", + "artifact_dir": ( + RUN_ARTIFACT_DIR_PREFIX + + "sample_market_intel_manual_fetch" + ), + "max_total_requests": max( + 1, + min( + target_review.get("source_target_count", 1), + MAX_TOTAL_REQUESTS, + ), + ), + "stop_after_error_count": 2, + "requires_shell_operator": True, + "dry_run_first": True, + "write_receipt_required": True, + "allow_api_execution": False, + "allow_external_network_in_api": False, + "allow_database_write": False, + "allow_scheduler_attach": False, + "operator_acknowledgements": { + key: True for key in RUN_ACKNOWLEDGEMENT_LABELS + }, + } + + +def _sample_run_package(): + target_preview = build_mcp_fetch_target_review_preview() + target_review_package = target_preview["sample_target_review_package"] + accepted_target_review = build_mcp_fetch_target_review_preview( + handoff_package=target_review_package["handoff_package"], + target_review=target_review_package["target_review"], + ) + return { + "target_review_package": target_review_package, + "operator_run_controls": _sample_operator_run_controls( + accepted_target_review + ), + } + + +def _target_review_from_inputs(target_review_package, target_review_result, phase): + if isinstance(target_review_result, dict) and target_review_result: + return target_review_result + + target_review_package = ( + target_review_package + if isinstance(target_review_package, dict) + else {} + ) + return build_mcp_fetch_target_review_preview( + handoff_package=target_review_package.get("handoff_package", {}), + handoff_review=target_review_package.get("handoff_review"), + target_review=target_review_package.get("target_review", {}), + phase=phase, + ) + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + key_path = f"{path}.{key}" if path else key + if key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _acknowledgement_status(operator_run_controls): + acknowledgements = operator_run_controls.get("operator_acknowledgements", {}) + if not isinstance(acknowledgements, dict): + acknowledgements = {} + return { + key: { + "label": label, + "acknowledged": bool(acknowledgements.get(key)), + } + for key, label in RUN_ACKNOWLEDGEMENT_LABELS.items() + } + + +def _to_positive_int(value): + try: + parsed = int(value) + except (TypeError, ValueError): + return None + if parsed <= 0: + return None + return parsed + + +def _safe_artifact_dir(value): + if not isinstance(value, str): + return False + normalized = value.strip().replace("\\", "/") + if not normalized or normalized.startswith("/"): + return False + parts = [part for part in normalized.split("/") if part] + if any(part in (".", "..") for part in parts): + return False + return normalized.startswith(RUN_ARTIFACT_DIR_PREFIX) + + +def _source_index(): + index = {} + for adapter in get_adapter_registry().values(): + for source in adapter.campaign_sources(): + index[(adapter.platform_code, source.source_key)] = { + **source.to_dict(), + "platform_code": adapter.platform_code, + "platform_name": adapter.platform_name, + } + return index + + +def _receipt_path(artifact_dir, platform_code, source_key): + safe_platform = str(platform_code).replace("/", "_") + safe_source = str(source_key).replace("/", "_") + return f"{artifact_dir}/{safe_platform}_{safe_source}_receipt.json" + + +def _command_previews(target_review, operator_run_controls): + source_index = _source_index() + artifact_dir = operator_run_controls.get("artifact_dir") or "" + command_previews = [] + + for target in target_review.get("target_summaries", []): + if not target.get("ready"): + continue + platform_code = target.get("platform_code") + for source_key in target.get("source_keys", []): + source = source_index.get((platform_code, source_key), {}) + receipt_path = _receipt_path(artifact_dir, platform_code, source_key) + command_previews.append( + { + "platform_code": platform_code, + "platform_name": target.get("platform_name"), + "source_key": source_key, + "source_url": source.get("url"), + "campaign_type": source.get("campaign_type"), + "delay_seconds": target.get("delay_seconds"), + "timeout_seconds": target.get("timeout_seconds"), + "sample_limit": target.get("sample_limit"), + "receipt_path": receipt_path, + "argv_preview": [ + "python", + "scripts/market_intel_manual_fetch_runner.py", + "--platform", + platform_code, + "--source", + source_key, + "--source-url", + source.get("url"), + "--delay", + str(target.get("delay_seconds")), + "--timeout", + str(target.get("timeout_seconds")), + "--sample-limit", + str(target.get("sample_limit")), + "--receipt-path", + receipt_path, + "--dry-run-first", + ], + "command_executed": False, + "external_network_executed_by_api": False, + "receipt_written_by_api": False, + } + ) + + return command_previews + + +def _run_controls_payload(operator_run_controls): + return operator_run_controls if isinstance(operator_run_controls, dict) else {} + + +def build_mcp_fetch_run_package_preview( + *, + target_review_package=None, + target_review_result=None, + operator_run_controls=None, + phase=None, +): + """建立 manual fetch run package review;只輸出 command preview。""" + target_review_package = ( + target_review_package + if isinstance(target_review_package, dict) + else {} + ) + operator_controls = _run_controls_payload(operator_run_controls) + target_review = _target_review_from_inputs( + target_review_package, + target_review_result, + phase, + ) + run_payload_received = bool( + target_review_package or target_review_result or operator_run_controls + ) + target_review_received = bool(target_review_package or target_review_result) + target_review_accepted = bool( + target_review.get("mcp_fetch_target_review_accepted") + ) + controls_received = bool(operator_controls) + acknowledgements = _acknowledgement_status(operator_controls) + acknowledgements_complete = all( + item["acknowledged"] for item in acknowledgements.values() + ) + artifact_dir = operator_controls.get("artifact_dir") + max_total_requests = _to_positive_int( + operator_controls.get("max_total_requests") + ) + stop_after_error_count = _to_positive_int( + operator_controls.get("stop_after_error_count") + ) + command_previews = _command_previews(target_review, operator_controls) + side_effects = _blocked_side_effects(operator_controls) + _blocked_side_effects( + target_review + ) + no_api_execution = bool( + not operator_controls.get("allow_api_execution") + and not operator_controls.get("allow_external_network_in_api") + and not operator_controls.get("api_executes_cli") + and not operator_controls.get("api_uses_external_network") + and not operator_controls.get("fetch_executed") + and not operator_controls.get("network_request_allowed") + ) + no_database_write = bool( + not operator_controls.get("allow_database_write") + and not operator_controls.get("write_database") + and not operator_controls.get("api_writes_database") + and not operator_controls.get("database_write_executed") + ) + no_scheduler_attach = bool( + not operator_controls.get("allow_scheduler_attach") + and not operator_controls.get("attach_scheduler") + and not operator_controls.get("scheduler_attached") + ) + command_budget_ok = bool( + max_total_requests is not None + and max_total_requests <= MAX_TOTAL_REQUESTS + and max_total_requests <= max(1, len(command_previews)) + ) + error_stop_ok = bool( + stop_after_error_count is not None + and stop_after_error_count <= MAX_STOP_AFTER_ERROR_COUNT + ) + + gates = [ + { + "key": "target_review_payload_or_result_received", + "passed": target_review_received, + "label": "已提供 target review package 或已審核結果", + }, + { + "key": "target_review_accepted", + "passed": target_review_accepted, + "label": "target review 已通過,平台與來源白名單可供 run package 使用", + }, + { + "key": "operator_run_controls_received", + "passed": controls_received, + "label": "已提供操作員 run controls", + }, + { + "key": "operator_acknowledgements_complete", + "passed": acknowledgements_complete, + "label": "操作員已確認 command、artifact、dry-run、receipt 與無副作用邊界", + }, + { + "key": "artifact_dir_safe", + "passed": _safe_artifact_dir(artifact_dir), + "label": "artifact_dir 必須在 market intel manual fetch 相對目錄內", + }, + { + "key": "command_preview_built_from_targets", + "passed": bool(command_previews), + "label": "command preview 只由已通過的 target summaries 生成", + }, + { + "key": "request_budget_within_target_limit", + "passed": command_budget_ok, + "label": "max_total_requests 不得超過來源數與全域安全上限", + }, + { + "key": "stop_after_error_count_safe", + "passed": error_stop_ok, + "label": "錯誤停止門檻需維持小於等於 3", + }, + { + "key": "dry_run_first_confirmed", + "passed": operator_controls.get("dry_run_first") is True, + "label": "人工執行必須先 dry-run first", + }, + { + "key": "receipt_required", + "passed": operator_controls.get("write_receipt_required") is True, + "label": "每個來源必須產生 receipt,回貼後才可進下一段", + }, + { + "key": "shell_operator_required", + "passed": operator_controls.get("requires_shell_operator") is True, + "label": "正式抓取只能由操作員 shell 命令執行,不由 API 執行", + }, + { + "key": "no_api_fetch_execution", + "passed": no_api_execution, + "label": "本 API 不執行 CLI、不發外部 request", + }, + { + "key": "no_database_write", + "passed": no_database_write, + "label": "本階段不寫 DB、不 commit", + }, + { + "key": "no_scheduler_attach", + "passed": no_scheduler_attach, + "label": "本階段不掛 scheduler", + }, + { + "key": "run_package_side_effect_free", + "passed": not side_effects, + "label": "run package review 不執行 CLI、不寫檔、不連外、不開 DB", + }, + ] + gates.extend( + { + "key": f"ack_{key}", + "passed": item["acknowledged"], + "label": item["label"], + } + for key, item in acknowledgements.items() + ) + blocked_reasons = [ + gate["key"] for gate in gates + if not gate["passed"] + ] + accepted = bool(run_payload_received and not blocked_reasons) + + return { + "mode": ( + "mcp_fetch_run_package_review" + if run_payload_received + else "mcp_fetch_run_package_preview" + ), + "phase": phase, + "run_payload_received": run_payload_received, + "target_review_received": target_review_received, + "target_review_accepted": target_review_accepted, + "operator_run_controls_received": controls_received, + "operator_acknowledgements_complete": acknowledgements_complete, + "mcp_fetch_run_package_accepted": accepted, + "ready_for_manual_fetch_run_readiness_review": accepted, + "ready_for_manual_fetch_operator_run": False, + "manual_fetch_gate_opened_by_api": False, + "network_request_allowed": False, + "fetch_executed": False, + "cli_executed": False, + "database_write_executed": False, + "scheduler_attached": False, + "command_preview_count": len(command_previews), + "max_total_requests": max_total_requests, + "stop_after_error_count": stop_after_error_count, + "artifact_dir": artifact_dir, + "artifact_dir_safe": _safe_artifact_dir(artifact_dir), + "blocked_side_effects": side_effects, + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "operator_acknowledgement_status": acknowledgements, + "command_previews": command_previews, + "target_review_summary": { + "mode": target_review.get("mode"), + "accepted": target_review_accepted, + "platform_target_count": target_review.get("platform_target_count", 0), + "source_target_count": target_review.get("source_target_count", 0), + "blocked_reasons": target_review.get("blocked_reasons", []), + "ready_for_manual_fetch_run_package_review": bool( + target_review.get("ready_for_manual_fetch_run_package_review") + ), + }, + "mcp_fetch_target_review": target_review, + "sample_run_package": _sample_run_package(), + "next_operator_steps": [ + "若 run package review 通過,只代表可進下一段 run readiness,不代表 API 可執行抓取", + "操作員需在 shell 依 argv preview 人工執行,並貼回 receipt 供下一段審核", + "正式 DB write、scheduler attach、Telegram/AI 摘要仍需各自獨立 gate", + ], + "payload_persisted": False, + "run_package_persisted": False, + "command_preview_persisted": False, + "package_artifact_created": False, + "api_executes_health_check": False, + "api_executes_docker": False, + "api_executes_ssh": False, + "api_executes_cli": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "database_session_created": False, + "database_commit_executed": False, + "external_network_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 7215f1d..41a553e 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_121_market_intel_mcp_fetch_target_review" +MARKET_INTEL_PHASE = "phase_122_market_intel_mcp_fetch_run_package" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index 4bb05c1..a4903fd 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -682,6 +682,32 @@ +
+
+
+

MCP / FETCH RUN PACKAGE

+

MCP Fetch Run Package 審核

+
+ +
+
+ loading +
+
+
讀取 MCP Fetch Run Package 審核中...
+
+
+ +
+ +
+
+
+
@@ -1191,6 +1217,7 @@ const mcpRuntimePromotionRoot = document.querySelector('[data-market-intel-mcp-runtime-promotion]'); const mcpManualFetchHandoffRoot = document.querySelector('[data-market-intel-mcp-manual-fetch-handoff]'); const mcpFetchTargetReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-target-review]'); + const mcpFetchRunPackageRoot = document.querySelector('[data-market-intel-mcp-fetch-run-package]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1207,7 +1234,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1284,6 +1311,12 @@ const mcpFetchTargetReviewReview = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-review]') : null; const mcpFetchTargetReviewRefresh = mcpFetchTargetReviewRoot ? mcpFetchTargetReviewRoot.querySelector('[data-market-intel-mcp-fetch-target-review-refresh]') : null; const mcpFetchTargetReviewEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_target_review') }}"; + const mcpFetchRunPackageMeta = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-meta]') : null; + const mcpFetchRunPackageBody = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-body]') : null; + const mcpFetchRunPackageInput = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-input]') : null; + const mcpFetchRunPackageReview = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-review]') : null; + const mcpFetchRunPackageRefresh = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-refresh]') : null; + const mcpFetchRunPackageEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_run_package') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -2841,6 +2874,124 @@ } }; + const renderMcpFetchRunPackageMeta = data => { + mcpFetchRunPackageMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_run_package_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `commands=${data.command_preview_count || 0}`, + `operator=${data.ready_for_manual_fetch_operator_run ? 'ready' : 'blocked'}`, + `network=${data.network_request_allowed ? 'open' : 'closed'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchRunPackageBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const commands = data.command_previews || []; + const target = data.target_review_summary || {}; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchRunPackageBody.innerHTML = ` +
此 run package 只產生人工命令 argv preview 與 receipt 契約;API 不執行 CLI、不抓外站、不寫檔、不開 DB。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

RUN PACKAGE GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 run package gates。
' + }
+
+
+

COMMAND PREVIEW

+
${ + commands.length + ? commands.map(item => renderCheck( + `${item.platform_code || 'unknown'}:${item.source_key || 'source'}`, + `${item.receipt_path || 'no receipt'} / limit=${item.sample_limit || 'n/a'}`, + item.command_executed ? 'BLOCK' : 'PREVIEW' + )).join('') + : '
尚未產生命令預覽。
' + }
+
+
+

TARGET / NEXT

+
+ ${renderCheck( + 'target_review', + `${target.platform_target_count || 0} platforms / ${target.source_target_count || 0} sources`, + target.accepted ? 'ACCEPTED' : 'PENDING' + )} + ${renderCheck( + 'api_boundary', + 'no CLI / no external request / no file / no DB / no scheduler', + data.api_executes_cli ? 'BLOCK' : 'CLOSED' + )} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'MANUAL')).join('')} +
+
+
+ `; + if (mcpFetchRunPackageInput && !mcpFetchRunPackageInput.value.trim() && data.sample_run_package) { + mcpFetchRunPackageInput.value = JSON.stringify(data.sample_run_package, null, 2); + } + }; + + const loadMcpFetchRunPackage = async () => { + if (!mcpFetchRunPackageMeta || !mcpFetchRunPackageBody) return; + mcpFetchRunPackageBody.innerHTML = '
讀取 MCP Fetch Run Package 審核中...
'; + try { + const response = await fetch(mcpFetchRunPackageEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchRunPackageMeta(data); + renderMcpFetchRunPackageBody(data); + } catch (error) { + mcpFetchRunPackageMeta.innerHTML = 'error'; + mcpFetchRunPackageBody.innerHTML = `
MCP Fetch Run Package 審核讀取失敗:${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchRunPackage = async () => { + if (!mcpFetchRunPackageMeta || !mcpFetchRunPackageBody || !mcpFetchRunPackageInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchRunPackageInput.value || '{}'); + } catch (error) { + mcpFetchRunPackageMeta.innerHTML = 'json_error'; + mcpFetchRunPackageBody.innerHTML = `
JSON 格式錯誤:${escapeHtml(error.message)}
`; + return; + } + mcpFetchRunPackageBody.innerHTML = '
審核 MCP Fetch Run Package 中...
'; + try { + const response = await fetch(mcpFetchRunPackageEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ run_package: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchRunPackageMeta(data); + renderMcpFetchRunPackageBody(data); + } catch (error) { + mcpFetchRunPackageMeta.innerHTML = 'error'; + mcpFetchRunPackageBody.innerHTML = `
MCP Fetch Run Package 審核失敗:${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -12274,6 +12425,12 @@ if (mcpFetchTargetReviewReview) { mcpFetchTargetReviewReview.addEventListener('click', reviewMcpFetchTargetReview); } + if (mcpFetchRunPackageRefresh) { + mcpFetchRunPackageRefresh.addEventListener('click', loadMcpFetchRunPackage); + } + if (mcpFetchRunPackageReview) { + mcpFetchRunPackageReview.addEventListener('click', reviewMcpFetchRunPackage); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -12533,6 +12690,7 @@ loadMcpRuntimePromotion(); loadMcpManualFetchHandoff(); loadMcpFetchTargetReview(); + loadMcpFetchRunPackage(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 1304424..7eb8630 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -20,6 +20,9 @@ from services.market_intel.mcp_completion_audit import build_mcp_completion_audi from services.market_intel.mcp_contract import build_mcp_tool_contract_preview from services.market_intel.mcp_deploy_preflight import build_mcp_deploy_preflight_plan from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview +from services.market_intel.mcp_fetch_run_package import ( + build_mcp_fetch_run_package_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -965,6 +968,11 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-mcp-fetch-target-review-gates" in template assert "data-market-intel-mcp-fetch-target-review-targets" in template assert "data-market-intel-mcp-fetch-target-review-next" in template + assert "market_intel.market_intel_mcp_fetch_run_package" in template + assert "data-market-intel-mcp-fetch-run-package" in template + assert "data-market-intel-mcp-fetch-run-package-gates" in template + assert "data-market-intel-mcp-fetch-run-package-commands" in template + assert "data-market-intel-mcp-fetch-run-package-next" in template assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1435,7 +1443,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert bridge["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1593,7 +1601,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert contract["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1726,7 +1734,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1739,7 +1747,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert gate["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1809,7 +1817,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1823,7 +1831,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert audit["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -1897,7 +1905,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -1914,11 +1922,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_121_market_intel_mcp_fetch_target_review" + phase="phase_122_market_intel_mcp_fetch_run_package" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert evidence["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -1943,7 +1951,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2001,12 +2009,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2015,11 +2023,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_121_market_intel_mcp_fetch_target_review" + phase="phase_122_market_intel_mcp_fetch_run_package" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert receipt["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2047,7 +2055,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2112,12 +2120,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2126,11 +2134,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_121_market_intel_mcp_fetch_target_review" + phase="phase_122_market_intel_mcp_fetch_run_package" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert promotion["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2158,7 +2166,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2218,12 +2226,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2232,11 +2240,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert handoff["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2264,7 +2272,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2326,12 +2334,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2342,11 +2350,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2376,7 +2384,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_121_market_intel_mcp_fetch_target_review", + phase="phase_122_market_intel_mcp_fetch_run_package", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2454,13 +2462,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2470,11 +2478,142 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert post_data["api_uses_external_network"] is False +def test_mcp_fetch_run_package_preview_is_safe_without_payload(): + package = build_mcp_fetch_run_package_preview( + phase="phase_122_market_intel_mcp_fetch_run_package", + ) + + assert package["mode"] == "mcp_fetch_run_package_preview" + assert package["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert package["run_payload_received"] is False + assert package["mcp_fetch_run_package_accepted"] is False + assert package["ready_for_manual_fetch_run_readiness_review"] is False + assert package["ready_for_manual_fetch_operator_run"] is False + assert package["manual_fetch_gate_opened_by_api"] is False + assert package["network_request_allowed"] is False + assert package["fetch_executed"] is False + assert package["cli_executed"] is False + assert package["payload_persisted"] is False + assert package["run_package_persisted"] is False + assert package["command_preview_persisted"] is False + assert package["package_artifact_created"] is False + assert package["api_executes_cli"] is False + assert package["api_opens_database_connection"] is False + assert package["api_writes_database"] is False + assert package["api_uses_external_network"] is False + assert package["database_write_executed"] is False + assert package["external_network_executed"] is False + assert package["file_written"] is False + assert package["scheduler_attached"] is False + assert "target_review_payload_or_result_received" in package["blocked_reasons"] + assert "operator_run_controls_received" in package["blocked_reasons"] + assert "target_review_package" in package["sample_run_package"] + assert "operator_run_controls" in package["sample_run_package"] + + +def test_mcp_fetch_run_package_accepts_sample_package(): + sample = build_mcp_fetch_run_package_preview()["sample_run_package"] + package = build_mcp_fetch_run_package_preview( + target_review_package=sample["target_review_package"], + operator_run_controls=sample["operator_run_controls"], + phase="phase_122_market_intel_mcp_fetch_run_package", + ) + + assert package["mode"] == "mcp_fetch_run_package_review" + assert package["mcp_fetch_run_package_accepted"] is True + assert package["ready_for_manual_fetch_run_readiness_review"] is True + assert package["ready_for_manual_fetch_operator_run"] is False + assert package["target_review_accepted"] is True + assert package["operator_acknowledgements_complete"] is True + assert package["blocked_reasons"] == [] + assert package["passed_gate_count"] == package["gate_count"] + assert package["command_preview_count"] >= 8 + assert all( + item["command_executed"] is False + and item["external_network_executed_by_api"] is False + and item["receipt_written_by_api"] is False + for item in package["command_previews"] + ) + assert package["manual_fetch_gate_opened_by_api"] is False + assert package["network_request_allowed"] is False + assert package["fetch_executed"] is False + assert package["cli_executed"] is False + assert package["package_artifact_created"] is False + assert package["file_written"] is False + assert package["database_write_executed"] is False + assert package["api_uses_external_network"] is False + assert package["scheduler_attached"] is False + + +def test_mcp_fetch_run_package_blocks_unsafe_controls(): + sample = build_mcp_fetch_run_package_preview()["sample_run_package"] + controls = sample["operator_run_controls"] + controls["artifact_dir"] = "../unsafe" + controls["max_total_requests"] = 99 + controls["allow_api_execution"] = True + controls["operator_acknowledgements"]["no_api_execution"] = False + + package = build_mcp_fetch_run_package_preview( + target_review_package=sample["target_review_package"], + operator_run_controls=controls, + ) + + assert package["mcp_fetch_run_package_accepted"] is False + assert package["target_review_accepted"] is True + assert "artifact_dir_safe" in package["blocked_reasons"] + assert "request_budget_within_target_limit" in package["blocked_reasons"] + assert "no_api_fetch_execution" in package["blocked_reasons"] + assert "run_package_side_effect_free" in package["blocked_reasons"] + assert "ack_no_api_execution" in package["blocked_reasons"] + assert package["network_request_allowed"] is False + assert package["api_writes_database"] is False + assert package["scheduler_attached"] is False + + +def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get("/api/market_intel/mcp_fetch_run_package") + get_data = get_response.get_json() + sample = get_data["sample_run_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_run_package", + json={"run_package": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == "mcp_fetch_run_package_preview" + assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["api_executes_cli"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_uses_external_network"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_run_package_review" + assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["mcp_fetch_run_package_accepted"] is True + assert post_data["ready_for_manual_fetch_operator_run"] is False + assert post_data["manual_fetch_gate_opened_by_api"] is False + assert post_data["network_request_allowed"] is False + assert post_data["fetch_executed"] is False + assert post_data["cli_executed"] is False + assert post_data["run_package_persisted"] is False + assert post_data["api_opens_database_connection"] is False + assert post_data["api_uses_external_network"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -2522,7 +2661,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -2533,7 +2672,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert acceptance["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -2575,7 +2714,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -2587,7 +2726,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -2698,7 +2837,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -2737,7 +2876,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -2799,7 +2938,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -2879,7 +3018,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert handoff["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -2943,7 +3082,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -3002,7 +3141,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert queue_draft["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -3076,7 +3215,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -3139,7 +3278,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert approval["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -3217,7 +3356,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -3280,7 +3419,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert transaction["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -3360,7 +3499,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -9071,7 +9210,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9146,7 +9285,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -9418,7 +9557,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9706,7 +9845,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -10016,7 +10155,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -10319,7 +10458,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -10578,7 +10717,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -10851,7 +10990,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -11099,7 +11238,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -11329,7 +11468,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -11566,7 +11705,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -11808,7 +11947,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -12084,7 +12223,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -12361,7 +12500,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -12640,7 +12779,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -12969,7 +13108,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -13231,7 +13370,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -13495,7 +13634,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -13765,7 +13904,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -14053,7 +14192,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -14340,7 +14479,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -14426,7 +14565,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -14483,7 +14622,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -14572,7 +14711,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -14626,7 +14765,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -14682,7 +14821,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -14748,7 +14887,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -15050,7 +15189,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -15098,7 +15237,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -15147,7 +15286,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -15205,7 +15344,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -15271,7 +15410,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -15342,7 +15481,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -15418,7 +15557,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -15500,7 +15639,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15586,7 +15725,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -15669,7 +15808,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15752,7 +15891,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -15838,7 +15977,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -15929,7 +16068,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -16039,7 +16178,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16125,7 +16264,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16182,7 +16321,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16235,7 +16374,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16288,7 +16427,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16349,7 +16488,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16418,7 +16557,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16490,7 +16629,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -16563,7 +16702,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -16634,7 +16773,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -16699,7 +16838,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -16770,7 +16909,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -16843,7 +16982,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -16920,7 +17059,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -16997,7 +17136,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -17074,7 +17213,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -17148,7 +17287,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -17227,7 +17366,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -17314,7 +17453,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -17395,7 +17534,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -17477,7 +17616,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_121_market_intel_mcp_fetch_target_review" + "phase_122_market_intel_mcp_fetch_run_package" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -17560,7 +17699,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -17585,7 +17724,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -17623,7 +17762,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -17634,7 +17773,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -17670,7 +17809,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -17681,7 +17820,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -17722,7 +17861,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -17733,7 +17872,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -17781,7 +17920,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -17793,7 +17932,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -17839,7 +17978,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -17852,7 +17991,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -17937,7 +18076,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -18015,7 +18154,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -18030,7 +18169,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert readiness["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -18423,6 +18562,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["mcp_runtime_promotion_preview_safe"] is True assert readiness["checks"]["mcp_manual_fetch_handoff_preview_safe"] is True assert readiness["checks"]["mcp_fetch_target_review_preview_safe"] is True + assert readiness["checks"]["mcp_fetch_run_package_preview_safe"] is True assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -18799,6 +18939,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/mcp_runtime_promotion" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_manual_fetch_handoff" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_fetch_target_review" in readiness["production_smoke_targets"] + assert "/api/market_intel/mcp_fetch_run_package" in readiness["production_smoke_targets"] assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -19173,6 +19314,21 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["mcp_fetch_target_review"]["api_writes_database"] is False assert readiness["mcp_fetch_target_review"]["api_uses_external_network"] is False assert readiness["mcp_fetch_target_review"]["scheduler_attached"] is False + assert readiness["mcp_fetch_run_package"]["mode"] == "mcp_fetch_run_package_preview" + assert readiness["mcp_fetch_run_package"]["run_payload_received"] is False + assert readiness["mcp_fetch_run_package"]["payload_persisted"] is False + assert readiness["mcp_fetch_run_package"]["run_package_persisted"] is False + assert readiness["mcp_fetch_run_package"]["command_preview_persisted"] is False + assert readiness["mcp_fetch_run_package"]["package_artifact_created"] is False + assert readiness["mcp_fetch_run_package"]["manual_fetch_gate_opened_by_api"] is False + assert readiness["mcp_fetch_run_package"]["network_request_allowed"] is False + assert readiness["mcp_fetch_run_package"]["fetch_executed"] is False + assert readiness["mcp_fetch_run_package"]["cli_executed"] is False + assert readiness["mcp_fetch_run_package"]["api_executes_cli"] is False + assert readiness["mcp_fetch_run_package"]["api_writes_database"] is False + assert readiness["mcp_fetch_run_package"]["api_uses_external_network"] is False + assert readiness["mcp_fetch_run_package"]["file_written"] is False + assert readiness["mcp_fetch_run_package"]["scheduler_attached"] is False assert readiness["manual_sample_plan"]["mode"] == "manual_sample_fetch_plan_preview" assert readiness["manual_sample_plan"]["sample_fetch_executed"] is False assert readiness["manual_sample_plan"]["external_network_executed"] is False @@ -22792,7 +22948,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert drill["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -22907,7 +23063,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -22919,7 +23075,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -23034,7 +23190,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -23047,7 +23203,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert smoke["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -23109,7 +23265,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -23122,7 +23278,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert inventory["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -23266,7 +23422,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -23502,7 +23658,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -23531,7 +23687,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_121_market_intel_mcp_fetch_target_review" + assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False