diff --git a/TODO_NEXT_STEPS.txt b/TODO_NEXT_STEPS.txt index 9910145..36d9ccf 100644 --- a/TODO_NEXT_STEPS.txt +++ b/TODO_NEXT_STEPS.txt @@ -4,6 +4,7 @@ ================================================================================ 【已完成】 + - V10.414 補市場情報 MCP fetch run readiness gate:新增 `mcp_fetch_run_readiness` read-only builder、GET/POST endpoint、UI run readiness 審核面板與 deployment readiness smoke target,在 run package 後檢查 command preview、receipt path、artifact path、節流/timeout/dry-run-first 與操作員 shell-only 邊界;API/UI 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,只放行到人工 shell dry-run 與後續 receipt gate。 - V10.412 補市場情報 MCP fetch run package gate:新增 `mcp_fetch_run_package` read-only builder、route extension、GET/POST endpoint、UI run package 審核面板與 deployment readiness smoke target,將已通過的 target review 轉成操作員可覆核的 command argv preview 與 receipt path 契約;API/UI 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,只放行到後續 run readiness review。 - V10.409 補市場情報 MCP fetch target review gate:新增 `mcp_fetch_target_review` read-only builder、GET/POST endpoint、UI target review 審核面板與 deployment readiness smoke target,讓 manual fetch handoff 通過後,先人工審核 adapter registry 公開入口、每平台節流、樣本數、timeout 與 rollback plan;API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler,也不會自動打開 manual fetch。 - V10.405 補市場情報 MCP manual fetch handoff gate:新增 `mcp_manual_fetch_handoff` read-only builder、GET/POST endpoint、UI handoff package 審核面板與 deployment readiness smoke target,將 runtime promotion package 與操作員安全確認合併成「可進人工 fetch gate 審核」的交接收據;API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler,也不會自動打開 manual fetch。 diff --git a/config.py b/config.py index 8db8202..3c6cbbe 100644 --- a/config.py +++ b/config.py @@ -325,7 +325,7 @@ YOUTUBE_API_KEY = os.getenv('YOUTUBE_API_KEY', '') # ========================================== # 系統版本與路徑 # ========================================== -SYSTEM_VERSION = "V10.413" +SYSTEM_VERSION = "V10.414" LOG_FILE_PATH = os.path.join(BASE_DIR, 'logs/system.log') public_url = PUBLIC_URL # 用於模板顯示 diff --git a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md index 4dc630c..e307829 100644 --- a/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md +++ b/docs/adr/ADR-035-cross-platform-market-campaign-intelligence.md @@ -161,6 +161,7 @@ EwoooC 目前已有 MOMO EDM / 節慶活動資料、`promo_products`、PChome - 2026-05-24 追加 MCP manual fetch handoff gate:`services.market_intel.mcp_manual_fetch_handoff` 與 `/api/market_intel/mcp_manual_fetch_handoff` 將 runtime promotion package 與操作員安全確認合併成可審核 handoff,只放行到人工 fetch gate operator review;API/UI 不保存 payload、不打 health、不開 DB、不抓外站、不掛 scheduler,也不會自動打開 manual fetch。 - 2026-05-24 追加 MCP fetch target review gate:`services.market_intel.mcp_fetch_target_review` 與 `/api/market_intel/mcp_fetch_target_review` 在 manual fetch handoff 後審核 adapter registry 公開入口白名單、平台來源、每平台 delay / timeout / max pages / sample_limit、rollback plan 與操作員確認;API/UI 不保存 payload、不發外部 request、不開 DB、不寫入、不掛 scheduler,也不會自動打開 manual fetch,只放行到後續人工 fetch run package review。 - 2026-05-24 追加 MCP fetch run package gate:`services.market_intel.mcp_fetch_run_package` 與 `/api/market_intel/mcp_fetch_run_package` 將已通過的 target review 轉成 command argv preview、receipt path 與操作員 run controls 審核包;路由拆至 `routes.market_intel_mcp_run_routes`,主 Blueprint 僅掛 extension import。此階段不執行 CLI、不發外部 request、不寫 artifact、不開 DB、不掛 scheduler,只放行到後續 run readiness review。 +- 2026-05-24 追加 MCP fetch run readiness gate:`services.market_intel.mcp_fetch_run_readiness` 與 `/api/market_intel/mcp_fetch_run_readiness` 在 run package 後檢查 command preview、receipt path、artifact path、節流/timeout/dry-run-first、secret payload 與操作員 shell-only 邊界;此階段不執行 CLI、不發外部 request、不寫 artifact、不開 DB、不掛 scheduler,只放行到人工 shell dry-run 與後續 receipt review。 - 2026-05-18 追加 scheduler attach plan preview:`services.market_intel.scheduler_plan` 與 `/api/market_intel/scheduler_plan` 描述未來 `campaign_discovery_daily`、`campaign_product_probe`、`product_match_review_seed` 三個 job 的 cadence、gate、fallback 與安全邊界。此階段不註冊 scheduler job、不啟動 crawler、不連外、不寫 DB;排程掛載必須等 migration、seed、MCP fetch gate、manual sample 與人工批准全過。 - 2026-05-18 追加 match review plan preview:`services.market_intel.match_review_plan` 與 `/api/market_intel/match_review_plan` 定義商品比對訊號、分數門檻、`needs_review → confirmed/rejected` HITL 流程與安全邊界。此階段不建立 review queue、不自動 confirmed、不寫 `market_product_matches`、不呼叫 MCP;價格只能作為輔助訊號,不能單獨決定同品比對。 - 2026-05-18 追加 opportunity plan preview:`services.market_intel.opportunity_plan` 與 `/api/market_intel/opportunity_plan` 定義競品低價威脅、促銷缺口、深折重疊、活動即將結束四類規則與分級策略。此階段不建立 opportunity queue、不派送 Telegram、不產生 AI 摘要、不寫 DB;高風險項必須先有 confirmed match 與 DB evidence 才能升級。 diff --git a/docs/memory/code_modularization_inventory_20260430.md b/docs/memory/code_modularization_inventory_20260430.md index 6347ff1..59cee9b 100644 --- a/docs/memory/code_modularization_inventory_20260430.md +++ b/docs/memory/code_modularization_inventory_20260430.md @@ -40,6 +40,8 @@ - 2026-05-24 追記:同步市場情報 MCP manual fetch handoff gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增邏輯已放在獨立 `services/market_intel/mcp_manual_fetch_handoff.py`,route 僅保留薄 glue,下一個 MCP/UI gate 應優先拆出子 Blueprint 或 route registration helper。 - 2026-05-24 追記:同步市場情報 MCP fetch target review gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增邏輯已放在獨立 `services/market_intel/mcp_fetch_target_review.py`,route 僅保留薄 glue,後續市場情報 MCP route 應拆出子 Blueprint 或 route registration helper。 - 2026-05-24 追記:同步市場情報 MCP fetch run package gate 後的 `routes/market_intel_routes.py` 與 `services/market_intel/deployment_readiness.py` 行數;本次新增 endpoint 已拆到 `routes/market_intel_mcp_run_routes.py`,主 Blueprint 只新增 extension import,後續 MCP route 應延續此模式。 +- 2026-05-24 追記:同步市場情報 MCP fetch run readiness gate 後的 `services/market_intel/deployment_readiness.py` 行數;本次新增 endpoint 延續 `routes/market_intel_mcp_run_routes.py` route extension,新增邏輯放在獨立 `services/market_intel/mcp_fetch_run_readiness.py`。 +- 2026-05-24 追記:同步背景 Code Review 111 fallback 保護合併後的 `services/code_review_pipeline_service.py` 行數;此處只更新 inventory,不變更 Code Review 行為。 - 2026-05-21 追記:同步 PChome/LUDEYA 商品線名稱漂移比對更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 MAC/Yuskin/AHC 名稱漂移與 bundle equivalent matcher 更新後的 `services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 - 2026-05-21 追記:同步 EDM 失效頁 alert guard 與 REJURAN 唇膏寬價差 exact-identity matcher 更新後的 `scheduler.py`、`services/marketplace_product_matcher.py` 行數;此處只更新 inventory,不變更模組化決策。 @@ -77,7 +79,7 @@ | 865 | `routes/daily_sales_routes.py` | P2 Daily Sales Blueprint | route glue / export helpers / daily query and formatting service | | 961 | `services/ollama_service.py` | P2 Ollama client | host health / request client / fallback policy / response parsing | | 849 | `services/pchome_crawler.py` | P2 PChome crawler | search fetch / parsing / fallback source handling / rate limit policy | -| 1042 | `services/code_review_pipeline_service.py` | P2 Code review pipeline service | scan orchestration / finding normalization / persistence adapter | +| 1100 | `services/code_review_pipeline_service.py` | P2 Code review pipeline service | scan orchestration / finding normalization / persistence adapter | | 953 | `routes/export_routes.py` | P2 Export flow | export command/router glue / file path / download orchestration | | 816 | `services/ppt_vision_service.py` | P2 PPT vision QA service | runtime state / queue status / model probe / audit execution 分離 | | 2149 | `services/competitor_price_feeder.py` | P2 competitor price feeder | crawler scheduling / price normalization / retryable candidate recovery / cache strategy | @@ -85,7 +87,7 @@ | 805 | `routes/bot_api_routes.py` | P2 Bot API Blueprint | route glue / bot action service | | 1319 | `routes/market_intel_review_report_routes.py` | P2 market intel review report Blueprint | review report route glue / export payload / phase handoff orchestration | | 917 | `routes/market_intel_routes.py` | P2 market intel Blueprint | page route / API route glue / MCP gate route registration helper | -| 1009 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | +| 1040 | `services/market_intel/deployment_readiness.py` | P2 market intel deployment readiness | preflight gates / readiness payload / route contract helpers | | 846 | `services/market_intel/candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt.py` | P2 market intel review receipt pipeline | AI summary / persistence / Telegram dispatch / report catalog run receipt orchestration | ## 市場情報開發前置禁區 diff --git a/docs/memory/history_logs.md b/docs/memory/history_logs.md index 49132cd..0e0c477 100644 --- a/docs/memory/history_logs.md +++ b/docs/memory/history_logs.md @@ -13,6 +13,7 @@ ## 📅 詳細更新日誌 (考古存檔) ### 2026-05-24:PChome 近門檻身份回收第二輪 +- **V10.414 MCP fetch run readiness gate**: 新增 `mcp_fetch_run_readiness` read-only builder、GET/POST endpoint、UI run readiness 審核面板與 deployment readiness smoke target,在 run package 後檢查 command preview、receipt path、artifact path、節流/timeout/dry-run-first 與操作員 shell-only 邊界;API/UI 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,只放行到人工 shell dry-run 與後續 receipt gate。 - **V10.413 Code Review 預設保護 111 fallback**: production `ai_calls` 顯示 GCP-A 不可達時,Code Review OpenClaw 會先耗掉 primary timeout,再讓 GCP-B 撐到 60s,最後落到 111 `llama3.2` 成功,造成 111 與 GCP-B 高負載。新增 `CODE_REVIEW_ALLOW_111_FALLBACK=false` 預設:Code Review 的 Hermes LLM scan / OpenClaw assessment 只跑 GCP-A → GCP-B;只有明確設 true 才把部署後重分析丟給 111。若 GCP-A/GCP-B 都失敗且 Claude/Gemini 未顯式開啟,改回 deterministic 本地降級摘要,不呼叫 Gemini,也不再用 111 承接非即時重分析。 - **V10.412 MCP fetch run package gate**: 新增 `mcp_fetch_run_package` read-only builder、獨立 route extension、GET/POST endpoint、UI run package 審核面板與 deployment readiness smoke target,將已通過的 target review 轉成操作員可覆核的 command argv preview 與 receipt path 契約;API/UI 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler,只放行到後續 run readiness review。 - **V10.411 rom&nd / Summer’s Eve / Solone 近門檻 review-only 回收**: marketplace matcher 追加三條窄範圍 focused identity:rom&nd 果汁唇釉 2.0 catalog、Summer’s Eve 舒摩兒全肌防護浴潔露 2入、Solone 持久眼線筆;皆只進 `identity_review` / manual-review,不直接價格告警。production pilot 已回刷 3/3,`matched` 1616→1619、`true_low_confidence` 763→760;rom&nd 染眉膏 ZO&FRIENDS 色號、Summer’s Eve 雙天王任選、Lactacyd 清新舒涼 vs 生理呵護、MAC 柔霧 vs 緞光、NIVEA / 曼秀雷敦包數差異仍不自動救回,維持準確率優先。 diff --git a/routes/market_intel_mcp_run_routes.py b/routes/market_intel_mcp_run_routes.py index 7b0b1b5..b800ae5 100644 --- a/routes/market_intel_mcp_run_routes.py +++ b/routes/market_intel_mcp_run_routes.py @@ -10,6 +10,9 @@ from services.market_intel import MarketIntelService from services.market_intel.mcp_fetch_run_package import ( build_mcp_fetch_run_package_preview, ) +from services.market_intel.mcp_fetch_run_readiness import ( + build_mcp_fetch_run_readiness_preview, +) @market_intel_bp.route("/api/market_intel/mcp_fetch_run_package", methods=["GET", "POST"]) @@ -34,3 +37,39 @@ def market_intel_mcp_fetch_run_package(): phase=service.phase, ) ) + + +@market_intel_bp.route("/api/market_intel/mcp_fetch_run_readiness", methods=["GET", "POST"]) +@login_required +def market_intel_mcp_fetch_run_readiness(): + run_package = {} + run_package_result = None + operator_readiness = {} + if request.method == "POST": + payload = request.get_json(silent=True) or {} + package = payload.get("run_readiness") or payload.get("readiness_package") or payload + run_package = ( + package.get("run_package") + or package.get("fetch_run_package") + or package.get("run_package_payload") + or {} + ) + run_package_result = ( + package.get("run_package_result") + or package.get("mcp_fetch_run_package") + ) + operator_readiness = ( + package.get("operator_readiness") + or package.get("operator_run_readiness") + or {} + ) + + service = MarketIntelService() + return jsonify( + build_mcp_fetch_run_readiness_preview( + run_package=run_package, + run_package_result=run_package_result, + operator_readiness=operator_readiness, + phase=service.phase, + ) + ) diff --git a/services/market_intel/deployment_readiness.py b/services/market_intel/deployment_readiness.py index 549ee1f..0ca7ed6 100644 --- a/services/market_intel/deployment_readiness.py +++ b/services/market_intel/deployment_readiness.py @@ -66,6 +66,9 @@ from services.market_intel.mcp_fetch_target_review import ( from services.market_intel.mcp_fetch_run_package import ( build_mcp_fetch_run_package_preview, ) +from services.market_intel.mcp_fetch_run_readiness import ( + build_mcp_fetch_run_readiness_preview, +) from services.market_intel.mcp_manual_fetch_handoff import ( build_mcp_manual_fetch_handoff_preview, ) @@ -173,6 +176,11 @@ PRODUCTION_SMOKE_TARGETS = ( + ("/api/market_intel/mcp_fetch_run_package",) + PRODUCTION_SMOKE_TARGETS[-1:] ) +PRODUCTION_SMOKE_TARGETS = ( + PRODUCTION_SMOKE_TARGETS[:-1] + + ("/api/market_intel/mcp_fetch_run_readiness",) + + PRODUCTION_SMOKE_TARGETS[-1:] +) def _run_review_preview_safe(payload, mode): return bool(payload["mode"] == mode and all(not payload.get(key) for key in BLOCKED_RUN_REVIEW_KEYS)) def build_deployment_readiness_preview(*, service, market_intel_tables, schema_smoke_builder): @@ -203,6 +211,9 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s mcp_fetch_run_package = build_mcp_fetch_run_package_preview( phase=service.phase, ) + mcp_fetch_run_readiness = build_mcp_fetch_run_readiness_preview( + phase=service.phase, + ) scheduler_plan = service.build_scheduler_plan() manual_sample_plan = service.build_manual_sample_plan() manual_sample_acceptance = service.build_manual_sample_acceptance() @@ -495,6 +506,25 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s and not mcp_fetch_run_package["file_written"] and not mcp_fetch_run_package["scheduler_attached"] ), + "mcp_fetch_run_readiness_preview_safe": bool( + mcp_fetch_run_readiness["mode"] == "mcp_fetch_run_readiness_preview" + and not mcp_fetch_run_readiness["payload_persisted"] + and not mcp_fetch_run_readiness["run_readiness_persisted"] + and not mcp_fetch_run_readiness["run_readiness_artifact_created"] + and not mcp_fetch_run_readiness["run_readiness_file_written"] + and not mcp_fetch_run_readiness["receipt_file_written"] + and not mcp_fetch_run_readiness["manual_fetch_gate_opened_by_api"] + and not mcp_fetch_run_readiness["network_request_allowed"] + and not mcp_fetch_run_readiness["api_executes_cli"] + and not mcp_fetch_run_readiness["api_opens_database_connection"] + and not mcp_fetch_run_readiness["api_writes_database"] + and not mcp_fetch_run_readiness["api_uses_external_network"] + and not mcp_fetch_run_readiness["database_write_executed"] + and not mcp_fetch_run_readiness["fetch_executed"] + and not mcp_fetch_run_readiness["cli_executed"] + and not mcp_fetch_run_readiness["file_written"] + and not mcp_fetch_run_readiness["scheduler_attached"] + ), "scheduler_plan_preview_safe": bool( scheduler_plan["mode"] == "scheduler_attach_plan_preview" and not scheduler_plan["scheduler_registration_executed"] @@ -932,6 +962,7 @@ def build_deployment_readiness_preview(*, service, market_intel_tables, schema_s "mcp_manual_fetch_handoff": mcp_manual_fetch_handoff, "mcp_fetch_target_review": mcp_fetch_target_review, "mcp_fetch_run_package": mcp_fetch_run_package, + "mcp_fetch_run_readiness": mcp_fetch_run_readiness, "scheduler_plan": scheduler_plan, "manual_sample_plan": manual_sample_plan, "manual_sample_acceptance": manual_sample_acceptance, diff --git a/services/market_intel/mcp_fetch_run_readiness.py b/services/market_intel/mcp_fetch_run_readiness.py new file mode 100644 index 0000000..667bd31 --- /dev/null +++ b/services/market_intel/mcp_fetch_run_readiness.py @@ -0,0 +1,518 @@ +"""市場情報 MCP manual fetch run readiness preview。 + +本模組只檢查上一段 run package 是否可交給操作員 shell 手動 dry-run; +不執行 CLI、不發 HTTP request、不寫檔、不開 DB、不掛 scheduler。 +""" + +from services.market_intel.mcp_fetch_run_package import ( + MAX_TOTAL_REQUESTS, + RUN_ARTIFACT_DIR_PREFIX, + build_mcp_fetch_run_package_preview, +) + + +FORBIDDEN_SECRET_KEYS = ( + "approval_token", + "approval-token", + "api_key", + "authorization", + "bearer", + "client_secret", + "cookie", + "password", + "session_cookie", +) + +_BLOCKED_SIDE_EFFECT_KEYS = ( + "allow_api_execution", + "allow_database_write", + "allow_external_network_in_api", + "allow_scheduler_attach", + "api_executes_cli", + "api_executes_docker", + "api_executes_health_check", + "api_executes_ssh", + "api_opens_database_connection", + "api_uses_external_network", + "api_writes_database", + "attach_scheduler", + "cli_executed", + "command_executed", + "database_commit_executed", + "database_session_created", + "database_write_executed", + "external_network_executed", + "fetch_executed", + "file_written", + "manual_fetch_gate_opened_by_api", + "network_request_allowed", + "package_artifact_created", + "ready_for_manual_fetch_operator_run", + "receipt_file_written", + "run_package_persisted", + "run_readiness_artifact_created", + "run_readiness_file_written", + "run_readiness_persisted", + "scheduler_attached", + "write_database", + "writes_executed", + "would_write_database", +) + + +def _as_dict(value): + return value if isinstance(value, dict) else {} + + +def _as_list(value): + if value is None: + return [] + if isinstance(value, (list, tuple, set)): + return list(value) + return [value] + + +def _has_text(value): + return bool(isinstance(value, str) and value.strip()) + + +def _safe_text(value, limit=500): + if value is None: + return None + text = str(value).strip() + return text[:limit] if text else None + + +def _safe_artifact_path(value, *, require_json=False): + if not isinstance(value, str): + return False + normalized = value.strip().replace("\\", "/") + if not normalized or normalized.startswith("/"): + return False + parts = [part for part in normalized.split("/") if part] + if any(part in (".", "..") for part in parts): + return False + if not normalized.startswith(RUN_ARTIFACT_DIR_PREFIX): + return False + return not require_json or normalized.endswith(".json") + + +def _contains_forbidden_secret_key(value): + if isinstance(value, dict): + for key, nested in value.items(): + normalized_key = str(key).lower() + if any(secret_key in normalized_key for secret_key in FORBIDDEN_SECRET_KEYS): + return True + if _contains_forbidden_secret_key(nested): + return True + elif isinstance(value, list): + return any(_contains_forbidden_secret_key(item) for item in value) + return False + + +def _blocked_side_effects(payload): + found = [] + + def visit(value, path): + if isinstance(value, dict): + for key, item in value.items(): + key_path = f"{path}.{key}" if path else key + if key in _BLOCKED_SIDE_EFFECT_KEYS and bool(item): + found.append(key_path) + visit(item, key_path) + elif isinstance(value, list): + for index, item in enumerate(value): + visit(item, f"{path}[{index}]") + + visit(payload, "") + return found + + +def _run_package_from_inputs(run_package, run_package_result, phase): + if isinstance(run_package_result, dict) and run_package_result: + return run_package_result + + run_package = _as_dict(run_package) + return build_mcp_fetch_run_package_preview( + target_review_package=run_package.get("target_review_package", {}), + target_review_result=run_package.get("target_review_result"), + operator_run_controls=run_package.get("operator_run_controls", {}), + phase=phase, + ) + + +def _sample_run_readiness_package(): + package_preview = build_mcp_fetch_run_package_preview() + run_package = package_preview["sample_run_package"] + run_package_result = build_mcp_fetch_run_package_preview( + target_review_package=run_package["target_review_package"], + operator_run_controls=run_package["operator_run_controls"], + ) + artifact_dir = run_package_result.get("artifact_dir") or ( + RUN_ARTIFACT_DIR_PREFIX + "sample_market_intel_manual_fetch" + ) + operator_readiness = { + "run_readiness_artifact_path": f"{artifact_dir}/run_readiness_review.json", + "dry_run_receipt_path": f"{artifact_dir}/dry_run_receipt.json", + "command_previews_reviewed": True, + "receipt_paths_reviewed": True, + "artifact_dir_reviewed": True, + "rate_limit_confirmed": True, + "timeout_confirmed": True, + "stop_on_error_confirmed": True, + "dry_run_first_confirmed": True, + "shell_only_confirmed": True, + "external_network_shell_only_confirmed": True, + "receipt_review_next_confirmed": True, + "operator_confirmed_no_secret_payload": True, + "operator_confirmed_no_api_execution": True, + "operator_confirmed_no_database_write": True, + "operator_confirmed_no_scheduler_attach": True, + } + return { + "run_package": run_package, + "run_package_result": run_package_result, + "operator_readiness": operator_readiness, + } + + +def _command_summary(run_package_result): + commands = [_as_dict(item) for item in _as_list( + run_package_result.get("command_previews") + )] + return { + "command_count": len(commands), + "receipt_path_count": sum( + 1 for item in commands + if _has_text(item.get("receipt_path")) + ), + "receipt_paths_safe": bool( + commands + and all( + _safe_artifact_path(item.get("receipt_path"), require_json=True) + for item in commands + ) + ), + "argv_preview_count": sum( + 1 for item in commands + if isinstance(item.get("argv_preview"), list) + ), + "all_have_dry_run_first": bool( + commands + and all("--dry-run-first" in _as_list(item.get("argv_preview")) for item in commands) + ), + "commands_executed_by_api": any( + item.get("command_executed") + or item.get("external_network_executed_by_api") + or item.get("receipt_written_by_api") + for item in commands + ), + "commands": [ + { + "platform_code": item.get("platform_code"), + "source_key": item.get("source_key"), + "receipt_path": item.get("receipt_path"), + "argv_preview": item.get("argv_preview"), + "ready_for_operator_shell": False, + "command_executed": bool(item.get("command_executed")), + "external_network_executed_by_api": bool( + item.get("external_network_executed_by_api") + ), + "receipt_written_by_api": bool(item.get("receipt_written_by_api")), + } + for item in commands + ], + } + + +def _package_summary(run_package_result): + command_summary = _command_summary(run_package_result) + return { + "mode": run_package_result.get("mode"), + "accepted": bool(run_package_result.get("mcp_fetch_run_package_accepted")), + "ready_for_manual_fetch_run_readiness_review": bool( + run_package_result.get("ready_for_manual_fetch_run_readiness_review") + ), + "ready_for_manual_fetch_operator_run": bool( + run_package_result.get("ready_for_manual_fetch_operator_run") + ), + "artifact_dir": run_package_result.get("artifact_dir"), + "artifact_dir_safe": bool(run_package_result.get("artifact_dir_safe")), + "max_total_requests": run_package_result.get("max_total_requests"), + "stop_after_error_count": run_package_result.get("stop_after_error_count"), + "blocked_reasons": run_package_result.get("blocked_reasons", []), + "side_effects_clear": not _blocked_side_effects(run_package_result), + **command_summary, + } + + +def _operator_summary(operator_readiness): + operator_readiness = _as_dict(operator_readiness) + return { + "provided_keys": sorted(operator_readiness.keys()), + "run_readiness_artifact_path": _safe_text( + operator_readiness.get("run_readiness_artifact_path") + ), + "dry_run_receipt_path": _safe_text( + operator_readiness.get("dry_run_receipt_path") + ), + "run_readiness_artifact_path_safe": _safe_artifact_path( + operator_readiness.get("run_readiness_artifact_path"), + require_json=True, + ), + "dry_run_receipt_path_safe": _safe_artifact_path( + operator_readiness.get("dry_run_receipt_path"), + require_json=True, + ), + "command_previews_reviewed": bool( + operator_readiness.get("command_previews_reviewed") + ), + "receipt_paths_reviewed": bool( + operator_readiness.get("receipt_paths_reviewed") + ), + "artifact_dir_reviewed": bool( + operator_readiness.get("artifact_dir_reviewed") + ), + "rate_limit_confirmed": bool( + operator_readiness.get("rate_limit_confirmed") + ), + "timeout_confirmed": bool(operator_readiness.get("timeout_confirmed")), + "stop_on_error_confirmed": bool( + operator_readiness.get("stop_on_error_confirmed") + ), + "dry_run_first_confirmed": bool( + operator_readiness.get("dry_run_first_confirmed") + ), + "shell_only_confirmed": bool( + operator_readiness.get("shell_only_confirmed") + ), + "external_network_shell_only_confirmed": bool( + operator_readiness.get("external_network_shell_only_confirmed") + ), + "receipt_review_next_confirmed": bool( + operator_readiness.get("receipt_review_next_confirmed") + ), + "operator_confirmed_no_secret_payload": bool( + operator_readiness.get("operator_confirmed_no_secret_payload") + ), + "operator_confirmed_no_api_execution": bool( + operator_readiness.get("operator_confirmed_no_api_execution") + ), + "operator_confirmed_no_database_write": bool( + operator_readiness.get("operator_confirmed_no_database_write") + ), + "operator_confirmed_no_scheduler_attach": bool( + operator_readiness.get("operator_confirmed_no_scheduler_attach") + ), + "secret_or_token_submitted_to_api": _contains_forbidden_secret_key( + operator_readiness + ), + "blocked_side_effects": _blocked_side_effects(operator_readiness), + } + + +def _readiness_gates(*, run_package_received, package, operator): + operator_confirmed_review = bool( + operator["command_previews_reviewed"] + and operator["receipt_paths_reviewed"] + and operator["artifact_dir_reviewed"] + ) + operator_confirmed_runtime_limits = bool( + operator["rate_limit_confirmed"] + and operator["timeout_confirmed"] + and operator["stop_on_error_confirmed"] + and operator["dry_run_first_confirmed"] + ) + operator_confirmed_boundaries = bool( + operator["shell_only_confirmed"] + and operator["external_network_shell_only_confirmed"] + and operator["receipt_review_next_confirmed"] + and operator["operator_confirmed_no_secret_payload"] + and operator["operator_confirmed_no_api_execution"] + and operator["operator_confirmed_no_database_write"] + and operator["operator_confirmed_no_scheduler_attach"] + ) + return [ + { + "key": "run_package_payload_or_result_received", + "label": "已提供 run package payload 或已審核結果", + "passed": run_package_received, + }, + { + "key": "run_package_accepted", + "label": "run package gate 已通過", + "passed": package["accepted"], + }, + { + "key": "run_package_ready_for_readiness_review", + "label": "run package 只放行到 run readiness review", + "passed": package["ready_for_manual_fetch_run_readiness_review"], + }, + { + "key": "run_package_did_not_open_operator_run", + "label": "前一階段不得自行打開 operator run", + "passed": not package["ready_for_manual_fetch_operator_run"], + }, + { + "key": "command_preview_count_within_limit", + "label": "command preview 數量必須介於 1 與全域安全上限", + "passed": bool(0 < package["command_count"] <= MAX_TOTAL_REQUESTS), + }, + { + "key": "command_previews_not_executed_by_api", + "label": "command preview 尚未由 API 執行或寫 receipt", + "passed": not package["commands_executed_by_api"], + }, + { + "key": "command_receipt_paths_safe", + "label": "所有 receipt path 都限定於 market intel manual fetch 目錄", + "passed": package["receipt_paths_safe"], + }, + { + "key": "command_previews_keep_dry_run_first", + "label": "所有命令預覽都保留 dry-run-first", + "passed": package["all_have_dry_run_first"], + }, + { + "key": "run_package_side_effect_free", + "label": "run package 結果未夾帶 API 執行、DB、寫檔或 scheduler 副作用", + "passed": package["side_effects_clear"], + }, + { + "key": "operator_readiness_received", + "label": "已提供操作員 readiness 證據", + "passed": bool(operator["provided_keys"]), + }, + { + "key": "run_readiness_artifact_path_safe", + "label": "run readiness artifact path 合法且為 JSON", + "passed": operator["run_readiness_artifact_path_safe"], + }, + { + "key": "dry_run_receipt_path_safe", + "label": "dry-run receipt path 合法且為 JSON", + "passed": operator["dry_run_receipt_path_safe"], + }, + { + "key": "operator_confirmed_command_and_receipt_review", + "label": "操作員已覆核 command preview、receipt path 與 artifact 目錄", + "passed": operator_confirmed_review, + }, + { + "key": "operator_confirmed_runtime_limits", + "label": "操作員已確認節流、timeout、錯誤停止與 dry-run-first", + "passed": operator_confirmed_runtime_limits, + }, + { + "key": "operator_confirmed_shell_only_boundaries", + "label": "操作員確認 shell-only、無 secret、無 API/DB/scheduler 副作用", + "passed": operator_confirmed_boundaries, + }, + { + "key": "secret_or_token_not_submitted_to_api", + "label": "readiness payload 不得包含 secret、cookie、password 或 token key", + "passed": not operator["secret_or_token_submitted_to_api"], + }, + { + "key": "operator_readiness_side_effect_free", + "label": "operator readiness payload 不得要求 API 執行、連外、寫檔或寫 DB", + "passed": not operator["blocked_side_effects"], + }, + ] + + +def build_mcp_fetch_run_readiness_preview( + *, + run_package=None, + run_package_result=None, + operator_readiness=None, + phase=None, +): + """建立 manual fetch run readiness review;不執行任何抓取。""" + run_package = _as_dict(run_package) + run_package_result_received = bool( + isinstance(run_package_result, dict) and run_package_result + ) + operator_readiness = _as_dict(operator_readiness) + run_package_result = _run_package_from_inputs( + run_package, + run_package_result, + phase, + ) + run_readiness_payload_received = bool( + run_package or run_package_result_received or operator_readiness + ) + run_package_received = bool(run_package or run_package_result_received) + package = _package_summary(run_package_result) + operator = _operator_summary(operator_readiness) + gates = _readiness_gates( + run_package_received=run_package_received, + package=package, + operator=operator, + ) + blocked_reasons = [gate["key"] for gate in gates if not gate["passed"]] + accepted = bool(run_readiness_payload_received and not blocked_reasons) + command_readiness = [ + { + **command, + "ready_for_operator_shell": accepted, + } + for command in package["commands"] + ] + + return { + "mode": ( + "mcp_fetch_run_readiness_review" + if run_readiness_payload_received + else "mcp_fetch_run_readiness_preview" + ), + "phase": phase, + "run_readiness_payload_received": run_readiness_payload_received, + "run_package_received": run_package_received, + "run_package_accepted": package["accepted"], + "operator_readiness_received": bool(operator["provided_keys"]), + "mcp_fetch_run_readiness_accepted": accepted, + "run_readiness_ready": accepted, + "ready_for_manual_fetch_operator_run": accepted, + "ready_for_manual_fetch_run_receipt_gate": accepted, + "manual_fetch_gate_opened_by_api": False, + "network_request_allowed": False, + "operator_shell_external_network_required": accepted, + "fetch_executed": False, + "cli_executed": False, + "database_write_executed": False, + "scheduler_attached": False, + "command_readiness_count": len(command_readiness), + "gate_count": len(gates), + "passed_gate_count": sum(1 for gate in gates if gate["passed"]), + "blocked_reasons": blocked_reasons, + "gates": gates, + "run_package_summary": package, + "operator_readiness_summary": operator, + "command_readiness": command_readiness, + "sample_run_readiness_package": _sample_run_readiness_package(), + "next_operator_steps": [ + "readiness 通過後,操作員才可在 shell 依 argv preview 執行 dry-run fetch", + "每個來源都必須保存 receipt JSON,再回貼到下一個 receipt review gate", + "API/UI 仍不得執行 CLI、不得抓外站、不得寫檔、不得開 DB、不得掛 scheduler", + ], + "payload_persisted": False, + "run_readiness_persisted": False, + "run_readiness_artifact_created": False, + "run_readiness_file_written": False, + "receipt_file_written": False, + "run_receipt_file_written": False, + "api_executes_health_check": False, + "api_executes_docker": False, + "api_executes_ssh": False, + "api_executes_cli": False, + "api_opens_database_connection": False, + "api_writes_database": False, + "api_uses_external_network": False, + "database_session_created": False, + "database_commit_executed": False, + "external_network_executed": False, + "file_written": False, + "writes_executed": False, + "would_write_database": False, + } diff --git a/services/market_intel/phase.py b/services/market_intel/phase.py index 41a553e..2126a83 100644 --- a/services/market_intel/phase.py +++ b/services/market_intel/phase.py @@ -1,3 +1,3 @@ """市場情報 rollout phase 單一來源。""" -MARKET_INTEL_PHASE = "phase_122_market_intel_mcp_fetch_run_package" +MARKET_INTEL_PHASE = "phase_123_market_intel_mcp_fetch_run_readiness" diff --git a/templates/market_intel/disabled.html b/templates/market_intel/disabled.html index a4903fd..098cc36 100644 --- a/templates/market_intel/disabled.html +++ b/templates/market_intel/disabled.html @@ -708,6 +708,32 @@ +
+
+
+

MCP / FETCH RUN READINESS

+

MCP Fetch Run Readiness 審核

+
+ +
+
+ loading +
+
+
讀取 MCP Fetch Run Readiness 審核中...
+
+
+ +
+ +
+
+
+
@@ -1218,6 +1244,7 @@ const mcpManualFetchHandoffRoot = document.querySelector('[data-market-intel-mcp-manual-fetch-handoff]'); const mcpFetchTargetReviewRoot = document.querySelector('[data-market-intel-mcp-fetch-target-review]'); const mcpFetchRunPackageRoot = document.querySelector('[data-market-intel-mcp-fetch-run-package]'); + const mcpFetchRunReadinessRoot = document.querySelector('[data-market-intel-mcp-fetch-run-readiness]'); const manualSampleRoot = document.querySelector('[data-market-intel-manual-sample]'); const sampleAcceptanceRoot = document.querySelector('[data-market-intel-sample-acceptance]'); const sampleReviewRoot = document.querySelector('[data-market-intel-sample-review]'); @@ -1234,7 +1261,7 @@ const liveInventoryRoot = document.querySelector('[data-market-intel-live-inventory]'); const approvalRoot = document.querySelector('[data-market-intel-approval]'); const deployRoot = document.querySelector('[data-market-intel-deploy]'); - if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; + if (!root && !writerRoot && !cliRoot && !dbProbeRoot && !seedDiffRoot && !legacyBridgeRoot && !mcpReadinessRoot && !mcpPreflightRoot && !mcpActivationRoot && !mcpFetchGateRoot && !mcpCompletionRoot && !mcpActivationEvidenceRoot && !mcpRuntimeSmokeRoot && !mcpRuntimePromotionRoot && !mcpManualFetchHandoffRoot && !mcpFetchTargetReviewRoot && !mcpFetchRunPackageRoot && !mcpFetchRunReadinessRoot && !manualSampleRoot && !sampleAcceptanceRoot && !sampleReviewRoot && !schedulerRoot && !matchReviewRoot && !opportunityRoot && !opportunityScoringRoot && !opportunityEvidenceRoot && !opportunityAlertRoot && !migrationRoot && !migrationDrillRoot && !catalogReviewRoot && !liveSmokeRoot && !liveInventoryRoot && !approvalRoot && !deployRoot) return; const meta = root ? root.querySelector('[data-market-intel-preview-meta]') : null; const body = root ? root.querySelector('[data-market-intel-preview-body]') : null; @@ -1317,6 +1344,12 @@ const mcpFetchRunPackageReview = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-review]') : null; const mcpFetchRunPackageRefresh = mcpFetchRunPackageRoot ? mcpFetchRunPackageRoot.querySelector('[data-market-intel-mcp-fetch-run-package-refresh]') : null; const mcpFetchRunPackageEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_run_package') }}"; + const mcpFetchRunReadinessMeta = mcpFetchRunReadinessRoot ? mcpFetchRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-run-readiness-meta]') : null; + const mcpFetchRunReadinessBody = mcpFetchRunReadinessRoot ? mcpFetchRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-run-readiness-body]') : null; + const mcpFetchRunReadinessInput = mcpFetchRunReadinessRoot ? mcpFetchRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-run-readiness-input]') : null; + const mcpFetchRunReadinessReview = mcpFetchRunReadinessRoot ? mcpFetchRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-run-readiness-review]') : null; + const mcpFetchRunReadinessRefresh = mcpFetchRunReadinessRoot ? mcpFetchRunReadinessRoot.querySelector('[data-market-intel-mcp-fetch-run-readiness-refresh]') : null; + const mcpFetchRunReadinessEndpoint = "{{ url_for('market_intel.market_intel_mcp_fetch_run_readiness') }}"; const manualSampleMeta = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-meta]') : null; const manualSampleBody = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-body]') : null; const manualSampleRefresh = manualSampleRoot ? manualSampleRoot.querySelector('[data-market-intel-manual-sample-refresh]') : null; @@ -2992,6 +3025,134 @@ } }; + const renderMcpFetchRunReadinessMeta = data => { + mcpFetchRunReadinessMeta.innerHTML = [ + `mode=${data.mode || 'unknown'}`, + `accepted=${data.mcp_fetch_run_readiness_accepted ? 'yes' : 'no'}`, + `gates=${data.passed_gate_count || 0}/${data.gate_count || 0}`, + `commands=${data.command_readiness_count || 0}`, + `operator=${data.ready_for_manual_fetch_operator_run ? 'ready' : 'blocked'}`, + `api_network=${data.network_request_allowed ? 'open' : 'closed'}` + ].map(item => `${escapeHtml(item)}`).join(''); + }; + + const renderMcpFetchRunReadinessBody = data => { + const blockers = (data.blocked_reasons || []).join(' / '); + const gates = data.gates || []; + const commands = data.command_readiness || []; + const operator = data.operator_readiness_summary || {}; + const packageSummary = data.run_package_summary || {}; + const steps = data.next_operator_steps || []; + const renderCheck = (key, label, status) => ` +
+
+ ${escapeHtml(key)} + ${escapeHtml(label || '')} +
+ ${escapeHtml(status)} +
+ `; + mcpFetchRunReadinessBody.innerHTML = ` +
此 readiness 只檢查人工 shell dry-run fetch 前置條件;API 不執行 CLI、不抓外站、不寫檔、不開 DB、不掛 scheduler。${blockers ? `阻擋:${escapeHtml(blockers)}` : ''}
+
+
+

READINESS GATES

+
${ + gates.length + ? gates.map(item => renderCheck(item.key, item.label, item.passed ? 'PASS' : 'BLOCK')).join('') + : '
尚未提供 readiness gates。
' + }
+
+
+

OPERATOR EVIDENCE

+
+ ${renderCheck('run_readiness_path', operator.run_readiness_artifact_path || 'missing', operator.run_readiness_artifact_path_safe ? 'SAFE' : 'BLOCK')} + ${renderCheck('dry_run_receipt_path', operator.dry_run_receipt_path || 'missing', operator.dry_run_receipt_path_safe ? 'SAFE' : 'BLOCK')} + ${renderCheck('command_review', `keys=${(operator.provided_keys || []).length}`, operator.command_previews_reviewed ? 'REVIEWED' : 'PENDING')} + ${renderCheck('secret_payload', 'no secret/cookie/password key submitted to API', operator.secret_or_token_submitted_to_api ? 'BLOCK' : 'CLEAR')} +
+
+
+

COMMAND READINESS

+
${ + commands.length + ? commands.map(item => renderCheck( + `${item.platform_code || 'unknown'}:${item.source_key || 'source'}`, + `${item.receipt_path || 'no receipt'} / argv=${(item.argv_preview || []).length}`, + item.ready_for_operator_shell ? 'SHELL' : 'PREVIEW' + )).join('') + : '
尚未產生命令 readiness。
' + }
+
+
+

PACKAGE / NEXT

+
+ ${renderCheck( + 'run_package', + `${packageSummary.command_count || 0} commands / receipts=${packageSummary.receipt_path_count || 0}`, + packageSummary.accepted ? 'ACCEPTED' : 'PENDING' + )} + ${renderCheck( + 'api_boundary', + 'no CLI / no external request / no file / no DB / no scheduler', + data.api_executes_cli ? 'BLOCK' : 'CLOSED' + )} + ${steps.map((item, index) => renderCheck(`step_${index + 1}`, item, 'MANUAL')).join('')} +
+
+
+ `; + if (mcpFetchRunReadinessInput && !mcpFetchRunReadinessInput.value.trim() && data.sample_run_readiness_package) { + mcpFetchRunReadinessInput.value = JSON.stringify(data.sample_run_readiness_package, null, 2); + } + }; + + const loadMcpFetchRunReadiness = async () => { + if (!mcpFetchRunReadinessMeta || !mcpFetchRunReadinessBody) return; + mcpFetchRunReadinessBody.innerHTML = '
讀取 MCP Fetch Run Readiness 審核中...
'; + try { + const response = await fetch(mcpFetchRunReadinessEndpoint, { credentials: 'same-origin' }); + if (!response.ok) throw new Error(`HTTP ${response.status}`); + const data = await response.json(); + renderMcpFetchRunReadinessMeta(data); + renderMcpFetchRunReadinessBody(data); + } catch (error) { + mcpFetchRunReadinessMeta.innerHTML = 'error'; + mcpFetchRunReadinessBody.innerHTML = `
MCP Fetch Run Readiness 審核讀取失敗:${escapeHtml(error.message)}
`; + } + }; + + const reviewMcpFetchRunReadiness = async () => { + if (!mcpFetchRunReadinessMeta || !mcpFetchRunReadinessBody || !mcpFetchRunReadinessInput) return; + let parsed; + try { + parsed = JSON.parse(mcpFetchRunReadinessInput.value || '{}'); + } catch (error) { + mcpFetchRunReadinessMeta.innerHTML = 'json_error'; + mcpFetchRunReadinessBody.innerHTML = `
JSON 格式錯誤:${escapeHtml(error.message)}
`; + return; + } + mcpFetchRunReadinessBody.innerHTML = '
審核 MCP Fetch Run Readiness 中...
'; + try { + const response = await fetch(mcpFetchRunReadinessEndpoint, { + method: 'POST', + credentials: 'same-origin', + headers: { + 'Content-Type': 'application/json', + 'X-CSRFToken': csrfToken + }, + body: JSON.stringify({ run_readiness: parsed }) + }); + const data = await response.json(); + if (!response.ok && !data.mode) throw new Error(`HTTP ${response.status}`); + renderMcpFetchRunReadinessMeta(data); + renderMcpFetchRunReadinessBody(data); + } catch (error) { + mcpFetchRunReadinessMeta.innerHTML = 'error'; + mcpFetchRunReadinessBody.innerHTML = `
MCP Fetch Run Readiness 審核失敗:${escapeHtml(error.message)}
`; + } + }; + const renderManualSampleMeta = data => { manualSampleMeta.innerHTML = [ `mode=${data.mode || 'unknown'}`, @@ -12431,6 +12592,12 @@ if (mcpFetchRunPackageReview) { mcpFetchRunPackageReview.addEventListener('click', reviewMcpFetchRunPackage); } + if (mcpFetchRunReadinessRefresh) { + mcpFetchRunReadinessRefresh.addEventListener('click', loadMcpFetchRunReadiness); + } + if (mcpFetchRunReadinessReview) { + mcpFetchRunReadinessReview.addEventListener('click', reviewMcpFetchRunReadiness); + } if (manualSampleRefresh) { manualSampleRefresh.addEventListener('click', loadManualSample); } @@ -12691,6 +12858,7 @@ loadMcpManualFetchHandoff(); loadMcpFetchTargetReview(); loadMcpFetchRunPackage(); + loadMcpFetchRunReadiness(); loadManualSample(); loadSampleAcceptance(); loadSampleReview(); diff --git a/tests/test_market_intel_skeleton.py b/tests/test_market_intel_skeleton.py index 7eb8630..acd0f17 100644 --- a/tests/test_market_intel_skeleton.py +++ b/tests/test_market_intel_skeleton.py @@ -23,6 +23,9 @@ from services.market_intel.mcp_fetch_gate import build_mcp_fetch_gate_preview from services.market_intel.mcp_fetch_run_package import ( build_mcp_fetch_run_package_preview, ) +from services.market_intel.mcp_fetch_run_readiness import ( + build_mcp_fetch_run_readiness_preview, +) from services.market_intel.mcp_fetch_target_review import ( build_mcp_fetch_target_review_preview, ) @@ -973,6 +976,12 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint(): assert "data-market-intel-mcp-fetch-run-package-gates" in template assert "data-market-intel-mcp-fetch-run-package-commands" in template assert "data-market-intel-mcp-fetch-run-package-next" in template + assert "market_intel.market_intel_mcp_fetch_run_readiness" in template + assert "data-market-intel-mcp-fetch-run-readiness" in template + assert "data-market-intel-mcp-fetch-run-readiness-gates" in template + assert "data-market-intel-mcp-fetch-run-readiness-operator" in template + assert "data-market-intel-mcp-fetch-run-readiness-commands" in template + assert "data-market-intel-mcp-fetch-run-readiness-next" in template assert "market_intel.market_intel_manual_sample_plan" in template assert "market_intel.market_intel_manual_sample_acceptance" in template assert "market_intel.market_intel_manual_sample_review" in template @@ -1443,7 +1452,7 @@ def test_legacy_source_bridge_default_is_planned_only(): bridge = MarketIntelService().build_legacy_source_bridge() assert bridge["mode"] == "legacy_source_bridge_planned" - assert bridge["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert bridge["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert bridge["execute_requested"] is False assert bridge["read_only_query_executed"] is False assert bridge["database_connection_opened"] is False @@ -1601,7 +1610,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted(): contract = MarketIntelService().build_mcp_tool_contract() assert contract["mode"] == "mcp_tool_contract_preview" - assert contract["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert contract["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert contract["caller"] == "market_intel" assert contract["contract_ready"] is True assert contract["blocked_reasons"] == [] @@ -1734,7 +1743,7 @@ def test_mcp_activation_runbook_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_activation_runbook_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -1747,7 +1756,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch(): gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True) assert gate["mode"] == "mcp_fetch_gate_planned" - assert gate["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert gate["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert gate["fetch_requested"] is True assert gate["manual_fetch_gate_open"] is False assert gate["network_request_allowed"] is False @@ -1817,7 +1826,7 @@ def test_mcp_fetch_gate_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_fetch_gate_planned" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["fetch_requested"] is False assert data["network_request_allowed"] is False assert data["external_network_executed"] is False @@ -1831,7 +1840,7 @@ def test_mcp_completion_audit_summarizes_external_and_internal_state(monkeypatch audit = MarketIntelService().build_mcp_completion_audit() assert audit["mode"] == "mcp_completion_audit_preview" - assert audit["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert audit["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert audit["audit_ready_for_operator_review"] is True assert audit["audit_preview_safe"] is True assert audit["external_mcp_runtime_complete"] is False @@ -1905,7 +1914,7 @@ def test_mcp_completion_audit_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_completion_audit_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["audit_preview_safe"] is True assert data["external_mcp_runtime_complete"] is False assert data["internal_mcp_contract_complete"] is True @@ -1922,11 +1931,11 @@ def test_mcp_completion_audit_route_is_preview_only(): def test_mcp_activation_evidence_preview_is_safe_without_payload(): evidence = build_mcp_activation_evidence_preview( - phase="phase_122_market_intel_mcp_fetch_run_package" + phase="phase_123_market_intel_mcp_fetch_run_readiness" ) assert evidence["mode"] == "mcp_activation_evidence_preview" - assert evidence["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert evidence["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert evidence["evidence_payload_received"] is False assert evidence["activation_evidence_accepted"] is False assert evidence["ready_for_runtime_promotion"] is False @@ -1951,7 +1960,7 @@ def test_mcp_activation_evidence_accepts_redacted_runtime_evidence(): ] evidence = build_mcp_activation_evidence_preview( evidence=sample, - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert evidence["mode"] == "mcp_activation_evidence_review" @@ -2009,12 +2018,12 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_activation_evidence_preview" - assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_activation_evidence_review" - assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert post_data["activation_evidence_accepted"] is True assert post_data["payload_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2023,11 +2032,11 @@ def test_mcp_activation_evidence_route_get_and_post_are_preview_only(): def test_mcp_runtime_smoke_receipt_preview_is_safe_without_payload(): receipt = build_mcp_runtime_smoke_receipt_preview( - phase="phase_122_market_intel_mcp_fetch_run_package" + phase="phase_123_market_intel_mcp_fetch_run_readiness" ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_preview" - assert receipt["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert receipt["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert receipt["receipt_payload_received"] is False assert receipt["runtime_smoke_receipt_accepted"] is False assert receipt["ready_for_completion_runtime_promotion"] is False @@ -2055,7 +2064,7 @@ def test_mcp_runtime_smoke_receipt_accepts_complete_readiness_receipt(): ] receipt = build_mcp_runtime_smoke_receipt_preview( receipt=sample, - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert receipt["mode"] == "mcp_runtime_smoke_receipt_review" @@ -2120,12 +2129,12 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_smoke_receipt_preview" - assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_smoke_receipt_review" - assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert post_data["runtime_smoke_receipt_accepted"] is True assert post_data["receipt_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2134,11 +2143,11 @@ def test_mcp_runtime_smoke_receipt_route_get_and_post_are_preview_only(): def test_mcp_runtime_promotion_preview_is_safe_without_payload(): promotion = build_mcp_runtime_promotion_preview( - phase="phase_122_market_intel_mcp_fetch_run_package" + phase="phase_123_market_intel_mcp_fetch_run_readiness" ) assert promotion["mode"] == "mcp_runtime_promotion_preview" - assert promotion["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert promotion["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert promotion["promotion_payload_received"] is False assert promotion["runtime_promotion_accepted"] is False assert promotion["ready_for_completion_runtime_promotion"] is False @@ -2166,7 +2175,7 @@ def test_mcp_runtime_promotion_accepts_evidence_and_receipt_package(): promotion = build_mcp_runtime_promotion_preview( activation_evidence=sample["activation_evidence"], runtime_receipt=sample["runtime_receipt"], - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert promotion["mode"] == "mcp_runtime_promotion_review" @@ -2226,12 +2235,12 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_runtime_promotion_preview" - assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_runtime_promotion_review" - assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert post_data["runtime_promotion_accepted"] is True assert post_data["promotion_persisted"] is False assert post_data["api_opens_database_connection"] is False @@ -2240,11 +2249,11 @@ def test_mcp_runtime_promotion_route_get_and_post_are_preview_only(): def test_mcp_manual_fetch_handoff_preview_is_safe_without_payload(): handoff = build_mcp_manual_fetch_handoff_preview( - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_preview" - assert handoff["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert handoff["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert handoff["handoff_payload_received"] is False assert handoff["manual_fetch_handoff_accepted"] is False assert handoff["ready_for_manual_fetch_gate_operator_review"] is False @@ -2272,7 +2281,7 @@ def test_mcp_manual_fetch_handoff_accepts_promotion_and_acknowledgements(): handoff = build_mcp_manual_fetch_handoff_preview( promotion_package=sample["promotion_package"], operator_acknowledgements=sample["operator_acknowledgements"], - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert handoff["mode"] == "mcp_manual_fetch_handoff_review" @@ -2334,12 +2343,12 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_manual_fetch_handoff_preview" - assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_manual_fetch_handoff_review" - assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert post_data["manual_fetch_handoff_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2350,11 +2359,11 @@ def test_mcp_manual_fetch_handoff_route_get_and_post_are_preview_only(): def test_mcp_fetch_target_review_preview_is_safe_without_payload(): review = build_mcp_fetch_target_review_preview( - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert review["mode"] == "mcp_fetch_target_review_preview" - assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert review["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert review["target_payload_received"] is False assert review["mcp_fetch_target_review_accepted"] is False assert review["ready_for_manual_fetch_run_package_review"] is False @@ -2384,7 +2393,7 @@ def test_mcp_fetch_target_review_accepts_sample_targets(): review = build_mcp_fetch_target_review_preview( handoff_package=sample["handoff_package"], target_review=sample["target_review"], - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert review["mode"] == "mcp_fetch_target_review" @@ -2462,13 +2471,13 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_target_review_preview" - assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert get_data["api_executes_health_check"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_target_review" - assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert post_data["mcp_fetch_target_review_accepted"] is True assert post_data["manual_fetch_gate_opened_by_api"] is False assert post_data["network_request_allowed"] is False @@ -2480,11 +2489,11 @@ def test_mcp_fetch_target_review_route_get_and_post_are_preview_only(): def test_mcp_fetch_run_package_preview_is_safe_without_payload(): package = build_mcp_fetch_run_package_preview( - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert package["mode"] == "mcp_fetch_run_package_preview" - assert package["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert package["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert package["run_payload_received"] is False assert package["mcp_fetch_run_package_accepted"] is False assert package["ready_for_manual_fetch_run_readiness_review"] is False @@ -2516,7 +2525,7 @@ def test_mcp_fetch_run_package_accepts_sample_package(): package = build_mcp_fetch_run_package_preview( target_review_package=sample["target_review_package"], operator_run_controls=sample["operator_run_controls"], - phase="phase_122_market_intel_mcp_fetch_run_package", + phase="phase_123_market_intel_mcp_fetch_run_readiness", ) assert package["mode"] == "mcp_fetch_run_package_review" @@ -2591,13 +2600,13 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert get_response.status_code == 200 assert get_data["mode"] == "mcp_fetch_run_package_preview" - assert get_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert get_data["api_executes_cli"] is False assert get_data["api_writes_database"] is False assert get_data["api_uses_external_network"] is False assert post_response.status_code == 200 assert post_data["mode"] == "mcp_fetch_run_package_review" - assert post_data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert post_data["mcp_fetch_run_package_accepted"] is True assert post_data["ready_for_manual_fetch_operator_run"] is False assert post_data["manual_fetch_gate_opened_by_api"] is False @@ -2609,11 +2618,150 @@ def test_mcp_fetch_run_package_route_get_and_post_are_preview_only(): assert post_data["api_uses_external_network"] is False +def test_mcp_fetch_run_readiness_preview_is_safe_without_payload(): + readiness = build_mcp_fetch_run_readiness_preview( + phase="phase_123_market_intel_mcp_fetch_run_readiness", + ) + + assert readiness["mode"] == "mcp_fetch_run_readiness_preview" + assert readiness["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" + assert readiness["run_readiness_payload_received"] is False + assert readiness["mcp_fetch_run_readiness_accepted"] is False + assert readiness["run_readiness_ready"] is False + assert readiness["ready_for_manual_fetch_operator_run"] is False + assert readiness["ready_for_manual_fetch_run_receipt_gate"] is False + assert readiness["manual_fetch_gate_opened_by_api"] is False + assert readiness["network_request_allowed"] is False + assert readiness["fetch_executed"] is False + assert readiness["cli_executed"] is False + assert readiness["payload_persisted"] is False + assert readiness["run_readiness_persisted"] is False + assert readiness["run_readiness_artifact_created"] is False + assert readiness["run_readiness_file_written"] is False + assert readiness["receipt_file_written"] is False + assert readiness["api_executes_cli"] is False + assert readiness["api_opens_database_connection"] is False + assert readiness["api_writes_database"] is False + assert readiness["api_uses_external_network"] is False + assert readiness["database_write_executed"] is False + assert readiness["external_network_executed"] is False + assert readiness["file_written"] is False + assert readiness["scheduler_attached"] is False + assert "run_package_payload_or_result_received" in readiness["blocked_reasons"] + assert "operator_readiness_received" in readiness["blocked_reasons"] + assert "run_package" in readiness["sample_run_readiness_package"] + assert "operator_readiness" in readiness["sample_run_readiness_package"] + + +def test_mcp_fetch_run_readiness_accepts_sample_package(): + sample = build_mcp_fetch_run_readiness_preview()["sample_run_readiness_package"] + readiness = build_mcp_fetch_run_readiness_preview( + run_package=sample["run_package"], + run_package_result=sample["run_package_result"], + operator_readiness=sample["operator_readiness"], + phase="phase_123_market_intel_mcp_fetch_run_readiness", + ) + + assert readiness["mode"] == "mcp_fetch_run_readiness_review" + assert readiness["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" + assert readiness["mcp_fetch_run_readiness_accepted"] is True + assert readiness["run_readiness_ready"] is True + assert readiness["ready_for_manual_fetch_operator_run"] is True + assert readiness["ready_for_manual_fetch_run_receipt_gate"] is True + assert readiness["operator_shell_external_network_required"] is True + assert readiness["blocked_reasons"] == [] + assert readiness["passed_gate_count"] == readiness["gate_count"] + assert readiness["run_package_summary"]["accepted"] is True + assert readiness["run_package_summary"]["command_count"] >= 8 + assert readiness["operator_readiness_summary"]["run_readiness_artifact_path_safe"] is True + assert readiness["operator_readiness_summary"]["dry_run_receipt_path_safe"] is True + assert all( + item["ready_for_operator_shell"] is True + and item["command_executed"] is False + and item["external_network_executed_by_api"] is False + and item["receipt_written_by_api"] is False + for item in readiness["command_readiness"] + ) + assert readiness["manual_fetch_gate_opened_by_api"] is False + assert readiness["network_request_allowed"] is False + assert readiness["fetch_executed"] is False + assert readiness["cli_executed"] is False + assert readiness["run_readiness_artifact_created"] is False + assert readiness["file_written"] is False + assert readiness["database_write_executed"] is False + assert readiness["api_uses_external_network"] is False + assert readiness["scheduler_attached"] is False + + +def test_mcp_fetch_run_readiness_blocks_unsafe_operator_payload(): + sample = build_mcp_fetch_run_readiness_preview()["sample_run_readiness_package"] + operator_readiness = sample["operator_readiness"] + operator_readiness["run_readiness_artifact_path"] = "../unsafe.json" + operator_readiness["api_executes_cli"] = True + operator_readiness["approval_token"] = "do-not-submit" + operator_readiness["operator_confirmed_no_api_execution"] = False + + readiness = build_mcp_fetch_run_readiness_preview( + run_package=sample["run_package"], + run_package_result=sample["run_package_result"], + operator_readiness=operator_readiness, + ) + + assert readiness["mcp_fetch_run_readiness_accepted"] is False + assert readiness["run_package_accepted"] is True + assert "run_readiness_artifact_path_safe" in readiness["blocked_reasons"] + assert "operator_confirmed_shell_only_boundaries" in readiness["blocked_reasons"] + assert "secret_or_token_not_submitted_to_api" in readiness["blocked_reasons"] + assert "operator_readiness_side_effect_free" in readiness["blocked_reasons"] + assert readiness["network_request_allowed"] is False + assert readiness["api_writes_database"] is False + assert readiness["scheduler_attached"] is False + + +def test_mcp_fetch_run_readiness_route_get_and_post_are_preview_only(): + from routes.market_intel_routes import market_intel_bp + + app = Flask(__name__) + app.secret_key = "test-secret" + app.register_blueprint(market_intel_bp) + client = app.test_client() + with client.session_transaction() as session: + session["logged_in"] = True + + get_response = client.get("/api/market_intel/mcp_fetch_run_readiness") + get_data = get_response.get_json() + sample = get_data["sample_run_readiness_package"] + post_response = client.post( + "/api/market_intel/mcp_fetch_run_readiness", + json={"run_readiness": sample}, + ) + post_data = post_response.get_json() + + assert get_response.status_code == 200 + assert get_data["mode"] == "mcp_fetch_run_readiness_preview" + assert get_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" + assert get_data["api_executes_cli"] is False + assert get_data["api_writes_database"] is False + assert get_data["api_uses_external_network"] is False + assert post_response.status_code == 200 + assert post_data["mode"] == "mcp_fetch_run_readiness_review" + assert post_data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" + assert post_data["mcp_fetch_run_readiness_accepted"] is True + assert post_data["ready_for_manual_fetch_operator_run"] is True + assert post_data["manual_fetch_gate_opened_by_api"] is False + assert post_data["network_request_allowed"] is False + assert post_data["fetch_executed"] is False + assert post_data["cli_executed"] is False + assert post_data["run_readiness_persisted"] is False + assert post_data["api_opens_database_connection"] is False + assert post_data["api_uses_external_network"] is False + + def test_manual_sample_plan_preview_blocks_fetch_and_write(): plan = MarketIntelService().build_manual_sample_plan() assert plan["mode"] == "manual_sample_fetch_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_for_manual_sample_fetch"] is False assert plan["sample_fetch_executed"] is False assert plan["external_network_executed"] is False @@ -2661,7 +2809,7 @@ def test_manual_sample_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_fetch_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["sample_fetch_executed"] is False assert data["external_network_executed"] is False assert data["database_write_executed"] is False @@ -2672,7 +2820,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import(): acceptance = MarketIntelService().build_manual_sample_acceptance() assert acceptance["mode"] == "manual_sample_acceptance_preview" - assert acceptance["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert acceptance["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert acceptance["contract_ready"] is True assert acceptance["sample_result_loaded"] is False assert acceptance["sample_result_accepted"] is False @@ -2714,7 +2862,7 @@ def test_manual_sample_acceptance_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_acceptance_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["sample_result_loaded"] is False assert data["candidate_import_allowed"] is False assert data["external_network_executed"] is False @@ -2726,7 +2874,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded(): review = MarketIntelService().build_manual_sample_review() assert review["mode"] == "manual_sample_review_preview" - assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert review["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert review["contract_ready"] is True assert review["sample_result_loaded"] is False assert review["sample_result_reviewed"] is False @@ -2837,7 +2985,7 @@ def test_manual_sample_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["sample_result_loaded"] is False assert data["sample_result_reviewed"] is False assert data["candidate_import_allowed"] is False @@ -2876,7 +3024,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist ) assert review["mode"] == "manual_sample_review_evaluation_preview" - assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert review["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert review["review_request_type"] == "operator_posted_json" assert review["payload_received"] is True assert review["payload_valid_json_object"] is True @@ -2938,7 +3086,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_review_evaluation_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["payload_received"] is True assert data["payload_valid_json_object"] is True assert data["payload_persisted"] is False @@ -3018,7 +3166,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers ) assert handoff["mode"] == "manual_sample_candidate_handoff_preview" - assert handoff["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert handoff["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert handoff["payload_received"] is True assert handoff["payload_valid_json_object"] is True assert handoff["payload_persisted"] is False @@ -3082,7 +3230,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_handoff_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["candidate_handoff_created"] is True @@ -3141,7 +3289,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without ) assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview" - assert queue_draft["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert queue_draft["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert queue_draft["payload_received"] is True assert queue_draft["payload_valid_json_object"] is True assert queue_draft["payload_persisted"] is False @@ -3215,7 +3363,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_draft_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["payload_received"] is True assert data["handoff_ready"] is True assert data["queue_draft_ready"] is True @@ -3278,7 +3426,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro ) assert approval["mode"] == "manual_sample_candidate_queue_approval_preview" - assert approval["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert approval["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert approval["payload_received"] is True assert approval["payload_valid_json_object"] is True assert approval["payload_persisted"] is False @@ -3356,7 +3504,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_approval_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["payload_received"] is True assert data["approval_preview_created"] is True assert data["approval_request_created"] is False @@ -3419,7 +3567,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution(): ) assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert transaction["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert transaction["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert transaction["payload_received"] is True assert transaction["payload_valid_json_object"] is True assert transaction["payload_persisted"] is False @@ -3499,7 +3647,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri assert response.status_code == 200 assert data["mode"] == "manual_sample_candidate_queue_transaction_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["payload_received"] is True assert data["transaction_preview_created"] is True assert data["transaction_ready"] is False @@ -9210,7 +9358,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9285,7 +9433,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_summary_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_archive_summary_ready"] is False assert ( @@ -9557,7 +9705,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_input_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_input_ready"] is False assert data["summary_persistence_telegram_dispatch_report_input_ready"] is False @@ -9845,7 +9993,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_package_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_run_package_ready"] is False assert ( @@ -10155,7 +10303,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_readiness_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_run_readiness_ready"] is False assert ( @@ -10458,7 +10606,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_run_receipt_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_run_receipt_passed"] is False assert ( @@ -10717,7 +10865,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_closeout_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_closeout_passed"] is False assert ( @@ -10990,7 +11138,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_archive_passed"] is False assert ( @@ -11238,7 +11386,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_archive_summary_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_archive_summary_passed"] is False assert ( @@ -11468,7 +11616,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_handoff_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_handoff_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_handoff_passed"] is False @@ -11705,7 +11853,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_index_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_index_passed"] is False assert data["summary_persistence_telegram_dispatch_report_catalog_index_passed"] is False @@ -11947,7 +12095,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_write_preflight_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_write_preflight_passed"] is False assert ( @@ -12223,7 +12371,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_write_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_write_passed"] is False assert ( @@ -12500,7 +12648,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_package_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_run_package_passed"] is False assert ( @@ -12779,7 +12927,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_readiness_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_run_readiness_passed"] is False assert ( @@ -13108,7 +13256,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_run_receipt_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_run_receipt_passed"] is False assert ( @@ -13370,7 +13518,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_commit_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_commit_passed"] is False assert ( @@ -13634,7 +13782,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_closeout_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_closeout_passed"] is False assert ( @@ -13904,7 +14052,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_archive_passed"] is False assert ( @@ -14192,7 +14340,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_archive_summary_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_archive_summary_passed"] is False assert ( @@ -14479,7 +14627,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_ "candidate_queue_review_ai_summary_persistence_telegram_dispatch_report_catalog_record_final_closeout_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_report_catalog_record_final_closeout_passed"] is False assert ( @@ -14565,7 +14713,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_preflight_planned" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -14622,7 +14770,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -14711,7 +14859,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write( assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -14765,7 +14913,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write() assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_operator_drill_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["operator_drill_ready"] is True assert data["api_executes_cli"] is False assert data["api_reads_approval_token"] is False @@ -14821,7 +14969,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_package_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["package_ready"] is True assert data["package_artifact_created"] is False assert data["api_writes_file"] is False @@ -14887,7 +15035,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_readiness_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["ready_for_cli_operator_run"] is True assert data["ready_for_api_database_write"] is False assert data["api_executes_cli"] is False @@ -15189,7 +15337,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["receipt_passed"] is True assert data["ready_for_api_database_write"] is False assert data["ready_for_scheduler_attach"] is False @@ -15237,7 +15385,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_closeout_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["closeout_passed"] is True assert data["ready_for_next_manual_phase"] is True assert data["ready_for_api_database_write"] is False @@ -15286,7 +15434,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_handoff_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["handoff_ready"] is True assert data["ready_for_manual_queue_review"] is True assert data["ready_for_api_database_write"] is False @@ -15344,7 +15492,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_inventory_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["review_inventory_ready"] is False assert data["ready_for_human_decision_review"] is False @@ -15410,7 +15558,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write(): assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["decision_ready"] is False assert data["ready_for_human_decision_record"] is False assert data["ready_for_api_review_state_update"] is False @@ -15481,7 +15629,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_approval_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["approval_ready"] is False assert data["ready_for_review_state_transaction_preview"] is False assert data["ready_for_cli_decision_writer"] is False @@ -15557,7 +15705,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_transaction_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["transaction_preview_created"] is False assert data["transaction_ready"] is False assert data["ready_for_manual_shell_update_window"] is False @@ -15639,7 +15787,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["approval_token_present"] is False @@ -15725,7 +15873,7 @@ def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and assert data["mode"] == ( "candidate_queue_review_decision_writer_preflight_preview" ) - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is True assert data["apply_real_write_requested"] is True assert data["read_only_query_executed"] is False @@ -15808,7 +15956,7 @@ def test_candidate_queue_review_decision_writer_postwrite_smoke_route_is_post_on assert data["mode"] == ( "candidate_queue_review_decision_writer_postwrite_smoke_planned" ) - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_connection_opened"] is False @@ -15891,7 +16039,7 @@ def test_candidate_queue_review_decision_writer_operator_drill_route_is_post_onl assert data["mode"] == ( "candidate_queue_review_decision_writer_operator_drill_preview" ) - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["operator_drill_ready"] is False assert data["ready_for_api_review_state_update"] is False assert data["ready_for_api_database_write"] is False @@ -15977,7 +16125,7 @@ def test_candidate_queue_review_decision_writer_run_package_route_is_post_only_a assert data["mode"] == ( "candidate_queue_review_decision_writer_run_package_preview" ) - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["package_ready"] is False assert data["package_artifact_created"] is False assert data["ready_for_api_review_state_update"] is False @@ -16068,7 +16216,7 @@ def test_candidate_queue_review_decision_writer_run_readiness_route_is_post_only "candidate_queue_review_decision_writer_run_readiness_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["ready_for_cli_operator_run"] is False assert data["ready_for_api_review_state_update"] is False @@ -16178,7 +16326,7 @@ def test_candidate_queue_review_decision_writer_run_receipt_route_is_post_only_a "candidate_queue_review_decision_writer_run_receipt_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["receipt_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16264,7 +16412,7 @@ def test_candidate_queue_review_decision_writer_run_closeout_route_is_post_only_ "candidate_queue_review_decision_writer_run_closeout_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["closeout_passed"] is False assert data["ready_for_api_review_state_update"] is False @@ -16321,7 +16469,7 @@ def test_candidate_queue_review_decision_post_closeout_inventory_route_is_post_o "candidate_queue_review_decision_post_closeout_inventory_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["post_closeout_inventory_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16374,7 +16522,7 @@ def test_candidate_queue_review_completion_archive_route_is_post_only_and_no_wri assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_completion_archive_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["review_completion_archive_ready"] is False assert data["archive_manifest_ready"] is False assert data["ready_for_api_review_state_update"] is False @@ -16427,7 +16575,7 @@ def test_candidate_queue_review_archive_summary_route_is_post_only_and_no_write( assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_archive_summary_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["archive_summary_ready"] is False assert data["summary_input_ready"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16488,7 +16636,7 @@ def test_candidate_queue_review_ai_summary_preflight_route_is_post_only_and_no_w assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_preflight_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["ai_summary_preflight_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16557,7 +16705,7 @@ def test_candidate_queue_review_ai_summary_run_package_route_is_post_only_and_no assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_run_package_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["ai_summary_run_package_ready"] is False assert data["ready_for_manual_ollama_summary_run"] is False assert data["ready_for_ai_summary_generation"] is False @@ -16629,7 +16777,7 @@ def test_candidate_queue_review_ai_summary_output_receipt_route_is_post_only_and assert get_response.status_code == 405 assert response.status_code == 200 assert data["mode"] == "candidate_queue_review_ai_summary_output_receipt_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["ai_summary_output_receipt_ready"] is False assert data["ready_for_summary_persistence_review"] is False assert data["manual_ai_summary_output_provided"] is False @@ -16702,7 +16850,7 @@ def test_candidate_queue_review_ai_summary_persistence_preflight_route_is_post_o "candidate_queue_review_ai_summary_persistence_preflight_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["summary_persistence_preflight_ready"] is False assert data["ready_for_summary_transaction_preview"] is False @@ -16773,7 +16921,7 @@ def test_candidate_queue_review_ai_summary_persistence_transaction_route_is_post "candidate_queue_review_ai_summary_persistence_transaction_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["summary_persistence_transaction_ready"] is False assert data["ready_for_summary_persistence_writer_gate"] is False @@ -16838,7 +16986,7 @@ def test_candidate_queue_review_ai_summary_persistence_writer_preflight_route_is "candidate_queue_review_ai_summary_persistence_writer_preflight_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["summary_persistence_writer_preflight_ready"] is False assert data["ready_for_summary_persistence_run_package"] is False @@ -16909,7 +17057,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_package_route_is_post "candidate_queue_review_ai_summary_persistence_run_package_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["package_ready"] is False assert data["ready_for_summary_persistence_run_readiness"] is False @@ -16982,7 +17130,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_readiness_route_is_po "candidate_queue_review_ai_summary_persistence_run_readiness_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["run_readiness_ready"] is False assert data["summary_persistence_run_readiness_ready"] is False @@ -17059,7 +17207,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_receipt_route_is_post "candidate_queue_review_ai_summary_persistence_run_receipt_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["run_receipt_passed"] is False assert data["summary_persistence_run_receipt_passed"] is False @@ -17136,7 +17284,7 @@ def test_candidate_queue_review_ai_summary_persistence_run_closeout_route_is_pos "candidate_queue_review_ai_summary_persistence_run_closeout_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["closeout_passed"] is False assert data["summary_persistence_closeout_passed"] is False @@ -17213,7 +17361,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_ro "candidate_queue_review_ai_summary_persistence_telegram_dispatch_gate_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_gate_passed"] is False assert data["summary_persistence_telegram_dispatch_gate_passed"] is False @@ -17287,7 +17435,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_pac "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_package_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_run_package_ready"] is False assert data["summary_persistence_telegram_dispatch_run_package_ready"] is False @@ -17366,7 +17514,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rea "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_readiness_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_run_readiness_ready"] is False assert ( @@ -17453,7 +17601,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_rec "candidate_queue_review_ai_summary_persistence_telegram_dispatch_run_receipt_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_run_receipt_passed"] is False assert data["summary_persistence_telegram_dispatch_run_receipt_passed"] is False @@ -17534,7 +17682,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeou "candidate_queue_review_ai_summary_persistence_telegram_dispatch_closeout_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_closeout_passed"] is False assert data["summary_persistence_telegram_dispatch_closeout_passed"] is False @@ -17616,7 +17764,7 @@ def test_candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive "candidate_queue_review_ai_summary_persistence_telegram_dispatch_archive_preview" ) assert data["phase"] == ( - "phase_122_market_intel_mcp_fetch_run_package" + "phase_123_market_intel_mcp_fetch_run_readiness" ) assert data["telegram_dispatch_archive_ready"] is False assert data["summary_persistence_telegram_dispatch_archive_ready"] is False @@ -17699,7 +17847,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write(): assert response.status_code == 200 assert data["mode"] == "candidate_queue_writer_run_receipt_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["receipt_passed"] is True assert data["ready_for_next_manual_review"] is True assert data["ready_for_api_database_write"] is False @@ -17724,7 +17872,7 @@ def test_scheduler_plan_preview_blocks_job_attachment(): plan = MarketIntelService().build_scheduler_plan() assert plan["mode"] == "scheduler_attach_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_to_attach_scheduler"] is False assert plan["scheduler_attached"] is False assert plan["scheduler_registration_executed"] is False @@ -17762,7 +17910,7 @@ def test_scheduler_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "scheduler_attach_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["scheduler_registration_executed"] is False assert data["crawler_job_started"] is False assert data["external_network_executed"] is False @@ -17773,7 +17921,7 @@ def test_match_review_plan_preview_blocks_auto_confirm(): plan = MarketIntelService().build_match_review_plan() assert plan["mode"] == "match_review_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_for_review_queue"] is False assert plan["review_queue_created"] is False assert plan["auto_match_executed"] is False @@ -17809,7 +17957,7 @@ def test_match_review_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "match_review_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["review_queue_created"] is False assert data["auto_confirm_executed"] is False assert data["external_network_executed"] is False @@ -17820,7 +17968,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary(): plan = MarketIntelService().build_opportunity_plan() assert plan["mode"] == "opportunity_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_for_opportunity_queue"] is False assert plan["opportunity_queue_created"] is False assert plan["threat_alert_dispatched"] is False @@ -17861,7 +18009,7 @@ def test_opportunity_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["opportunity_queue_created"] is False assert data["threat_alert_dispatched"] is False assert data["ai_summary_generated"] is False @@ -17872,7 +18020,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts(): plan = MarketIntelService().build_opportunity_scoring_plan() assert plan["mode"] == "opportunity_scoring_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_for_scoring_job"] is False assert plan["scoring_job_created"] is False assert plan["score_calculation_executed"] is False @@ -17920,7 +18068,7 @@ def test_opportunity_scoring_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_scoring_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["scoring_job_created"] is False assert data["score_calculation_executed"] is False assert data["sample_scores_generated"] is False @@ -17932,7 +18080,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts(): plan = MarketIntelService().build_opportunity_evidence_plan() assert plan["mode"] == "opportunity_evidence_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_for_evidence_bundle"] is False assert plan["evidence_bundle_created"] is False assert plan["evidence_query_executed"] is False @@ -17978,7 +18126,7 @@ def test_opportunity_evidence_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_evidence_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["evidence_bundle_created"] is False assert data["evidence_query_executed"] is False assert data["sample_evidence_generated"] is False @@ -17991,7 +18139,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls(): plan = MarketIntelService().build_opportunity_alert_plan() assert plan["mode"] == "opportunity_alert_plan_preview" - assert plan["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert plan["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert plan["ready_for_alert_candidates"] is False assert plan["alert_candidate_created"] is False assert plan["alert_queue_created"] is False @@ -18076,7 +18224,7 @@ def test_opportunity_alert_plan_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "opportunity_alert_plan_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["alert_candidate_created"] is False assert data["alert_queue_created"] is False assert data["review_queue_created"] is False @@ -18154,7 +18302,7 @@ def test_mcp_deploy_preflight_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "mcp_external_deploy_preflight_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["deployment_actions_executed"] is False assert data["docker_command_executed"] is False assert data["ssh_command_executed"] is False @@ -18169,7 +18317,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch): readiness = MarketIntelService().build_mcp_readiness() assert readiness["mode"] == "mcp_readiness_planned" - assert readiness["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert readiness["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert readiness["execute_requested"] is False assert readiness["router_enabled"] is False assert readiness["external_mcp_complete"] is False @@ -18563,6 +18711,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["checks"]["mcp_manual_fetch_handoff_preview_safe"] is True assert readiness["checks"]["mcp_fetch_target_review_preview_safe"] is True assert readiness["checks"]["mcp_fetch_run_package_preview_safe"] is True + assert readiness["checks"]["mcp_fetch_run_readiness_preview_safe"] is True assert readiness["checks"]["scheduler_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_plan_preview_safe"] is True assert readiness["checks"]["manual_sample_acceptance_preview_safe"] is True @@ -18940,6 +19089,7 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert "/api/market_intel/mcp_manual_fetch_handoff" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_fetch_target_review" in readiness["production_smoke_targets"] assert "/api/market_intel/mcp_fetch_run_package" in readiness["production_smoke_targets"] + assert "/api/market_intel/mcp_fetch_run_readiness" in readiness["production_smoke_targets"] assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_plan" in readiness["production_smoke_targets"] assert "/api/market_intel/manual_sample_acceptance" in readiness["production_smoke_targets"] @@ -19329,6 +19479,22 @@ def test_deployment_readiness_reports_app_only_release_gate(): assert readiness["mcp_fetch_run_package"]["api_uses_external_network"] is False assert readiness["mcp_fetch_run_package"]["file_written"] is False assert readiness["mcp_fetch_run_package"]["scheduler_attached"] is False + assert readiness["mcp_fetch_run_readiness"]["mode"] == "mcp_fetch_run_readiness_preview" + assert readiness["mcp_fetch_run_readiness"]["run_readiness_payload_received"] is False + assert readiness["mcp_fetch_run_readiness"]["payload_persisted"] is False + assert readiness["mcp_fetch_run_readiness"]["run_readiness_persisted"] is False + assert readiness["mcp_fetch_run_readiness"]["run_readiness_artifact_created"] is False + assert readiness["mcp_fetch_run_readiness"]["run_readiness_file_written"] is False + assert readiness["mcp_fetch_run_readiness"]["receipt_file_written"] is False + assert readiness["mcp_fetch_run_readiness"]["manual_fetch_gate_opened_by_api"] is False + assert readiness["mcp_fetch_run_readiness"]["network_request_allowed"] is False + assert readiness["mcp_fetch_run_readiness"]["fetch_executed"] is False + assert readiness["mcp_fetch_run_readiness"]["cli_executed"] is False + assert readiness["mcp_fetch_run_readiness"]["api_executes_cli"] is False + assert readiness["mcp_fetch_run_readiness"]["api_writes_database"] is False + assert readiness["mcp_fetch_run_readiness"]["api_uses_external_network"] is False + assert readiness["mcp_fetch_run_readiness"]["file_written"] is False + assert readiness["mcp_fetch_run_readiness"]["scheduler_attached"] is False assert readiness["manual_sample_plan"]["mode"] == "manual_sample_fetch_plan_preview" assert readiness["manual_sample_plan"]["sample_fetch_executed"] is False assert readiness["manual_sample_plan"]["external_network_executed"] is False @@ -22948,7 +23114,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only(): drill = MarketIntelService().build_migration_apply_drill() assert drill["mode"] == "migration_apply_drill_preview" - assert drill["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert drill["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert drill["execute_requested"] is False assert drill["schema_state"] == "planned_no_db_probe" assert drill["drill_ready_for_operator_review"] is True @@ -23063,7 +23229,7 @@ def test_migration_apply_drill_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_apply_drill_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["migration_executed"] is False assert data["rollback_executed"] is False @@ -23075,7 +23241,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic(): review = MarketIntelService().build_migration_catalog_review() assert review["mode"] == "migration_catalog_review_preview" - assert review["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert review["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert review["execute_requested"] is False assert review["catalog_state"] == "planned_no_probe" assert review["seed_state"] == "planned_no_probe" @@ -23190,7 +23356,7 @@ def test_migration_catalog_review_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_catalog_review_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["catalog_state"] == "planned_no_probe" assert data["migration_executed"] is False @@ -23203,7 +23369,7 @@ def test_migration_live_smoke_planned_is_preview_only(): smoke = MarketIntelService().build_migration_live_smoke() assert smoke["mode"] == "migration_live_smoke_preview" - assert smoke["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert smoke["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert smoke["execute_requested"] is False assert smoke["smoke_result"] == "planned_no_execution" assert smoke["live_smoke_passed"] is False @@ -23265,7 +23431,7 @@ def test_migration_live_smoke_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "migration_live_smoke_preview" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["smoke_result"] == "planned_no_execution" assert data["migration_executed"] is False @@ -23278,7 +23444,7 @@ def test_live_db_inventory_planned_is_preview_only(): inventory = MarketIntelService().build_live_db_inventory() assert inventory["mode"] == "live_db_inventory_planned" - assert inventory["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert inventory["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert inventory["execute_requested"] is False assert inventory["read_only_query_executed"] is False assert inventory["database_connection_opened"] is False @@ -23422,7 +23588,7 @@ def test_live_db_inventory_route_is_preview_only(): assert response.status_code == 200 assert data["mode"] == "live_db_inventory_planned" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["read_only_query_executed"] is False assert data["database_write_executed"] is False @@ -23658,7 +23824,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path): assert result.returncode == 0 assert data["mode"] == "candidate_queue_writer_cli_blocked" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["writes_executed"] is False @@ -23687,7 +23853,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en assert result.returncode == 0 assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked" - assert data["phase"] == "phase_122_market_intel_mcp_fetch_run_package" + assert data["phase"] == "phase_123_market_intel_mcp_fetch_run_readiness" assert data["execute_requested"] is False assert data["apply_real_write_requested"] is False assert data["approval_token_present"] is False