feat(market-intel): add opportunity plan preview

tests/test_market_intel_skeleton.py

@@ -453,6 +453,11 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
     assert "data-market-intel-match-review-signals" in template
     assert "data-market-intel-match-review-actions" in template
     assert "data-market-intel-match-review-sequence" in template
+    assert "data-market-intel-opportunity" in template
+    assert "data-market-intel-opportunity-checks" in template
+    assert "data-market-intel-opportunity-rules" in template
+    assert "data-market-intel-opportunity-severity" in template
+    assert "data-market-intel-opportunity-sequence" in template
     assert "data-market-intel-migration" in template
     assert "data-market-intel-migration-tables" in template
     assert "data-market-intel-approval" in template
@@ -472,6 +477,7 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
     assert "market_intel.market_intel_mcp_fetch_gate" in template
     assert "market_intel.market_intel_scheduler_plan" in template
     assert "market_intel.market_intel_match_review_plan" in template
+    assert "market_intel.market_intel_opportunity_plan" in template
     assert "market_intel.market_intel_migration_blueprint" in template
     assert "market_intel.market_intel_write_approval_runbook" in template
     assert "market_intel.market_intel_deployment_readiness" in template
@@ -497,7 +503,7 @@ def test_legacy_source_bridge_default_is_planned_only():
     bridge = MarketIntelService().build_legacy_source_bridge()
 
     assert bridge["mode"] == "legacy_source_bridge_planned"
-    assert bridge["phase"] == "phase_34_match_review_plan_preview"
+    assert bridge["phase"] == "phase_35_opportunity_plan_preview"
     assert bridge["execute_requested"] is False
     assert bridge["read_only_query_executed"] is False
     assert bridge["database_connection_opened"] is False
@@ -655,7 +661,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
     contract = MarketIntelService().build_mcp_tool_contract()
 
     assert contract["mode"] == "mcp_tool_contract_preview"
-    assert contract["phase"] == "phase_34_match_review_plan_preview"
+    assert contract["phase"] == "phase_35_opportunity_plan_preview"
     assert contract["caller"] == "market_intel"
     assert contract["contract_ready"] is True
     assert contract["blocked_reasons"] == []
@@ -788,7 +794,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "mcp_activation_runbook_preview"
-    assert data["phase"] == "phase_34_match_review_plan_preview"
+    assert data["phase"] == "phase_35_opportunity_plan_preview"
     assert data["deployment_actions_executed"] is False
     assert data["docker_command_executed"] is False
     assert data["ssh_command_executed"] is False
@@ -801,7 +807,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
     gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
 
     assert gate["mode"] == "mcp_fetch_gate_planned"
-    assert gate["phase"] == "phase_34_match_review_plan_preview"
+    assert gate["phase"] == "phase_35_opportunity_plan_preview"
     assert gate["fetch_requested"] is True
     assert gate["manual_fetch_gate_open"] is False
     assert gate["network_request_allowed"] is False
@@ -871,7 +877,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "mcp_fetch_gate_planned"
-    assert data["phase"] == "phase_34_match_review_plan_preview"
+    assert data["phase"] == "phase_35_opportunity_plan_preview"
     assert data["fetch_requested"] is False
     assert data["network_request_allowed"] is False
     assert data["external_network_executed"] is False
@@ -883,7 +889,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
     plan = MarketIntelService().build_scheduler_plan()
 
     assert plan["mode"] == "scheduler_attach_plan_preview"
-    assert plan["phase"] == "phase_34_match_review_plan_preview"
+    assert plan["phase"] == "phase_35_opportunity_plan_preview"
     assert plan["ready_to_attach_scheduler"] is False
     assert plan["scheduler_attached"] is False
     assert plan["scheduler_registration_executed"] is False
@@ -921,7 +927,7 @@ def test_scheduler_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "scheduler_attach_plan_preview"
-    assert data["phase"] == "phase_34_match_review_plan_preview"
+    assert data["phase"] == "phase_35_opportunity_plan_preview"
     assert data["scheduler_registration_executed"] is False
     assert data["crawler_job_started"] is False
     assert data["external_network_executed"] is False
@@ -932,7 +938,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
     plan = MarketIntelService().build_match_review_plan()
 
     assert plan["mode"] == "match_review_plan_preview"
-    assert plan["phase"] == "phase_34_match_review_plan_preview"
+    assert plan["phase"] == "phase_35_opportunity_plan_preview"
     assert plan["ready_for_review_queue"] is False
     assert plan["review_queue_created"] is False
     assert plan["auto_match_executed"] is False
@@ -968,13 +974,65 @@ def test_match_review_plan_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "match_review_plan_preview"
-    assert data["phase"] == "phase_34_match_review_plan_preview"
+    assert data["phase"] == "phase_35_opportunity_plan_preview"
     assert data["review_queue_created"] is False
     assert data["auto_confirm_executed"] is False
     assert data["external_network_executed"] is False
     assert data["database_write_executed"] is False
 
 
+def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
+    plan = MarketIntelService().build_opportunity_plan()
+
+    assert plan["mode"] == "opportunity_plan_preview"
+    assert plan["phase"] == "phase_35_opportunity_plan_preview"
+    assert plan["ready_for_opportunity_queue"] is False
+    assert plan["opportunity_queue_created"] is False
+    assert plan["threat_alert_dispatched"] is False
+    assert plan["telegram_dispatched"] is False
+    assert plan["ai_summary_generated"] is False
+    assert plan["database_session_created"] is False
+    assert plan["database_write_executed"] is False
+    assert plan["database_commit_executed"] is False
+    assert plan["external_network_executed"] is False
+    assert plan["scheduler_attached"] is False
+    assert plan["writes_executed"] is False
+    assert plan["would_write_database"] is False
+    assert plan["rule_count"] == 4
+    assert {item["key"] for item in plan["rules"]} == {
+        "competitor_price_threat",
+        "promotion_gap",
+        "deep_discount_overlap",
+        "campaign_ending_watch",
+    }
+    assert "match_review_candidates_available" in plan["blocked_reasons"]
+    assert "manual_operator_approval" in plan["blocked_reasons"]
+    assert "do_not_dispatch_alerts_from_preview" in plan["safe_boundaries"]
+    assert "do_not_auto_adjust_price" in plan["safe_boundaries"]
+
+
+def test_opportunity_plan_route_is_preview_only():
+    from routes.market_intel_routes import market_intel_bp
+
+    app = Flask(__name__)
+    app.secret_key = "test-secret"
+    app.register_blueprint(market_intel_bp)
+    client = app.test_client()
+    with client.session_transaction() as session:
+        session["logged_in"] = True
+
+    response = client.get("/api/market_intel/opportunity_plan")
+    data = response.get_json()
+
+    assert response.status_code == 200
+    assert data["mode"] == "opportunity_plan_preview"
+    assert data["phase"] == "phase_35_opportunity_plan_preview"
+    assert data["opportunity_queue_created"] is False
+    assert data["threat_alert_dispatched"] is False
+    assert data["ai_summary_generated"] is False
+    assert data["database_write_executed"] is False
+
+
 def test_mcp_deploy_preflight_blocks_without_required_env():
     preflight = build_mcp_deploy_preflight_plan(env={})
 
@@ -1038,7 +1096,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
 
     assert response.status_code == 200
     assert data["mode"] == "mcp_external_deploy_preflight_preview"
-    assert data["phase"] == "phase_34_match_review_plan_preview"
+    assert data["phase"] == "phase_35_opportunity_plan_preview"
     assert data["deployment_actions_executed"] is False
     assert data["docker_command_executed"] is False
     assert data["ssh_command_executed"] is False
@@ -1053,7 +1111,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
     readiness = MarketIntelService().build_mcp_readiness()
 
     assert readiness["mode"] == "mcp_readiness_planned"
-    assert readiness["phase"] == "phase_34_match_review_plan_preview"
+    assert readiness["phase"] == "phase_35_opportunity_plan_preview"
     assert readiness["execute_requested"] is False
     assert readiness["router_enabled"] is False
     assert readiness["external_mcp_complete"] is False
@@ -1442,6 +1500,7 @@ def test_deployment_readiness_reports_app_only_release_gate():
     assert readiness["checks"]["mcp_fetch_gate_preview_safe"] is True
     assert readiness["checks"]["scheduler_plan_preview_safe"] is True
     assert readiness["checks"]["match_review_plan_preview_safe"] is True
+    assert readiness["checks"]["opportunity_plan_preview_safe"] is True
     assert readiness["checks"]["writer_plan_dry_run_only"] is True
     assert readiness["writer_plan_summary"]["writes_executed"] is False
     assert "readiness_checks_not_all_passed" not in readiness["blocked_reasons"]
@@ -1464,6 +1523,7 @@ def test_deployment_readiness_reports_app_only_release_gate():
     assert "/api/market_intel/mcp_fetch_gate" in readiness["production_smoke_targets"]
     assert "/api/market_intel/scheduler_plan" in readiness["production_smoke_targets"]
     assert "/api/market_intel/match_review_plan" in readiness["production_smoke_targets"]
+    assert "/api/market_intel/opportunity_plan" in readiness["production_smoke_targets"]
     assert readiness["write_approval_runbook"]["ready_for_real_write"] is False
     assert readiness["write_approval_runbook"]["writes_executed"] is False
     assert readiness["migration_blueprint"]["migration_executed"] is False
@@ -1488,6 +1548,9 @@ def test_deployment_readiness_reports_app_only_release_gate():
     assert readiness["match_review_plan"]["review_queue_created"] is False
     assert readiness["match_review_plan"]["auto_confirm_executed"] is False
     assert readiness["match_review_plan"]["database_write_executed"] is False
+    assert readiness["opportunity_plan"]["opportunity_queue_created"] is False
+    assert readiness["opportunity_plan"]["threat_alert_dispatched"] is False
+    assert readiness["opportunity_plan"]["database_write_executed"] is False
 
 
 def test_write_approval_runbook_is_read_only_and_blocks_real_write():