新增市場情報 review decision writer preflight
All checks were successful
CD Pipeline / deploy (push) Successful in 1m51s

This commit is contained in:
OoO
2026-05-19 14:25:05 +08:00
parent d504ddac51
commit 026d11b295
10 changed files with 1005 additions and 65 deletions

View File

@@ -836,10 +836,18 @@ def test_market_intel_preview_template_uses_safe_fetch_false_endpoint():
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_status"
in template
)
assert (
"market_intel_review.market_intel_manual_sample_candidate_queue_review_decision_writer_preflight"
in template
)
assert (
"data-market-intel-sample-candidate-queue-review-decision-writer"
in template
)
assert (
"data-market-intel-sample-candidate-queue-review-decision-preflight"
in template
)
assert "X-CSRFToken" in template
assert "market_intel.market_intel_scheduler_plan" in template
assert "market_intel.market_intel_match_review_plan" in template
@@ -876,7 +884,7 @@ def test_legacy_source_bridge_default_is_planned_only():
bridge = MarketIntelService().build_legacy_source_bridge()
assert bridge["mode"] == "legacy_source_bridge_planned"
assert bridge["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert bridge["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert bridge["execute_requested"] is False
assert bridge["read_only_query_executed"] is False
assert bridge["database_connection_opened"] is False
@@ -1034,7 +1042,7 @@ def test_mcp_tool_contract_preview_is_read_only_and_whitelisted():
contract = MarketIntelService().build_mcp_tool_contract()
assert contract["mode"] == "mcp_tool_contract_preview"
assert contract["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert contract["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert contract["caller"] == "market_intel"
assert contract["contract_ready"] is True
assert contract["blocked_reasons"] == []
@@ -1167,7 +1175,7 @@ def test_mcp_activation_runbook_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_activation_runbook_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -1180,7 +1188,7 @@ def test_mcp_fetch_gate_default_blocks_external_fetch():
gate = MarketIntelService().build_mcp_fetch_gate(fetch_requested=True)
assert gate["mode"] == "mcp_fetch_gate_planned"
assert gate["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert gate["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert gate["fetch_requested"] is True
assert gate["manual_fetch_gate_open"] is False
assert gate["network_request_allowed"] is False
@@ -1250,7 +1258,7 @@ def test_mcp_fetch_gate_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_fetch_gate_planned"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["fetch_requested"] is False
assert data["network_request_allowed"] is False
assert data["external_network_executed"] is False
@@ -1262,7 +1270,7 @@ def test_manual_sample_plan_preview_blocks_fetch_and_write():
plan = MarketIntelService().build_manual_sample_plan()
assert plan["mode"] == "manual_sample_fetch_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_for_manual_sample_fetch"] is False
assert plan["sample_fetch_executed"] is False
assert plan["external_network_executed"] is False
@@ -1310,7 +1318,7 @@ def test_manual_sample_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_fetch_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["sample_fetch_executed"] is False
assert data["external_network_executed"] is False
assert data["database_write_executed"] is False
@@ -1321,7 +1329,7 @@ def test_manual_sample_acceptance_preview_blocks_candidate_import():
acceptance = MarketIntelService().build_manual_sample_acceptance()
assert acceptance["mode"] == "manual_sample_acceptance_preview"
assert acceptance["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert acceptance["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert acceptance["contract_ready"] is True
assert acceptance["sample_result_loaded"] is False
assert acceptance["sample_result_accepted"] is False
@@ -1363,7 +1371,7 @@ def test_manual_sample_acceptance_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_acceptance_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["sample_result_loaded"] is False
assert data["candidate_import_allowed"] is False
assert data["external_network_executed"] is False
@@ -1375,7 +1383,7 @@ def test_manual_sample_review_preview_is_planned_until_result_loaded():
review = MarketIntelService().build_manual_sample_review()
assert review["mode"] == "manual_sample_review_preview"
assert review["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert review["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert review["contract_ready"] is True
assert review["sample_result_loaded"] is False
assert review["sample_result_reviewed"] is False
@@ -1486,7 +1494,7 @@ def test_manual_sample_review_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "manual_sample_review_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["sample_result_loaded"] is False
assert data["sample_result_reviewed"] is False
assert data["candidate_import_allowed"] is False
@@ -1525,7 +1533,7 @@ def test_manual_sample_review_evaluation_preview_accepts_payload_without_persist
)
assert review["mode"] == "manual_sample_review_evaluation_preview"
assert review["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert review["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert review["review_request_type"] == "operator_posted_json"
assert review["payload_received"] is True
assert review["payload_valid_json_object"] is True
@@ -1587,7 +1595,7 @@ def test_manual_sample_review_evaluate_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_review_evaluation_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["payload_received"] is True
assert data["payload_valid_json_object"] is True
assert data["payload_persisted"] is False
@@ -1667,7 +1675,7 @@ def test_manual_sample_candidate_handoff_preview_creates_candidates_without_pers
)
assert handoff["mode"] == "manual_sample_candidate_handoff_preview"
assert handoff["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert handoff["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert handoff["payload_received"] is True
assert handoff["payload_valid_json_object"] is True
assert handoff["payload_persisted"] is False
@@ -1731,7 +1739,7 @@ def test_manual_sample_candidate_handoff_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_handoff_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["payload_received"] is True
assert data["handoff_ready"] is True
assert data["candidate_handoff_created"] is True
@@ -1790,7 +1798,7 @@ def test_manual_sample_candidate_queue_draft_preview_builds_review_items_without
)
assert queue_draft["mode"] == "manual_sample_candidate_queue_draft_preview"
assert queue_draft["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert queue_draft["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert queue_draft["payload_received"] is True
assert queue_draft["payload_valid_json_object"] is True
assert queue_draft["payload_persisted"] is False
@@ -1864,7 +1872,7 @@ def test_manual_sample_candidate_queue_draft_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_draft_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["payload_received"] is True
assert data["handoff_ready"] is True
assert data["queue_draft_ready"] is True
@@ -1927,7 +1935,7 @@ def test_manual_sample_candidate_queue_approval_preview_blocks_write_and_maps_ro
)
assert approval["mode"] == "manual_sample_candidate_queue_approval_preview"
assert approval["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert approval["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert approval["payload_received"] is True
assert approval["payload_valid_json_object"] is True
assert approval["payload_persisted"] is False
@@ -2005,7 +2013,7 @@ def test_manual_sample_candidate_queue_approval_route_is_post_only_and_no_write(
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_approval_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["payload_received"] is True
assert data["approval_preview_created"] is True
assert data["approval_request_created"] is False
@@ -2068,7 +2076,7 @@ def test_manual_sample_candidate_queue_transaction_preview_blocks_execution():
)
assert transaction["mode"] == "manual_sample_candidate_queue_transaction_preview"
assert transaction["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert transaction["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert transaction["payload_received"] is True
assert transaction["payload_valid_json_object"] is True
assert transaction["payload_persisted"] is False
@@ -2148,7 +2156,7 @@ def test_manual_sample_candidate_queue_transaction_route_is_post_only_and_no_wri
assert response.status_code == 200
assert data["mode"] == "manual_sample_candidate_queue_transaction_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["payload_received"] is True
assert data["transaction_preview_created"] is True
assert data["transaction_ready"] is False
@@ -3867,6 +3875,83 @@ def test_candidate_queue_review_decision_writer_cli_gate_is_non_writing():
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_review_decision_writer_preflight_is_payload_only():
from services.market_intel.candidate_queue_review_decision_writer_cli import (
build_candidate_queue_review_decision_writer_cli_plan,
)
from services.market_intel.candidate_queue_review_decision_writer_preflight import (
build_candidate_queue_review_decision_writer_preflight,
)
transaction, operator_evidence = _build_ready_review_decision_transaction()
writer_status = build_candidate_queue_review_decision_writer_cli_plan(
transaction_preview=transaction,
execute_requested=False,
apply_real_write=False,
)
preflight = build_candidate_queue_review_decision_writer_preflight(
writer_status=writer_status,
transaction_preview=transaction,
operator_evidence={
**operator_evidence,
"operator_confirmed_review_state_preflight_only": True,
},
)
token_leak = build_candidate_queue_review_decision_writer_preflight(
writer_status=writer_status,
transaction_preview=transaction,
operator_evidence={**operator_evidence, "approval_token": TEST_APPROVAL_TOKEN},
)
payload = json.dumps(preflight, ensure_ascii=False, sort_keys=True)
assert preflight["mode"] == (
"candidate_queue_review_decision_writer_preflight_preview"
)
assert preflight["target_table"] == "market_alert_review_queue"
assert preflight["target_operation"] == "update_review_state"
assert preflight["execute_requested"] is False
assert preflight["apply_real_write_requested"] is False
assert preflight["preflight_payload_ready"] is True
assert preflight["writer_status_safe"] is True
assert preflight["writer_implementation_enabled"] is False
assert preflight["preflight_ready"] is False
assert preflight["ready_for_real_write"] is False
assert preflight["ready_for_api_review_state_update"] is False
assert preflight["ready_for_api_database_write"] is False
assert preflight["api_executes_cli"] is False
assert preflight["api_reads_approval_token"] is False
assert preflight["api_writes_database"] is False
assert preflight["api_updates_review_state"] is False
assert preflight["review_state_update_executed"] is False
assert preflight["read_only_query_executed"] is False
assert preflight["database_connection_opened"] is False
assert preflight["database_session_created"] is False
assert preflight["transaction_opened"] is False
assert preflight["transaction_committed"] is False
assert preflight["database_write_executed"] is False
assert preflight["database_commit_executed"] is False
assert preflight["scheduler_attached"] is False
assert preflight["writes_executed"] is False
assert preflight["would_write_database"] is False
assert preflight["statement_summary"]["statement_count"] == 1
assert preflight["statement_summary"]["invalid_statement_count"] == 0
assert preflight["statement_summary"]["review_state_updates"][0][
"next_review_state"
] == "confirmed"
assert preflight["update_contract"]["expected_current_review_state"] == (
"needs_review"
)
assert preflight["catalog_probe_plan"]["read_only_query_executed"] is False
assert "review_decision_writer_implementation_enabled" in preflight[
"blocked_reasons"
]
assert "do_not_update_review_state_from_review_state_preflight" in preflight[
"safe_boundaries"
]
assert "preflight_no_token_submitted_to_api" in token_leak["blocked_reasons"]
assert TEST_APPROVAL_TOKEN not in payload
def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
@@ -3909,7 +3994,7 @@ def test_candidate_queue_writer_preflight_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_preflight_planned"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -3966,7 +4051,7 @@ def test_candidate_queue_writer_status_route_never_leaks_approval_token(monkeypa
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_cli_blocked"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["approval_token_present"] is False
@@ -4055,7 +4140,7 @@ def test_candidate_queue_writer_postwrite_smoke_route_is_post_only_and_no_write(
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_postwrite_smoke_planned"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
@@ -4109,7 +4194,7 @@ def test_candidate_queue_writer_operator_drill_route_is_post_only_and_no_write()
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_operator_drill_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["operator_drill_ready"] is True
assert data["api_executes_cli"] is False
assert data["api_reads_approval_token"] is False
@@ -4165,7 +4250,7 @@ def test_candidate_queue_writer_run_package_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_package_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["package_ready"] is True
assert data["package_artifact_created"] is False
assert data["api_writes_file"] is False
@@ -4231,7 +4316,7 @@ def test_candidate_queue_writer_run_readiness_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_readiness_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["ready_for_cli_operator_run"] is True
assert data["ready_for_api_database_write"] is False
assert data["api_executes_cli"] is False
@@ -4533,7 +4618,7 @@ def test_candidate_queue_writer_run_receipt_route_accepts_inline_payload_no_writ
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["receipt_passed"] is True
assert data["ready_for_api_database_write"] is False
assert data["ready_for_scheduler_attach"] is False
@@ -4581,7 +4666,7 @@ def test_candidate_queue_writer_run_closeout_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_closeout_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["closeout_passed"] is True
assert data["ready_for_next_manual_phase"] is True
assert data["ready_for_api_database_write"] is False
@@ -4630,7 +4715,7 @@ def test_candidate_queue_review_handoff_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_handoff_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["handoff_ready"] is True
assert data["ready_for_manual_queue_review"] is True
assert data["ready_for_api_database_write"] is False
@@ -4688,7 +4773,7 @@ def test_candidate_queue_review_inventory_route_is_post_only_and_no_write():
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_inventory_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["review_inventory_ready"] is False
assert data["ready_for_human_decision_review"] is False
@@ -4754,7 +4839,7 @@ def test_candidate_queue_review_decision_route_is_post_only_and_no_write():
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["decision_ready"] is False
assert data["ready_for_human_decision_record"] is False
assert data["ready_for_api_review_state_update"] is False
@@ -4825,7 +4910,7 @@ def test_candidate_queue_review_decision_approval_route_is_post_only_and_no_writ
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_approval_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["approval_ready"] is False
assert data["ready_for_review_state_transaction_preview"] is False
assert data["ready_for_cli_decision_writer"] is False
@@ -4901,7 +4986,7 @@ def test_candidate_queue_review_decision_transaction_route_is_post_only_and_no_w
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_transaction_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["transaction_preview_created"] is False
assert data["transaction_ready"] is False
assert data["ready_for_manual_shell_update_window"] is False
@@ -4983,7 +5068,7 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["approval_token_present"] is False
@@ -5014,6 +5099,90 @@ def test_candidate_queue_review_decision_writer_status_route_is_post_only_and_no
]
def test_candidate_queue_review_decision_writer_preflight_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
from routes.market_intel_review_routes import market_intel_review_bp
fixture = _build_candidate_queue_writer_receipt_fixture(
"sample-batch-review-decision-preflight-route"
)
app = Flask(__name__)
app.secret_key = "test-secret"
app.register_blueprint(market_intel_bp)
app.register_blueprint(market_intel_review_bp)
client = app.test_client()
with client.session_transaction() as session:
session["logged_in"] = True
get_response = client.get(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_preflight"
)
response = client.post(
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_preflight?execute=true"
"&apply_real_write=true",
json={
"sample_result": fixture["sample_result"],
"operator_evidence": {
**fixture["operator_evidence"],
"closeout_artifact_path": "artifacts/market_intel/closeout.json",
"operator_confirmed_queue_review_next": True,
"operator_confirmed_no_scheduler_attach": True,
"operator_confirmed_no_api_db_write": True,
"operator_confirmed_inventory_read_only": True,
"reviewer_id": "operator-a",
"proposed_review_decision": "confirmed",
"decision_notes": "manual review only",
"operator_confirmed_manual_decision_only": True,
"decision_approval_notes": "cli-only approval gate",
"operator_confirmed_decision_payload_reviewed": True,
"operator_confirmed_decision_apply_requires_cli": True,
"operator_confirmed_review_state_update_is_not_api": True,
"decision_transaction_notes": "shell-only transaction preview",
"operator_confirmed_transaction_payload_reviewed": True,
"operator_confirmed_cli_only_transaction": True,
},
"writer_output": fixture["writer_output"],
"postwrite_smoke_result": fixture["postwrite_smoke_result"],
},
)
data = response.get_json()
assert get_response.status_code == 405
assert response.status_code == 200
assert data["mode"] == (
"candidate_queue_review_decision_writer_preflight_preview"
)
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is True
assert data["apply_real_write_requested"] is True
assert data["read_only_query_executed"] is False
assert data["database_connection_opened"] is False
assert data["database_session_created"] is False
assert data["explicit_transaction_opened"] is False
assert data["transaction_opened"] is False
assert data["transaction_committed"] is False
assert data["database_write_executed"] is False
assert data["database_commit_executed"] is False
assert data["review_state_update_executed"] is False
assert data["api_updates_review_state"] is False
assert data["scheduler_attached"] is False
assert data["writes_executed"] is False
assert data["would_write_database"] is False
assert data["preflight_payload_ready"] is False
assert data["statement_summary"]["statement_count"] == 0
assert "statement_payloads_present" in data["blocked_reasons"]
assert "preflight_execute_not_requested_from_api" in data["blocked_reasons"]
assert "preflight_apply_real_write_not_requested_from_api" in data[
"blocked_reasons"
]
assert "review_decision_writer_implementation_enabled" in data["blocked_reasons"]
assert "do_not_update_review_state_from_review_state_preflight" in data[
"safe_boundaries"
]
def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
from routes.market_intel_routes import market_intel_bp
@@ -5042,7 +5211,7 @@ def test_candidate_queue_writer_run_receipt_route_is_post_only_and_no_write():
assert response.status_code == 200
assert data["mode"] == "candidate_queue_writer_run_receipt_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["receipt_passed"] is True
assert data["ready_for_next_manual_review"] is True
assert data["ready_for_api_database_write"] is False
@@ -5067,7 +5236,7 @@ def test_scheduler_plan_preview_blocks_job_attachment():
plan = MarketIntelService().build_scheduler_plan()
assert plan["mode"] == "scheduler_attach_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_to_attach_scheduler"] is False
assert plan["scheduler_attached"] is False
assert plan["scheduler_registration_executed"] is False
@@ -5105,7 +5274,7 @@ def test_scheduler_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "scheduler_attach_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["scheduler_registration_executed"] is False
assert data["crawler_job_started"] is False
assert data["external_network_executed"] is False
@@ -5116,7 +5285,7 @@ def test_match_review_plan_preview_blocks_auto_confirm():
plan = MarketIntelService().build_match_review_plan()
assert plan["mode"] == "match_review_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_for_review_queue"] is False
assert plan["review_queue_created"] is False
assert plan["auto_match_executed"] is False
@@ -5152,7 +5321,7 @@ def test_match_review_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "match_review_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["review_queue_created"] is False
assert data["auto_confirm_executed"] is False
assert data["external_network_executed"] is False
@@ -5163,7 +5332,7 @@ def test_opportunity_plan_preview_blocks_alerts_and_ai_summary():
plan = MarketIntelService().build_opportunity_plan()
assert plan["mode"] == "opportunity_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_for_opportunity_queue"] is False
assert plan["opportunity_queue_created"] is False
assert plan["threat_alert_dispatched"] is False
@@ -5204,7 +5373,7 @@ def test_opportunity_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["opportunity_queue_created"] is False
assert data["threat_alert_dispatched"] is False
assert data["ai_summary_generated"] is False
@@ -5215,7 +5384,7 @@ def test_opportunity_scoring_plan_preview_blocks_scoring_and_alerts():
plan = MarketIntelService().build_opportunity_scoring_plan()
assert plan["mode"] == "opportunity_scoring_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_for_scoring_job"] is False
assert plan["scoring_job_created"] is False
assert plan["score_calculation_executed"] is False
@@ -5263,7 +5432,7 @@ def test_opportunity_scoring_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_scoring_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["scoring_job_created"] is False
assert data["score_calculation_executed"] is False
assert data["sample_scores_generated"] is False
@@ -5275,7 +5444,7 @@ def test_opportunity_evidence_plan_preview_blocks_queries_and_alerts():
plan = MarketIntelService().build_opportunity_evidence_plan()
assert plan["mode"] == "opportunity_evidence_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_for_evidence_bundle"] is False
assert plan["evidence_bundle_created"] is False
assert plan["evidence_query_executed"] is False
@@ -5321,7 +5490,7 @@ def test_opportunity_evidence_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_evidence_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["evidence_bundle_created"] is False
assert data["evidence_query_executed"] is False
assert data["sample_evidence_generated"] is False
@@ -5334,7 +5503,7 @@ def test_opportunity_alert_plan_preview_blocks_dispatch_and_llm_calls():
plan = MarketIntelService().build_opportunity_alert_plan()
assert plan["mode"] == "opportunity_alert_plan_preview"
assert plan["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert plan["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert plan["ready_for_alert_candidates"] is False
assert plan["alert_candidate_created"] is False
assert plan["alert_queue_created"] is False
@@ -5419,7 +5588,7 @@ def test_opportunity_alert_plan_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "opportunity_alert_plan_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["alert_candidate_created"] is False
assert data["alert_queue_created"] is False
assert data["review_queue_created"] is False
@@ -5497,7 +5666,7 @@ def test_mcp_deploy_preflight_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "mcp_external_deploy_preflight_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["deployment_actions_executed"] is False
assert data["docker_command_executed"] is False
assert data["ssh_command_executed"] is False
@@ -5512,7 +5681,7 @@ def test_mcp_readiness_default_is_planned_only(monkeypatch):
readiness = MarketIntelService().build_mcp_readiness()
assert readiness["mode"] == "mcp_readiness_planned"
assert readiness["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert readiness["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert readiness["execute_requested"] is False
assert readiness["router_enabled"] is False
assert readiness["external_mcp_complete"] is False
@@ -5958,6 +6127,12 @@ def test_deployment_readiness_reports_app_only_release_gate():
]
is True
)
assert (
readiness["checks"][
"candidate_queue_review_decision_writer_preflight_safe"
]
is True
)
assert (
readiness["checks"][
"candidate_queue_review_decision_writer_cli_status_safe"
@@ -6052,6 +6227,11 @@ def test_deployment_readiness_reports_app_only_release_gate():
"candidate_queue_review_decision_transaction"
in readiness["production_smoke_targets"]
)
assert (
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_preflight"
in readiness["production_smoke_targets"]
)
assert (
"/api/market_intel/manual_sample_review/"
"candidate_queue_review_decision_writer_status"
@@ -6837,6 +7017,64 @@ def test_deployment_readiness_reports_app_only_release_gate():
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"]["mode"]
== "candidate_queue_review_decision_writer_preflight_preview"
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"preflight_payload_ready"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"ready_for_api_review_state_update"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"api_updates_review_state"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"read_only_query_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"database_connection_opened"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"database_write_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"database_commit_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"review_state_update_executed"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_preflight"][
"scheduler_attached"
]
is False
)
assert (
readiness["candidate_queue_review_decision_writer_status"]["mode"]
== "candidate_queue_review_decision_writer_cli_blocked"
@@ -6987,7 +7225,7 @@ def test_migration_apply_drill_planned_is_safe_and_manual_only():
drill = MarketIntelService().build_migration_apply_drill()
assert drill["mode"] == "migration_apply_drill_preview"
assert drill["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert drill["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert drill["execute_requested"] is False
assert drill["schema_state"] == "planned_no_db_probe"
assert drill["drill_ready_for_operator_review"] is True
@@ -7102,7 +7340,7 @@ def test_migration_apply_drill_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_apply_drill_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["migration_executed"] is False
assert data["rollback_executed"] is False
@@ -7114,7 +7352,7 @@ def test_migration_catalog_review_planned_is_safe_and_diagnostic():
review = MarketIntelService().build_migration_catalog_review()
assert review["mode"] == "migration_catalog_review_preview"
assert review["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert review["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert review["execute_requested"] is False
assert review["catalog_state"] == "planned_no_probe"
assert review["seed_state"] == "planned_no_probe"
@@ -7229,7 +7467,7 @@ def test_migration_catalog_review_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_catalog_review_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["catalog_state"] == "planned_no_probe"
assert data["migration_executed"] is False
@@ -7242,7 +7480,7 @@ def test_migration_live_smoke_planned_is_preview_only():
smoke = MarketIntelService().build_migration_live_smoke()
assert smoke["mode"] == "migration_live_smoke_preview"
assert smoke["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert smoke["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert smoke["execute_requested"] is False
assert smoke["smoke_result"] == "planned_no_execution"
assert smoke["live_smoke_passed"] is False
@@ -7304,7 +7542,7 @@ def test_migration_live_smoke_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "migration_live_smoke_preview"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["smoke_result"] == "planned_no_execution"
assert data["migration_executed"] is False
@@ -7317,7 +7555,7 @@ def test_live_db_inventory_planned_is_preview_only():
inventory = MarketIntelService().build_live_db_inventory()
assert inventory["mode"] == "live_db_inventory_planned"
assert inventory["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert inventory["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert inventory["execute_requested"] is False
assert inventory["read_only_query_executed"] is False
assert inventory["database_connection_opened"] is False
@@ -7461,7 +7699,7 @@ def test_live_db_inventory_route_is_preview_only():
assert response.status_code == 200
assert data["mode"] == "live_db_inventory_planned"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["read_only_query_executed"] is False
assert data["database_write_executed"] is False
@@ -7688,7 +7926,7 @@ def test_candidate_queue_writer_cli_script_outputs_blocked_gate(tmp_path):
assert result.returncode == 0
assert data["mode"] == "candidate_queue_writer_cli_blocked"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["apply_real_write_requested"] is False
assert data["writes_executed"] is False
@@ -7717,7 +7955,7 @@ def test_review_decision_writer_cli_script_outputs_blocked_gate_without_login_en
assert result.returncode == 0
assert data["mode"] == "candidate_queue_review_decision_writer_cli_blocked"
assert data["phase"] == "phase_69_candidate_queue_review_decision_writer_cli"
assert data["phase"] == "phase_70_candidate_queue_review_decision_writer_preflight"
assert data["execute_requested"] is False
assert data["apply_real_write_requested"] is False
assert data["approval_token_present"] is False