From efb38cf6af334d729caa71b52fe9cd1e639688b5 Mon Sep 17 00:00:00 2001 From: Your Name Date: Thu, 21 May 2026 10:51:20 +0800 Subject: [PATCH] feat(awooop): verify source correlation links in status chain --- .../src/services/platform_operator_service.py | 53 +++++++- .../test_awooop_operator_timeline_labels.py | 118 +++++++++++++++++- apps/web/messages/en.json | 15 ++- apps/web/messages/zh-TW.json | 15 ++- .../src/components/awooop/status-chain.tsx | 44 ++++++- docs/LOGBOOK.md | 54 ++++++++ ...-04-15-MASTER-ai-autonomous-flywheel-v2.md | 8 ++ 7 files changed, 298 insertions(+), 9 deletions(-) diff --git a/apps/api/src/services/platform_operator_service.py b/apps/api/src/services/platform_operator_service.py index 577780452..28edb2a45 100644 --- a/apps/api/src/services/platform_operator_service.py +++ b/apps/api/src/services/platform_operator_service.py @@ -1332,18 +1332,24 @@ def _source_correlation_empty( "incident_ids": incident_ids, "direct_ref_total": 0, "candidate_total": 0, + "applied_link_total": 0, "provider_event_total": 0, + "latest_applied_link_at": None, + "verification_status": status_value, "providers": { provider: { "direct_ref_total": 0, "candidate_total": 0, + "applied_link_total": 0, "latest_event_at": None, "latest_heartbeat_at": None, + "latest_applied_link_at": None, } for provider in _SOURCE_CORRELATION_PROVIDERS }, "top_candidates": [], "matching_criteria": [ + "source_correlation_linked_stage", "direct_source_ref", "fingerprint_overlap", "alertname_overlap", @@ -1557,6 +1563,17 @@ def _score_source_correlation_event( } +def _is_source_correlation_applied_link( + event_context: dict[str, Any], + scored: dict[str, Any], +) -> bool: + """Applied source links must be append-only events that still match directly.""" + return ( + str(event_context.get("stage") or "").lower() == "source_correlation_linked" + and bool(scored.get("is_direct")) + ) + + async def _fetch_source_correlation_summary( *, project_id: str, @@ -1689,6 +1706,19 @@ async def _fetch_source_correlation_summary( summary["candidate_total"] += 1 provider_item["candidate_total"] += 1 + is_applied_link = _is_source_correlation_applied_link( + event_context, + best_match, + ) + if is_applied_link: + applied_at = _iso_or_none(row.get("received_at")) + summary["applied_link_total"] += 1 + provider_item["applied_link_total"] += 1 + if summary.get("latest_applied_link_at") is None: + summary["latest_applied_link_at"] = applied_at + if provider_item.get("latest_applied_link_at") is None: + provider_item["latest_applied_link_at"] = applied_at + top_candidates.append( { "provider": provider, @@ -1696,19 +1726,40 @@ async def _fetch_source_correlation_summary( "stage": str(event_context.get("stage") or ""), "score": best_match["score"], "match_type": "direct" if best_match["is_direct"] else "candidate", + "link_state": ( + "applied" + if is_applied_link + else "direct_ref" + if best_match["is_direct"] + else "candidate" + ), + "verification_status": ( + "applied_link_verified" + if is_applied_link + else "direct_ref_verified" + if best_match["is_direct"] + else "candidate_only" + ), "reasons": best_match["reasons"], "received_at": _iso_or_none(row.get("received_at")), } ) - if summary["direct_ref_total"] > 0: + if summary["applied_link_total"] > 0: summary["status"] = "linked" + summary["verification_status"] = "applied_link_verified" + summary["missing_reason"] = None + elif summary["direct_ref_total"] > 0: + summary["status"] = "linked" + summary["verification_status"] = "direct_ref_verified" summary["missing_reason"] = None elif summary["candidate_total"] > 0: summary["status"] = "candidate_found" + summary["verification_status"] = "candidate_only" summary["missing_reason"] = None elif any(item.get("latest_heartbeat_at") for item in providers.values()): summary["status"] = "provider_fresh_no_match" + summary["verification_status"] = "provider_fresh_no_match" summary["missing_reason"] = "provider_heartbeat_present_but_no_incident_match" summary["top_candidates"] = sorted( diff --git a/apps/api/tests/test_awooop_operator_timeline_labels.py b/apps/api/tests/test_awooop_operator_timeline_labels.py index fdd5f4437..c3b96cfb4 100644 --- a/apps/api/tests/test_awooop_operator_timeline_labels.py +++ b/apps/api/tests/test_awooop_operator_timeline_labels.py @@ -21,6 +21,7 @@ from src.services.platform_operator_service import ( _callback_reply_event_item, _callback_reply_summary_matches_status, _collect_run_incident_ids, + _is_source_correlation_applied_link, _legacy_mcp_timeline_status, _legacy_mcp_timeline_summary, _list_filter_context_limit, @@ -33,6 +34,7 @@ from src.services.platform_operator_service import ( _run_callback_reply_summary, _run_remediation_list_summary, _score_source_correlation_event, + _source_event_correlation_context, _timeline_sort_key, _validate_ai_route_workload, _validate_callback_reply_action_filter, @@ -612,12 +614,22 @@ def test_awooop_status_chain_includes_source_provider_correlation() -> None: source_correlation={ "schema_version": "source_provider_correlation_v1", "status": "candidate_found", + "verification_status": "candidate_only", "direct_ref_total": 0, "candidate_total": 2, + "applied_link_total": 0, "provider_event_total": 2, "providers": { - "sentry": {"direct_ref_total": 0, "candidate_total": 1}, - "signoz": {"direct_ref_total": 0, "candidate_total": 1}, + "sentry": { + "direct_ref_total": 0, + "candidate_total": 1, + "applied_link_total": 0, + }, + "signoz": { + "direct_ref_total": 0, + "candidate_total": 1, + "applied_link_total": 0, + }, }, "top_candidates": [ { @@ -634,10 +646,56 @@ def test_awooop_status_chain_includes_source_provider_correlation() -> None: correlation = chain["source_refs"]["correlation"] assert correlation["status"] == "candidate_found" assert correlation["candidate_total"] == 2 + assert correlation["verification_status"] == "candidate_only" assert correlation["providers"]["sentry"]["candidate_total"] == 1 assert correlation["top_candidates"][0]["provider_event_id"] == "sentry:issue:1" +def test_awooop_status_chain_preserves_applied_source_link_verification() -> None: + chain = _build_awooop_status_chain( + incident_ids=["INC-20260520-4D1124"], + source_id="INC-20260520-4D1124", + source_correlation={ + "schema_version": "source_provider_correlation_v1", + "status": "linked", + "verification_status": "applied_link_verified", + "direct_ref_total": 1, + "candidate_total": 0, + "applied_link_total": 1, + "latest_applied_link_at": "2026-05-21T02:03:04", + "provider_event_total": 1, + "providers": { + "sentry": { + "direct_ref_total": 1, + "candidate_total": 0, + "applied_link_total": 1, + "latest_applied_link_at": "2026-05-21T02:03:04", + }, + }, + "top_candidates": [ + { + "provider": "sentry", + "provider_event_id": "sentry:source_correlation_linked:issue-1", + "stage": "source_correlation_linked", + "score": 100, + "match_type": "direct", + "link_state": "applied", + "verification_status": "applied_link_verified", + "reasons": ["direct_incident_ref"], + } + ], + }, + ) + + correlation = chain["source_refs"]["correlation"] + assert correlation["status"] == "linked" + assert correlation["verification_status"] == "applied_link_verified" + assert correlation["applied_link_total"] == 1 + assert correlation["latest_applied_link_at"] == "2026-05-21T02:03:04" + assert correlation["providers"]["sentry"]["applied_link_total"] == 1 + assert correlation["top_candidates"][0]["link_state"] == "applied" + + def test_source_correlation_scoring_distinguishes_direct_and_candidate() -> None: incident_context = { "incident_ids": ["INC-20260520-4D1124"], @@ -684,6 +742,62 @@ def test_source_correlation_scoring_distinguishes_direct_and_candidate() -> None assert unrelated["is_candidate"] is False +def test_source_correlation_applied_link_requires_stage_and_direct_match() -> None: + incident_context = { + "incident_ids": ["INC-20260520-4D1124"], + "alertnames": ["sentry issue"], + "severities": ["error"], + "fingerprints": ["fp-sentry-1"], + "namespaces": ["awoooi-prod"], + "targets": ["web"], + } + event_context = _source_event_correlation_context({ + "provider": "sentry", + "provider_event_id": "sentry:source_correlation_linked:issue-1", + "received_at": datetime(2026, 5, 21, 2, 3, 4), + "source_envelope": { + "provider": "sentry", + "stage": "source_correlation_linked", + "source_refs": { + "incident_ids": ["INC-20260520-4D1124"], + "fingerprints": ["fp-sentry-1"], + }, + "log_correlation": { + "alertname": "Sentry Issue", + "severity": "error", + "namespace": "awoooi-prod", + "target_resource": "web", + }, + }, + }) + scored = _score_source_correlation_event(incident_context, event_context) + + assert scored["is_direct"] is True + assert _is_source_correlation_applied_link(event_context, scored) is True + + candidate_only_context = { + **event_context, + "incident_ids": [], + "fingerprints": [], + } + candidate_only = _score_source_correlation_event( + incident_context, + candidate_only_context, + ) + non_link_stage = { + **event_context, + "stage": "upstream_canary", + } + + assert candidate_only["is_direct"] is False + assert candidate_only["is_candidate"] is True + assert _is_source_correlation_applied_link( + candidate_only_context, + candidate_only, + ) is False + assert _is_source_correlation_applied_link(non_link_stage, scored) is False + + def test_awooop_status_chain_marks_read_only_manual_gate() -> None: chain = _build_awooop_status_chain( incident_ids=["INC-20260513-79ED5E"], diff --git a/apps/web/messages/en.json b/apps/web/messages/en.json index 48b9712c8..f35af97cd 100644 --- a/apps/web/messages/en.json +++ b/apps/web/messages/en.json @@ -2565,8 +2565,10 @@ }, "source": { "status": "Source Link", - "directCandidate": "Direct / Candidate", - "directCandidateValue": "{direct} / {candidate}", + "verification": "Status-chain Verification", + "directCandidate": "Direct / Candidate / Applied", + "directCandidateValue": "{direct} / {candidate} / {applied}", + "latestApplied": "Latest Applied Event", "providers": "Provider", "statuses": { "linked": "Directly linked", @@ -2575,6 +2577,15 @@ "missing": "No match yet", "noIncidentContext": "Missing incident context", "fetchFailed": "Read failed" + }, + "verificationStatuses": { + "appliedLinkVerified": "Applied and verified", + "directRefVerified": "Direct ref verified", + "candidateOnly": "Candidate only", + "providerFreshNoMatch": "Provider fresh, no match", + "missing": "No match yet", + "noIncidentContext": "Missing incident context", + "fetchFailed": "Read failed" } } }, diff --git a/apps/web/messages/zh-TW.json b/apps/web/messages/zh-TW.json index 87e375cd9..ef95cf77f 100644 --- a/apps/web/messages/zh-TW.json +++ b/apps/web/messages/zh-TW.json @@ -2566,8 +2566,10 @@ }, "source": { "status": "來源關聯", - "directCandidate": "Direct / Candidate", - "directCandidateValue": "{direct} / {candidate}", + "verification": "狀態鏈驗證", + "directCandidate": "Direct / Candidate / Applied", + "directCandidateValue": "{direct} / {candidate} / {applied}", + "latestApplied": "最新套用事件", "providers": "Provider", "statuses": { "linked": "已直接關聯", @@ -2576,6 +2578,15 @@ "missing": "尚無匹配", "noIncidentContext": "缺 Incident 脈絡", "fetchFailed": "讀取失敗" + }, + "verificationStatuses": { + "appliedLinkVerified": "已套用且驗證", + "directRefVerified": "直接關聯已驗證", + "candidateOnly": "僅候選，待確認", + "providerFreshNoMatch": "Provider 新鮮但未匹配", + "missing": "尚無匹配", + "noIncidentContext": "缺 Incident 脈絡", + "fetchFailed": "讀取失敗" } } }, diff --git a/apps/web/src/components/awooop/status-chain.tsx b/apps/web/src/components/awooop/status-chain.tsx index 06c81aa17..b3f79b7a7 100644 --- a/apps/web/src/components/awooop/status-chain.tsx +++ b/apps/web/src/components/awooop/status-chain.tsx @@ -103,14 +103,19 @@ export interface AwoooPStatusChain { schema_version?: string; status?: string | null; missing_reason?: string | null; + verification_status?: string | null; direct_ref_total?: number | null; candidate_total?: number | null; + applied_link_total?: number | null; provider_event_total?: number | null; + latest_applied_link_at?: string | null; providers?: Record; top_candidates?: Array<{ provider?: string | null; @@ -118,6 +123,8 @@ export interface AwoooPStatusChain { stage?: string | null; score?: number | null; match_type?: string | null; + link_state?: string | null; + verification_status?: string | null; reasons?: string[]; received_at?: string | null; }>; @@ -222,10 +229,27 @@ export function AwoooPStatusChainPanel({ no_incident_context: t("source.statuses.noIncidentContext"), fetch_failed: t("source.statuses.fetchFailed"), }; + const sourceVerificationLabels: Record = { + applied_link_verified: t("source.verificationStatuses.appliedLinkVerified"), + direct_ref_verified: t("source.verificationStatuses.directRefVerified"), + candidate_only: t("source.verificationStatuses.candidateOnly"), + provider_fresh_no_match: t("source.verificationStatuses.providerFreshNoMatch"), + missing: t("source.verificationStatuses.missing"), + no_incident_context: t("source.verificationStatuses.noIncidentContext"), + fetch_failed: t("source.verificationStatuses.fetchFailed"), + }; const sourceStatus = String(sourceCorrelation?.status ?? "missing"); + const sourceVerificationStatus = String(sourceCorrelation?.verification_status ?? sourceStatus); + const topAppliedLink = sourceCorrelation?.top_candidates?.find( + (item) => item.link_state === "applied" + ); + const latestAppliedLabel = valueOrEmpty( + topAppliedLink?.provider_event_id ?? sourceCorrelation?.latest_applied_link_at, + emptyLabel + ); const sourceProviderSummary = ["sentry", "signoz"].map((provider) => { const providerItem = sourceCorrelation?.providers?.[provider]; - return `${provider} ${providerItem?.direct_ref_total ?? 0}/${providerItem?.candidate_total ?? 0}`; + return `${provider} ${providerItem?.direct_ref_total ?? 0}/${providerItem?.candidate_total ?? 0}/${providerItem?.applied_link_total ?? 0}`; }).join(" · "); return ( @@ -300,22 +324,38 @@ export function AwoooPStatusChainPanel({ {sourceCorrelation && ( -
+

{t("source.status")}

{sourceStatusLabels[sourceStatus] ?? valueOrEmpty(sourceCorrelation.status, emptyLabel)}

+
+

{t("source.verification")}

+

+ {sourceVerificationLabels[sourceVerificationStatus] ?? valueOrEmpty(sourceVerificationStatus, emptyLabel)} +

+

{t("source.directCandidate")}

{t("source.directCandidateValue", { direct: sourceCorrelation.direct_ref_total ?? 0, candidate: sourceCorrelation.candidate_total ?? 0, + applied: sourceCorrelation.applied_link_total ?? 0, })}

+
+

{t("source.latestApplied")}

+

+ {latestAppliedLabel} +

+

{t("source.providers")}

diff --git a/docs/LOGBOOK.md b/docs/LOGBOOK.md index f73672f71..04b8b2f5f 100644 --- a/docs/LOGBOOK.md +++ b/docs/LOGBOOK.md @@ -1,3 +1,57 @@ +## 2026-05-21｜T119 Source correlation status-chain verification + +**觸發**： + +- T118 已能把 accepted source review append 成 `source_correlation_linked` source event。 +- 但 AwoooP Status Chain 仍只看得出 linked / candidate，前端無法明確回答「已套用的來源配對是否被狀態鏈驗證讀回」。 + +**修正**： + +- `platform_operator_service` 的 source correlation summary 新增： + - `applied_link_total`。 + - `latest_applied_link_at`。 + - `verification_status`（`applied_link_verified` / `direct_ref_verified` / `candidate_only` / freshness / missing 類狀態）。 + - provider-level `applied_link_total` 與 `latest_applied_link_at`。 +- `source_correlation_linked` 來源事件必須同時直接匹配 Incident（direct incident ref 或 fingerprint）才會被標成 `applied_link_verified`。 +- Status Chain 共用前端面板新增： + - 狀態鏈驗證欄。 + - Direct / Candidate / Applied 三段統計。 + - 最新套用事件。 + - provider-level direct/candidate/applied 摘要。 +- 影響範圍涵蓋 Runs、Approvals、Work Items 共用的 `AwoooPStatusChainPanel`，避免只修單頁。 + +**Verification**： + +```text +python -m py_compile apps/api/src/services/platform_operator_service.py + -> pass +DATABASE_URL=postgresql+asyncpg://test:test@localhost/test pytest -q apps/api/tests/test_awooop_operator_timeline_labels.py + -> 39 passed +pnpm --dir apps/web exec tsc --noEmit + -> pass +NEXT_PUBLIC_API_URL=https://awoooi.wooo.work pnpm --dir apps/web run build + -> compiled successfully, 90/90 static pages +python -m ruff check --ignore B008 apps/api/src/services/platform_operator_service.py apps/api/tests/test_awooop_operator_timeline_labels.py + -> pass +python -m json.tool apps/web/messages/zh-TW.json +python -m json.tool apps/web/messages/en.json + -> pass +git diff --check + -> pass +Browser local check: + -> http://localhost:3035/zh-TW/awooop/work-items rendered + -> sidebar/nav visible + -> Status Chain panel present with 狀態鏈驗證 label +``` + +**目前整體進度**： + +- Source correlation apply 狀態鏈可驗證性：0% → 85%（local contract 已完成，production smoke 待推版後補證）。 +- Incident-level source correlation 可見性：93% → 95%。 +- AwoooP 告警可觀測鏈：99.991% → 99.992%。 +- 前端 AI 自動化管理介面同步：99.99%（共用 status-chain panel 已能呈現來源套用驗證）。 +- 完整 AI 自動化管理產品化：99.76% → 99.78%。 + ## 2026-05-21｜T118 Source correlation apply append-only link **觸發**： diff --git a/docs/superpowers/specs/2026-04-15-MASTER-ai-autonomous-flywheel-v2.md b/docs/superpowers/specs/2026-04-15-MASTER-ai-autonomous-flywheel-v2.md index 450ffea43..30be383bb 100644 --- a/docs/superpowers/specs/2026-04-15-MASTER-ai-autonomous-flywheel-v2.md +++ b/docs/superpowers/specs/2026-04-15-MASTER-ai-autonomous-flywheel-v2.md @@ -2541,6 +2541,14 @@ Phase 6 完成後 - Production / CI：`fe3bf5dc feat(awooop): apply source correlation links` 已推 Gitea main；deploy marker `593d928d chore(cd): deploy fe3bf5d [skip ci]`。Actions：#2704 Code Review success、#2703 CD success。Production health healthy/prod/mock_mode=false；recurrence `provider=sentry` 回 `source_correlation_applied_group_total=0`、`source_correlation_decision_recorded_group_total=1`；apply smoke 對 `needs_more_evidence` canary 正確 blocked，write flags 全為 false；Work Items HTTP 200。 - 目前進度更新：AwoooP 告警可觀測鏈約 99.991%；Source refs / Sentry / SigNoz 可見性約 99.96%；Incident-level source correlation 可見性約 93%；Source correlation review 可處理性約 90%；完整 AI 自動化管理產品化約 99.76%。 +**T119 Source correlation status-chain verification（2026-05-21 台北）**： +- 觸發：T118 已能 append `source_correlation_linked` 來源事件，但 Status Chain 仍只顯示 linked / candidate，operator 無法判斷「已套用」是否真的被狀態鏈讀回並驗證。 +- 修正：source correlation summary 新增 `applied_link_total`、`latest_applied_link_at`、`verification_status`，provider-level 同步新增 `applied_link_total` 與 `latest_applied_link_at`。`source_correlation_linked` 必須仍能直接匹配 Incident 才標示為 `applied_link_verified`。 +- UI：共用 `AwoooPStatusChainPanel` 新增狀態鏈驗證、Direct / Candidate / Applied、最新套用事件與 provider direct/candidate/applied 摘要；Runs、Approvals、Work Items 共用受益。 +- 安全邊界：本段只讀取已存在的 append-only source event，不改 Incident、不改 auto-repair、不建立 ticket、不新增外部副作用。 +- Local verification：`py_compile` pass；targeted pytest `39 passed`；web typecheck pass；production URL build 90/90 static pages；i18n JSON ok；targeted ruff pass；`git diff --check` pass；browser local check 確認 `/zh-TW/awooop/work-items` nav 可見且 Status Chain panel 顯示「狀態鏈驗證」。 +- 目前進度更新：AwoooP 告警可觀測鏈約 99.992%；Source refs / Sentry / SigNoz 可見性約 99.97%；Incident-level source correlation 可見性約 95%；Source correlation apply 狀態鏈可驗證性約 85%（production smoke 待推版後補證）；完整 AI 自動化管理產品化約 99.78%。 + --- ### 2026-04-20 晚 (台北) — C1-C4 全流程串接 — Playbook 鏈路保護（commit de2d34d）