fix(reboot): surface windows99 collector metrics

apps/api/tests/test_reboot_auto_recovery_slo_scorecard_api.py

@@ -684,6 +684,49 @@ def test_reboot_slo_prometheus_readback_uses_single_combined_query(monkeypatch):
                 }
                 for alias in ["111", "112", "120", "121", "188"]
             ],
+            {
+                "metric": {
+                    "__name__": (
+                        "awoooi_windows99_no_secret_collector_readback_present"
+                    ),
+                },
+                "value": [1783010479, "1"],
+            },
+            {
+                "metric": {
+                    "__name__": "awoooi_windows99_no_secret_collector_status",
+                    "status": "blocked_ssh_publickey_auth_missing",
+                    "safe_next_step": (
+                        "select_existing_authorized_public_key_user_or_set_"
+                        "WINDOWS99_SSH_USERS_then_rerun_collector_no_password"
+                    ),
+                },
+                "value": [1783010479, "1"],
+            },
+            {
+                "metric": {
+                    "__name__": (
+                        "awoooi_windows99_no_secret_collector_"
+                        "ssh_batchmode_auth_ready"
+                    ),
+                },
+                "value": [1783010479, "0"],
+            },
+            {
+                "metric": {
+                    "__name__": "awoooi_windows99_no_secret_collector_port_22_open",
+                },
+                "value": [1783010479, "1"],
+            },
+            {
+                "metric": {
+                    "__name__": (
+                        "awoooi_windows99_no_secret_collector_"
+                        "remote_verify_attempted"
+                    ),
+                },
+                "value": [1783010479, "0"],
+            },
         ]
 
     monkeypatch.setattr(
@@ -715,6 +758,67 @@ def test_reboot_slo_prometheus_readback_uses_single_combined_query(monkeypatch):
         "121",
         "188",
     ]
+    assert payload["windows99_no_secret_collector_readback_present"] is True
+    assert (
+        payload["windows99_no_secret_collector_status"]
+        == "blocked_ssh_publickey_auth_missing"
+    )
+    assert payload["windows99_no_secret_collector_port_22_open"] is True
+    assert (
+        payload["windows99_no_secret_collector_ssh_batchmode_auth_ready"] is False
+    )
+    assert (
+        payload["windows99_no_secret_collector_remote_verify_attempted"] is False
+    )
+
+
+def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_collector_blocker():
+    metric_readback = dict(PROMETHEUS_RUNTIME_READBACK)
+    metric_readback.update(
+        {
+            "windows99_vmware_readback_present": False,
+            "windows99_no_secret_collector_readback_present": True,
+            "windows99_no_secret_collector_status": (
+                "blocked_ssh_publickey_auth_missing"
+            ),
+            "windows99_no_secret_collector_safe_next_step": (
+                "select_existing_authorized_public_key_user_or_set_"
+                "WINDOWS99_SSH_USERS_then_rerun_collector_no_password"
+            ),
+            "windows99_no_secret_collector_ssh_batchmode_auth_ready": False,
+            "windows99_no_secret_collector_port_22_open": True,
+            "windows99_no_secret_collector_remote_verify_attempted": False,
+        }
+    )
+
+    payload = load_latest_reboot_auto_recovery_slo_scorecard(
+        prometheus_metric_readback=metric_readback
+    )
+
+    collection = payload["windows99_verify_collection"]
+    assert collection["no_secret_collector_readback_present"] is True
+    assert (
+        collection["no_secret_collector_status"]
+        == "blocked_ssh_publickey_auth_missing"
+    )
+    assert collection["no_secret_collector_port_22_open"] is True
+    assert collection["no_secret_collector_ssh_batchmode_auth_ready"] is False
+    assert collection["no_secret_collector_remote_verify_attempted"] is False
+    assert (
+        collection["no_secret_collector"]["source"]
+        == "prometheus_textfile_metric"
+    )
+    assert "windows99_ssh_publickey_auth_missing" in collection[
+        "collection_blockers"
+    ]
+    assert payload["readback"]["windows99_no_secret_collector_status"] == (
+        "blocked_ssh_publickey_auth_missing"
+    )
+    assert payload["readback"]["windows99_no_secret_collector_port_22_open"] is True
+    assert payload["rollups"]["windows99_no_secret_collector_status"] == (
+        "blocked_ssh_publickey_auth_missing"
+    )
+    assert payload["rollups"]["windows99_no_secret_collector_readback_present"] is True
 
 
 def test_reboot_auto_recovery_slo_scorecard_endpoint_returns_readback(monkeypatch):