From 90f392128de973af1bcddd3f7921991298c4a996 Mon Sep 17 00:00:00 2001 From: Your Name Date: Sun, 28 Jun 2026 19:35:55 +0800 Subject: [PATCH] fix(delivery): mark deploy source sha as observed readback --- apps/api/src/services/delivery_closure_workbench.py | 6 ++++-- apps/api/tests/test_delivery_closure_workbench_api.py | 6 +++--- .../awoooi-production-deploy-readback-blocker.snapshot.json | 4 ++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/apps/api/src/services/delivery_closure_workbench.py b/apps/api/src/services/delivery_closure_workbench.py index 08688ce81..725ed982f 100644 --- a/apps/api/src/services/delivery_closure_workbench.py +++ b/apps/api/src/services/delivery_closure_workbench.py @@ -118,8 +118,10 @@ def build_delivery_closure_workbench( "blocker_count": _int(production_deploy_rollups.get("hard_blocker_count")), "metric": { "kind": "deploy_readback", - "source_control_main_short_sha": str( - production_deploy_readback.get("source_control_main_short_sha") + "observed_source_control_main_short_sha": str( + production_deploy_readback.get( + "observed_source_control_main_short_sha" + ) or "" ), "production_image_tag_short_sha": str( diff --git a/apps/api/tests/test_delivery_closure_workbench_api.py b/apps/api/tests/test_delivery_closure_workbench_api.py index 6fbd30bbc..89b344ba5 100644 --- a/apps/api/tests/test_delivery_closure_workbench_api.py +++ b/apps/api/tests/test_delivery_closure_workbench_api.py @@ -77,9 +77,9 @@ def test_delivery_closure_workbench_endpoint_returns_product_summary(): "blocked_waiting_authorized_gitea_workflow_dispatch" ) assert lanes["production_deploy"]["blocker_count"] == 1 - assert lanes["production_deploy"]["metric"]["source_control_main_short_sha"] == ( - "718a5d04ad4f" - ) + assert lanes["production_deploy"]["metric"][ + "observed_source_control_main_short_sha" + ] == "718a5d04ad4f" assert lanes["production_deploy"]["metric"][ "production_image_tag_short_sha" ] == "af45811e87" diff --git a/docs/operations/awoooi-production-deploy-readback-blocker.snapshot.json b/docs/operations/awoooi-production-deploy-readback-blocker.snapshot.json index 3c09f761b..9e0f393be 100644 --- a/docs/operations/awoooi-production-deploy-readback-blocker.snapshot.json +++ b/docs/operations/awoooi-production-deploy-readback-blocker.snapshot.json @@ -5,8 +5,8 @@ "priority": "P0", "scope": "awoooi_production_truth", "readback": { - "source_control_main_sha": "718a5d04ad4f594ab28e15c528413cbf2714f3ed", - "source_control_main_short_sha": "718a5d04ad4f", + "observed_source_control_main_sha": "718a5d04ad4f594ab28e15c528413cbf2714f3ed", + "observed_source_control_main_short_sha": "718a5d04ad4f", "governance_closure_merge_sha": "27b96f0450d0e3ca6651d6b5f274a341dd727ef2", "governance_closure_commit_sha": "9e3e7fbb6ba3ffd324b45abf3ad1e7b6ec826b22", "production_image_tag_sha": "af45811e876fda322ee63c036fbc39c9f07ffd76",