fix(review): Code Review C1/C2/I2/M2 修補
Some checks failed
CD Pipeline / build-and-deploy (push) Has been cancelled

C1 drift_interpreter: 寫死 192.168.0.111 → settings.OLLAMA_URL
  違反 feedback_frontend_internal_ip_ban 鐵律(後端 service 層同樣禁止寫死內網 IP)

C2 km_conversion_service: BUG-004 補同步 Redis Working Memory vectorized 欄位
  原修復只更新 DB,Redis incident:{id} JSON 的 vectorized 未同步
  → 審計查 Redis 仍顯示 False,fly-wheel 閉環指標仍不準
  修復:DB 更新後 GET → JSON patch vectorized=True → SET(保留原 TTL)

I2 decision_manager: _ALERTNAME_KEYWORDS HostHighDiskUsage→HostOutOfDiskSpace
  + 補 DockerContainerExited
  + fallback 路徑加 debug log

M2 decision_manager: import json as _json 從 for 迴圈移至方法頂部

docs: ADR-072 新增 Code Review 發現與技術債記錄

2026-04-11 Claude Sonnet 4.6 Asia/Taipei

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
OG T
2026-04-11 20:36:59 +08:00
parent e447f97616
commit 82e1c05df8
4 changed files with 70 additions and 7 deletions

View File

@@ -106,8 +106,12 @@ class NemotronDriftInterpreter:
改用 Ollama httpx 直接呼叫,繞過 nvidia_provider與 drift_narrator_service 一致
"""
import httpx
from src.core.config import get_settings
OLLAMA_URL = "http://192.168.0.111:11434"
# C1 修復 2026-04-11: 禁止寫死內網 IPfeedback_frontend_internal_ip_ban 鐵律)
# 改從 settings.OLLAMA_URL 讀取已有此設定default=http://192.168.0.111:11434
_settings = get_settings()
OLLAMA_URL = getattr(_settings, "OLLAMA_URL", "http://192.168.0.111:11434")
MODEL = "qwen2.5:7b-instruct"
TIMEOUT = 45.0