feat(governance): 新增 Agent 工具採用批准包
All checks were successful
CD Pipeline / tests (push) Successful in 1m27s
Code Review / ai-code-review (push) Successful in 14s
CD Pipeline / build-and-deploy (push) Successful in 4m29s
CD Pipeline / post-deploy-checks (push) Successful in 1m32s

This commit is contained in:
Your Name
2026-06-11 13:25:51 +08:00
parent 25b6999b00
commit 42622a5bad
14 changed files with 1555 additions and 32 deletions

View File

@@ -58,6 +58,9 @@ from src.services.ai_agent_deployment_layout import (
from src.services.ai_agent_proactive_operations_contract import (
load_latest_ai_agent_proactive_operations_contract,
)
from src.services.ai_agent_tool_adoption_approval_package import (
load_latest_ai_agent_tool_adoption_approval_package,
)
from src.services.ai_agent_version_freshness_snapshot import (
load_latest_ai_agent_version_freshness_snapshot,
)
@@ -614,6 +617,34 @@ async def get_agent_version_freshness_snapshot() -> dict[str, Any]:
) from exc
@router.get(
"/agent-tool-adoption-approval-package",
response_model=dict[str, Any],
summary="取得 AI Agent 工具採用批准包",
description=(
"讀取最新已提交的 Renovate / OSV-Scanner / Trivy / Syft / Grype 工具採用批准包;"
"此端點不安裝工具、不寫 CI workflow、不下載漏洞資料庫、不查外部 registry、不升級套件、"
"不寫 lockfile、不 build/pull image、不建立 Gitea PR、不 auto merge、不發 Telegram、"
"不呼叫付費服務、不修改生產路由。"
),
)
async def get_agent_tool_adoption_approval_package() -> dict[str, Any]:
"""Return the latest read-only AI Agent tool adoption approval package."""
try:
return await asyncio.to_thread(load_latest_ai_agent_tool_adoption_approval_package)
except FileNotFoundError as exc:
raise HTTPException(
status_code=status.HTTP_404_NOT_FOUND,
detail=str(exc),
) from exc
except (json.JSONDecodeError, ValueError) as exc:
logger.error("ai_agent_tool_adoption_approval_package_invalid", error=str(exc))
raise HTTPException(
status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
detail="AI Agent 工具採用批准包無效",
) from exc
@router.get(
"/runtime-surface-inventory",
response_model=dict[str, Any],

View File

@@ -0,0 +1,178 @@
"""
AI Agent tool adoption approval package snapshot.
Loads the latest committed, read-only approval package for adopting tools such
as Renovate, OSV-Scanner, Trivy, Syft, and Grype. This module never installs
tools, writes CI workflows, downloads vulnerability databases, queries
registries, creates PRs, sends Telegram messages, or changes production.
"""
from __future__ import annotations
import json
from pathlib import Path
from typing import Any
from src.services.snapshot_paths import default_evaluations_dir
_DEFAULT_EVALUATIONS_DIR = default_evaluations_dir(Path(__file__))
_SNAPSHOT_PATTERN = "ai_agent_tool_adoption_approval_package_*.json"
_SCHEMA_VERSION = "ai_agent_tool_adoption_approval_package_v1"
_RUNTIME_AUTHORITY = "approval_package_only_no_tool_install_or_ci_change"
def load_latest_ai_agent_tool_adoption_approval_package(
evaluations_dir: Path | None = None,
) -> dict[str, Any]:
"""Load the newest committed AI Agent tool adoption approval package."""
directory = evaluations_dir or _DEFAULT_EVALUATIONS_DIR
candidates = sorted(directory.glob(_SNAPSHOT_PATTERN))
if not candidates:
raise FileNotFoundError(
f"no AI Agent tool adoption approval package snapshots found in {directory}"
)
latest = candidates[-1]
with latest.open(encoding="utf-8") as handle:
payload = json.load(handle)
if not isinstance(payload, dict):
raise ValueError(f"{latest}: expected JSON object")
_require_schema(payload, _SCHEMA_VERSION, str(latest))
_require_read_only_boundaries(payload, str(latest))
_require_rollup_consistency(payload, str(latest))
_require_tool_safety(payload, str(latest))
return payload
def _require_schema(payload: dict[str, Any], expected: str, label: str) -> None:
actual = payload.get("schema_version")
if actual != expected:
raise ValueError(f"{label}: expected schema_version={expected}, got {actual!r}")
def _require_read_only_boundaries(payload: dict[str, Any], label: str) -> None:
program_status = payload.get("program_status") or {}
if program_status.get("read_only_mode") is not True:
raise ValueError(f"{label}: program_status.read_only_mode must be true")
if program_status.get("runtime_authority") != _RUNTIME_AUTHORITY:
raise ValueError(f"{label}: runtime_authority must stay {_RUNTIME_AUTHORITY}")
boundaries = payload.get("approval_boundaries") or {}
blocked_flags = {
"tool_install_allowed",
"ci_workflow_change_allowed",
"external_registry_lookup_allowed",
"vulnerability_database_download_allowed",
"package_upgrade_allowed",
"lockfile_write_allowed",
"docker_build_allowed",
"image_pull_allowed",
"gitea_pr_creation_allowed",
"auto_merge_allowed",
"telegram_direct_send_allowed",
"paid_service_enabled",
"production_route_change_allowed",
"secret_plaintext_allowed",
}
allowed = sorted(flag for flag in blocked_flags if boundaries.get(flag) is not False)
if allowed:
raise ValueError(f"{label}: approval boundaries must remain false: {allowed}")
def _require_rollup_consistency(payload: dict[str, Any], label: str) -> None:
tools = payload.get("tool_candidates") or []
sources = payload.get("source_evidence") or []
lanes = payload.get("adoption_lanes") or []
rollups = payload.get("rollups") or {}
expected_counts = {
"tool_count": len(tools),
"source_evidence_count": len(sources),
"adoption_lane_count": len(lanes),
}
mismatched = {
key: {"expected": expected, "actual": rollups.get(key)}
for key, expected in expected_counts.items()
if rollups.get(key) != expected
}
if mismatched:
raise ValueError(f"{label}: rollup counts must match payload sections: {mismatched}")
expected_lists = {
"approval_required_tool_ids": sorted(
tool.get("tool_id")
for tool in tools
if tool.get("adoption_status") == "approval_required"
),
"ci_change_required_tool_ids": sorted(
tool.get("tool_id") for tool in tools if tool.get("ci_change_required") is True
),
"secret_required_tool_ids": sorted(
tool.get("tool_id") for tool in tools if _requires_secret_review(tool)
),
"external_data_required_tool_ids": sorted(
tool.get("tool_id") for tool in tools if _requires_external_data_gate(tool)
),
}
for key, expected in expected_lists.items():
if sorted(rollups.get(key) or []) != expected:
raise ValueError(f"{label}: rollups.{key} mismatch")
zero_rollups = {
"tool_install_allowed_count",
"ci_change_allowed_count",
"auto_merge_allowed_count",
"telegram_direct_send_count",
}
nonzero = sorted(key for key in zero_rollups if rollups.get(key) != 0)
if nonzero:
raise ValueError(f"{label}: rollout safety counters must remain 0: {nonzero}")
def _require_tool_safety(payload: dict[str, Any], label: str) -> None:
source_ids = {source.get("source_id") for source in payload.get("source_evidence") or []}
unsafe_tools = [
tool.get("tool_id")
for tool in payload.get("tool_candidates") or []
if tool.get("adoption_status") != "approval_required"
or not tool.get("approval_requirements")
or not tool.get("blocked_until_approval")
or not set(tool.get("official_source_refs") or []).issubset(source_ids)
or not tool.get("rollback_plan")
]
if unsafe_tools:
raise ValueError(f"{label}: tools must stay approval-bound: {unsafe_tools}")
unsafe_lanes = [
lane.get("lane_id")
for lane in payload.get("adoption_lanes") or []
if not lane.get("approval_gate") or not lane.get("blocked_now")
]
if unsafe_lanes:
raise ValueError(f"{label}: adoption lanes need approval gates: {unsafe_lanes}")
missing_required_fields = [
field.get("field_id")
for field in payload.get("approval_packet_fields") or []
if field.get("required") is True and not field.get("description")
]
if missing_required_fields:
raise ValueError(f"{label}: approval fields need descriptions: {missing_required_fields}")
def _requires_secret_review(tool: dict[str, Any]) -> bool:
requirement = str(tool.get("secret_requirement") or "").lower()
return "credentials" in requirement or "token" in requirement
def _requires_external_data_gate(tool: dict[str, Any]) -> bool:
requirement = str(tool.get("external_data_requirement") or "").lower()
if requirement.startswith("no external"):
return False
return (
"currently blocked" in requirement
or "metadata required" in requirement
or "database required" in requirement
or "db required" in requirement
)

View File

@@ -13,9 +13,9 @@ def test_load_latest_ai_agent_proactive_operations_contract_reads_committed_snap
data = load_latest_ai_agent_proactive_operations_contract()
assert data["schema_version"] == "ai_agent_proactive_operations_contract_v1"
assert data["program_status"]["overall_completion_percent"] == 42
assert data["program_status"]["current_task_id"] == "P2-402B"
assert data["program_status"]["next_task_id"] == "P2-402C"
assert data["program_status"]["overall_completion_percent"] == 55
assert data["program_status"]["current_task_id"] == "P2-402C"
assert data["program_status"]["next_task_id"] == "P2-402D"
assert data["program_status"]["read_only_mode"] is True
assert data["program_status"]["runtime_authority"] == "contract_only_no_version_or_runtime_update"
assert data["approval_boundaries"]["runtime_version_update_allowed"] is False

View File

@@ -16,9 +16,9 @@ def test_ai_agent_proactive_operations_contract_endpoint_returns_committed_snaps
assert response.status_code == 200
data = response.json()
assert data["schema_version"] == "ai_agent_proactive_operations_contract_v1"
assert data["program_status"]["overall_completion_percent"] == 42
assert data["program_status"]["current_task_id"] == "P2-402B"
assert data["program_status"]["next_task_id"] == "P2-402C"
assert data["program_status"]["overall_completion_percent"] == 55
assert data["program_status"]["current_task_id"] == "P2-402C"
assert data["program_status"]["next_task_id"] == "P2-402D"
assert data["program_status"]["read_only_mode"] is True
assert data["approval_boundaries"]["runtime_version_update_allowed"] is False
assert data["approval_boundaries"]["package_upgrade_allowed"] is False

View File

@@ -0,0 +1,207 @@
from __future__ import annotations
import json
import pytest
from src.services.ai_agent_tool_adoption_approval_package import (
load_latest_ai_agent_tool_adoption_approval_package,
)
def test_load_latest_ai_agent_tool_adoption_approval_package_reads_committed_snapshot():
data = load_latest_ai_agent_tool_adoption_approval_package()
assert data["schema_version"] == "ai_agent_tool_adoption_approval_package_v1"
assert data["program_status"]["overall_completion_percent"] == 55
assert data["program_status"]["current_task_id"] == "P2-402C"
assert data["program_status"]["next_task_id"] == "P2-402D"
assert data["program_status"]["read_only_mode"] is True
assert (
data["program_status"]["runtime_authority"]
== "approval_package_only_no_tool_install_or_ci_change"
)
assert data["approval_boundaries"]["tool_install_allowed"] is False
assert data["approval_boundaries"]["ci_workflow_change_allowed"] is False
assert data["approval_boundaries"]["external_registry_lookup_allowed"] is False
assert data["approval_boundaries"]["vulnerability_database_download_allowed"] is False
assert data["approval_boundaries"]["gitea_pr_creation_allowed"] is False
assert data["approval_boundaries"]["telegram_direct_send_allowed"] is False
assert data["rollups"]["tool_count"] == len(data["tool_candidates"]) == 5
assert data["rollups"]["source_evidence_count"] == len(data["source_evidence"]) == 5
assert data["rollups"]["adoption_lane_count"] == len(data["adoption_lanes"]) == 4
assert data["rollups"]["tool_install_allowed_count"] == 0
assert data["rollups"]["ci_change_allowed_count"] == 0
assert data["rollups"]["auto_merge_allowed_count"] == 0
assert data["rollups"]["telegram_direct_send_count"] == 0
assert set(data["rollups"]["approval_required_tool_ids"]) == {
"renovate_gitea",
"osv_scanner",
"trivy",
"syft",
"grype",
}
assert set(data["rollups"]["secret_required_tool_ids"]) == {
"renovate_gitea",
"trivy",
"syft",
"grype",
}
assert "syft" not in data["rollups"]["external_data_required_tool_ids"]
def test_ai_agent_tool_adoption_approval_package_rejects_tool_install_allowed(tmp_path):
snapshot = _snapshot()
snapshot["approval_boundaries"]["tool_install_allowed"] = True
(tmp_path / "ai_agent_tool_adoption_approval_package_2026-06-11.json").write_text(
json.dumps(snapshot),
encoding="utf-8",
)
with pytest.raises(ValueError, match="approval boundaries"):
load_latest_ai_agent_tool_adoption_approval_package(tmp_path)
def test_ai_agent_tool_adoption_approval_package_rejects_rollup_mismatch(tmp_path):
snapshot = _snapshot()
snapshot["rollups"]["tool_count"] = 99
(tmp_path / "ai_agent_tool_adoption_approval_package_2026-06-11.json").write_text(
json.dumps(snapshot),
encoding="utf-8",
)
with pytest.raises(ValueError, match="rollup counts"):
load_latest_ai_agent_tool_adoption_approval_package(tmp_path)
def test_ai_agent_tool_adoption_approval_package_rejects_non_approval_tool(tmp_path):
snapshot = _snapshot()
snapshot["tool_candidates"][0]["adoption_status"] = "enabled"
snapshot["rollups"]["approval_required_tool_ids"] = []
(tmp_path / "ai_agent_tool_adoption_approval_package_2026-06-11.json").write_text(
json.dumps(snapshot),
encoding="utf-8",
)
with pytest.raises(ValueError, match="approval-bound"):
load_latest_ai_agent_tool_adoption_approval_package(tmp_path)
def test_ai_agent_tool_adoption_approval_package_rejects_unknown_source_ref(tmp_path):
snapshot = _snapshot()
snapshot["tool_candidates"][0]["official_source_refs"] = ["unknown_source"]
(tmp_path / "ai_agent_tool_adoption_approval_package_2026-06-11.json").write_text(
json.dumps(snapshot),
encoding="utf-8",
)
with pytest.raises(ValueError, match="approval-bound"):
load_latest_ai_agent_tool_adoption_approval_package(tmp_path)
def _snapshot() -> dict:
return {
"schema_version": "ai_agent_tool_adoption_approval_package_v1",
"generated_at": "2026-06-11T23:35:00+08:00",
"program_status": {
"overall_completion_percent": 55,
"current_priority": "P2",
"current_task_id": "P2-402C",
"next_task_id": "P2-402D",
"read_only_mode": True,
"runtime_authority": "approval_package_only_no_tool_install_or_ci_change",
"status_note": "測試。",
},
"source_evidence": [
{
"source_id": "renovate_gitea_platform_docs",
"tool_id": "renovate_gitea",
"name": "Renovate Gitea platform docs",
"url": "https://docs.renovatebot.com/modules/platform/gitea/",
"retrieved_at": "2026-06-11T23:35:00+08:00",
"evidence_type": "official_documentation",
"usage_boundary": "測試。",
}
],
"agent_review_matrix": [
{
"agent_id": "openclaw",
"role": "測試。",
"allowed_now": ["讀取批准包"],
"blocked_until_approval": ["安裝工具"],
"output": "verdict",
}
],
"adoption_lanes": [
{
"lane_id": "dependency_update_pr_lane",
"display_name": "Dependency update PR lane",
"owner_agent": "hermes",
"tool_ids": ["renovate_gitea"],
"approval_gate": "approval_required",
"planned_output": "approval package",
"blocked_now": ["PR creation"],
}
],
"tool_candidates": [
{
"tool_id": "renovate_gitea",
"display_name": "Renovate for Gitea",
"category": "dependency_update_pr",
"owner_agent": "hermes",
"adoption_status": "approval_required",
"risk_tier": "high",
"cost_profile": "runner cost requires approval",
"secret_requirement": "Gitea bot token required after approval.",
"external_data_requirement": "Package registry metadata required after approval; currently blocked.",
"ci_change_required": True,
"official_source_refs": ["renovate_gitea_platform_docs"],
"intended_scope": ["dependency update PR draft"],
"approval_requirements": ["bot token storage plan"],
"blocked_until_approval": ["PR creation"],
"recommendation": "測試。",
"rollback_plan": "測試。",
}
],
"approval_packet_fields": [
{
"field_id": "operator_approval_id",
"required": True,
"owner_agent": "openclaw",
"description": "測試。",
}
],
"approval_boundaries": {
"tool_install_allowed": False,
"ci_workflow_change_allowed": False,
"external_registry_lookup_allowed": False,
"vulnerability_database_download_allowed": False,
"package_upgrade_allowed": False,
"lockfile_write_allowed": False,
"docker_build_allowed": False,
"image_pull_allowed": False,
"gitea_pr_creation_allowed": False,
"auto_merge_allowed": False,
"telegram_direct_send_allowed": False,
"paid_service_enabled": False,
"production_route_change_allowed": False,
"secret_plaintext_allowed": False,
},
"rollups": {
"tool_count": 1,
"source_evidence_count": 1,
"adoption_lane_count": 1,
"approval_required_tool_ids": ["renovate_gitea"],
"ci_change_required_tool_ids": ["renovate_gitea"],
"secret_required_tool_ids": ["renovate_gitea"],
"external_data_required_tool_ids": ["renovate_gitea"],
"sbom_tool_ids": [],
"vulnerability_scan_tool_ids": [],
"update_pr_tool_ids": ["renovate_gitea"],
"tool_install_allowed_count": 0,
"ci_change_allowed_count": 0,
"auto_merge_allowed_count": 0,
"telegram_direct_send_count": 0,
"next_approval_task_ids": ["P2-402D"],
},
}

View File

@@ -0,0 +1,40 @@
from __future__ import annotations
from fastapi import FastAPI
from fastapi.testclient import TestClient
from src.api.v1.agents import router
def test_agent_tool_adoption_approval_package_endpoint_returns_committed_snapshot():
app = FastAPI()
app.include_router(router, prefix="/api/v1")
client = TestClient(app)
response = client.get("/api/v1/agents/agent-tool-adoption-approval-package")
assert response.status_code == 200
data = response.json()
assert data["schema_version"] == "ai_agent_tool_adoption_approval_package_v1"
assert data["program_status"]["overall_completion_percent"] == 55
assert data["program_status"]["current_task_id"] == "P2-402C"
assert data["program_status"]["next_task_id"] == "P2-402D"
assert data["program_status"]["read_only_mode"] is True
assert data["approval_boundaries"]["tool_install_allowed"] is False
assert data["approval_boundaries"]["ci_workflow_change_allowed"] is False
assert data["approval_boundaries"]["external_registry_lookup_allowed"] is False
assert data["approval_boundaries"]["vulnerability_database_download_allowed"] is False
assert data["approval_boundaries"]["gitea_pr_creation_allowed"] is False
assert data["approval_boundaries"]["telegram_direct_send_allowed"] is False
assert data["rollups"]["tool_count"] == 5
assert data["rollups"]["source_evidence_count"] == 5
assert data["rollups"]["adoption_lane_count"] == 4
assert data["rollups"]["tool_install_allowed_count"] == 0
assert data["rollups"]["ci_change_allowed_count"] == 0
assert data["rollups"]["auto_merge_allowed_count"] == 0
assert data["rollups"]["telegram_direct_send_count"] == 0
assert any(tool["tool_id"] == "renovate_gitea" for tool in data["tool_candidates"])
assert any(tool["tool_id"] == "osv_scanner" for tool in data["tool_candidates"])
assert any(tool["tool_id"] == "trivy" for tool in data["tool_candidates"])
assert any(tool["tool_id"] == "syft" for tool in data["tool_candidates"])
assert any(tool["tool_id"] == "grype" for tool in data["tool_candidates"])