fix(reboot): prefer windows99 runtime metrics

apps/api/tests/test_reboot_auto_recovery_slo_scorecard_api.py

@@ -103,7 +103,6 @@ PROMETHEUS_SOURCE_RECONCILED_BLOCKER = (
 )
 WINDOWS99_RUNTIME_READBACK_ADDED_BLOCKERS = [
     "windows99_vmware_autostart_config_not_ready",
-    "windows99_update_no_auto_reboot_policy_not_ready",
 ]
 PROMETHEUS_RUNTIME_SOURCE_RECONCILED_BLOCKERS = [
     blocker
@@ -426,7 +425,7 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
     )
     assert payload["runtime_metric_source_control_reconciled_blocker_count"] == 1
     assert payload["active_blockers"] == expected_active_blockers
-    assert payload["active_blocker_count"] == 9
+    assert payload["active_blocker_count"] == 8
     assert payload["readiness_percent"] == 47
     assert payload["primary_blocker"] == "reboot_event_required_host_unreachable"
     assert payload["next_safe_action"] == (
@@ -439,7 +438,7 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
         payload["runtime_metric_runtime_readback_added_blockers"]
         == WINDOWS99_RUNTIME_READBACK_ADDED_BLOCKERS
     )
-    assert payload["runtime_metric_runtime_readback_added_blocker_count"] == 2
+    assert payload["runtime_metric_runtime_readback_added_blocker_count"] == 1
     package = payload["windows99_vmx_source_repair_package"]
     assert package["schema_version"] == (
         "windows99_vmx_source_repair_check_mode_package_v1"
@@ -481,7 +480,7 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
         is True
     )
     assert payload["controlled_service_data_backup_readback"]["blocking_fields"] == []
-    assert payload["active_blocker_action_matrix"]["item_count"] == 9
+    assert payload["active_blocker_action_matrix"]["item_count"] == 8
     assert payload["windows99_vmware_autostart"]["readback_present"] is True
     assert payload["windows99_vmware_autostart"]["missing_vmx_aliases"] == ["111"]
     assert payload["windows99_vmware_autostart"]["powered_off_aliases"] == [
@@ -494,13 +493,13 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
     assert payload["windows99_vmware_autostart"]["blockers"] == [
         "windows99_vmware_guest_power_not_ready",
         "windows99_vmware_vmx_missing",
-        *WINDOWS99_RUNTIME_READBACK_ADDED_BLOCKERS,
+        "windows99_vmware_autostart_config_not_ready",
     ]
     assert payload["readback"]["windows99_vmware_readback_present"] is True
     assert payload["readback"]["windows99_vmrun_present"] is True
     assert payload["readback"]["windows99_vmware_config_ready"] is False
     assert payload["readback"]["windows99_vmware_power_ready"] is False
-    assert payload["readback"]["windows99_update_no_auto_reboot_ready"] is False
+    assert payload["readback"]["windows99_update_no_auto_reboot_ready"] is True
     assert payload["readback"]["windows99_runtime_metric_overlay_applied"] is True
     assert (
         payload["windows99_verify_collection"]["status"]
@@ -515,7 +514,7 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
     assert payload["rollups"]["windows99_vmrun_present"] is True
     assert payload["rollups"]["windows99_vmware_config_ready"] is False
     assert payload["rollups"]["windows99_vmware_power_ready"] is False
-    assert payload["rollups"]["windows99_update_no_auto_reboot_ready"] is False
+    assert payload["rollups"]["windows99_update_no_auto_reboot_ready"] is True
     assert payload["rollups"]["windows99_vmware_missing_vmx_count"] == 1
     assert payload["rollups"]["windows99_vmware_powered_off_count"] == 5
     assert payload["rollups"]["windows99_missing_vmx_alias_count"] == 1
@@ -560,7 +559,7 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
     ] == 5
     assert payload["active_blocker_action_matrix"]["category_counts"][
         "windows99_vmware_autostart"
-    ] == 4
+    ] == 3
     assert payload["active_blocker_action_matrix"]["category_counts"].get(
         "post_reboot_service_readiness",
         0,
@@ -573,7 +572,7 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
         "security_observability",
         0,
     ) == 0
-    assert payload["readback"]["active_blocker_count"] == 9
+    assert payload["readback"]["active_blocker_count"] == 8
     assert payload["readback"]["runtime_metric_readback_present"] is True
     assert payload["readback"][
         "runtime_metric_source_control_reconciled_blocker_count"
@@ -583,20 +582,63 @@ def test_reboot_auto_recovery_slo_scorecard_overlays_prometheus_runtime_metrics(
     ] == WINDOWS99_RUNTIME_READBACK_ADDED_BLOCKERS
     assert payload["readback"][
         "runtime_metric_runtime_readback_added_blocker_count"
-    ] == 2
-    assert payload["rollups"]["active_blocker_count"] == 9
+    ] == 1
+    assert payload["rollups"]["active_blocker_count"] == 8
     assert payload["rollups"]["runtime_metric_readback_present"] is True
     assert payload["rollups"][
         "runtime_metric_source_control_reconciled_blocker_count"
     ] == 1
     assert payload["rollups"][
         "runtime_metric_runtime_readback_added_blocker_count"
-    ] == 2
+    ] == 1
     assert payload["rollups"]["primary_blocker_owner_lane"] == (
         "reboot_event_detector_and_host_probe"
     )
 
 
+def test_reboot_auto_recovery_slo_scorecard_does_not_reopen_windows99_config_when_runtime_metric_is_ready():
+    metric_readback = {
+        **PROMETHEUS_RUNTIME_READBACK,
+        "active_blockers": [
+            "all_required_hosts_not_in_10_minute_reboot_window",
+            "fresh_all_host_reboot_event_missing",
+            "host_boot_observation_older_than_target_window",
+            "host_unreachable_after_reboot",
+            "host_uptime_unknown",
+            "reboot_event_required_host_unreachable",
+            "windows99_vmware_guest_power_not_ready",
+        ],
+        "active_blocker_count": 7,
+        "windows99_vmware_autostart_config_ready": True,
+        "windows99_windows_update_no_auto_reboot_ready": True,
+        "windows99_missing_vmx_aliases": [],
+        "windows99_powered_off_aliases": ["110", "112", "120", "121", "188"],
+    }
+
+    payload = load_latest_reboot_auto_recovery_slo_scorecard(
+        prometheus_metric_readback=metric_readback,
+    )
+
+    assert payload["active_blockers"] == metric_readback["active_blockers"]
+    assert payload["active_blocker_count"] == 7
+    assert payload["runtime_metric_runtime_readback_added_blockers"] == []
+    assert payload["runtime_metric_runtime_readback_added_blocker_count"] == 0
+    assert "windows99_vmware_autostart_config_not_ready" not in payload[
+        "active_blockers"
+    ]
+    assert "windows99_update_no_auto_reboot_policy_not_ready" not in payload[
+        "active_blockers"
+    ]
+    assert payload["windows99_vmware_autostart"]["config_ready"] is True
+    assert payload["windows99_vmware_autostart"][
+        "windows_update_no_auto_reboot_ready"
+    ] is True
+    assert payload["readback"]["windows99_vmware_config_ready"] is True
+    assert payload["readback"]["windows99_update_no_auto_reboot_ready"] is True
+    assert payload["rollups"]["windows99_vmware_config_ready"] is True
+    assert payload["rollups"]["windows99_update_no_auto_reboot_ready"] is True
+
+
 def test_reboot_auto_recovery_slo_scorecard_surfaces_windows99_console_artifact_blocker(
     tmp_path,
 ):
@@ -710,7 +752,7 @@ def test_reboot_auto_recovery_slo_scorecard_keeps_prometheus_source_missing_when
         *PROMETHEUS_RUNTIME_BLOCKERS,
         *WINDOWS99_RUNTIME_READBACK_ADDED_BLOCKERS,
     ]
-    assert payload["active_blocker_count"] == 10
+    assert payload["active_blocker_count"] == 9
     assert payload["runtime_metric_source_control_reconciled_blocker_count"] == 0
     action_by_blocker = {
         item["blocker"]: item