fix(critic-hotfix): 4 修補 critic BLOCKER + HIGH(CD 阻塞 + 飛輪空轉)
Some checks are pending
CD Pipeline / build-and-deploy (push) Has started running
Some checks are pending
CD Pipeline / build-and-deploy (push) Has started running
Critic 全面審查 6 個 commit 後抓出:
CD 阻塞修復:
- test_ai_router_failover_integration.py: 3 個 test 改用 patch.object 直接
mock _select_provider_and_model 強制初始 OLLAMA。原 IntentType.UNKNOWN mock
在 router 內仍被 reclassify 成 DIAGNOSE → openclaw_nemo,failover 不觸發。
→ 5/5 PASSED
BLOCKER B1 — Gitea Telegram 通知永遠發不出去:
- apps/api/src/api/v1/gitea_webhook.py:399
redis = await get_redis() → redis = get_redis()
原 await 會 raise TypeError 被外層 except 吞 → Task C PR merged + workflow_run
failure 通知全部失效(CI 綠燈是假象,test 只驗 HTTP 202 不驗實際送達)
BLOCKER B2 — P1.3+P1.4 學習鏈閉環空轉(兩處同 bug):
- apps/api/src/api/v1/webhooks.py:261
- apps/api/src/services/approval_execution.py:771(pre-existing)
EvidenceSnapshot.get_latest_snapshot(...) 是 module-level async function
不是 classmethod → AttributeError 被 except 吞成 warning
→ 飛輪閉環假性接通實際空跑(feature flag default off 暫時免爆)
HIGH H3 — main.py lifespan 順序競爭:
- apps/api/src/main.py: configure_alerter() 移到 _recovery_svc.start() 之前
原順序:start() 觸發 immediate-check → 可能呼叫 alert_recovery,但 alerter
尚未注入 Redis → dedup fail-open,重複告警風險。
HIGH H1 — Gemini quota dedup 跨日吞告警:
- apps/api/src/services/failover_alerter.py:89
dedup key 加 :{YYYY-MM-DD} 後綴,每日獨立 dedup window
原昨 22:00 觸發,今 21:30 再觸發時 dedup 還沒過期會被吞掉
Tests: 14 passed (failover_alerter + ai_router_failover_integration + lifespan_wiring)
延後 follow-up:
- H2: proactive_inspector memory metric 改名 + baseline 清理
- H4: probe_success NaN fallback
- M1-M4 / S1-S2: 見 critic 報告
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -561,11 +561,10 @@ async def lifespan(_app: FastAPI) -> AsyncGenerator[None, None]:
|
||||
# wire callback:failover 切換時通知 recovery service 更新 current_primary
|
||||
_failover_mgr.set_recovery_callback(_recovery_svc.set_current_primary)
|
||||
|
||||
# 啟動 recovery service(從 Redis bootstrap current_primary,並啟動背景監控)
|
||||
await _recovery_svc.start()
|
||||
|
||||
# 2026-04-26 P1.5 整合點 4 by Claude Opus 4.7 — Failover Alerter 注入 Redis client
|
||||
# 必須在 recovery_svc.start() 之後(確保 Redis pool 已可用),yield 之前
|
||||
# 2026-04-26 critic-H3 hotfix by Claude Opus 4.7 — alerter 必須在 recovery 啟動前注入
|
||||
# 原順序:start() 後才注入 → recovery bootstrap immediate-check 若觸發 alert_recovery,
|
||||
# alerter 還沒注入 Redis → dedup fail-open,告警會送出且無 dedup 保護(重複告警風險)
|
||||
# 修法:configure_alerter() 提前到 start() 之前;Redis pool 在 lifespan 早期已就緒
|
||||
try:
|
||||
from src.services.failover_alerter import configure_alerter
|
||||
from src.core.redis_client import get_redis
|
||||
@@ -574,6 +573,9 @@ async def lifespan(_app: FastAPI) -> AsyncGenerator[None, None]:
|
||||
except Exception as _alerter_err:
|
||||
logger.warning("failover_alerter_configure_failed", error=str(_alerter_err))
|
||||
|
||||
# 啟動 recovery service(從 Redis bootstrap current_primary,並啟動背景監控)
|
||||
await _recovery_svc.start()
|
||||
|
||||
logger.info("ollama_failover_system_started")
|
||||
except Exception as e:
|
||||
logger.warning("ollama_failover_system_start_failed", error=str(e))
|
||||
|
||||
Reference in New Issue
Block a user