docs(security): add owner response audit retention checks
This commit is contained in:
@@ -110,6 +110,7 @@ def validate(root: Path) -> None:
|
||||
"s4_13_owner_response_validation_reviewer_audit_collection_checks",
|
||||
"s4_13_owner_response_validation_reviewer_audit_redaction_examples",
|
||||
"s4_13_owner_response_validation_reviewer_audit_retention_rules",
|
||||
"s4_13_owner_response_validation_reviewer_audit_retention_checks",
|
||||
]
|
||||
assert_equal(
|
||||
"progress_delta_ledger.delta_ids",
|
||||
@@ -185,6 +186,11 @@ def validate(root: Path) -> None:
|
||||
owner_summary["owner_response_validation_reviewer_audit_retention_rule_count"],
|
||||
5,
|
||||
)
|
||||
assert_equal(
|
||||
"owner_rollup.owner_response_validation_reviewer_audit_retention_check_count",
|
||||
owner_summary["owner_response_validation_reviewer_audit_retention_check_count"],
|
||||
6,
|
||||
)
|
||||
assert_false("owner_rollup.runtime_execution_authorized", owner_summary["runtime_execution_authorized"])
|
||||
assert_false("owner_rollup.repo_creation_authorized", owner_summary["repo_creation_authorized"])
|
||||
assert_false("owner_rollup.refs_sync_authorized", owner_summary["refs_sync_authorized"])
|
||||
|
||||
@@ -359,6 +359,15 @@ EXPECTED_ROLLUP_REVIEWER_AUDIT_RETENTION_RULES = [
|
||||
"retention-counter-snapshot-only",
|
||||
]
|
||||
|
||||
EXPECTED_ROLLUP_REVIEWER_AUDIT_RETENTION_CHECKS = [
|
||||
"check-reviewer-audit-retention-rules-visible",
|
||||
"check-reviewer-audit-retained-metadata-only",
|
||||
"check-reviewer-audit-raw-payloads-blocked",
|
||||
"check-reviewer-audit-secret-retention-blocked",
|
||||
"check-reviewer-audit-counter-snapshot-only",
|
||||
"check-reviewer-audit-no-runtime-retention-side-effect",
|
||||
]
|
||||
|
||||
|
||||
def load_json(path: Path) -> dict[str, Any]:
|
||||
return json.loads(path.read_text(encoding="utf-8"))
|
||||
@@ -446,6 +455,11 @@ def validate(root: Path) -> None:
|
||||
rollup_summary["owner_response_validation_reviewer_audit_retention_rule_count"],
|
||||
len(EXPECTED_ROLLUP_REVIEWER_AUDIT_RETENTION_RULES),
|
||||
)
|
||||
assert_equal(
|
||||
"rollup.owner_response_validation_reviewer_audit_retention_check_count",
|
||||
rollup_summary["owner_response_validation_reviewer_audit_retention_check_count"],
|
||||
len(EXPECTED_ROLLUP_REVIEWER_AUDIT_RETENTION_CHECKS),
|
||||
)
|
||||
assert_true("rollup.quarantine_required", rollup_summary["quarantine_required"])
|
||||
assert_equal("rollup.primary_ready_count", rollup_summary["primary_ready_count"], 0)
|
||||
|
||||
@@ -1097,6 +1111,47 @@ def validate(root: Path) -> None:
|
||||
item["not_approval"],
|
||||
)
|
||||
|
||||
reviewer_audit_retention_checks = rollup["owner_response_validation_reviewer_audit_retention_checks"]
|
||||
assert_equal(
|
||||
"owner_response_validation_reviewer_audit_retention_checks.ids",
|
||||
[item["check_id"] for item in reviewer_audit_retention_checks],
|
||||
EXPECTED_ROLLUP_REVIEWER_AUDIT_RETENTION_CHECKS,
|
||||
)
|
||||
assert_equal(
|
||||
"owner_response_validation_reviewer_audit_retention_checks.display_order",
|
||||
[item["display_order"] for item in reviewer_audit_retention_checks],
|
||||
list(range(1, len(EXPECTED_ROLLUP_REVIEWER_AUDIT_RETENTION_CHECKS) + 1)),
|
||||
)
|
||||
for item in reviewer_audit_retention_checks:
|
||||
assert_equal(
|
||||
f"owner_response_validation_reviewer_audit_retention_checks.{item['check_id']}.awooop_display_mode",
|
||||
item["awooop_display_mode"],
|
||||
"display_reviewer_audit_retention_check_only",
|
||||
)
|
||||
assert_false(
|
||||
f"owner_response_validation_reviewer_audit_retention_checks.{item['check_id']}.execution_authorized",
|
||||
item["execution_authorized"],
|
||||
)
|
||||
assert_true(
|
||||
f"owner_response_validation_reviewer_audit_retention_checks.{item['check_id']}.not_approval",
|
||||
item["not_approval"],
|
||||
)
|
||||
for blocked in item["blocked_interpretations"]:
|
||||
if blocked in {
|
||||
"enable_audit_storage_from_check",
|
||||
"store_raw_owner_response_for_retention",
|
||||
"retain_token_value",
|
||||
"treat_retention_check_pass_as_runtime_gate",
|
||||
"create_runtime_gate_from_retention_check",
|
||||
"create_execution_queue_from_retention_check",
|
||||
"add_action_button_from_retention_check",
|
||||
"start_scan_from_retention_check",
|
||||
}:
|
||||
assert_false(
|
||||
f"owner_response_validation_reviewer_audit_retention_checks.{item['check_id']}.runtime_execution_authorized",
|
||||
item["execution_authorized"],
|
||||
)
|
||||
|
||||
first_lane = LANES[0]
|
||||
first_collection_item = collection_order_by_id[first_lane["lane_id"]]
|
||||
first_missing_lane = missing_lane_by_id[first_lane["lane_id"]]
|
||||
|
||||
Reference in New Issue
Block a user